dri-devel June 2019

dri-devel@lists.freedesktop.org

350 participants
2370 discussions

[PATCH] drm/docs: More links for implicit/explicit fencing.
by Daniel Vetter 03 Jun '19

03 Jun '19

drm_atomic_set_fence_for_plane() contains the main discussion from a driver pov, link to that from more places. Cc: Pekka Paalanen <pekka.paalanen(a)collabora.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <maxime.ripard(a)bootlin.com> Cc: Sean Paul <sean(a)poorly.run> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 ++++++ include/drm/drm_plane.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index 6fd48efe288c..6791245963c3 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -284,6 +284,9 @@ EXPORT_SYMBOL_GPL(drm_gem_fb_create_with_dirty); * There is no need for &drm_plane_helper_funcs.cleanup_fb hook for simple * gem based framebuffer drivers which have their buffers always pinned in * memory. + * + * See drm_atomic_set_fence_for_plane() for a discussion of implicit and + * explicit fencing in atomic modeset updates. */ int drm_gem_fb_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state) @@ -314,6 +317,9 @@ EXPORT_SYMBOL_GPL(drm_gem_fb_prepare_fb); * &dma_buf attached, extracts the exclusive fence and attaches it to plane * state for the atomic helper to wait on. Drivers can use this as their * &drm_simple_display_pipe_funcs.prepare_fb callback. + * + * See drm_atomic_set_fence_for_plane() for a discussion of implicit and + * explicit fencing in atomic modeset updates. */ int drm_gem_fb_simple_display_pipe_prepare_fb(struct drm_simple_display_pipe *pipe, struct drm_plane_state *plane_state) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 6078c700d9ba..cd5903ad33f7 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -69,7 +69,7 @@ struct drm_plane_state { * * Optional fence to wait for before scanning out @fb. The core atomic * code will set this when userspace is using explicit fencing. Do not - * write this directly for a driver's implicit fence, use + * write this field directly for a driver's implicit fence, use * drm_atomic_set_fence_for_plane() to ensure that an explicit fence is * preserved. * -- 2.20.1

3 2

[PATCH] drm/msm/adreno: Ensure that the zap shader region is big enough
by Jordan Crouse 03 Jun '19

03 Jun '19

Before loading the zap shader we should ensure that the reserved memory region is big enough to hold the loaded file. Signed-off-by: Jordan Crouse <jcrouse(a)codeaurora.org> --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 6f7f411..3db8e49 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -67,7 +67,6 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, return ret; mem_phys = r.start; - mem_size = resource_size(&r); /* Request the MDT file for the firmware */ fw = adreno_request_fw(to_adreno_gpu(gpu), fwname); @@ -83,6 +82,13 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, goto out; } + if (mem_size > resource_size(&r)) { + DRM_DEV_ERROR(dev, + "memory region is too small to load the MDT\n"); + ret = -E2BIG; + goto out; + } + /* Allocate memory for the firmware image */ mem_region = memremap(mem_phys, mem_size, MEMREMAP_WC); if (!mem_region) { -- 2.7.4

3 2

linux-next: unable to fetch the drm-intel-fixes tree
by Stephen Rothwell 03 Jun '19

03 Jun '19

Hi all, Trying to fetch the drm-intel-fixes tree today gives me this error: ----------------------------------------------------------------- fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ----------------------------------------------------------------- The same for drm-misc-fixes, drm-intel and drm-misc. These are all hosted on git://anongit.freedesktop.org/ . -- Cheers, Stephen Rothwell

2 4

[PATCH] drm/sched: Fix make htmldocs warnings.
by Andrey Grodzovsky 03 Jun '19

03 Jun '19

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky(a)amd.com> --- drivers/gpu/drm/scheduler/sched_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 49e7d07..c1058ee 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -353,6 +353,7 @@ EXPORT_SYMBOL(drm_sched_increase_karma); * drm_sched_stop - stop the scheduler * * @sched: scheduler instance + * @bad: job which caused the time out * * Stop the scheduler and also removes and frees all completed jobs. * Note: bad job will not be freed as it might be used later and so it's @@ -422,6 +423,7 @@ EXPORT_SYMBOL(drm_sched_stop); * drm_sched_job_recovery - recover jobs after a reset * * @sched: scheduler instance + * @full_recovery: proceed with complete sched restart * */ void drm_sched_start(struct drm_gpu_scheduler *sched, bool full_recovery) -- 2.7.4

5 7

Re: drm_gem_dumb_map_offset patch
by Noralf Trønnes 03 Jun '19

03 Jun '19

Hi, [add Daniel Vetter] [cc dri-devel] Den 29.05.2019 15.09, skrev Pierre Yves MORDRET: > Hello Noralf, > > Sorry for bothering you with question but I need to better understand the > rational about a patch you did in DRM/GEM. > > First of all, let me introduce myself. > I'm currently employee to STMicroelectronics company and in charge of GPU > integration within STM32 MPU (Cortex A7 + Cortex M4) > > On Cortex A7 is running a Linux Kernel 4.19 as for today. > > We came across some trouble when we switch from Kernel 4.14 to 4.19 for GPU > stack. On august you submit this commit : > > 90378e58919285637aa0f063c04ba0c6449d98b1 > drm/gem: drm_gem_dumb_map_offset(): reject dma-buf > > Reject mapping an imported dma-buf since is's an invalid use-case. > > In Userland GPU stack we have such statements : > bo_map_fd > DRM_IOCTL_MODE_MAP_DUMB > mmap (offset) > > With the patch above, ioctl returns an error EINVAL and prevents the nmap. > As for today we revert this patch and it works fine in our end. > > Thus the questions are : > - what is the rational behind this fix ? > - What we doing wrong this situation ? > - What do we need in such situation ? > I need to pass those on to Daniel Vetter (DRM maintainer) since he wanted the change. The details were never clear to me. Some of the discussion is here: https://patchwork.freedesktop.org/patch/172242/ Noralf. > Many thanks in advance. > Best Regards >

3 3

[Bug 110823] [Intel-GFX-CI][BAT] igt@amdgpu/amd_basic@userptr - fail - Failed assertion: r == 0
by bugzilla-daemon＠freedesktop.org 03 Jun '19

03 Jun '19

https://bugs.freedesktop.org/show_bug.cgi?id=110823 --- Comment #3 from Chris Wilson <chris(a)chris-wilson.co.uk> --- (In reply to Martin Peres from comment #0) > Hi, it looks like amdgpu's userptrs are now broken: > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6179/fi-kbl-8809g/ > igt@amdgpu_amd_basic@userptr.html > > Starting subtest: userptr > (amd_basic:3888) CRITICAL: Test assertion failure function > amdgpu_userptr_test, file ../tests/amdgpu/amd_basic.c:1331: > (amd_basic:3888) CRITICAL: Failed assertion: r == 0 > (amd_basic:3888) CRITICAL: Last errno: 19, No such device > (amd_basic:3888) CRITICAL: error: -19 != 0 Is quite clear for a change. Now one might argue that amdgpu changing the userptr ABI behind a non-default config option from a default option is a bit mean... -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110823] [Intel-GFX-CI][BAT] igt@amdgpu/amd_basic@userptr - fail - Failed assertion: r == 0
by bugzilla-daemon＠freedesktop.org 03 Jun '19

03 Jun '19

https://bugs.freedesktop.org/show_bug.cgi?id=110823 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|DRM/AMDgpu |IGT --- Comment #2 from Chris Wilson <chris(a)chris-wilson.co.uk> --- CI config error. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PULL] drm-intel-fixes
by Joonas Lahtinen 03 Jun '19

03 Jun '19

Hi Dave & Daniel, Missed last week's window of opportunity due to trouble getting CI results for Icelake. So this is against -rc2 still to avoid re-doing the GVT pull third time. Just a single Icelake W/A for i915. For GVT a fix for recently seen arbitrary DMA map fault and more enforcement fixes. I'll be on my summer vacation starting end of this week, so Jani/Rodrigo will cover for the rest of the -rcs. Regards, Joonas *** drm-intel-fixes-2019-06-03: - Add missing Icelake W/A to disable GPU hang on cache ECC error The following changes since commit cd6c84d8f0cdc911df435bb075ba22ce3c605b07: Linux 5.2-rc2 (2019-05-26 16:49:19 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2019-06-03 for you to fetch changes up to afb286bcae85ee816e8497596bf8e7f83347f47b: Merge tag 'gvt-fixes-2019-05-30' of https://github.com/intel/gvt-linux into drm-intel-fixes (2019-05-31 10:51:59 +0300) ---------------------------------------------------------------- - Add missing Icelake W/A to disable GPU hang on cache ECC error ---------------------------------------------------------------- Colin Xu (3): drm/i915/gvt: Update force-to-nonpriv register whitelist drm/i915/gvt: Fix GFX_MODE handling drm/i915/gvt: Fix vGPU CSFE_CHICKEN1_REG mmio handler Gao, Fred (1): drm/i915/gvt: Fix cmd length of VEB_DI_IECP Joonas Lahtinen (1): Merge tag 'gvt-fixes-2019-05-30' of https://github.com/intel/gvt-linux into drm-intel-fixes Tina Zhang (1): drm/i915/gvt: Initialize intel_gvt_gtt_entry in stack Tvrtko Ursulin (1): drm/i915/icl: Add WaDisableBankHangMode Xiong Zhang (1): drm/i915/gvt: refine ggtt range validation drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- drivers/gpu/drm/i915/gvt/gtt.c | 26 +++++++++++++++-------- drivers/gpu/drm/i915/gvt/handlers.c | 36 +++++++++++++++++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_workarounds.c | 6 ++++++ 5 files changed, 62 insertions(+), 11 deletions(-)

1 0

[v2 0/3] Document fixes for DRM UAPI and HDR
by Uma Shankar 03 Jun '19

03 Jun '19

This series adds DRM UAPI header structure documentation to kernel docs. Fixes issues with existing structure documentation in drm uapi header. This also fixes warnings in HDR doc and addresses suggestions from Daniel Vetter. v2: 2 patches from v1 are merged. This series version adds remaining on top of that. Addressed review comments from Daniel Vetter. Uma Shankar (3): drm: ADD UAPI structure definition section in kernel doc drm: Fix docbook warnings in hdr metadata helper structures video/hdmi: Dropped static functions from kernel doc Documentation/gpu/drm-uapi.rst | 9 +++++ drivers/gpu/drm/drm_connector.c | 37 +++++++++++++++++++++ drivers/video/hdmi.c | 30 ----------------- include/drm/drm_connector.h | 1 + include/drm/drm_mode_config.h | 4 +-- include/linux/hdmi.h | 12 +++++++ include/uapi/drm/drm_mode.h | 74 ++++++++++++++++++++++++++++++++++++++++- 7 files changed, 134 insertions(+), 33 deletions(-) -- 1.9.1

1 3

Re: [PATCH] of/device: add blacklist for iommu dma_ops
by Vivek Gautam 03 Jun '19

03 Jun '19

On Mon, Jun 3, 2019 at 4:47 PM Christoph Hellwig <hch(a)lst.de> wrote: > > If you (and a few others actors in the thread) want people to actually > read what you wrote please follow proper mailing list ettiquette. I've > given up on reading all the recent mails after scrolling through two > pages of full quotes. Apologies for not cutting down the quoted text. I will be more careful next time onwards. Regards Vivek -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2019