dri-devel August 2019

dri-devel@lists.freedesktop.org

318 participants
2338 discussions

[PATCH libdrm v2 1/4] meson.build: Fix typo
by Emil Velikov 01 Aug '19

01 Aug '19

From: Niclas Zeising <zeising(a)daemonic.se> Reviewed-by: Emil Velikov <emil.l.velikov(a)gmail.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index be768afa..64f0d5b1 100644 --- a/meson.build +++ b/meson.build @@ -248,7 +248,7 @@ if prog_xslt.found() endif with_man_pages = with_man_pages != 'false' and prog_xslt.found() and prog_sed.found() -# Used for tets +# Used for tests prog_bash = find_program('bash') config.set10('HAVE_VISIBILITY', -- 2.21.0

3 10

[PATCH -next] drm/i915: fix possible memory leak in intel_hdcp_auth_downstream()
by Wei Yongjun 01 Aug '19

01 Aug '19

'ksv_fifo' is malloced in intel_hdcp_auth_downstream() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Signed-off-by: Wei Yongjun <weiyongjun1(a)huawei.com> --- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index bc3a94d491c4..27bd7276a82d 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -536,7 +536,8 @@ int intel_hdcp_auth_downstream(struct intel_connector *connector) if (drm_hdcp_check_ksvs_revoked(dev, ksv_fifo, num_downstream)) { DRM_ERROR("Revoked Ksv(s) in ksv_fifo\n"); - return -EPERM; + ret = -EPERM; + goto err; } /*

2 1

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled
by Liviu Dudau 01 Aug '19

01 Aug '19

On Thu, Aug 01, 2019 at 06:31:13AM +0000, Lowry Li (Arm Technology China) wrote: > Hi Liviu, > > On Wed, Jul 31, 2019 at 01:15:25PM +0000, Liviu Dudau wrote: > > Hi Lowry, > > > > On Wed, Jul 31, 2019 at 11:04:45AM +0000, Lowry Li (Arm Technology China) wrote: > > > During it signals the completion of a writeback job, after releasing > > > the out_fence, we'd clear the pointer. > > > > > > Check if fence left over in drm_writeback_cleanup_job(), release it. > > > > > > Signed-off-by: Lowry Li (Arm Technology China) <lowry.li(a)arm.com> > > > --- > > > drivers/gpu/drm/drm_writeback.c | 23 +++++++++++++++-------- > > > 1 file changed, 15 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c > > > index ff138b6..43d9e3b 100644 > > > --- a/drivers/gpu/drm/drm_writeback.c > > > +++ b/drivers/gpu/drm/drm_writeback.c > > > @@ -324,6 +324,9 @@ void drm_writeback_cleanup_job(struct drm_writeback_job *job) > > > if (job->fb) > > > drm_framebuffer_put(job->fb); > > > > > > + if (job->out_fence) > > > + dma_fence_put(job->out_fence); > > > + > > > kfree(job); > > > } > > > > This change looks good. > > > > > EXPORT_SYMBOL(drm_writeback_cleanup_job); > > > @@ -366,25 +369,29 @@ static void cleanup_work(struct work_struct *work) > > > { > > > unsigned long flags; > > > struct drm_writeback_job *job; > > > + struct dma_fence *out_fence; > > > > > > spin_lock_irqsave(&wb_connector->job_lock, flags); > > > job = list_first_entry_or_null(&wb_connector->job_queue, > > > struct drm_writeback_job, > > > list_entry); > > > - if (job) { > > > + if (job) > > > list_del(&job->list_entry); > > > - if (job->out_fence) { > > > - if (status) > > > - dma_fence_set_error(job->out_fence, status); > > > - dma_fence_signal(job->out_fence); > > > - dma_fence_put(job->out_fence); > > > > *Here* > > > > > - } > > > - } > > > + > > > spin_unlock_irqrestore(&wb_connector->job_lock, flags); > > > > > > if (WARN_ON(!job)) > > > return; > > > > > > + out_fence = job->out_fence; > > > + if (out_fence) { > > > + if (status) > > > + dma_fence_set_error(out_fence, status); > > > + dma_fence_signal(out_fence); > > > + dma_fence_put(out_fence); > > > + job->out_fence = NULL; > > > + } > > > + > > > > I don't get the point of this change. Why not just add job->out_fence = NULL > > where *Here* is? > > > > Best regards, > > Liviu > Besides setting NULL, also did a refine by moving the fence operation > out of the lock block. OK, now it makes sense. May I suggest you add that to the commit message? Otherwise, Acked-by: Liviu Dudau <liviu.dudau(a)arm.com> Best regards, Liviu > > Best regards, > Lowry > > > INIT_WORK(&job->cleanup_work, cleanup_work); > > > queue_work(system_long_wq, &job->cleanup_work); > > > } > > > -- > > > 1.9.1 > > > > > > > -- > > ==================== > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > ¯\_(ツ)_/¯ > > -- > Regards, > Lowry -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯

1 0

[PATCH] drm/panel: make drm_panel.h self-contained
by Jani Nikula 01 Aug '19

01 Aug '19

Fix build warning if drm_panel.h is built with CONFIG_OF=n or CONFIG_DRM_PANEL=n and included without the prerequisite err.h: ./include/drm/drm_panel.h: In function ‘of_drm_find_panel’: ./include/drm/drm_panel.h:203:9: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration] return ERR_PTR(-ENODEV); ^~~~~~~ ./include/drm/drm_panel.h:203:9: error: returning ‘int’ from a function with return type ‘struct drm_panel *’ makes pointer from integer without a cast [-Werror=int-conversion] return ERR_PTR(-ENODEV); ^~~~~~~~~~~~~~~~ Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL") Cc: Boris Brezillon <boris.brezillon(a)bootlin.com> Cc: Thierry Reding <treding(a)nvidia.com> Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> --- I don't know if there's a combo where this actually fails, so I'm not adding cc: stable. It's just something I hit when playing with other code. --- include/drm/drm_panel.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 8c738c0e6e9f..26377836141c 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -24,6 +24,7 @@ #ifndef __DRM_PANEL_H__ #define __DRM_PANEL_H__ +#include <linux/err.h> #include <linux/errno.h> #include <linux/list.h> -- 2.20.1

3 3

[PATCH] drm/omap: Add 'alpha' and 'pixel blend mode' plane properties
by Jean-Jacques Hiblot 01 Aug '19

01 Aug '19

Add the following properties for planes: * alpha * pixel blend mode. Only "Pre-multiplied" and "Coverage" are supported Signed-off-by: Jean-Jacques Hiblot <jjhiblot(a)ti.com> --- drivers/gpu/drm/omapdrm/omap_plane.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c index 84e1be981cfe..73ec99819a3d 100644 --- a/drivers/gpu/drm/omapdrm/omap_plane.c +++ b/drivers/gpu/drm/omapdrm/omap_plane.c @@ -53,8 +53,12 @@ static void omap_plane_atomic_update(struct drm_plane *plane, memset(&info, 0, sizeof(info)); info.rotation_type = OMAP_DSS_ROT_NONE; info.rotation = DRM_MODE_ROTATE_0; - info.global_alpha = 0xff; + info.global_alpha = state->alpha >> 8; info.zorder = state->normalized_zpos; + if (state->pixel_blend_mode == DRM_MODE_BLEND_PREMULTI) + info.pre_mult_alpha = 1; + else + info.pre_mult_alpha = 0; /* update scanout: */ omap_framebuffer_update_scanout(state->fb, state, &info); @@ -285,6 +289,9 @@ struct drm_plane *omap_plane_init(struct drm_device *dev, omap_plane_install_properties(plane, &plane->base); drm_plane_create_zpos_property(plane, 0, 0, num_planes - 1); + drm_plane_create_alpha_property(plane); + drm_plane_create_blend_mode_property(plane, BIT(DRM_MODE_BLEND_PREMULTI) | + BIT(DRM_MODE_BLEND_COVERAGE)); return plane; -- 2.17.1

2 1

[PATCH 1/8] drm/amdgpu: drop drmP.h in amdgpu_amdkfd_arcturus.c
by Alex Deucher 01 Aug '19

01 Aug '19

Unused. Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c index 4d9101834ba7..c79aaebeeaf0 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c @@ -28,7 +28,6 @@ #include <linux/uaccess.h> #include <linux/mmu_context.h> #include <linux/firmware.h> -#include <drm/drmP.h> #include "amdgpu.h" #include "amdgpu_amdkfd.h" #include "sdma0/sdma0_4_2_2_offset.h" -- 2.20.1

4 10

linux-next: build failure after merge of the drm-misc tree
by Stephen Rothwell 01 Aug '19

01 Aug '19

Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_connector': drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: error: 'ddc' undeclared (first use in this function) ddc = &radeon_connector->ddc_bus->adapter; ^~~ drivers/gpu/drm/radeon/radeon_connectors.c:2433:5: note: each undeclared identifier is reported only once for each function it appears in Caused by commit bed7a2182de6 ("drm/radeon: Provide ddc symlink in connector sysfs directory") I have used the drm-misc tree from next-20190731 for today. -- Cheers, Stephen Rothwell

1 0

[Bug 110961] Are provoded libdrm packages completely open source?
by bugzilla-daemon＠freedesktop.org 01 Aug '19

01 Aug '19

https://bugs.freedesktop.org/show_bug.cgi?id=110961 Bug ID: 110961 Summary: Are provoded libdrm packages completely open source? Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: major Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel(a)lists.freedesktop.org Reporter: ashark(a)linuxcomp.ru 19.20-812932 release for Ubuntu Provided libdrm related packages have MIT licence. But are they built completely from open source? In the changelog I can see that it is some amd-mainline-hybrid-master20190125. And actually if I omit these packages while using proprietay OpenGL, applications crashes; and clinfo utility crashes with segfault. I tested it in Ubuntu 18.04.2, in Ubuntu 19.04 and in Arch Linux. In Ubuntu 19.04 the repo's libraries have the same version as provided in bundled archive. But it was still failing with them (I even tried to place repo's libraries to /opt location, it did not help). I want to avoid needing of installation of these libdrm packages (libdrm-amdgpu-amdgpu1, libdrm-amdgpu-common, libdrm2-amdgpu) because I am repacking amdgpu-pro for arch linux. Is that possible? If not, then why do not name these packages and their libraries with -pro prefix? Ideally, I want it to use libdrm provided by arch linux. In that case I could even repack all other files to the normal system paths instead of placing all to /opt. List of packages that I still use for Arch are: libdrm-amdgpu-amdgpu1: provides libdrm_amdgpu.so.1.0.0 libdrm-amdgpu-common: provides amdgpu.ids file that slightly differs from Arch's standard one libdrm2-amdgpu: provides 91-amdgpu-pro-modeset.rules libdrm.so.2.4.0 libkms.so.1.0.0 -- You are receiving this mail because: You are the assignee for the bug.

1 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2019