dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH] drm: rcar_lvds: Fix color mismatches on R-Car H2 ES2.0 and later
by Geert Uytterhoeven 26 Sep '19

26 Sep '19

Commit 5cca30ebe089be23 ("drm/rcar-du: Add LVDS_LANES quirk") states that LVDS lanes 1 and 3 are inverted on R-Car H2 ES1 only, and that the problem has been fixed in newer revisions. However, the code didn't take into account the actual hardware revision, thus applying the quirk also on newer hardware revisions, causing green color reversals. Fix this by applying the quirk when running on R-Car H2 ES1.x only. Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> Fixes: c6a27fa41fabb35f ("drm: rcar-du: Convert LVDS encoder code to bridge driver") Signed-off-by: Geert Uytterhoeven <geert+renesas(a)glider.be> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> --- Does anyone know if this was fixed in ES2.0, or in any earlier ES1.x? While the issue was present before aforementioned commit, I do not think there is a real need to fix the older code variant, as the new LVDS encoder was backported to v4.14-ltsi. --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 3fc7e6899cab5843..50c11a7f0467f746 100644 --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c @@ -16,6 +16,7 @@ #include <linux/of_graph.h> #include <linux/platform_device.h> #include <linux/slab.h> +#include <linux/sys_soc.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> @@ -842,8 +843,23 @@ static int rcar_lvds_get_clocks(struct rcar_lvds *lvds) return 0; } +static const struct rcar_lvds_device_info rcar_lvds_r8a7790es1_info = { + .gen = 2, + .quirks = RCAR_LVDS_QUIRK_LANES, + .pll_setup = rcar_lvds_pll_setup_gen2, +}; + +static const struct soc_device_attribute lvds_quirk_matches[] = { + { + .soc_id = "r8a7790", .revision = "ES1.*", + .data = &rcar_lvds_r8a7790es1_info, + }, + { /* sentinel */ } +}; + static int rcar_lvds_probe(struct platform_device *pdev) { + const struct soc_device_attribute *attr; struct rcar_lvds *lvds; struct resource *mem; int ret; @@ -857,6 +873,10 @@ static int rcar_lvds_probe(struct platform_device *pdev) lvds->dev = &pdev->dev; lvds->info = of_device_get_match_data(&pdev->dev); + attr = soc_device_match(lvds_quirk_matches); + if (attr) + lvds->info = attr->data; + ret = rcar_lvds_parse_dt(lvds); if (ret < 0) return ret; @@ -893,12 +913,6 @@ static const struct rcar_lvds_device_info rcar_lvds_gen2_info = { .pll_setup = rcar_lvds_pll_setup_gen2, }; -static const struct rcar_lvds_device_info rcar_lvds_r8a7790_info = { - .gen = 2, - .quirks = RCAR_LVDS_QUIRK_LANES, - .pll_setup = rcar_lvds_pll_setup_gen2, -}; - static const struct rcar_lvds_device_info rcar_lvds_gen3_info = { .gen = 3, .quirks = RCAR_LVDS_QUIRK_PWD, @@ -930,7 +944,7 @@ static const struct of_device_id rcar_lvds_of_table[] = { { .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info }, { .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info }, { .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info }, - { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info }, + { .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_gen2_info }, { .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info }, { .compatible = "renesas,r8a7793-lvds", .data = &rcar_lvds_gen2_info }, { .compatible = "renesas,r8a7795-lvds", .data = &rcar_lvds_gen3_info }, -- 2.17.1

4 4

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming
by bugzilla-daemon＠freedesktop.org 26 Sep '19

26 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #107 from jeroenimo <freedesktop(a)jeroenimo.nl> --- I have a workaround that at least makes the system workable. After some testing I managed to run glmark2 at the lowest and second lowest clock speed on my RX560 >From root: echo manual > /sys/class/drm/card0/device/power_dpm_force_performance_level echo 1 > /sys/class/drm/card0/device/pp_dpm_sclk giving me this cat /sys/class/drm/card0/device/pp_dpm_sclk 0: 214Mhz 1: 387Mhz * 2: 843Mhz 3: 995Mhz 4: 1062Mhz 5: 1108Mhz 6: 1149Mhz 7: 1176Mhz Obviously this decreases performance big time, but I don't really game so it makes my system usable. Any clock speeds over 4: 1062Mhz crashes my system immediately.. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH v2] drm: Don't free jobs in wait_event_interruptible()
by Steven Price 26 Sep '19

26 Sep '19

drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the condition of wait_event_interruptible() it must not sleep. Unfortuantly some free callbacks (notibly for Panfrost) do sleep. Instead let's rename drm_sched_cleanup_jobs() to drm_sched_get_cleanup_job() and simply return a job for processing if there is one. The caller can then call the free_job() callback outside the wait_event_interruptible() where sleeping is possible before re-checking and returning to sleep if necessary. Signed-off-by: Steven Price <steven.price(a)arm.com> --- Changes from v1: * Move list_first_entry_or_null() within the lock drivers/gpu/drm/scheduler/sched_main.c | 44 ++++++++++++++------------ 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 9a0ee74d82dc..0ed4aaa4e6d1 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -622,43 +622,41 @@ static void drm_sched_process_job(struct dma_fence *f, struct dma_fence_cb *cb) } /** - * drm_sched_cleanup_jobs - destroy finished jobs + * drm_sched_get_cleanup_job - fetch the next finished job to be destroyed * * @sched: scheduler instance * - * Remove all finished jobs from the mirror list and destroy them. + * Returns the next finished job from the mirror list (if there is one) + * ready for it to be destroyed. */ -static void drm_sched_cleanup_jobs(struct drm_gpu_scheduler *sched) +static struct drm_sched_job * +drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched) { + struct drm_sched_job *job = NULL; unsigned long flags; /* Don't destroy jobs while the timeout worker is running */ if (sched->timeout != MAX_SCHEDULE_TIMEOUT && !cancel_delayed_work(&sched->work_tdr)) - return; - - - while (!list_empty(&sched->ring_mirror_list)) { - struct drm_sched_job *job; + return NULL; - job = list_first_entry(&sched->ring_mirror_list, + job = list_first_entry_or_null(&sched->ring_mirror_list, struct drm_sched_job, node); - if (!dma_fence_is_signaled(&job->s_fence->finished)) - break; - spin_lock_irqsave(&sched->job_list_lock, flags); + spin_lock_irqsave(&sched->job_list_lock, flags); + + if (job && dma_fence_is_signaled(&job->s_fence->finished)) { /* remove job from ring_mirror_list */ list_del_init(&job->node); - spin_unlock_irqrestore(&sched->job_list_lock, flags); - - sched->ops->free_job(job); + } else { + job = NULL; + /* queue timeout for next job */ + drm_sched_start_timeout(sched); } - /* queue timeout for next job */ - spin_lock_irqsave(&sched->job_list_lock, flags); - drm_sched_start_timeout(sched); spin_unlock_irqrestore(&sched->job_list_lock, flags); + return job; } /** @@ -698,12 +696,18 @@ static int drm_sched_main(void *param) struct drm_sched_fence *s_fence; struct drm_sched_job *sched_job; struct dma_fence *fence; + struct drm_sched_job *cleanup_job = NULL; wait_event_interruptible(sched->wake_up_worker, - (drm_sched_cleanup_jobs(sched), + (cleanup_job = drm_sched_get_cleanup_job(sched)) || (!drm_sched_blocked(sched) && (entity = drm_sched_select_entity(sched))) || - kthread_should_stop())); + kthread_should_stop()); + + while (cleanup_job) { + sched->ops->free_job(cleanup_job); + cleanup_job = drm_sched_get_cleanup_job(sched); + } if (!entity) continue; -- 2.20.1

1 1

[PATCH -next] fbdev: c2p: Fix link failure on non-inlining
by Geert Uytterhoeven 26 Sep '19

26 Sep '19

When the compiler decides not to inline the Chunky-to-Planar core functions, the build fails with: c2p_planar.c:(.text+0xd6): undefined reference to `c2p_unsupported' c2p_planar.c:(.text+0x1dc): undefined reference to `c2p_unsupported' c2p_iplan2.c:(.text+0xc4): undefined reference to `c2p_unsupported' c2p_iplan2.c:(.text+0x150): undefined reference to `c2p_unsupported' Fix this by marking the functions __always_inline. Reported-by: noreply(a)ellerman.id.au Signed-off-by: Geert Uytterhoeven <geert(a)linux-m68k.org> --- Fixes: 025f072e5823947c ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly") As this is a patch in akpm's tree, the commit ID in the Fixes tag is not stable. --- drivers/video/fbdev/c2p_core.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/c2p_core.h b/drivers/video/fbdev/c2p_core.h index e1035a865fb945f0..45a6d895a7d7208e 100644 --- a/drivers/video/fbdev/c2p_core.h +++ b/drivers/video/fbdev/c2p_core.h @@ -29,7 +29,7 @@ static inline void _transp(u32 d[], unsigned int i1, unsigned int i2, extern void c2p_unsupported(void); -static inline u32 get_mask(unsigned int n) +static __always_inline u32 get_mask(unsigned int n) { switch (n) { case 1: @@ -57,7 +57,7 @@ static inline u32 get_mask(unsigned int n) * Transpose operations on 8 32-bit words */ -static inline void transp8(u32 d[], unsigned int n, unsigned int m) +static __always_inline void transp8(u32 d[], unsigned int n, unsigned int m) { u32 mask = get_mask(n); @@ -99,7 +99,7 @@ static inline void transp8(u32 d[], unsigned int n, unsigned int m) * Transpose operations on 4 32-bit words */ -static inline void transp4(u32 d[], unsigned int n, unsigned int m) +static __always_inline void transp4(u32 d[], unsigned int n, unsigned int m) { u32 mask = get_mask(n); @@ -126,7 +126,7 @@ static inline void transp4(u32 d[], unsigned int n, unsigned int m) * Transpose operations on 4 32-bit words (reverse order) */ -static inline void transp4x(u32 d[], unsigned int n, unsigned int m) +static __always_inline void transp4x(u32 d[], unsigned int n, unsigned int m) { u32 mask = get_mask(n); -- 2.17.1

2 4

[Bug 111747] [CI][DRMTIP] igt@ - incomplete - Jenkins gives up
by bugzilla-daemon＠freedesktop.org 26 Sep '19

26 Sep '19

1 0

[PATCH] drm/lima: allow to retry when allocating memory for BO
by Icenowy Zheng 26 Sep '19

26 Sep '19

Currently, when allocating the memory for BO by Mesa, the lima kernel driver set only GFP_DMA32 flag; and this allocation may fail when the memory is relatively adequate, thus retrying is needed. Add the GFP flags for retrying memory allocation. Signed-off-by: Icenowy Zheng <icenowy(a)aosc.io> --- drivers/gpu/drm/lima/lima_object.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/lima/lima_object.c b/drivers/gpu/drm/lima/lima_object.c index 87123b1d083c..1389aa1b948b 100644 --- a/drivers/gpu/drm/lima/lima_object.c +++ b/drivers/gpu/drm/lima/lima_object.c @@ -91,7 +91,9 @@ struct lima_bo *lima_bo_create(struct lima_device *dev, u32 size, goto err_out; } } else { - mapping_set_gfp_mask(bo->gem.filp->f_mapping, GFP_DMA32); + mapping_set_gfp_mask(bo->gem.filp->f_mapping, + GFP_DMA32 | __GFP_RETRY_MAYFAIL | + __GFP_NOWARN); bo->pages = drm_gem_get_pages(&bo->gem); if (IS_ERR(bo->pages)) { ret = ERR_CAST(bo->pages); -- 2.21.0

1 0

[Bug 111826] resmi
by bugzilla-daemon＠freedesktop.org 26 Sep '19

26 Sep '19

1 0

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming
by bugzilla-daemon＠freedesktop.org 26 Sep '19

26 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #106 from jeroenimo <freedesktop(a)jeroenimo.nl> --- This is quite a severe bug. I have reasonable stable system with Mint 19.2 (runs hours without a crash uname -a Linux jeroenimo-amd 4.15.0-64-generic #73-Ubuntu SMP Thu Sep 12 13:16:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux (X)ubuntu 18.04 LTS LTS crashes a lot faster (1 or 2 minutes) 5.0.0.29 kernel I can reproduce the bug with glmark2 instantly 100% of the times (https://launchpad.net/glmark2) or sudo apt install glmark2 I'm not very good at debugging but this is what my dmesg looks like when I ssh and run glmark2 [ 6619.587749] [drm:drm_atomic_helper_wait_for_flip_done [drm_kms_helper]] *ERROR* [CRTC:45:crtc-1] flip_done timed out And that's it, no more info. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 111747] [CI][DRMTIP] igt@ - incomplete - Jenkins gives up
by bugzilla-daemon＠freedesktop.org 26 Sep '19

26 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=111747 --- Comment #6 from CI Bug Log <cibuglog(a)gmail.com> --- A CI Bug Log filter associated to this bug has been updated: {- TGL: igt@* -incomplete - Abort requested by .* terminating children -} {+ TGL: igt@* -incomplete - Abort requested by .* terminating children +} New failures caught by the filter: * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_378/fi-tgl-u2/igt@kms_curso… -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 108547] RX550 amdgpu_job_timedout ring sdma0 timeout; failed to send message; uvd_v6_0_enc_ring_test_ring; amdgpu_device_ip_resume failed
by bugzilla-daemon＠freedesktop.org 26 Sep '19

26 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=108547 Bug ID: 108547 Summary: RX550 amdgpu_job_timedout ring sdma0 timeout; failed to send message; uvd_v6_0_enc_ring_test_ring; amdgpu_device_ip_resume failed Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu Assignee: dri-devel(a)lists.freedesktop.org Reporter: anode.dev(a)gmail.com Created attachment 142190 --> https://bugs.freedesktop.org/attachment.cgi?id=142190&action=edit dmesg log file I had a lot of warning/or error messages in dmesg, sometimes UI and keyboard is completely freezes for several seconds, especially when browsing youtube - [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma0 timeout; - [drm] IP block:gfx_v8_0 is hung! - failed to send message N ret is 0 - [drm:uvd_v6_0_enc_ring_test_ring [amdgpu]] *ERROR* amdgpu: ring 13 test failed - [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <uvd_v6_0> failed -110 - amdgpu_device_ip_resume failed - amdgpu: [powerplay] Voltage value looks like a Leakage ID but it's not patched Linux version 4.18.16-arch1-1-ARCH (builduser@heftig-28760) (gcc version 8.2.1 20180831 (GCC)) #1 SMP PREEMPT Sat Oct 20 22:06:45 UTC 2018 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Wani [Radeon R5/R6/R7 Graphics] (rev ca) (prog-if 00 [VGA controller]) Subsystem: Acer Incorporated [ALI] Wani [Radeon R5/R6/R7 Graphics] Flags: bus master, fast devsel, latency 0, IRQ 43 Memory at e0000000 (64-bit, prefetchable) [size=256M] Memory at d0800000 (64-bit, prefetchable) [size=8M] I/O ports at 4000 [size=256] Memory at d1500000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at 000c0000 [disabled] [size=128K] Capabilities: [48] Vendor Specific Information: Len=08 <?> Capabilities: [50] Power Management version 3 Capabilities: [58] Express Root Complex Integrated Endpoint, MSI 00 Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Capabilities: [100] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?> Capabilities: [270] Secondary PCI Express <?> Capabilities: [2b0] Address Translation Service (ATS) Capabilities: [2c0] Page Request Interface (PRI) Capabilities: [2d0] Process Address Space ID (PASID) Kernel driver in use: amdgpu Kernel modules: amdgpu 03:00.0 Display controller: Advanced Micro Devices, Inc. [AMD/ATI] Lexa PRO [Radeon RX 550/550X] (rev c3) Subsystem: Acer Incorporated [ALI] Lexa PRO [Radeon RX 550/550X] Physical Slot: 0 Flags: bus master, fast devsel, latency 0, IRQ 50 Memory at c0000000 (64-bit, prefetchable) [size=256M] Memory at d0000000 (64-bit, prefetchable) [size=2M] I/O ports at 2000 [size=256] Memory at d1200000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at d1240000 [disabled] [size=128K] Capabilities: [48] Vendor Specific Information: Len=08 <?> Capabilities: [50] Power Management version 3 Capabilities: [58] Express Legacy Endpoint, MSI 00 Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Capabilities: [100] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?> Capabilities: [270] Secondary PCI Express <?> Capabilities: [320] Latency Tolerance Reporting Kernel driver in use: amdgpu Kernel modules: amdgpu Please let me know if I can help with something -- You are receiving this mail because: You are the assignee for the bug.

1 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019