dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PULL] drm-intel-next-fixes
by Rodrigo Vivi 19 Sep '19

19 Sep '19

Hi Dave and Daniel, Here goes drm-intel-next-fixes-2019-09-19: - Extend old HSW workaround to fix some GPU hangs on Haswell GT2 - Fix return error code on GEM mmap. - White list a chicken bit register for push constants legacy mode on Mesa - Fix resume issue related to GGTT restore - Remove incorrect BUG_ON on execlist's schedule-out - Fix unrecoverable GPU hangs with Vulkan compute workloads on SKL Thanks, Rodrigo. The following changes since commit 6e5c5272ca00809aae20817efb6f25881268b50b: drm/i915: Use NOEVICT for first pass on attemping to pin a GGTT mmap (2019-09-06 09:53:15 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-fixes-2019-09-19 for you to fetch changes up to a95819a173788bec7414d260f76f42a9934890b4: drm/i915: Extend Haswell GT1 PSMI workaround to all (2019-09-18 10:53:38 -0700) ---------------------------------------------------------------- - Extend old HSW workaround to fix some GPU hangs on Haswell GT2 - Fix return error code on GEM mmap. - White list a chicken bit register for push constants legacy mode on Mesa - Fix resume issue related to GGTT restore - Remove incorrect BUG_ON on execlist's schedule-out - Fix unrecoverable GPU hangs with Vulkan compute workloads on SKL ---------------------------------------------------------------- Chris Wilson (5): drm/i915: Restore relaxed padding (OCL_OOB_SUPPRES_ENABLE) for skl+ drm/i915/execlists: Remove incorrect BUG_ON for schedule-out drm/i915: Perform GGTT restore much earlier during resume drm/i915: Don't mix srcu tag and negative error codes drm/i915: Extend Haswell GT1 PSMI workaround to all Kenneth Graunke (1): drm/i915: Whitelist COMMON_SLICE_CHICKEN2 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 6 ++---- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 3 --- drivers/gpu/drm/i915/gt/intel_lrc.c | 1 - drivers/gpu/drm/i915/gt/intel_reset.c | 8 +++----- drivers/gpu/drm/i915/gt/intel_reset.h | 2 +- drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 +++----- drivers/gpu/drm/i915/i915_drv.c | 5 +++++ drivers/gpu/drm/i915/selftests/i915_gem.c | 6 ++++++ 9 files changed, 21 insertions(+), 20 deletions(-)

1 0

[radeon-alex:amd-mainline-dkms-5.0 3697/3724] include/drm/drm_fb_helper.h:641:1: sparse: the previous one is here
by kbuild test robot 19 Sep '19

19 Sep '19

tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.0 head: a51a5ad4b8daf0dd0a437d51a19c2baa98953675 commit: f460c248a3f0bca3a875602cf40693de672485c4 [3697/3724] drm/amd/autoconf: refactor dma_fence header check reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty git checkout f460c248a3f0bca3a875602cf40693de672485c4 make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) include/kcl/kcl_drm.h:167:1: sparse: sparse: multiple definitions for function 'drm_fb_helper_remove_conflicting_pci_framebuffers' >> include/drm/drm_fb_helper.h:641:1: sparse: the previous one is here include/kcl/kcl_drm.h:390:28: sparse: sparse: redefinition of struct drm_format_name_buf vim +641 include/drm/drm_fb_helper.h 0a3bfe29f81622 Chris Wilson 2016-08-22 627 c9527f0de508b1 Michał Mirosław 2018-09-07 628 /** c9527f0de508b1 Michał Mirosław 2018-09-07 629 * drm_fb_helper_remove_conflicting_pci_framebuffers - remove firmware-configured framebuffers for PCI devices c9527f0de508b1 Michał Mirosław 2018-09-07 630 * @pdev: PCI device c9527f0de508b1 Michał Mirosław 2018-09-07 631 * @resource_id: index of PCI BAR configuring framebuffer memory c9527f0de508b1 Michał Mirosław 2018-09-07 632 * @name: requesting driver name c9527f0de508b1 Michał Mirosław 2018-09-07 633 * c9527f0de508b1 Michał Mirosław 2018-09-07 634 * This function removes framebuffer devices (eg. initialized by firmware) c9527f0de508b1 Michał Mirosław 2018-09-07 635 * using memory range configured for @pdev's BAR @resource_id. c9527f0de508b1 Michał Mirosław 2018-09-07 636 * c9527f0de508b1 Michał Mirosław 2018-09-07 637 * The function assumes that PCI device with shadowed ROM drives a primary c9527f0de508b1 Michał Mirosław 2018-09-07 638 * display and so kicks out vga16fb. c9527f0de508b1 Michał Mirosław 2018-09-07 639 */ 4d18975c78f2d5 Michał Mirosław 2018-09-01 640 static inline int 4d18975c78f2d5 Michał Mirosław 2018-09-01 @641 drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, 4d18975c78f2d5 Michał Mirosław 2018-09-01 642 int resource_id, 4d18975c78f2d5 Michał Mirosław 2018-09-01 643 const char *name) 4d18975c78f2d5 Michał Mirosław 2018-09-01 644 { 4d18975c78f2d5 Michał Mirosław 2018-09-01 645 #if IS_REACHABLE(CONFIG_FB) 4d18975c78f2d5 Michał Mirosław 2018-09-01 646 return remove_conflicting_pci_framebuffers(pdev, resource_id, name); 4d18975c78f2d5 Michał Mirosław 2018-09-01 647 #else 4d18975c78f2d5 Michał Mirosław 2018-09-01 648 return 0; 4d18975c78f2d5 Michał Mirosław 2018-09-01 649 #endif 4d18975c78f2d5 Michał Mirosław 2018-09-01 650 } 4d18975c78f2d5 Michał Mirosław 2018-09-01 651 :::::: The code at line 641 was first introduced by commit :::::: 4d18975c78f2d5c91792356501cf369e67594241 fbdev: add remove_conflicting_pci_framebuffers() :::::: TO: Michał Mirosław <mirq-linux(a)rere.qmqm.pl> :::::: CC: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[Bug 99955] [r600g] GPU load always displayed at 100% with GALLIUM_HUD=GPU-load
by bugzilla-daemon＠freedesktop.org 19 Sep '19

19 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=99955 Bug ID: 99955 Summary: [r600g] GPU load always displayed at 100% with GALLIUM_HUD=GPU-load Product: Mesa Version: git Hardware: All OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 Assignee: dri-devel(a)lists.freedesktop.org Reporter: megwattt(a)gmail.com QA Contact: dri-devel(a)lists.freedesktop.org Hello, The GPU-load graph from GALLIUM_HUD will always be at 100%, no matter what application is launched (even glxgears with vblank_mode=3). I tested that on my Radeon HD 5770. This regression is caused by commit b8f3b00742eab6ee1868407b876f69195a51f3b6 : gallium/radeon: include SDMA in the GPU load query. It doesn't seems to affect radeonsi, as the GPU-load results on a TOPAZ XT chip are more reasonable (~5% with the same test). -- You are receiving this mail because: You are the assignee for the bug.

1 8

[PATCH] i915: intel_dp_aux_backlight: Fix max backlight calculations
by Furquan Shaikh 19 Sep '19

19 Sep '19

Max backlight value for the panel was being calculated using byte count i.e. 0xffff if 2 bytes are supported for backlight brightness and 0xff if 1 byte is supported. However, EDP_PWMGEN_BIT_COUNT determines the number of active control bits used for the brightness setting. Thus, even if the panel uses 2 byte setting, it might not use all the control bits. Thus, max backlight should be set based on the value of EDP_PWMGEN_BIT_COUNT instead of assuming 65535 or 255. Additionally, EDP_PWMGEN_BIT_COUNT was being updated based on the VBT frequency which results in a different max backlight value. Thus, setting of EDP_PWMGEN_BIT_COUNT is moved to setup phase instead of enable so that max backlight can be calculated correctly. Only the frequency divider is set during the enable phase using the value of EDP_PWMGEN_BIT_COUNT. Signed-off-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Stéphane Marchesin <marcheu(a)chromium.org> --- drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 132 ++++++++++++------ 1 file changed, 88 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c index 357136f17f85..4636c8e8ae8a 100644 --- a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c @@ -110,61 +110,34 @@ static bool intel_dp_aux_set_pwm_freq(struct intel_connector *connector) { struct drm_i915_private *dev_priv = to_i915(connector->base.dev); struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base); - int freq, fxp, fxp_min, fxp_max, fxp_actual, f = 1; - u8 pn, pn_min, pn_max; + int freq, fxp, f, fxp_actual, fxp_min, fxp_max; + u8 pn; - /* Find desired value of (F x P) - * Note that, if F x P is out of supported range, the maximum value or - * minimum value will applied automatically. So no need to check that. - */ freq = dev_priv->vbt.backlight.pwm_freq_hz; - DRM_DEBUG_KMS("VBT defined backlight frequency %u Hz\n", freq); if (!freq) { DRM_DEBUG_KMS("Use panel default backlight frequency\n"); return false; } - fxp = DIV_ROUND_CLOSEST(KHz(DP_EDP_BACKLIGHT_FREQ_BASE_KHZ), freq); - - /* Use highest possible value of Pn for more granularity of brightness - * adjustment while satifying the conditions below. - * - Pn is in the range of Pn_min and Pn_max - * - F is in the range of 1 and 255 - * - FxP is within 25% of desired value. - * Note: 25% is arbitrary value and may need some tweak. - */ - if (drm_dp_dpcd_readb(&intel_dp->aux, - DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, &pn_min) != 1) { - DRM_DEBUG_KMS("Failed to read pwmgen bit count cap min\n"); + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_PWMGEN_BIT_COUNT, + &pn) < 0) { + DRM_DEBUG_KMS("Failed to read aux pwmgen bit count\n"); return false; } - if (drm_dp_dpcd_readb(&intel_dp->aux, - DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX, &pn_max) != 1) { - DRM_DEBUG_KMS("Failed to read pwmgen bit count cap max\n"); - return false; - } - pn_min &= DP_EDP_PWMGEN_BIT_COUNT_MASK; - pn_max &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + fxp = DIV_ROUND_CLOSEST(KHz(DP_EDP_BACKLIGHT_FREQ_BASE_KHZ), freq); + f = clamp(DIV_ROUND_CLOSEST(fxp, 1 << pn), 1, 255); + fxp_actual = f << pn; + + /* Ensure frequency is within 25% of desired value */ fxp_min = DIV_ROUND_CLOSEST(fxp * 3, 4); fxp_max = DIV_ROUND_CLOSEST(fxp * 5, 4); - if (fxp_min < (1 << pn_min) || (255 << pn_max) < fxp_max) { - DRM_DEBUG_KMS("VBT defined backlight frequency out of range\n"); - return false; - } - for (pn = pn_max; pn >= pn_min; pn--) { - f = clamp(DIV_ROUND_CLOSEST(fxp, 1 << pn), 1, 255); - fxp_actual = f << pn; - if (fxp_min <= fxp_actual && fxp_actual <= fxp_max) - break; - } - - if (drm_dp_dpcd_writeb(&intel_dp->aux, - DP_EDP_PWMGEN_BIT_COUNT, pn) < 0) { - DRM_DEBUG_KMS("Failed to write aux pwmgen bit count\n"); + if (fxp_min > fxp_actual || fxp_actual > fxp_max) { + DRM_DEBUG_KMS("Actual frequency out of range\n"); return false; } + if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_EDP_BACKLIGHT_FREQ_SET, (u8) f) < 0) { DRM_DEBUG_KMS("Failed to write aux backlight freq\n"); @@ -224,16 +197,87 @@ static void intel_dp_aux_disable_backlight(const struct drm_connector_state *old set_aux_backlight_enable(enc_to_intel_dp(old_conn_state->best_encoder), false); } +static u32 intel_dp_aux_calc_max_backlight(struct intel_connector *connector) +{ + struct drm_i915_private *dev_priv = to_i915(connector->base.dev); + struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base); + u32 max_backlight = 0; + int freq, fxp, fxp_min, fxp_max, fxp_actual, f = 1; + u8 pn, pn_min, pn_max; + + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_PWMGEN_BIT_COUNT, &pn)) { + pn &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + max_backlight = (1 << pn) - 1; + } + + /* Find desired value of (F x P) + * Note that, if F x P is out of supported range, the maximum value or + * minimum value will applied automatically. So no need to check that. + */ + freq = dev_priv->vbt.backlight.pwm_freq_hz; + DRM_DEBUG_KMS("VBT defined backlight frequency %u Hz\n", freq); + if (!freq) { + DRM_DEBUG_KMS("Use panel default backlight frequency\n"); + return max_backlight; + } + + fxp = DIV_ROUND_CLOSEST(KHz(DP_EDP_BACKLIGHT_FREQ_BASE_KHZ), freq); + + /* Use highest possible value of Pn for more granularity of brightness + * adjustment while satifying the conditions below. + * - Pn is in the range of Pn_min and Pn_max + * - F is in the range of 1 and 255 + * - FxP is within 25% of desired value. + * Note: 25% is arbitrary value and may need some tweak. + */ + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, &pn_min) != 1) { + DRM_DEBUG_KMS("Failed to read pwmgen bit count cap min\n"); + return max_backlight; + } + if (drm_dp_dpcd_readb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX, &pn_max) != 1) { + DRM_DEBUG_KMS("Failed to read pwmgen bit count cap max\n"); + return max_backlight; + } + pn_min &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + pn_max &= DP_EDP_PWMGEN_BIT_COUNT_MASK; + + fxp_min = DIV_ROUND_CLOSEST(fxp * 3, 4); + fxp_max = DIV_ROUND_CLOSEST(fxp * 5, 4); + if (fxp_min < (1 << pn_min) || (255 << pn_max) < fxp_max) { + DRM_DEBUG_KMS("VBT defined backlight frequency out of range\n"); + return max_backlight; + } + + for (pn = pn_max; pn >= pn_min; pn--) { + f = clamp(DIV_ROUND_CLOSEST(fxp, 1 << pn), 1, 255); + fxp_actual = f << pn; + if (fxp_min <= fxp_actual && fxp_actual <= fxp_max) + break; + } + + if (drm_dp_dpcd_writeb(&intel_dp->aux, + DP_EDP_PWMGEN_BIT_COUNT, pn) < 0) { + DRM_DEBUG_KMS("Failed to write aux pwmgen bit count\n"); + return max_backlight; + } + + max_backlight = (1 << pn) - 1; + + return max_backlight; +} + static int intel_dp_aux_setup_backlight(struct intel_connector *connector, enum pipe pipe) { struct intel_dp *intel_dp = enc_to_intel_dp(&connector->encoder->base); struct intel_panel *panel = &connector->panel; - if (intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT) - panel->backlight.max = 0xFFFF; - else - panel->backlight.max = 0xFF; + panel->backlight.max = intel_dp_aux_calc_max_backlight(connector); + + if (!panel->backlight.max) + return -ENODEV; panel->backlight.min = 0; panel->backlight.level = intel_dp_aux_get_backlight(connector); -- 2.22.0.410.gd8fdbe21b5-goog

4 4

Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
by Xin Ji 19 Sep '19

19 Sep '19

On Thu, Sep 19, 2019 at 08:57:12AM +0200, Neil Armstrong wrote: > Hi, > > On 19/09/2019 08:55, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > > > You can add support to your board with binding. > > > > Example: > > anx_bridge: anx7625@58 { > > compatible = "analogix,anx7625"; > > reg = <0x58>; > > anx,low_power_mode = <1>; > > anx,dsi_supported = <1>; > > anx,dsi_channel = <1>; > > anx,dsi_lanes = <4>; > > anx,internal_pannel = <1>; > > anx,p-on-gpio = <&gpio0 45 GPIO_ACTIVE_LOW>; > > anx,reset-gpio = <&gpio0 73 GPIO_ACTIVE_LOW>; > > status = "okay"; > > port { > > anx7625_1_in: endpoint { > > remote-endpoint = <&mipi_dsi_bridge_1>; > > }; > > }; > > }; > > > > Signed-off-by: Xin Ji <xji(a)analogixsemi.com> > > --- > > .../devicetree/bindings/display/bridge/anx7625.txt | 42 ++++++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.txt b/Documentation/devicetree/bindings/display/bridge/anx7625.txt > > new file mode 100644 > > index 0000000..f2a1c2a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.txt > > @@ -0,0 +1,42 @@ > > +Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) > > +----------------------------------------------- > > New bindings should use yaml format: > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bind… > > Neil OK, I'll follow the yaml format in the next version. Thanks, Xin > > > + > > +The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > > +designed for portable devices. > > + > > +Required properties: > > + > > + - compatible : "analogix,anx7625" > > + - reg : I2C address of the device > > + - anx,low_power_mode : Low power mode support feature > > + - anx,dsi_supported : DSI or DPI > > + - anx,dsi_channel : DSI channel index > > + - anx,dsi_lanes : DSI lane count > > + - anx,intr-hpd-gpio : Which GPIO to use for interrupt > > + > > +Optional properties: > > + > > + - anx,extcon_supported > > + external connector interface support flag > > + - anx,internal_pannel > > + Which indicate internal pannel > > + - anx,p-on-gpio > > + Which GPIO to use for Power On chip > > + - anx,reset-gpio > > + Which GPIO to use for RESET > > + - port > > + SoC specific port nodes with endpoint definitions as defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt, > > + > > +Example: > > + > > + anx_bridge: anx7625@58 { > > + compatible = "analogix,anx7625"; > > + reg = <0x58>; > > + anx,low_power_mode = <0>; > > + anx,dsi_supported = <1>; > > + anx,dsi_channel = <1>; > > + anx,dsi_lanes = <4>; > > + anx,intr-hpd-gpio = <&gpio1 19 IRQ_TYPE_LEVEL_LOW>; > > + status = "okay"; > > + }; > >

1 0

Re: [PATCH v1 0/2] Add initial support for slimport anx7625
by Xin Ji 19 Sep '19

19 Sep '19

On Thu, Sep 19, 2019 at 08:56:01AM +0200, Neil Armstrong wrote: > Hi, > > Please Cc dri-devel(a)lists.freedesktop.org > > Thanks, > Neil OK, thanks. Xin > > On 19/09/2019 08:51, Xin Ji wrote: > > Hi all, > > > > The following series add initial support for the Slimport ANX7625 transmitter, a > > ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. > > > > This is the first version upload, any mistakes, please let me know, I will fix > > it in the next series. > > > > Thanks, > > Xin > > > > > > Xin Ji (2): > > dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding > > drm/bridge: anx7625: Add anx7625 MIPI to DP bridge driver > > > > .../devicetree/bindings/display/bridge/anx7625.txt | 42 + > > drivers/gpu/drm/bridge/Makefile | 2 +- > > drivers/gpu/drm/bridge/analogix/Kconfig | 6 + > > drivers/gpu/drm/bridge/analogix/Makefile | 1 + > > drivers/gpu/drm/bridge/analogix/anx7625.c | 2086 ++++++++++++++++++++ > > drivers/gpu/drm/bridge/analogix/anx7625.h | 397 ++++ > > 6 files changed, 2533 insertions(+), 1 deletion(-) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.txt > > create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c > > create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h > >

1 0

[Bug 111747] [CI][DRMTIP] igt@ - incomplete - Jenkins gives up
by bugzilla-daemon＠freedesktop.org 19 Sep '19

19 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=111747 Chris Wilson <chris(a)chris-wilson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[CI][DRMTIP] |[CI][DRMTIP] igt@ - |igt@gem_fenced_exec_thrash@ |incomplete - Jenkins gives |no-spare-fences - |up |incomplete | QA Contact|intel-gfx-bugs(a)lists.freede | |sktop.org | Assignee|intel-gfx-bugs(a)lists.freede |dri-devel(a)lists.freedesktop |sktop.org |.org Component|DRM/Intel |IGT --- Comment #2 from Chris Wilson <chris(a)chris-wilson.co.uk> --- [37.804681] [11/92] (958s left) gem_fenced_exec_thrash (no-spare-fences) Starting subtest: no-spare-fences [39.958307] Abort requested via Terminated, terminating children [39.958688] Abort requested via Terminated, terminating children [39.959050] Abort requested via Hangup, terminating children [39.959085] Abort requested via Hangup, terminating children [40.581122] Closing watchdogs -- You are receiving this mail because: You are the assignee for the bug.

1 0

[radeon-alex:amd-mainline-dkms-5.0 3698/3724] include/kcl/kcl_fence.h:142:20: error: redefinition of 'dma_fence_set_error'
by kbuild test robot 19 Sep '19

19 Sep '19

Hi Flora, FYI, the error/warning still remains. tree: git://people.freedesktop.org/~agd5f/linux.git amd-mainline-dkms-5.0 head: a51a5ad4b8daf0dd0a437d51a19c2baa98953675 commit: a5784d79d1577c00e6e81f892cde52593546a5f4 [3698/3724] drm/amdkcl: drop kcl_dma_fence_set_error config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 reproduce: git checkout a5784d79d1577c00e6e81f892cde52593546a5f4 # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/scheduler/backport/backport.h:5:0, from <command-line>:0: >> include/kcl/kcl_fence.h:142:20: error: redefinition of 'dma_fence_set_error' static inline void dma_fence_set_error(struct dma_fence *fence, ^~~~~~~~~~~~~~~~~~~ In file included from include/kcl/kcl_fence.h:9:0, from drivers/gpu/drm/scheduler/backport/backport.h:5, from <command-line>:0: include/linux/dma-fence.h:508:20: note: previous definition of 'dma_fence_set_error' was here static inline void dma_fence_set_error(struct dma_fence *fence, ^~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:5:0, from <command-line>:0: include/kcl/kcl_fence.h: In function 'dma_fence_set_error': include/kcl/kcl_fence.h:148:7: error: 'struct dma_fence' has no member named 'status' fence->status = error; ^~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: At top level: include/kcl/kcl_drm.h:167:1: error: redefinition of 'drm_fb_helper_remove_conflicting_pci_framebuffers' drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/kcl/kcl_drm.h:7:0, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: include/drm/drm_fb_helper.h:641:1: note: previous definition of 'drm_fb_helper_remove_conflicting_pci_framebuffers' was here drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_encoder_init': include/kcl/kcl_drm.h:307:9: error: too few arguments to function 'drm_encoder_init' return drm_encoder_init(dev, encoder, funcs, ^~~~~~~~~~~~~~~~ In file included from include/drm/drm_modeset_helper_vtables.h:33:0, from include/drm/drm_atomic_helper.h:32, from include/kcl/kcl_drm.h:11, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: include/drm/drm_encoder.h:183:5: note: declared here int drm_encoder_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_crtc_init_with_planes': include/kcl/kcl_drm.h:322:10: error: too few arguments to function 'drm_crtc_init_with_planes' return drm_crtc_init_with_planes(dev, crtc, primary, ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drmP.h:69:0, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: include/drm/drm_crtc.h:1120:5: note: declared here int drm_crtc_init_with_planes(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_universal_plane_init': include/kcl/kcl_drm.h:343:29: error: incompatible type for argument 7 of 'drm_universal_plane_init' formats, format_count, type); ^~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: include/drm/drm_plane.h:713:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h:342:10: error: too few arguments to function 'drm_universal_plane_init' return drm_universal_plane_init(dev, plane, possible_crtcs, funcs, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: include/drm/drm_plane.h:713:5: note: declared here int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_gem_object_lookup': include/kcl/kcl_drm.h:354:32: error: passing argument 1 of 'drm_gem_object_lookup' from incompatible pointer type [-Werror=incompatible-pointer-types] return drm_gem_object_lookup(dev, filp, handle); ^~~ In file included from include/kcl/kcl_drm.h:10:0, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: include/drm/drm_gem.h:365:24: note: expected 'struct drm_file *' but argument is of type 'struct drm_device *' struct drm_gem_object *drm_gem_object_lookup(struct drm_file *filp, u32 handle); ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/scheduler/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h:354:37: warning: passing argument 2 of 'drm_gem_object_lookup' makes integer from pointer without a cast [-Wint-conversion] return drm_gem_object_lookup(dev, filp, handle); ^~~~ In file included from include/kcl/kcl_drm.h:10:0, from drivers/gpu/drm/scheduler/backport/backport.h:6, from <command-line>:0: -- In file included from drivers/gpu/drm/ttm/backport/backport.h:5:0, from <command-line>:0: >> include/kcl/kcl_fence.h:142:20: error: redefinition of 'dma_fence_set_error' static inline void dma_fence_set_error(struct dma_fence *fence, ^~~~~~~~~~~~~~~~~~~ In file included from include/kcl/kcl_fence.h:9:0, from drivers/gpu/drm/ttm/backport/backport.h:5, from <command-line>:0: include/linux/dma-fence.h:508:20: note: previous definition of 'dma_fence_set_error' was here static inline void dma_fence_set_error(struct dma_fence *fence, ^~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:5:0, from <command-line>:0: include/kcl/kcl_fence.h: In function 'dma_fence_set_error': include/kcl/kcl_fence.h:148:7: error: 'struct dma_fence' has no member named 'status' fence->status = error; ^~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: At top level: include/kcl/kcl_drm.h:167:1: error: redefinition of 'drm_fb_helper_remove_conflicting_pci_framebuffers' drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/kcl/kcl_drm.h:7:0, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_fb_helper.h:641:1: note: previous definition of 'drm_fb_helper_remove_conflicting_pci_framebuffers' was here drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_encoder_init': include/kcl/kcl_drm.h:307:9: error: too few arguments to function 'drm_encoder_init' return drm_encoder_init(dev, encoder, funcs, ^~~~~~~~~~~~~~~~ In file included from include/drm/drm_modeset_helper_vtables.h:33:0, from include/drm/drm_atomic_helper.h:32, from include/kcl/kcl_drm.h:11, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_encoder.h:183:5: note: declared here int drm_encoder_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_crtc_init_with_planes': include/kcl/kcl_drm.h:322:10: error: too few arguments to function 'drm_crtc_init_with_planes' return drm_crtc_init_with_planes(dev, crtc, primary, ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drmP.h:69:0, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_crtc.h:1120:5: note: declared here int drm_crtc_init_with_planes(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_universal_plane_init': include/kcl/kcl_drm.h:343:29: error: incompatible type for argument 7 of 'drm_universal_plane_init' formats, format_count, type); ^~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_plane.h:713:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h:342:10: error: too few arguments to function 'drm_universal_plane_init' return drm_universal_plane_init(dev, plane, possible_crtcs, funcs, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_plane.h:713:5: note: declared here int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_gem_object_lookup': include/kcl/kcl_drm.h:354:32: error: passing argument 1 of 'drm_gem_object_lookup' from incompatible pointer type [-Werror=incompatible-pointer-types] return drm_gem_object_lookup(dev, filp, handle); ^~~ In file included from include/kcl/kcl_drm.h:10:0, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_gem.h:365:24: note: expected 'struct drm_file *' but argument is of type 'struct drm_device *' struct drm_gem_object *drm_gem_object_lookup(struct drm_file *filp, u32 handle); ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h:354:37: warning: passing argument 2 of 'drm_gem_object_lookup' makes integer from pointer without a cast [-Wint-conversion] return drm_gem_object_lookup(dev, filp, handle); ^~~~ In file included from include/kcl/kcl_drm.h:10:0, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: -- In file included from drivers/gpu/drm/ttm/backport/backport.h:5:0, from <command-line>:0: >> include/kcl/kcl_fence.h:142:20: error: redefinition of 'dma_fence_set_error' static inline void dma_fence_set_error(struct dma_fence *fence, ^~~~~~~~~~~~~~~~~~~ In file included from include/kcl/kcl_fence.h:9:0, from drivers/gpu/drm/ttm/backport/backport.h:5, from <command-line>:0: include/linux/dma-fence.h:508:20: note: previous definition of 'dma_fence_set_error' was here static inline void dma_fence_set_error(struct dma_fence *fence, ^~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:5:0, from <command-line>:0: include/kcl/kcl_fence.h: In function 'dma_fence_set_error': include/kcl/kcl_fence.h:148:7: error: 'struct dma_fence' has no member named 'status' fence->status = error; ^~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: At top level: include/kcl/kcl_drm.h:167:1: error: redefinition of 'drm_fb_helper_remove_conflicting_pci_framebuffers' drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/kcl/kcl_drm.h:7:0, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_fb_helper.h:641:1: note: previous definition of 'drm_fb_helper_remove_conflicting_pci_framebuffers' was here drm_fb_helper_remove_conflicting_pci_framebuffers(struct pci_dev *pdev, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_encoder_init': include/kcl/kcl_drm.h:307:9: error: too few arguments to function 'drm_encoder_init' return drm_encoder_init(dev, encoder, funcs, ^~~~~~~~~~~~~~~~ In file included from include/drm/drm_modeset_helper_vtables.h:33:0, from include/drm/drm_atomic_helper.h:32, from include/kcl/kcl_drm.h:11, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_encoder.h:183:5: note: declared here int drm_encoder_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_crtc_init_with_planes': include/kcl/kcl_drm.h:322:10: error: too few arguments to function 'drm_crtc_init_with_planes' return drm_crtc_init_with_planes(dev, crtc, primary, ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drmP.h:69:0, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_crtc.h:1120:5: note: declared here int drm_crtc_init_with_planes(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_universal_plane_init': include/kcl/kcl_drm.h:343:29: error: incompatible type for argument 7 of 'drm_universal_plane_init' formats, format_count, type); ^~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_plane.h:713:5: note: expected 'const uint64_t * {aka const long long unsigned int *}' but argument is of type 'enum drm_plane_type' int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h:342:10: error: too few arguments to function 'drm_universal_plane_init' return drm_universal_plane_init(dev, plane, possible_crtcs, funcs, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/drm/drm_crtc.h:45:0, from include/drm/drmP.h:69, from include/kcl/kcl_drm.h:6, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_plane.h:713:5: note: declared here int drm_universal_plane_init(struct drm_device *dev, ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h: In function 'kcl_drm_gem_object_lookup': include/kcl/kcl_drm.h:354:32: error: passing argument 1 of 'drm_gem_object_lookup' from incompatible pointer type [-Werror=incompatible-pointer-types] return drm_gem_object_lookup(dev, filp, handle); ^~~ In file included from include/kcl/kcl_drm.h:10:0, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: include/drm/drm_gem.h:365:24: note: expected 'struct drm_file *' but argument is of type 'struct drm_device *' struct drm_gem_object *drm_gem_object_lookup(struct drm_file *filp, u32 handle); ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/gpu/drm/ttm/backport/backport.h:6:0, from <command-line>:0: include/kcl/kcl_drm.h:354:37: warning: passing argument 2 of 'drm_gem_object_lookup' makes integer from pointer without a cast [-Wint-conversion] return drm_gem_object_lookup(dev, filp, handle); ^~~~ In file included from include/kcl/kcl_drm.h:10:0, from drivers/gpu/drm/ttm/backport/backport.h:6, from <command-line>:0: .. vim +/dma_fence_set_error +142 include/kcl/kcl_fence.h 140 141 #if !defined(HAVE_DMA_FENCE_SET_ERROR) > 142 static inline void dma_fence_set_error(struct dma_fence *fence, 143 int error) 144 { 145 BUG_ON(test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)); 146 BUG_ON(error >= 0 || error < -MAX_ERRNO); 147 148 fence->status = error; 149 } 150 #endif 151 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[PATCH 00/11] drm/vram: Add VRAM buffers for HW cursors
by Thomas Zimmermann 19 Sep '19

19 Sep '19

This patchset adds dedicated VRAM buffers and cleans up the memory management of HW cursors in ast and mgag200. The ast and mgag200 drivers support HW cursors of uncommon pixel formats. Both drivers manage cursor memory in dedicated GEM VRAM buffer objects with a double buffering scheme; either by alternating between two GEM BOs, or by alternating between offsets within the same GEM BO. The code is convoluted and can lead to memory fragmentation if the BO is stored the middle of VRAM. This is especially a problem on devices with only a small amount of video memory. This patchset introduces VRAM buffers, a simple data structure that manages dedicated areas of VRAM. The VRAM buffer supports double- buffering (or more) to allow for flicker-free updates. A typical use case is in managing small, static buffers, such as cursors or sprites. The patchset then cleans up cursor memory management in ast and mgag200. To avoid the fragmentation issue, at the high end of each device's VRAM, a few KiB are reserved for the HW cursor. This memory is maintained by a double-buffered VRAM buffer. For updating the cursor image, each driver's cursor_set() functions fills the current back buffer and then makes it the front buffer. The patchset has been tested on ast and mgag200 hardware. Thomas Zimmermann (11): drm/vram: Add struct drm_vram_buffer to VRAM helpers drm/ast: Don't call ast_show_cursor() from ast_cursor_move() drm/ast: Move cursor update code to ast_show_cursor() drm/ast: Reserve space for double-buffered cursor image drm/ast: Store cursor in reserved memory area drm/mgag200: Rename cursor functions to use mgag200_ prefix drm/mgag200: Add init and fini functions for cursor handling drm/mgag200: Add separate move-cursor function drm/mgag200: Move cursor-image update to mgag200_show_cursor() drm/mgag200: Reserve video memory for cursor plane drm/mgag200: Implement cursor buffer with struct drm_vram_buffer Documentation/gpu/drm-mm.rst | 19 +- drivers/gpu/drm/ast/ast_drv.h | 5 +- drivers/gpu/drm/ast/ast_mode.c | 198 +++++++++-------- drivers/gpu/drm/ast/ast_ttm.c | 13 +- drivers/gpu/drm/drm_vram_helper_common.c | 259 ++++++++++++++++++++++- drivers/gpu/drm/mgag200/mgag200_cursor.c | 252 +++++++++++----------- drivers/gpu/drm/mgag200/mgag200_drv.h | 24 +-- drivers/gpu/drm/mgag200/mgag200_main.c | 20 +- drivers/gpu/drm/mgag200/mgag200_mode.c | 6 +- drivers/gpu/drm/mgag200/mgag200_ttm.c | 15 +- include/drm/drm_vram_helper.h | 64 ++++++ 11 files changed, 607 insertions(+), 268 deletions(-) create mode 100644 include/drm/drm_vram_helper.h -- 2.23.0

2 13

[radeon-alex:amd-mainline-dkms-5.0 3697/3724] include/drm/drm_fb_helper.h:641:1: sparse: the previous one is here
by kbuild test robot 19 Sep '19

19 Sep '19

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019