dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH 0/2] Rate-limit shadow-FB-to-console-update to screen refresh
by Thomas Zimmermann 17 Sep '19

17 Sep '19

A full-screen memcpy() moves the console's shadow buffer to hardware; with possibly significant runtime overhead. [1] The console's dirty worker now waits for the vblank to rate limit the output frequency. Screen output can pile up while waiting and there's a chance that multiple screen updates can be handled with a single memcpy(). Note that this has no effect on tearing: while the dirty worker updates the hardware buffer, new data can still arrive in the shadow buffer. This can create a tearing effcet, even though console output is synchronized to vblank. The patchset adds vblank support to mgag200, because the problem was first reported with Matrox hardware. [1] https://lists.freedesktop.org/archives/dri-devel/2019-July/228663.html Thomas Zimmermann (2): drm/fb-helper: Synchronize dirty worker with vblank drm/mgag200: Add vblank support drivers/gpu/drm/drm_fb_helper.c | 12 ++++++++ drivers/gpu/drm/mgag200/mgag200_drv.c | 1 + drivers/gpu/drm/mgag200/mgag200_drv.h | 1 + drivers/gpu/drm/mgag200/mgag200_main.c | 33 ++++++++++++++++++++ drivers/gpu/drm/mgag200/mgag200_mode.c | 42 +++++++++++++++++++++++--- 5 files changed, 85 insertions(+), 4 deletions(-) -- 2.23.0

5 16

[PATCH] drm/selftests: fix spelling mistake "misssing" -> "missing"
by Colin King 17 Sep '19

17 Sep '19

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a literal string, fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/selftests/test-drm_framebuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/selftests/test-drm_framebuffer.c b/drivers/gpu/drm/selftests/test-drm_framebuffer.c index 74d5561a862b..2d29ea6f92e2 100644 --- a/drivers/gpu/drm/selftests/test-drm_framebuffer.c +++ b/drivers/gpu/drm/selftests/test-drm_framebuffer.c @@ -126,7 +126,7 @@ static struct drm_framebuffer_test createbuffer_tests[] = { .handles = { 1, 1, 0 }, .pitches = { MAX_WIDTH, MAX_WIDTH - 1, 0 }, } }, -{ .buffer_created = 0, .name = "NV12 Invalid modifier/misssing DRM_MODE_FB_MODIFIERS flag", +{ .buffer_created = 0, .name = "NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag", .cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_NV12, .handles = { 1, 1, 0 }, .modifier = { DRM_FORMAT_MOD_SAMSUNG_64_32_TILE, 0, 0 }, .pitches = { MAX_WIDTH, MAX_WIDTH, 0 }, -- 2.20.1

2 1

[PATCH] drm/panfrost: Prevent race when handling page fault
by Steven Price 17 Sep '19

17 Sep '19

When handling a GPU page fault addr_to_drm_mm_node() is used to translate the GPU address to a buffer object. However it is possible for the buffer object to be freed after the function has returned resulting in a use-after-free of the BO. Change addr_to_drm_mm_node to return the panfrost_gem_object with an extra reference on it, preventing the BO from being freed until after the page fault has been handled. Signed-off-by: Steven Price <steven.price(a)arm.com> --- I've managed to trigger this, generating the following stack trace. Unable to handle kernel NULL pointer dereference at virtual address 00000090 pgd = 33a6a181 [00000090] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Modules linked in: CPU: 0 PID: 81 Comm: irq/60-mmu Not tainted 5.3.0-rc1+ #4 Hardware name: Rockchip (Device Tree) PC is at panfrost_mmu_map_fault_addr+0x140/0x3a0 LR is at _raw_spin_unlock+0x20/0x3c pc : [<c0508944>] lr : [<c07ced10>] psr: 20030013 sp : ec643e88 ip : ea70ce24 fp : ec5fe840 r10: 00000001 r9 : 00000000 r8 : 000178c9 r7 : 00000000 r6 : 178c9f00 r5 : ec5fe940 r4 : ea70ce08 r3 : 00000000 r2 : 00000000 r1 : ec640e00 r0 : ec5fe940 Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c5387d Table: 29f8406a DAC: 00000051 Process irq/60-mmu (pid: 81, stack limit = 0x4b907106) Stack: (0xec643e88 to 0xec644000) 3e80: ec640e00 c07cede0 c0c0b200 ec640e00 00000000 00000000 3ea0: 000178c9 00000000 c0c0b200 c07cede0 eef91040 ec5fe840 00000001 00000000 3ec0: 00010001 010003c3 000000c3 00000001 178c9f00 c0508c98 eef91050 00000000 3ee0: ec643f34 c07c9188 00000001 c0167854 00000000 ec643ef8 c0c08448 c07c933c 3f00: 00000000 ec643f04 fffefffe 3d182b17 ee193468 ee193400 ec5db3c0 ec5db3c0 3f20: c0183840 ec5db3e4 c0cb2874 c0183b08 00000001 c018385c ffffe000 ee193400 3f40: ec5db3c0 c0183b8c c0c08448 00000000 60000013 00000000 c01839b8 3d182b17 3f60: ffffe000 ec5d0500 ec5db380 ec642000 ec5db3c0 c0183a64 00000000 ed025cd8 3f80: ec5d0538 c0146cfc ec642000 ec5db380 c0146bc0 00000000 00000000 00000000 3fa0: 00000000 00000000 00000000 c01010b4 00000000 00000000 00000000 00000000 3fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 3fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [<c0508944>] (panfrost_mmu_map_fault_addr) from [<c0508c98>] (panfrost_mmu_irq_handler_thread+0xf4/0x248) [<c0508c98>] (panfrost_mmu_irq_handler_thread) from [<c018385c>] (irq_thread_fn+0x1c/0x58) [<c018385c>] (irq_thread_fn) from [<c0183b8c>] (irq_thread+0x128/0x240) [<c0183b8c>] (irq_thread) from [<c0146cfc>] (kthread+0x13c/0x154) [<c0146cfc>] (kthread) from [<c01010b4>] (ret_from_fork+0x14/0x20) Exception stack(0xec643fb0 to 0xec643ff8) 3fa0: 00000000 00000000 00000000 00000000 3fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 3fe0: 00000000 00000000 00000000 00000000 00000013 00000000 Code: 1affffec eaffffe8 e5143004 e59d2014 (e5933090) ---[ end trace 04eadc3009b8f507 ]--- --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 38 ++++++++++++++++--------- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c index 842bdd7cf6be..115925e7460a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -392,9 +392,11 @@ void panfrost_mmu_pgtable_free(struct panfrost_file_priv *priv) free_io_pgtable_ops(mmu->pgtbl_ops); } -static struct drm_mm_node *addr_to_drm_mm_node(struct panfrost_device *pfdev, int as, u64 addr) +static struct panfrost_gem_object * +addr_to_drm_mm_node(struct panfrost_device *pfdev, int as, u64 addr) { - struct drm_mm_node *node = NULL; + struct panfrost_gem_object *bo = NULL; + struct drm_mm_node *node; u64 offset = addr >> PAGE_SHIFT; struct panfrost_mmu *mmu; @@ -406,14 +408,17 @@ static struct drm_mm_node *addr_to_drm_mm_node(struct panfrost_device *pfdev, in priv = container_of(mmu, struct panfrost_file_priv, mmu); drm_mm_for_each_node(node, &priv->mm) { - if (offset >= node->start && offset < (node->start + node->size)) + if (offset >= node->start && + offset < (node->start + node->size)) { + bo = drm_mm_node_to_panfrost_bo(node); + drm_gem_object_get(&bo->base.base); goto out; + } } } - out: spin_unlock(&pfdev->as_lock); - return node; + return bo; } #define NUM_FAULT_PAGES (SZ_2M / PAGE_SIZE) @@ -421,29 +426,28 @@ static struct drm_mm_node *addr_to_drm_mm_node(struct panfrost_device *pfdev, in int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, u64 addr) { int ret, i; - struct drm_mm_node *node; struct panfrost_gem_object *bo; struct address_space *mapping; pgoff_t page_offset; struct sg_table *sgt; struct page **pages; - node = addr_to_drm_mm_node(pfdev, as, addr); - if (!node) + bo = addr_to_drm_mm_node(pfdev, as, addr); + if (!bo) return -ENOENT; - bo = drm_mm_node_to_panfrost_bo(node); if (!bo->is_heap) { dev_WARN(pfdev->dev, "matching BO is not heap type (GPU VA = %llx)", - node->start << PAGE_SHIFT); - return -EINVAL; + bo->node.start << PAGE_SHIFT); + ret = -EINVAL; + goto err_bo; } WARN_ON(bo->mmu->as != as); /* Assume 2MB alignment and size multiple */ addr &= ~((u64)SZ_2M - 1); page_offset = addr >> PAGE_SHIFT; - page_offset -= node->start; + page_offset -= bo->node.start; mutex_lock(&bo->base.pages_lock); @@ -452,7 +456,8 @@ int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, u64 addr) sizeof(struct sg_table), GFP_KERNEL | __GFP_ZERO); if (!bo->sgts) { mutex_unlock(&bo->base.pages_lock); - return -ENOMEM; + ret = -ENOMEM; + goto err_bo; } pages = kvmalloc_array(bo->base.base.size >> PAGE_SHIFT, @@ -461,7 +466,8 @@ int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, u64 addr) kfree(bo->sgts); bo->sgts = NULL; mutex_unlock(&bo->base.pages_lock); - return -ENOMEM; + ret = -ENOMEM; + goto err_bo; } bo->base.pages = pages; bo->base.pages_use_count = 1; @@ -499,12 +505,16 @@ int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, u64 addr) dev_dbg(pfdev->dev, "mapped page fault @ AS%d %llx", as, addr); + drm_gem_object_put_unlocked(&bo->base.base); + return 0; err_map: sg_free_table(sgt); err_pages: drm_gem_shmem_put_pages(&bo->base); +err_bo: + drm_gem_object_put_unlocked(&bo->base.base); return ret; } -- 2.20.1

4 8

[PATCH] drm/amd/display: Restore backlight brightness after system resume
by Kai-Heng Feng 17 Sep '19

17 Sep '19

Laptops with AMD APU doesn't restore display backlight brightness after system resume. This issue started when DC was introduced. Let's use BL_CORE_SUSPENDRESUME so the backlight core calls update_status callback after system resume to restore the backlight level. Tested on Dell Inspiron 3180 (Stoney Ridge) and Dell Latitude 5495 (Raven Ridge). Cc: <stable(a)vger.kernel.org> Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 1b0949dd7808..183ef18ac6f3 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2111,6 +2111,7 @@ static int amdgpu_dm_backlight_get_brightness(struct backlight_device *bd) } static const struct backlight_ops amdgpu_dm_backlight_ops = { + .options = BL_CORE_SUSPENDRESUME, .get_brightness = amdgpu_dm_backlight_get_brightness, .update_status = amdgpu_dm_backlight_update_status, }; -- 2.17.1

3 2

[PATCH 0/2] drm/panfrost: Tidy up the devfreq implementation
by Steven Price 17 Sep '19

17 Sep '19

The devfreq implementation in panfrost is unnecessarily open coded. It also tracks utilisation metrics per slot which isn't very useful. Let's tidy it up! This should be picked up along with Mark's change[1] to fix regulator_get_optional() misuse. This also deletes the code changes from 52282163dfa6 and e21dd290881b which would otherwise need reverting, see the previous discussion[2]. [1] https://lore.kernel.org/lkml/20190904123032.23263-1-broonie@kernel.org/ [2] https://lore.kernel.org/lkml/ccd81530-2dbd-3c02-ca0a-1085b00663b5@arm.com/ Steven Price (2): drm/panfrost: Use generic code for devfreq drm/panfrost: Simplify devfreq utilisation tracking drivers/gpu/drm/panfrost/panfrost_devfreq.c | 126 ++++++-------------- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 3 +- drivers/gpu/drm/panfrost/panfrost_device.h | 14 +-- drivers/gpu/drm/panfrost/panfrost_job.c | 14 +-- 4 files changed, 48 insertions(+), 109 deletions(-) -- 2.20.1

5 7

[PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.
by Gerd Hoffmann 17 Sep '19

17 Sep '19

Gerd Hoffmann (17): drm/ttm: turn ttm_bo_device.vma_manager into a pointer drm/ttm: add gem_ttm_bo_device_init() drm/vram: switch vram helpers to the new gem_ttm_bo_device_init() drm/qxl: switch qxl to the new gem_ttm_bo_device_init() drm: add mmap() to drm_gem_object_funcs drm/shmem: switch shmem helper to drm_gem_object_funcs->mmap drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS drm/ttm: factor out ttm_bo_mmap_vma_setup drm/ttm: add drm_gem_ttm_mmap() drm/vram: switch vram helper to drm_gem_object_funcs->mmap codepath drm/vram: drop verify_access drm: drop DRM_VRAM_MM_FILE_OPERATIONS drm/qxl: use drm_gem_object_funcs drm/qxl: drop qxl_ttm_fault drm/qxl: switch qxl to drm_gem_object_funcs->mmap codepath drm/qxl: drop verify_access drm/qxl: use DEFINE_DRM_GEM_FOPS() drivers/gpu/drm/qxl/qxl_drv.h | 5 +- drivers/gpu/drm/qxl/qxl_object.h | 5 -- include/drm/drm_gem.h | 9 +++ include/drm/drm_gem_shmem_helper.h | 28 +-------- include/drm/drm_gem_ttm_helper.h | 32 ++++++++++ include/drm/drm_gem_vram_helper.h | 9 +-- include/drm/drm_vram_mm_helper.h | 27 --------- include/drm/ttm/ttm_bo_api.h | 8 +++ include/drm/ttm/ttm_bo_driver.h | 11 +++- drivers/gpu/drm/ast/ast_drv.c | 5 +- drivers/gpu/drm/bochs/bochs_drv.c | 5 +- drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/drm_gem.c | 6 ++ drivers/gpu/drm/drm_gem_shmem_helper.c | 18 +++--- drivers/gpu/drm/drm_gem_ttm_helper.c | 47 +++++++++++++++ drivers/gpu/drm/drm_gem_vram_helper.c | 53 +---------------- drivers/gpu/drm/drm_vram_mm_helper.c | 44 +------------- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 5 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/panfrost/panfrost_gem.c | 1 + drivers/gpu/drm/qxl/qxl_drv.c | 19 +----- drivers/gpu/drm/qxl/qxl_dumb.c | 17 ------ drivers/gpu/drm/qxl/qxl_ioctl.c | 5 +- drivers/gpu/drm/qxl/qxl_object.c | 13 +++++ drivers/gpu/drm/qxl/qxl_ttm.c | 58 ++----------------- drivers/gpu/drm/ttm/ttm_bo.c | 29 +++++++--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 53 +++++++++-------- drivers/gpu/drm/v3d/v3d_bo.c | 1 + drivers/gpu/drm/v3d/v3d_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_drv.c | 5 +- Documentation/gpu/drm-mm.rst | 12 ++++ drivers/gpu/drm/Kconfig | 8 +++ drivers/gpu/drm/Makefile | 3 + drivers/gpu/drm/qxl/Kconfig | 1 + 35 files changed, 231 insertions(+), 323 deletions(-) create mode 100644 include/drm/drm_gem_ttm_helper.h create mode 100644 drivers/gpu/drm/drm_gem_ttm_helper.c -- 2.18.1

4 32

[PATCH 0/3] drm/vram: Provide GEM VRAM vmap()/vunmap/()
by Thomas Zimmermann 17 Sep '19

17 Sep '19

The ast and mgag200 drivers pin() and kmap() cursor buffers; essentially reimplementing vmap(). We can share some code by using the respective functionality from GEM VRAM buffer objects. Thomas Zimmermann (3): drm/vram: Provide vmap and vunmap operations for GEM VRAM objects drm/ast: Use drm_gem_vram_{vmap,vunmap}() to map cursor source BO drm/mgag200: Use drm_gem_vram_{vmap,vunmap}() to map cursor source BO drivers/gpu/drm/ast/ast_mode.c | 21 ++--- drivers/gpu/drm/drm_gem_vram_helper.c | 106 ++++++++++++++++------- drivers/gpu/drm/mgag200/mgag200_cursor.c | 22 ++--- include/drm/drm_gem_vram_helper.h | 5 +- 4 files changed, 93 insertions(+), 61 deletions(-) -- 2.23.0

2 6

[PATCH 00/11] ARM: dts: qcom: msm8974: add support for external display
by Brian Masney 17 Sep '19

17 Sep '19

This patch series begins to add support for the external display over HDMI that is supported on msm8974 SoCs. I'm testing this series on the Nexus 5, and I'm able to communicate with the HDMI bridge via the analogix-anx78xx driver, however the external display is not working yet. When I plug in the HDMI cable, the monitor detects that a device is hooked up, but nothing is shown on the external monitor. The hot plug detect GPIO (hpd-gpios) on the analogix-anx78xx bridge and MSM HDMI drivers do not change state when the slimport adapter or HDMI cable is plugged in or removed. I wonder if a regulator is not enabled somewhere? I have a comment in patch 10 regarding 'hpd-gdsc-supply' that may potentially be an issue. I'm still digging in on this, however I'd appreciate any feedback if anyone has time. Most of these patches are ready now, so I marked the ones that aren't ready with 'PATCH RFC'. I'm using an Analogix Semiconductor SP6001 SlimPort Micro-USB to 4K HDMI Adapter to connect my phone to an external display via a standard HDMI cable. This works just fine with the downstream MSM kernel using Android. Brian Masney (11): dt-bindings: drm/bridge: analogix-anx78xx: add new variants drm/bridge: analogix-anx78xx: add new variants drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device drm/bridge: analogix-anx78xx: correct value of TX_P0 drm/bridge: analogix-anx78xx: add support for avdd33 regulator ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX drm/msm/hdmi: silence -EPROBE_DEFER warning ARM: dts: qcom: pm8941: add 5vs2 regulator node ARM: dts: qcom: msm8974: add HDMI nodes ARM: dts: qcom: msm8974-hammerhead: add support for external display .../bindings/display/bridge/anx7814.txt | 6 +- .../qcom-msm8974-lge-nexus5-hammerhead.dts | 140 ++++++++++++++++++ arch/arm/boot/dts/qcom-msm8974.dtsi | 80 ++++++++++ arch/arm/boot/dts/qcom-pm8941.dtsi | 10 ++ arch/arm/configs/qcom_defconfig | 1 + drivers/gpu/drm/bridge/analogix-anx78xx.c | 60 +++++++- drivers/gpu/drm/bridge/analogix-anx78xx.h | 2 +- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 8 +- 8 files changed, 295 insertions(+), 12 deletions(-) -- 2.21.0

6 37

nouveau-next-5.4
by Ben Skeggs 17 Sep '19

17 Sep '19

Hey Dave, A couple of fixes from Thierry fixing issues as a result of the reservation object rework in this cycle, as well as a fix from Lyude to allow the driver to load on Thinkpad P71. Thanks, Ben. The following changes since commit 9a60b2990d6c2b7ab935fe0a5cc274de67d98bed: Merge branch 'etnaviv/next' of https://git.pengutronix.de/git/lst/linux into drm-next (2019-09-06 16:58:10 +1000) are available in the Git repository at: git://github.com/skeggsb/linux linux-5.4 for you to fetch changes up to b568db62c5c46c8d859f1b9538495ea0fcbe7000: drm/nouveau/bar/gm20b: Avoid BAR1 teardown during init (2019-09-17 14:50:16 +1000) ---------------------------------------------------------------- Lyude Paul (1): drm/nouveau/kms/nv50-: Don't create MSTMs for eDP connectors Thierry Reding (4): drm/nouveau: Fix fallout from reservation object rework drm/nouveau/prime: Extend DMA reservation object lock drm/nouveau: Fix ordering between TTM and GEM release drm/nouveau/bar/gm20b: Avoid BAR1 teardown during init drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 ++- drivers/gpu/drm/nouveau/nouveau_bo.c | 26 +++++++++++++++--------- drivers/gpu/drm/nouveau/nouveau_bo.h | 4 ++-- drivers/gpu/drm/nouveau/nouveau_gem.c | 7 ++----- drivers/gpu/drm/nouveau/nouveau_prime.c | 27 ++++++++++++++++--------- drivers/gpu/drm/nouveau/nvkm/subdev/bar/gm20b.c | 1 - 6 files changed, 41 insertions(+), 27 deletions(-)

1 0

Re: linux-next: Tree for Sep 4 (amd/display/)
by Randy Dunlap 17 Sep '19

17 Sep '19

On 9/4/19 6:34 AM, Stephen Rothwell wrote: > Hi all, > > News: this will be the last linux-next I will release until Sept 30. > > Changes since 20190903: > on x86_64: In file included from ../drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c:77:0: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/../dml_inline_defs.h: In function ‘dml_min’: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/../dml_inline_defs.h:34:1: error: SSE register return with SSE disabled -- ~Randy

3 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019