dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

possible deadlock in __mmu_notifier_invalidate_range_end
by syzbot 06 Sep '19

06 Sep '19

Hello, syzbot found the following crash on: HEAD commit: 6d028043 Add linux-next specific files for 20190830 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16cbf22a600000 kernel config: https://syzkaller.appspot.com/x/.config?x=82a6bec43ab0cb69 dashboard link: https://syzkaller.appspot.com/bug?extid=aaedc50d99a03250fe1f compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15269876600000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12685092600000 The bug was bisected to: commit e58b341134ca751d9c12bacded12a8b4dd51368d Author: Stephen Rothwell <sfr(a)canb.auug.org.au> Date: Fri Aug 30 09:42:14 2019 +0000 Merge remote-tracking branch 'hmm/hmm' bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11ea65ea600000 final crash: https://syzkaller.appspot.com/x/report.txt?x=13ea65ea600000 console output: https://syzkaller.appspot.com/x/log.txt?x=15ea65ea600000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+aaedc50d99a03250fe1f(a)syzkaller.appspotmail.com Fixes: e58b341134ca ("Merge remote-tracking branch 'hmm/hmm'") ============================================ WARNING: possible recursive locking detected 5.3.0-rc6-next-20190830 #75 Not tainted -------------------------------------------- oom_reaper/1065 is trying to acquire lock: ffffffff8904ff60 (mmu_notifier_invalidate_range_start){+.+.}, at: __mmu_notifier_invalidate_range_end+0x0/0x360 mm/mmu_notifier.c:169 but task is already holding lock: ffffffff8904ff60 (mmu_notifier_invalidate_range_start){+.+.}, at: __oom_reap_task_mm+0x196/0x490 mm/oom_kill.c:542 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(mmu_notifier_invalidate_range_start); lock(mmu_notifier_invalidate_range_start); *** DEADLOCK *** May be due to missing lock nesting notation 2 locks held by oom_reaper/1065: #0: ffff888094ad3990 (&mm->mmap_sem#2){++++}, at: oom_reap_task_mm mm/oom_kill.c:570 [inline] #0: ffff888094ad3990 (&mm->mmap_sem#2){++++}, at: oom_reap_task mm/oom_kill.c:613 [inline] #0: ffff888094ad3990 (&mm->mmap_sem#2){++++}, at: oom_reaper+0x3a7/0x1320 mm/oom_kill.c:651 #1: ffffffff8904ff60 (mmu_notifier_invalidate_range_start){+.+.}, at: __oom_reap_task_mm+0x196/0x490 mm/oom_kill.c:542 stack backtrace: CPU: 1 PID: 1065 Comm: oom_reaper Not tainted 5.3.0-rc6-next-20190830 #75 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 print_deadlock_bug kernel/locking/lockdep.c:2371 [inline] check_deadlock kernel/locking/lockdep.c:2412 [inline] validate_chain kernel/locking/lockdep.c:2955 [inline] __lock_acquire.cold+0x15d/0x385 kernel/locking/lockdep.c:3955 lock_acquire+0x190/0x410 kernel/locking/lockdep.c:4487 __mmu_notifier_invalidate_range_end+0x3c/0x360 mm/mmu_notifier.c:193 mmu_notifier_invalidate_range_end include/linux/mmu_notifier.h:375 [inline] __oom_reap_task_mm+0x3fa/0x490 mm/oom_kill.c:552 oom_reap_task_mm mm/oom_kill.c:589 [inline] oom_reap_task mm/oom_kill.c:613 [inline] oom_reaper+0x2b2/0x1320 mm/oom_kill.c:651 kthread+0x361/0x430 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 oom_reaper: reaped process 10145 (syz-executor282), now anon-rss:16480kB, file-rss:872kB, shmem-rss:0kB oom_reaper: reaped process 10144 (syz-executor282), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB oom_reaper: reaped process 10158 (syz-executor282), now anon-rss:16824kB, file-rss:872kB, shmem-rss:0kB oom_reaper: reaped process 10187 (syz-executor282), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB oom_reaper: reaped process 10173 (syz-executor282), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB oom_reaper: reaped process 10139 (syz-executor282), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches

1 0

[PATCH] omapdrm/dss: Use PTR_ERR_OR_ZERO() in four functions
by Markus Elfring 06 Sep '19

06 Sep '19

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Fri, 6 Sep 2019 18:40:48 +0200 Simplify these function implementations by using a known function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 6 +----- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 4 +--- drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 4 +--- drivers/gpu/drm/omapdrm/dss/hdmi_phy.c | 4 +--- 4 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c index 0f557fad4513..b1a8d4bfbe48 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c @@ -586,11 +586,7 @@ static int hdmi_audio_register(struct omap_hdmi *hdmi) hdmi->audio_pdev = platform_device_register_data( &hdmi->pdev->dev, "omap-hdmi-audio", PLATFORM_DEVID_AUTO, &pdata, sizeof(pdata)); - - if (IS_ERR(hdmi->audio_pdev)) - return PTR_ERR(hdmi->audio_pdev); - - return 0; + return PTR_ERR_OR_ZERO(hdmi->audio_pdev); } /* ----------------------------------------------------------------------------- diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index 5d5d5588ebc1..0775109133b5 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -923,8 +923,6 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"); core->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(core->base)) - return PTR_ERR(core->base); - return 0; + return PTR_ERR_OR_ZERO(core->base); } diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c index 7400fb99d453..655cf2048809 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c @@ -899,8 +899,6 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core) res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"); core->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(core->base)) - return PTR_ERR(core->base); - return 0; + return PTR_ERR_OR_ZERO(core->base); } diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c index 00bbf24488c1..bbc02d5aa8fb 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_phy.c @@ -191,8 +191,6 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy, res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy"); phy->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(phy->base)) - return PTR_ERR(phy->base); - return 0; + return PTR_ERR_OR_ZERO(phy->base); } -- 2.23.0

1 0

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1
by bugzilla-daemon＠freedesktop.org 06 Sep '19

06 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #74 from Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> --- (In reply to Michel Dänzer from comment #73) > Looks like some client repeatedly calls XForceScreenSaver (probably to > prevent the monitors from blanking), which results in the DPMS property > getting re-set over and over. Nicholas, maybe the kernel could ignore such > no-op property "updates"? Even if it's no-op update it's still going to be locking the connector and potentially blocking other commits from occurring so ideally the client userspace wouldn't be dong this. I can try writing up a patch that doesn't lock everything if the connector state hasn't change at the very least but I'm not sure if it will fully address the issue or not. -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1
by bugzilla-daemon＠freedesktop.org 06 Sep '19

06 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #73 from Michel Dänzer <michel(a)daenzer.net> --- Looks like some client repeatedly calls XForceScreenSaver (probably to prevent the monitors from blanking), which results in the DPMS property getting re-set over and over. Nicholas, maybe the kernel could ignore such no-op property "updates"? -- You are receiving this mail because: You are the assignee for the bug.

1 0

[PATCH] drm/modes: Make the whitelist more const
by Maxime Ripard 06 Sep '19

06 Sep '19

The commit 3764137906a5 ("drm/modes: Introduce a whitelist for the named modes") introduced a whitelist in the named modes lookup code in order to be a bit more robust. However, even though the char pointers were made const, the data they were pointing were not. Let's fix that. Fixes: 3764137906a5 ("drm/modes: Introduce a whitelist for the named modes") Suggested-by: Jani Nikula <jani.nikula(a)linux.intel.com> Signed-off-by: Maxime Ripard <mripard(a)kernel.org> --- drivers/gpu/drm/drm_modes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 858c67281518..88232698d7a0 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1677,7 +1677,7 @@ static int drm_mode_parse_cmdline_options(char *str, size_t len, return 0; } -static const char *drm_named_modes_whitelist[] = { +static const char * const drm_named_modes_whitelist[] = { "NTSC", "PAL", }; -- 2.21.0

2 2

[pull] drm/msm: msm-next for 5.4
by Rob Clark 06 Sep '19

06 Sep '19

Hi Dave, This time around: + move msm8998 (snapdragon 835) display support + dpu fixes/cleanup + better async commit support for cursor updates (for dpu for now, I'll add mdp5 and possibly mdp4 once the movers deliver boxes full of my older hardware, so for v5.5) The following changes since commit c7eb7c12fddcba0bfb53e006baa9a7a10f26c5f0: Merge tag 'exynos-drm-next-for-v5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-next (2019-09-03 16:06:26 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git drm-msm-next-2019-09-06 for you to fetch changes up to 9f614197c744002f9968e82c649fdf7fe778e1e7: drm/msm: Use the correct dma_sync calls harder (2019-09-04 10:05:05 -0700) ---------------------------------------------------------------- Brian Masney (1): drm/msm/phy/dsi_phy: silence -EPROBE_DEFER warnings Denis Efremov (1): drm/msm: remove unlikely() from WARN_ON() conditions Gustavo A. R. Silva (1): drm/msm: Use struct_size() helper Jeffrey Hugo (3): drm/msm: Transition console to msm framebuffer drm/msm/mdp5: Add msm8998 support drm/msm/mdp5: Find correct node for creating gem address space Jordan Crouse (2): drm/msm: Use generic bulk clock function drm/msm: Remove Kconfig default Linus Walleij (4): drm/msm/mdp4: Drop unused GPIO include drm/msm/dsi: Drop unused GPIO includes drm/msm/dpu: Drop unused GPIO code drm/msm/hdmi: Convert to use GPIO descriptors Rob Clark (18): drm/msm/dpu: remove dpu_mdss:hwversion drm/msm/a6xx: add missing MODULE_FIRMWARE() drm/msm/dpu: fix "frame done" timeouts drm/msm/dpu: remove stray "\n" drm/msm/dpu: add rotation property drm/msm/dpu: remove some impossible error checking drm/msm/dpu: remove unused arg drm/msm/dpu: unwind async commit handling drm/msm/dpu: add real wait_for_commit_done() drm/msm/dpu: handle_frame_done() from vblank irq drm/msm: add kms->wait_flush() drm/msm: convert kms->complete_commit() to crtc_mask drm/msm: add kms->flush_commit() drm/msm: split power control from prepare/complete_commit drm/msm: async commit support drm/msm/dpu: async commit support drm/msm: add atomic traces drm/msm: Use the correct dma_sync calls harder Sam Ravnborg (1): drm/msm: drop use of drmP.h Sean Paul (1): drm/msm/dsi: Fix return value check for clk_get_parent drivers/gpu/drm/msm/Kconfig | 2 +- drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 16 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 95 ++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 7 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 75 ++----- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 11 +- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 - .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 44 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 3 - drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 9 - drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 112 +++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 10 + drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 9 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 23 +- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 11 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 1 + drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 51 +++-- drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 2 + .../gpu/drm/msm/disp/mdp4/mdp4_lvds_connector.c | 2 - drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 2 + drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 132 +++++++++++- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 3 + drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c | 4 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 60 ++++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 2 + drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 1 + drivers/gpu/drm/msm/disp/mdp_format.c | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 18 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 12 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 2 + drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 2 +- drivers/gpu/drm/msm/hdmi/hdmi.c | 66 +++--- drivers/gpu/drm/msm/hdmi/hdmi.h | 4 +- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 + drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 43 ++-- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 1 + drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 2 + drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 2 + drivers/gpu/drm/msm/msm_atomic.c | 232 ++++++++++++++++++--- drivers/gpu/drm/msm/msm_atomic_trace.h | 110 ++++++++++ drivers/gpu/drm/msm/msm_atomic_tracepoints.c | 3 + drivers/gpu/drm/msm/msm_debugfs.c | 5 + drivers/gpu/drm/msm/msm_drv.c | 51 +---- drivers/gpu/drm/msm/msm_drv.h | 6 +- drivers/gpu/drm/msm/msm_fb.c | 2 + drivers/gpu/drm/msm/msm_fbdev.c | 4 + drivers/gpu/drm/msm/msm_gem.c | 6 +- drivers/gpu/drm/msm/msm_gem_prime.c | 6 +- drivers/gpu/drm/msm/msm_gem_submit.c | 8 +- drivers/gpu/drm/msm/msm_gpu.c | 2 +- drivers/gpu/drm/msm/msm_gpu_trace.h | 2 +- drivers/gpu/drm/msm/msm_gpummu.c | 2 + drivers/gpu/drm/msm/msm_kms.h | 108 +++++++++- drivers/gpu/drm/msm/msm_perf.c | 3 + drivers/gpu/drm/msm/msm_rd.c | 7 +- drivers/gpu/drm/msm/msm_submitqueue.c | 2 + 66 files changed, 970 insertions(+), 451 deletions(-) create mode 100644 drivers/gpu/drm/msm/msm_atomic_trace.h create mode 100644 drivers/gpu/drm/msm/msm_atomic_tracepoints.c

1 0

[git pull] drm fixes for 5.3-rc8 (or final)
by Dave Airlie 06 Sep '19

06 Sep '19

Hey Linus, Live from my friend's couch in Barcelona. Latest round of drm fixes, the command line parser regression fixes look a bit larger because they come with selftests included for the bugs they fix. Otherwise a single nouveau, single ingenic and single vmwgfx fix. Dave. drm-fixes-2019-09-06: drm fixes for 5.3-rc8 (or final) nouveau: - add missing MODULE_FIRMWARE definitions igenic: - hardcode panel type DPI vmwgfx: - double free fix core: - command line mode parser fixes The following changes since commit 089cf7f6ecb266b6a4164919a2e69bd2f938374a: Linux 5.3-rc7 (2019-09-02 09:57:40 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-09-06 for you to fetch changes up to 1e19ec6c3c417a0893fcfae7abfba623e781d876: Merge tag 'drm-misc-fixes-2019-09-05' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-09-06 16:27:46 +1000) ---------------------------------------------------------------- drm fixes for 5.3-rc8 (or final) nouveau: - add missing MODULE_FIRMWARE definitions igenic: - hardcode panel type DPI vmwgfx: - double free fix core: - command line mode parser fixes ---------------------------------------------------------------- Ben Skeggs (1): drm/nouveau/sec2/gp102: add missing MODULE_FIRMWAREs Dan Carpenter (1): drm/vmwgfx: Fix double free in vmw_recv_msg() Dave Airlie (3): Merge branch 'linux-5.3' of git://github.com/skeggsb/linux into drm-fixes Merge branch 'vmwgfx-fixes-5.3' of git://people.freedesktop.org/~thomash/linux into drm-fixes Merge tag 'drm-misc-fixes-2019-09-05' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Laurent Pinchart (1): drm/ingenic: Hardcode panel type to DPI Maxime Ripard (4): drm/modes: Add a switch to differentiate free standing options drm/modes: Fix the command line parser to take force options into account drm/modes: Introduce a whitelist for the named modes drm/selftests: modes: Add more unit tests for the cmdline parser drivers/gpu/drm/drm_modes.c | 54 ++++++++- drivers/gpu/drm/ingenic/ingenic-drm.c | 5 +- .../gpu/drm/nouveau/nvkm/subdev/secboot/gp102.c | 12 ++ drivers/gpu/drm/selftests/drm_cmdline_selftests.h | 7 ++ .../gpu/drm/selftests/test-drm_cmdline_parser.c | 130 +++++++++++++++++++++ drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 8 +- 6 files changed, 202 insertions(+), 14 deletions(-)

2 1

[PATCH] staging: fbtft: make several arrays static const, makes object smaller
by Colin King 06 Sep '19

06 Sep '19

From: Colin Ian King <colin.king(a)canonical.com> Don't populate the arrays on the stack but instead make them static const. Makes the object code smaller by 1329 bytes. Before: text data bss dec hex filename 5581 1488 64 7133 1bdd drivers/staging/fbtft/fb_hx8340bn.o 5444 1264 0 6708 1a34 drivers/staging/fbtft/fb_hx8347d.o 3581 1360 0 4941 134d drivers/staging/fbtft/fb_ili9163.o 7154 1552 0 8706 2202 drivers/staging/fbtft/fb_ili9320.o 7478 2544 0 10022 2726 drivers/staging/fbtft/fb_ili9325.o 6327 1424 0 7751 1e47 drivers/staging/fbtft/fb_s6d1121.o 6498 1776 0 8274 2052 drivers/staging/fbtft/fb_ssd1289.o After: text data bss dec hex filename 5376 1584 64 7024 1b70 drivers/staging/fbtft/fb_hx8340bn.o 5276 1328 0 6604 19cc drivers/staging/fbtft/fb_hx8347d.o 3581 1360 0 4941 134d drivers/staging/fbtft/fb_ili9163.o 6905 1616 0 8521 2149 drivers/staging/fbtft/fb_ili9320.o 7229 2608 0 9837 266d drivers/staging/fbtft/fb_ili9325.o 6030 1488 0 7518 1d5e drivers/staging/fbtft/fb_s6d1121.o 6249 1872 0 8121 1fb9 drivers/staging/fbtft/fb_ssd1289.o (gcc version 9.2.1, amd64) Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fb_hx8347d.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 2 +- drivers/staging/fbtft/fb_ili9320.c | 2 +- drivers/staging/fbtft/fb_ili9325.c | 2 +- drivers/staging/fbtft/fb_s6d1121.c | 2 +- drivers/staging/fbtft/fb_ssd1289.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fbtft/fb_hx8340bn.c b/drivers/staging/fbtft/fb_hx8340bn.c index d47dcf31fffb..2fd7b87ea0ce 100644 --- a/drivers/staging/fbtft/fb_hx8340bn.c +++ b/drivers/staging/fbtft/fb_hx8340bn.c @@ -151,7 +151,7 @@ static int set_var(struct fbtft_par *par) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int set_gamma(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x0f, 0x0f, 0x1f, 0x0f, 0x0f, 0x0f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x03, 0x03, 0x0f, 0x0f, 0x1f, 0x0f, 0x0f, 0x0f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x00, 0x00, diff --git a/drivers/staging/fbtft/fb_hx8347d.c b/drivers/staging/fbtft/fb_hx8347d.c index 3427a858d17c..37eaf0862c5b 100644 --- a/drivers/staging/fbtft/fb_hx8347d.c +++ b/drivers/staging/fbtft/fb_hx8347d.c @@ -95,7 +95,7 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int set_gamma(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x7f, 0x7f, 0x1f, 0x1f, 0x1f, 0x1f, 0x1f, 0x0f, }; diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c index fd32376700e2..05648c3ffe47 100644 --- a/drivers/staging/fbtft/fb_ili9163.c +++ b/drivers/staging/fbtft/fb_ili9163.c @@ -195,7 +195,7 @@ static int set_var(struct fbtft_par *par) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int gamma_adj(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x3F, 0x3F, 0x3F, 0x3F, 0x3F, 0x1f, 0x3f, 0x0f, 0x0f, 0x7f, 0x1f, 0x3F, 0x3F, 0x3F, 0x3F, 0x3F}; diff --git a/drivers/staging/fbtft/fb_ili9320.c b/drivers/staging/fbtft/fb_ili9320.c index ea6e001288ce..f2e72d14431d 100644 --- a/drivers/staging/fbtft/fb_ili9320.c +++ b/drivers/staging/fbtft/fb_ili9320.c @@ -214,7 +214,7 @@ static int set_var(struct fbtft_par *par) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int set_gamma(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x1f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x1f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, }; diff --git a/drivers/staging/fbtft/fb_ili9325.c b/drivers/staging/fbtft/fb_ili9325.c index 85e54a10ed72..c9aa4cb43123 100644 --- a/drivers/staging/fbtft/fb_ili9325.c +++ b/drivers/staging/fbtft/fb_ili9325.c @@ -208,7 +208,7 @@ static int set_var(struct fbtft_par *par) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int set_gamma(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x1f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x1f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, }; diff --git a/drivers/staging/fbtft/fb_s6d1121.c b/drivers/staging/fbtft/fb_s6d1121.c index 5a129b1352cc..8c7de3290343 100644 --- a/drivers/staging/fbtft/fb_s6d1121.c +++ b/drivers/staging/fbtft/fb_s6d1121.c @@ -123,7 +123,7 @@ static int set_var(struct fbtft_par *par) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int set_gamma(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x1f, 0x1f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x3f, 0x1f, 0x1f, diff --git a/drivers/staging/fbtft/fb_ssd1289.c b/drivers/staging/fbtft/fb_ssd1289.c index 88a5b6925901..7a3fe022cc69 100644 --- a/drivers/staging/fbtft/fb_ssd1289.c +++ b/drivers/staging/fbtft/fb_ssd1289.c @@ -129,7 +129,7 @@ static int set_var(struct fbtft_par *par) #define CURVE(num, idx) curves[(num) * par->gamma.num_values + (idx)] static int set_gamma(struct fbtft_par *par, u32 *curves) { - unsigned long mask[] = { + static const unsigned long mask[] = { 0x1f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x1f, 0x1f, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, 0x07, }; -- 2.20.1

1 0

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1
by bugzilla-daemon＠freedesktop.org 06 Sep '19

06 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #72 from tempel.julian(a)gmail.com --- Created attachment 145280 --> https://bugs.freedesktop.org/attachment.cgi?id=145280&action=edit 2nd gdb backtrace log, now with debug symbols -- You are receiving this mail because: You are the assignee for the bug.

1 0

[Bug 110659] pageflipping seems to cause jittering on mouse input when running Hitman 2 in Wine/DXVK with amdgpu.dc=1
by bugzilla-daemon＠freedesktop.org 06 Sep '19

06 Sep '19

https://bugs.freedesktop.org/show_bug.cgi?id=110659 --- Comment #71 from tempel.julian(a)gmail.com --- Hope this helps: -- You are receiving this mail because: You are the assignee for the bug.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019