dri-devel September 2019

dri-devel@lists.freedesktop.org

315 participants
2278 discussions

[PATCH v2] drm/tegra: Turn off and reset hardware across suspend-resume
by Dmitry Osipenko 15 Nov '19

15 Nov '19

The drivers core bumps runtime PM refcount during of entering into suspend to workaround some problem where parent device may become turned off before its children. In order to disable and reset CRTCs/HDMI/etc hardware, the runtime PM needs to be "forced" into suspend mode. Signed-off-by: Dmitry Osipenko <digetx(a)gmail.com> --- Changelog: v2: The SYSTEM_SLEEP_PM_OPS are now set for all of the relevant drivers and not only for the DC because turned out that they all should enforce the suspending. drivers/gpu/drm/tegra/dc.c | 2 ++ drivers/gpu/drm/tegra/dpaux.c | 2 ++ drivers/gpu/drm/tegra/dsi.c | 2 ++ drivers/gpu/drm/tegra/hdmi.c | 2 ++ drivers/gpu/drm/tegra/hub.c | 2 ++ drivers/gpu/drm/tegra/sor.c | 2 ++ drivers/gpu/drm/tegra/vic.c | 2 ++ 7 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 4a75d149e368..6c8f5222d558 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -2572,6 +2572,8 @@ static int tegra_dc_resume(struct device *dev) static const struct dev_pm_ops tegra_dc_pm_ops = { SET_RUNTIME_PM_OPS(tegra_dc_suspend, tegra_dc_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; struct platform_driver tegra_dc_driver = { diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 2d94da225e51..22f80f69ffb8 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm/tegra/dpaux.c @@ -638,6 +638,8 @@ static int tegra_dpaux_resume(struct device *dev) static const struct dev_pm_ops tegra_dpaux_pm_ops = { SET_RUNTIME_PM_OPS(tegra_dpaux_suspend, tegra_dpaux_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static const struct of_device_id tegra_dpaux_of_match[] = { diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 2fbfefe9cb42..fd0f8cec8c7e 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1665,6 +1665,8 @@ static int tegra_dsi_resume(struct device *dev) static const struct dev_pm_ops tegra_dsi_pm_ops = { SET_RUNTIME_PM_OPS(tegra_dsi_suspend, tegra_dsi_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static const struct of_device_id tegra_dsi_of_match[] = { diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 334c4d7d238b..ef66defac767 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1739,6 +1739,8 @@ static int tegra_hdmi_resume(struct device *dev) static const struct dev_pm_ops tegra_hdmi_pm_ops = { SET_RUNTIME_PM_OPS(tegra_hdmi_suspend, tegra_hdmi_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; struct platform_driver tegra_hdmi_driver = { diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c index 92f202ec0577..3d33d0360169 100644 --- a/drivers/gpu/drm/tegra/hub.c +++ b/drivers/gpu/drm/tegra/hub.c @@ -931,6 +931,8 @@ static int __maybe_unused tegra_display_hub_resume(struct device *dev) static const struct dev_pm_ops tegra_display_hub_pm_ops = { SET_RUNTIME_PM_OPS(tegra_display_hub_suspend, tegra_display_hub_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; static const struct tegra_display_hub_soc tegra186_display_hub = { diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 4ffe3794e6d3..b743193bf0b1 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3572,6 +3572,8 @@ static int tegra_sor_resume(struct device *dev) static const struct dev_pm_ops tegra_sor_pm_ops = { SET_RUNTIME_PM_OPS(tegra_sor_suspend, tegra_sor_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; struct platform_driver tegra_sor_driver = { diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c index 958548ef69e7..880304a65c5c 100644 --- a/drivers/gpu/drm/tegra/vic.c +++ b/drivers/gpu/drm/tegra/vic.c @@ -476,6 +476,8 @@ static int vic_remove(struct platform_device *pdev) static const struct dev_pm_ops vic_pm_ops = { SET_RUNTIME_PM_OPS(vic_runtime_suspend, vic_runtime_resume, NULL) + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, + pm_runtime_force_resume) }; struct platform_driver tegra_vic_driver = { -- 2.22.0

2 3

[PATCH 0/5] drm: Aspect ratio fixes
by Ville Syrjala 14 Nov '19

14 Nov '19

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Ilia pointed out some oddball crap in the i915 aspect ratio handling. While looking at that I noticed a bunch of fail in the core as well. This series aims to fix it all. Cc: Ilia Mirkin <imirkin(a)alum.mit.edu> Ville Syrjälä (5): drm: Do not use bitwise OR to set picure_aspect_ratio drm: Do not accept garbage mode aspect ratio flags drm: WARN on illegal aspect ratio when converting a mode to umode drm/i915: Do not override mode's aspect ratio with the prop value NONE drm/i915: Drop redundant aspec ratio prop value initialization drivers/gpu/drm/drm_modes.c | 17 +++++++++++------ drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- drivers/gpu/drm/i915/display/intel_sdvo.c | 4 +--- 3 files changed, 14 insertions(+), 12 deletions(-) -- 2.21.0

4 9

[Bug 111638] Include tools/ in documentation
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=111638 Bug ID: 111638 Summary: Include tools/ in documentation Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: not set Priority: not set Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: arkadiusz.hiler(a)intel.com List the tools and include --help. If the tools have any gtk-doc-formatted documentation it also should be included. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 111637] Document configuration shadowing and clean up handling that in igt_core
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=111637 Bug ID: 111637 Summary: Document configuration shadowing and clean up handling that in igt_core Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: not set Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: arkadiusz.hiler(a)intel.com The current agreed order of importance is as follows: .igtrc < ENV < --switch or to put it in words .igtrc option is less important than ENV .igtrc and ENV are both less important than --switch Real world example: https://patchwork.freedesktop.org/series/63553/ device for IGT execution can be specified as Common::Device in .igtrc, IGT_DEVICE env variable or --device switch on command line. The idea is that .igtrc is the default set on the machine that can be overwritten for the whole session with env or just for a single test with --device. This needs to be documented and the whey we handle this in igt_core.c could use some streamlining. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 111630] Generate a list of tags for the machine that runs the testsuite
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=111630 Bug ID: 111630 Summary: Generate a list of tags for the machine that runs the testsuite Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: not set Priority: not set Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: martin.peres(a)free.fr Bug filing is done based on machine tags. They can be indicating a platform (TGL, SKL, ...), or a configuration (HDMI, PSR, CHAMELIUM, ...). This tagging is currently done manually, but it often is not in sync with the current platform state, which makes bug filing difficult and leads to random noise in CI until the proper tag is set. Since we would like individual developers and CI machines to have a consistent way of creating these tags (so as individual developers can filter out the known issues from their run locally), having an IGT test/utility to generate these tags would be ideal. I'll let Arek explain how it could be done :) -- You are receiving this mail because: You are the assignee for the bug.

1 2

[Bug 110754] Add tests checking how stable the CRCs are
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=110754 Bug ID: 110754 Summary: Add tests checking how stable the CRCs are Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: arkadiusz.hiler(a)intel.com Such test can be made part of BAT to give us overview of the health of pipe CRCs. Initial idea: 1. run collecting CRCs 2. pull off the chaos monkey doing hotplugs, workloads, etc 3. make sure that CRC is stable This way we will know which platforms suffer from unstable CRC and we can filter out all of the CRC mismatches using CI buglog. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 110619] Dump process stacktraces in case a test hangs
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=110619 Bug ID: 110619 Summary: Dump process stacktraces in case a test hangs Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: imre.deak(a)intel.com Feature request (ideas from Chris) to help determining where a test gets stuck: - provide the stack traces off all existing processes (cat /proc/*/stack) in case of a timeout - ptrace all the child from the IGT runner and provide the trace in case of a timeout -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 110600] [IGT runner] be more consistent with checks on display/outputs
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=110600 Bug ID: 110600 Summary: [IGT runner] be more consistent with checks on display/outputs Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: martin.peres(a)free.fr Right now, when a machine does not have modes or connectors, each test will skip in a different way, which makes bug filing a complete nightmare. KMS tests should all tests for some basic requirements and skip in the same way. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 110599] [IGT runner] Per-test external watchdog
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=110599 Bug ID: 110599 Summary: [IGT runner] Per-test external watchdog Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: martin.peres(a)free.fr Sometimes, machines' clock is not working at the right rate, or their watchdog is unreliable. To fix this issue, we should have an external watchdog which is reset after the beginning of every new test, and kills the machine after exceeding it. This watchdog's value should be greatly larger than the local watchdog in order to give it a chance to do the right thing. -- You are receiving this mail because: You are the assignee for the bug.

1 1

[Bug 110598] [IGT runner] allow tests to attach test-specific results
by bugzilla-daemon＠freedesktop.org 12 Nov '19

12 Nov '19

https://bugs.freedesktop.org/show_bug.cgi?id=110598 Bug ID: 110598 Summary: [IGT runner] allow tests to attach test-specific results Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: IGT Assignee: dri-devel(a)lists.freedesktop.org Reporter: martin.peres(a)free.fr Some tests might generate images or audio files which are relevant for debugging. We need to create a new way for tests to communicate to the igt runner these resources for it to store them in the results.json file. -- You are receiving this mail because: You are the assignee for the bug.

1 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2019