dri-devel April 2020

dri-devel@lists.freedesktop.org

353 participants
944 discussions

[PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms
by Michal Simek 25 Nov '20

25 Nov '20

Hi, recently we wanted to update xilinx intc driver and we found that function which we wanted to remove is still wired by ancient Xilinx PowerPC platforms. Here is the thread about it. https://lore.kernel.org/linux-next/48d3232d-0f1d-42ea-3109-f44bbabfa2e8@xil… I have been talking about it internally and there is no interest in these platforms and it is also orphan for quite a long time. None is really running/testing these platforms regularly that's why I think it makes sense to remove them also with drivers which are specific to this platform. U-Boot support was removed in 2017 without anybody complain about it https://github.com/Xilinx/u-boot-xlnx/commit/98f705c9cefdfdba62c069821bbba1… Based on current ppc/next. If anyone has any objection about it, please let me know. Thanks, Michal Michal Simek (2): sound: ac97: Remove sound driver for ancient platform powerpc: Remove Xilinx PPC405/PPC440 support Documentation/devicetree/bindings/xilinx.txt | 143 -- Documentation/powerpc/bootwrapper.rst | 28 +- MAINTAINERS | 6 - arch/powerpc/Kconfig.debug | 2 +- arch/powerpc/boot/Makefile | 7 +- arch/powerpc/boot/dts/Makefile | 1 - arch/powerpc/boot/dts/virtex440-ml507.dts | 406 ------ arch/powerpc/boot/dts/virtex440-ml510.dts | 466 ------- arch/powerpc/boot/ops.h | 1 - arch/powerpc/boot/serial.c | 5 - arch/powerpc/boot/uartlite.c | 79 -- arch/powerpc/boot/virtex.c | 97 -- arch/powerpc/boot/virtex405-head.S | 31 - arch/powerpc/boot/wrapper | 8 - arch/powerpc/configs/40x/virtex_defconfig | 75 - arch/powerpc/configs/44x/virtex5_defconfig | 74 - arch/powerpc/configs/ppc40x_defconfig | 8 - arch/powerpc/configs/ppc44x_defconfig | 8 - arch/powerpc/include/asm/xilinx_intc.h | 16 - arch/powerpc/include/asm/xilinx_pci.h | 21 - arch/powerpc/kernel/cputable.c | 39 - arch/powerpc/platforms/40x/Kconfig | 31 - arch/powerpc/platforms/40x/Makefile | 1 - arch/powerpc/platforms/40x/virtex.c | 54 - arch/powerpc/platforms/44x/Kconfig | 37 - arch/powerpc/platforms/44x/Makefile | 2 - arch/powerpc/platforms/44x/virtex.c | 60 - arch/powerpc/platforms/44x/virtex_ml510.c | 30 - arch/powerpc/platforms/Kconfig | 4 - arch/powerpc/sysdev/Makefile | 2 - arch/powerpc/sysdev/xilinx_intc.c | 88 -- arch/powerpc/sysdev/xilinx_pci.c | 132 -- arch/powerpc/xmon/ppc-dis.c | 6 - arch/powerpc/xmon/ppc-opc.c | 23 - arch/powerpc/xmon/ppc.h | 5 - drivers/char/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 2 +- sound/drivers/Kconfig | 12 - sound/drivers/Makefile | 2 - sound/drivers/ml403-ac97cr.c | 1298 ------------------ 40 files changed, 7 insertions(+), 3305 deletions(-) delete mode 100644 arch/powerpc/boot/dts/virtex440-ml507.dts delete mode 100644 arch/powerpc/boot/dts/virtex440-ml510.dts delete mode 100644 arch/powerpc/boot/uartlite.c delete mode 100644 arch/powerpc/boot/virtex.c delete mode 100644 arch/powerpc/boot/virtex405-head.S delete mode 100644 arch/powerpc/configs/40x/virtex_defconfig delete mode 100644 arch/powerpc/configs/44x/virtex5_defconfig delete mode 100644 arch/powerpc/include/asm/xilinx_intc.h delete mode 100644 arch/powerpc/include/asm/xilinx_pci.h delete mode 100644 arch/powerpc/platforms/40x/virtex.c delete mode 100644 arch/powerpc/platforms/44x/virtex.c delete mode 100644 arch/powerpc/platforms/44x/virtex_ml510.c delete mode 100644 arch/powerpc/sysdev/xilinx_intc.c delete mode 100644 arch/powerpc/sysdev/xilinx_pci.c delete mode 100644 sound/drivers/ml403-ac97cr.c -- 2.26.0

9 29

[Bug 201763] New: amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0!
by bugzilla-daemon＠bugzilla.kernel.org 19 Nov '20

19 Nov '20

https://bugzilla.kernel.org/show_bug.cgi?id=201763 Bug ID: 201763 Summary: amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0! Product: Drivers Version: 2.5 Kernel Version: 4.18.10 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: rbrito(a)ime.usp.br Regression: No Dear developers, I have a notebook that is giving me a lot of trouble, especially as it is the newest computer that I have at my disposal where I can perform any actual work. This notebook has VERY frequent lockups (hard freezes, where the screen displays something where I am working, but the keyboard does not respond, the mouse doesn't either etc.). The only way that I can resume any work is by forcibly shutting it down (by pushing the power button for many seconds) and, of course, having all previous unsaved work lost (including a previous report of this bug with the bugzilla interface). :-( There is no particular pattern that I could discover so far that triggers the problem (for the past year, at least), but I do see some error messages on my dmesg logs and I would like start with some of the more salient points by sharing some problems that I have and, perhaps, zero in on potentially loose ends that may help everybody with hardware that is similar. The notebook in question is a Dell Inspiron 5548 with a Core i7-5500U, with two graphic cards (or so I am told), with one of them being integrated with the CPU and another being a discrete AMD GPU. The userspace that I am using is a Debian testing (soon to be Debian 10) with Debian's kernel 4.18.0-2-amd64 (which is actually a kernel 4.18.10-2). I can, of course, test any other kernels for the sake of getting things fixed. Just let me know and I will do my best to fix things. BTW, no kernel that I have ever used on this machine has every worked perfectly, even the prebuilt, unpatched kernels that Ubuntu compiles daily. With that being said, when the kernel boots up, there are some red messages on the dmesg log that are related to this AMD GPU (the entire dmesg log will be attached) with some prominent lines being: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - $ dmesg | grep -E -i "drm|amdgpu|i965" [ 13.054583] fb: switching to inteldrmfb from EFI VGA [ 13.059874] [drm] Replacing VGA console driver [ 13.060448] [drm] ACPI BIOS requests an excessive sleep of 10000 ms, using 1500 ms instead [ 13.061122] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 13.061126] [drm] Driver supports precise vblank timestamp query. [ 13.067596] [drm] Initialized i915 1.6.0 20180514 for 0000:00:02.0 on minor 0 [ 13.071479] fbcon: inteldrmfb (fb0) is primary device [ 13.475640] [drm] amdgpu kernel modesetting enabled. [ 14.237446] i915 0000:00:02.0: fb0: inteldrmfb frame buffer device [ 14.238730] amdgpu 0000:04:00.0: enabling device (0100 -> 0103) [ 14.240876] [drm] initializing kernel modesetting (TOPAZ 0x1002:0x6900 0x1028:0x0643 0x00). [ 14.240888] [drm] register mmio base: 0xC2000000 [ 14.240888] [drm] register mmio size: 262144 [ 14.240898] [drm] probing gen 2 caps for device 8086:9c98 = 5323c42/0 [ 14.240899] [drm] probing mlw for device 8086:9c98 = 5323c42 [ 14.240901] [drm] add ip block number 0 <vi_common> [ 14.240901] [drm] add ip block number 1 <gmc_v7_0> [ 14.240902] [drm] add ip block number 2 <iceland_ih> [ 14.240902] [drm] add ip block number 3 <powerplay> [ 14.240903] [drm] add ip block number 4 <gfx_v8_0> [ 14.240904] [drm] add ip block number 5 <sdma_v2_4> [ 14.240905] amdgpu 0000:04:00.0: kfd not supported on this ASIC [ 14.262237] [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is 9-bit [ 14.346850] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_mc.bin [ 14.347897] amdgpu 0000:04:00.0: VRAM: 2048M 0x000000F400000000 - 0x000000F47FFFFFFF (2048M used) [ 14.348877] amdgpu 0000:04:00.0: GTT: 256M 0x0000000000000000 - 0x000000000FFFFFFF [ 14.350661] [drm] Detected VRAM RAM=2048M, BAR=256M [ 14.351494] [drm] RAM width 64bits DDR3 [ 14.358584] [drm] amdgpu: 2048M of VRAM memory ready [ 14.359442] [drm] amdgpu: 3072M of GTT memory ready. [ 14.360290] [drm] GART: num cpu pages 65536, num gpu pages 65536 [ 14.361807] [drm] PCIE GART of 256M enabled (table at 0x000000F400000000). [ 14.363257] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 14.364522] [drm] Driver supports precise vblank timestamp query. [ 14.365629] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_pfp.bin [ 14.366113] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_me.bin [ 14.366262] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_ce.bin [ 14.366264] [drm] Chained IB support enabled! [ 14.366414] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_rlc.bin [ 14.381603] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_mec.bin [ 14.384759] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_sdma.bin [ 14.386476] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_sdma1.bin [ 14.461717] amdgpu 0000:04:00.0: firmware: direct-loading firmware amdgpu/topaz_smc.bin [ 14.465233] amdgpu: [powerplay] can't get the mac of 5 [ 14.467411] amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0! [ 14.477284] [drm] Initialized amdgpu 3.26.0 20150101 for 0000:04:00.0 on minor 1 [ 21.824595] amdgpu: [powerplay] VI should always have 2 performance levels [ 21.871775] amdgpu 0000:04:00.0: GPU pci config reset [ 22.574755] [drm] PCIE GART of 256M enabled (table at 0x000000F400000000). [ 22.577374] amdgpu: [powerplay] can't get the mac of 5 [ 22.578782] amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0! [ 29.802702] amdgpu: [powerplay] VI should always have 2 performance levels [ 29.848230] amdgpu 0000:04:00.0: GPU pci config reset - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Well, that's it. Please let me know whatever information you want me to get and I will post it here. Reiterating: I can compile kernels and or run other programs to diagnose anything that you want me to to fix these issues. Thanks in advance, Rogério Brito. -- You are receiving this mail because: You are watching the assignee of the bug.

1 13

[RESEND PATCH v3 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs
by Sakari Ailus 03 Nov '20

03 Nov '20

Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab <mchehab(a)kernel.org> Signed-off-by: Sakari Ailus <sakari.ailus(a)linux.intel.com> --- since v2: - Add comments to explain why things are being done - Print characters under 32 (space) as hexadecimals in parenthesis. - Do not print spaces in the fourcc codes. - Make use of a loop over the fourcc characters instead of put_unaligned_le32(). This is necessary to omit spaces in the output. - Use DRM style format instead of V4L2. This provides the precise code as a numerical value as well as explicit endianness information. - Added WARN_ON_ONCE() sanity checks. Comments on these are welcome; I'd expect them mostly be covered by the tests. - Added tests for %p4cc in lib/test_printf.c Documentation/core-api/printk-formats.rst | 12 ++++ lib/test_printf.c | 17 +++++ lib/vsprintf.c | 86 +++++++++++++++++++++++ 3 files changed, 115 insertions(+) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index 8ebe46b1af39..7aa0451e06fb 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -545,6 +545,18 @@ For printing netdev_features_t. Passed by reference. +V4L2 and DRM FourCC code (pixel format) +--------------------------------------- + +:: + + %p4cc + +Print a FourCC code used by V4L2 or DRM, including format endianness and +its numerical value as hexadecimal. + +Passed by reference. + Thanks ====== diff --git a/lib/test_printf.c b/lib/test_printf.c index 2d9f520d2f27..a14754086707 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -624,6 +624,22 @@ static void __init fwnode_pointer(void) software_node_unregister_nodes(softnodes); } +static void __init fourcc_pointer(void) +{ + struct { + u32 code; + char *str; + } const try[] = { + { 0x20104646, "FF(10) little-endian (0x20104646)", }, + { 0xa0104646, "FF(10) big-endian (0xa0104646)", }, + { 0x10111213, "(13)(12)(11)(10) little-endian (0x10111213)", }, + }; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(try); i++) + test(try[i].str, "%p4cc", &try[i].code); +} + static void __init errptr(void) { @@ -668,6 +684,7 @@ test_pointer(void) flags(); errptr(); fwnode_pointer(); + fourcc_pointer(); } static void __init selftest(void) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 7c488a1ce318..02e7906619c0 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1721,6 +1721,89 @@ char *netdev_bits(char *buf, char *end, const void *addr, return special_hex_number(buf, end, num, size); } +static noinline_for_stack +char *fourcc_string(char *buf, char *end, const u32 *__fourcc, + struct printf_spec spec, const char *fmt) +{ +#define FOURCC_HEX_CHAR_STR "(xx)" +#define FOURCC_BIG_ENDIAN_STR " big-endian" +#define FOURCC_LITTLE_ENDIAN_STR " little-endian" +#define FOURCC_HEX_NUMBER " (0x01234567)" +#define FOURCC_STRING_MAX \ + FOURCC_HEX_CHAR_STR FOURCC_HEX_CHAR_STR FOURCC_HEX_CHAR_STR \ + FOURCC_HEX_CHAR_STR FOURCC_LITTLE_ENDIAN_STR FOURCC_HEX_NUMBER + struct printf_spec my_spec = { + .type = FORMAT_TYPE_UINT, + .field_width = 2, + .flags = SMALL, + .base = 16, + .precision = -1, + }; + char __s[sizeof(FOURCC_STRING_MAX)]; + char *s = __s; + unsigned int i; + /* + * The 31st bit defines the endianness of the data, so save its printing + * for later. + */ + u32 fourcc = *__fourcc & ~BIT(31); + int ret; + + if (check_pointer(&buf, end, __fourcc, spec)) + return buf; + + if (fmt[1] != 'c' || fmt[2] != 'c') + return error_string(buf, end, "(%p4?)", spec); + + for (i = 0; i < sizeof(fourcc); i++, fourcc >>= 8) { + unsigned char c = fourcc; + + /* Weed out spaces */ + if (c == ' ') + continue; + + /* Print non-control characters as-is */ + if (c > ' ') { + *s = c; + s++; + continue; + } + + if (WARN_ON_ONCE(sizeof(__s) < + (s - __s) + sizeof(FOURCC_HEX_CHAR_STR))) + break; + + *s = '('; + s++; + s = number(s, s + 2, c, my_spec); + *s = ')'; + s++; + } + + ret = strscpy(s, *__fourcc & BIT(31) ? FOURCC_BIG_ENDIAN_STR + : FOURCC_LITTLE_ENDIAN_STR, + sizeof(__s) - (s - __s)); + if (!WARN_ON_ONCE(ret < 0)) + s += ret; + + if (!WARN_ON_ONCE(sizeof(__s) < + (s - __s) + sizeof(FOURCC_HEX_NUMBER))) { + *s = ' '; + s++; + *s = '('; + s++; + /* subtract parentheses and the space from the size */ + special_hex_number(s, s + sizeof(FOURCC_HEX_NUMBER) - 3, + *__fourcc, sizeof(u32)); + s += sizeof(u32) * 2 + 2 /* 0x */; + *s = ')'; + s++; + *s = '\0'; + } + + return string(buf, end, __s, spec); +} + static noinline_for_stack char *address_val(char *buf, char *end, const void *addr, struct printf_spec spec, const char *fmt) @@ -2131,6 +2214,7 @@ char *fwnode_string(char *buf, char *end, struct fwnode_handle *fwnode, * correctness of the format string and va_list arguments. * - 'K' For a kernel pointer that should be hidden from unprivileged users * - 'NF' For a netdev_features_t + * - '4cc' V4L2 or DRM FourCC code, with endianness and raw numerical value. * - 'h[CDN]' For a variable-length buffer, it prints it as a hex string with * a certain separator (' ' by default): * C colon @@ -2223,6 +2307,8 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, return restricted_pointer(buf, end, ptr, spec); case 'N': return netdev_bits(buf, end, ptr, spec, fmt); + case '4': + return fourcc_string(buf, end, ptr, spec, fmt); case 'a': return address_val(buf, end, ptr, spec, fmt); case 'd': -- 2.20.1

4 5

[PATCH] drm/v3d: Fix double free in v3d_submit_cl_ioctl()
by Dan Carpenter 26 Oct '20

26 Oct '20

Originally this error path used to leak "bin" but then we accidentally applied two separate commits to fix it and ended up with a double free. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- Hi Stephen, I think this one is actually just a linux-next issue and the Fixes tag would point to commit f8593384f83f ("Merge remote-tracking branch 'drm/drm-next'"). The original commits are 0d352a3a8a1f ("drm/v3d: don't leak bin job if v3d_job_init fails.") and commit 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl"). I'm not totally sure how you guys address this normally but presumably you are experts at dealing with merge issues. :) drivers/gpu/drm/v3d/v3d_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 549dde83408b..37515e47b47e 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -568,7 +568,6 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data, ret = v3d_job_init(v3d, file_priv, &bin->base, v3d_job_free, args->in_sync_bcl); if (ret) { - kfree(bin); v3d_job_put(&render->base); kfree(bin); return ret; -- 2.20.1

3 4

[Bug 203339] New: AMDGPU: virtual_display disables physical outputs
by bugzilla-daemon＠bugzilla.kernel.org 21 Oct '20

21 Oct '20

https://bugzilla.kernel.org/show_bug.cgi?id=203339 Bug ID: 203339 Summary: AMDGPU: virtual_display disables physical outputs Product: Drivers Version: 2.5 Kernel Version: 5.0.7 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: parker.l.reed(a)gmail.com Regression: No Created attachment 282351 --> https://bugzilla.kernel.org/attachment.cgi?id=282351&action=edit Kernel log Unable to tell if this is intended or if caused by a crash. I have a monitor connected via HDMI. When I use the virtual_display kernel parameter, only the virtual displays show up. amdgpu.virtual_display=0000:07:00.0,2 Original patchset doesn't mention this usecase. https://lists.freedesktop.org/archives/amd-gfx/2016-August/001058.html Kernel log attached shows some crashes related to dce_virtual_crtc -- You are receiving this mail because: You are watching the assignee of the bug.

1 5

[Bug 203471] New: Tearing on Raven Ridge and RX560X PRIME setup even with Vsync enabled
by bugzilla-daemon＠bugzilla.kernel.org 16 Oct '20

16 Oct '20

https://bugzilla.kernel.org/show_bug.cgi?id=203471 Bug ID: 203471 Summary: Tearing on Raven Ridge and RX560X PRIME setup even with Vsync enabled Product: Drivers Version: 2.5 Kernel Version: 5.1 rc6 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: haxk612(a)gmail.com Regression: No I have Acer Nitro 5 AN515-42 with Ryzen 5 2500U and RX560X. When i launch some game with DRI_PRIME=1 to have it on dGPU there is huge tearing on top of the screen that is there with or without Vsync. If i launch the game on iGPU there is no tearing at all. Also the tearing happens only when the game is in fullscreen. If i take a screenshot there is no tearing in the screenshot. And i cannot post a picture as my phone camera is broken in my latest build of android. I have tried 5.2-wip branch and there is the same issue. Will post dmesg and journalctl in few hours. -- You are receiving this mail because: You are watching the assignee of the bug.

1 26

[PATCH v3] drm: shmobile: Reduce include dependencies
by Andy Shevchenko 13 Oct '20

13 Oct '20

This file doesn't need everything provided by <linux/kernel.h>. All it needs are some types, which are provided by <drm/drm_mode.h>. Drop unneeded <linux/kernel.h> completely. Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- v3: Drop header completely (Laurent) include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..d661399b217d 100644 --- a/include/linux/platform_data/shmob_drm.h +++ b/include/linux/platform_data/shmob_drm.h @@ -10,8 +10,6 @@ #ifndef __SHMOB_DRM_H__ #define __SHMOB_DRM_H__ -#include <linux/kernel.h> - #include <drm/drm_mode.h> enum shmob_drm_clk_source { -- 2.24.1

3 3

[PATCH] drm: aspeed: Fix GENMASK misuse
by Ondrej Jirman 09 Oct '20

09 Oct '20

Arguments to GENMASK should be msb >= lsb. Signed-off-by: Ondrej Jirman <megous(a)megous.com> --- I just grepped the whole kernel tree for GENMASK argument order issues, and this is one of the three that popped up. No testing was done. drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h index a10358bb61ec4..095ea03e5833c 100644 --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); /* CTRL2 */ #define CRT_CTRL_DAC_EN BIT(0) #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) /* CRT_HORIZ0 */ #define CRT_H_TOTAL(x) (x) -- 2.25.1

3 2

KASAN: vmalloc-out-of-bounds Write in sys_imageblit
by syzbot 07 Oct '20

07 Oct '20

Hello, syzbot found the following crash on: HEAD commit: 6794862a Merge tag 'for-5.5-rc1-kconfig-tag' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17f407f2e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=79f79de2a27d3e3d dashboard link: https://syzkaller.appspot.com/bug?extid=26dc38a00dc05118a4e6 compiler: gcc (GCC) 9.0.0 20181231 (experimental) Unfortunately, I don't have any reproducer for this crash yet. IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+26dc38a00dc05118a4e6(a)syzkaller.appspotmail.com ================================================================== BUG: KASAN: vmalloc-out-of-bounds in fast_imageblit drivers/video/fbdev/core/sysimgblt.c:229 [inline] BUG: KASAN: vmalloc-out-of-bounds in sys_imageblit+0x117f/0x1240 drivers/video/fbdev/core/sysimgblt.c:275 Write of size 4 at addr ffffc90008de1000 by task syz-executor.3/19698 CPU: 0 PID: 19698 Comm: syz-executor.3 Not tainted 5.5.0-rc1-syzkaller #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x197/0x210 lib/dump_stack.c:118 print_address_description.constprop.0.cold+0x5/0x30b mm/kasan/report.c:374 __kasan_report.cold+0x1b/0x41 mm/kasan/report.c:506 kasan_report+0x12/0x20 mm/kasan/common.c:639 __asan_report_store4_noabort+0x17/0x20 mm/kasan/generic_report.c:139 fast_imageblit drivers/video/fbdev/core/sysimgblt.c:229 [inline] sys_imageblit+0x117f/0x1240 drivers/video/fbdev/core/sysimgblt.c:275 drm_fb_helper_sys_imageblit+0x21/0x180 drivers/gpu/drm/drm_fb_helper.c:768 bit_putcs_unaligned drivers/video/fbdev/core/bitblit.c:139 [inline] bit_putcs+0x9a3/0xf10 drivers/video/fbdev/core/bitblit.c:188 fbcon_putcs+0x33c/0x3e0 drivers/video/fbdev/core/fbcon.c:1353 do_update_region+0x42b/0x6f0 drivers/tty/vt/vt.c:677 invert_screen+0x2da/0x650 drivers/tty/vt/vt.c:794 highlight drivers/tty/vt/selection.c:53 [inline] clear_selection drivers/tty/vt/selection.c:81 [inline] clear_selection+0x59/0x70 drivers/tty/vt/selection.c:77 vc_do_resize+0x1163/0x1460 drivers/tty/vt/vt.c:1200 vc_resize+0x4d/0x60 drivers/tty/vt/vt.c:1304 fbcon_do_set_font+0x4a6/0x960 drivers/video/fbdev/core/fbcon.c:2599 fbcon_set_font+0x72e/0x860 drivers/video/fbdev/core/fbcon.c:2696 con_font_set drivers/tty/vt/vt.c:4538 [inline] con_font_op+0xe30/0x1270 drivers/tty/vt/vt.c:4603 vt_ioctl+0xd2e/0x26d0 drivers/tty/vt/vt_ioctl.c:913 tty_ioctl+0xa37/0x14f0 drivers/tty/tty_io.c:2660 vfs_ioctl fs/ioctl.c:47 [inline] file_ioctl fs/ioctl.c:545 [inline] do_vfs_ioctl+0x977/0x14e0 fs/ioctl.c:732 ksys_ioctl+0xab/0xd0 fs/ioctl.c:749 __do_sys_ioctl fs/ioctl.c:756 [inline] __se_sys_ioctl fs/ioctl.c:754 [inline] __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:754 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x45a7c9 Code: bd b1 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 8b b1 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fcfa0ba6c88 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 000000000072bf00 RCX: 000000000045a7c9 RDX: 0000000020000140 RSI: 0000000000004b61 RDI: 0000000000000003 RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fcfa0ba76d4 R13: 00000000004ab60f R14: 00000000006ede60 R15: 00000000ffffffff Memory state around the buggy address: ffffc90008de0f00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ffffc90008de0f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > ffffc90008de1000: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 ^ ffffc90008de1080: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 ffffc90008de1100: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 ================================================================== --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

1 2

[PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system
by Kai-Heng Feng 07 Oct '20

07 Oct '20

There's another Samsung OLED panel needs to use DPCD aux interface to control backlight. Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index c6fbe6e6bc9d..d0cfee3b7a65 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -1299,6 +1299,8 @@ static const struct edid_quirk edid_quirk_list[] = { * only supports DPCD backlight controls */ { MFG(0x4c, 0x83), PROD_ID(0x41, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) }, + /* HP CML 2020 system */ + { MFG(0x4c, 0x83), PROD_ID(0x45, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) }, /* * Some Dell CML 2020 systems have panels support both AUX and PWM * backlight control, and some only support AUX backlight control. All -- 2.17.1

2 2

← Newer
1
2
3
4
5
6
7
8
9
...
95
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2020