dri-devel April 2020

dri-devel@lists.freedesktop.org

353 participants
944 discussions

[PATCH v5 0/4] Config mipi tx current and impedance
by Jitao Shi 10 Apr '20

10 Apr '20

Changes since v4: - add Reviewed-by: - move the get the calibration data code to probe. Changes since v3: - refine drive-strength-microamp as from 3000 to 6000. Changes since v2: - fix the title of commit message. - rename mipitx-current-drive to drive-strength-microamp Changes since v1: - fix coding style. - change mtk_mipi_tx_config_calibration_data() to void Jitao Shi (4): dt-bindings: display: mediatek: add property to control mipi tx drive current dt-bindings: display: mediatek: get mipitx calibration data from nvmem drm/mediatek: add the mipitx driving control drm/mediatek: config mipitx impedance with calibration data .../display/mediatek/mediatek,dsi.txt | 10 ++++ drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 54 +++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_mipi_tx.h | 4 ++ drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c | 28 ++++++++++ 4 files changed, 96 insertions(+) -- 2.21.0

2 5

[PATCH] AMDGPU: Correctly initialize thermal controller for GPUs with Powerplay table v0 (e.g Hawaii)
by Sandeep 10 Apr '20

10 Apr '20

This is required for the AMDGPU driver to report fan speed for Hawaii GPUs (otherwise the fan speed is just reported as 0) --- .../drm/amd/powerplay/hwmgr/processpptables.c | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c index 77c14671866c..bb58cfab1033 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c @@ -984,6 +984,34 @@ static int init_thermal_controller( struct pp_hwmgr *hwmgr, const ATOM_PPLIB_POWERPLAYTABLE *powerplay_table) { + hwmgr->thermal_controller.ucType = + powerplay_table->sThermalController.ucType; + hwmgr->thermal_controller.ucI2cLine = + powerplay_table->sThermalController.ucI2cLine; + hwmgr->thermal_controller.ucI2cAddress = + powerplay_table->sThermalController.ucI2cAddress; + + hwmgr->thermal_controller.fanInfo.bNoFan = + (0 != (powerplay_table->sThermalController.ucFanParameters & + ATOM_PP_FANPARAMETERS_NOFAN)); + + hwmgr->thermal_controller.fanInfo.ucTachometerPulsesPerRevolution = + powerplay_table->sThermalController.ucFanParameters & + ATOM_PP_FANPARAMETERS_TACHOMETER_PULSES_PER_REVOLUTION_MASK; + + hwmgr->thermal_controller.fanInfo.ulMinRPM + = powerplay_table->sThermalController.ucFanMinRPM * 100UL; + hwmgr->thermal_controller.fanInfo.ulMaxRPM + = powerplay_table->sThermalController.ucFanMaxRPM * 100UL; + + set_hw_cap( + hwmgr, + ATOM_PP_THERMALCONTROLLER_NONE != hwmgr->thermal_controller.ucType, + PHM_PlatformCaps_ThermalController + ); + + hwmgr->thermal_controller.use_hw_fan_control = 1; + return 0; } --

1 1

drm/tve200: Checking for a failed platform_get_irq() call in tve200_probe()
by Markus Elfring 10 Apr '20

10 Apr '20

Hello, I have taken another look at the implementation of the function “tve200_probe”. A software analysis approach points the following source code out for further development considerations. https://elixir.bootlin.com/linux/v5.6.3/source/drivers/gpu/drm/tve200/tve20… https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri… irq = platform_get_irq(pdev, 0); if (!irq) { ret = -EINVAL; goto clk_disable; } The software documentation is providing the following information for the used programming interface. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri… https://elixir.bootlin.com/linux/v5.6.3/source/drivers/base/platform.c#L202 “… * Return: IRQ number on success, negative error number on failure. …” Would you like to reconsider the shown condition check? Regards, Markus

2 4

Patch "drm/i915: Fix ref->mutex deadlock in i915_active_wait()" has been added to the 5.4-stable tree
by gregkh＠linuxfoundation.org 10 Apr '20

10 Apr '20

This is a note to let you know that I've just added the patch titled drm/i915: Fix ref->mutex deadlock in i915_active_wait() to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: drm-i915-fix-ref-mutex-deadlock-in-i915_active_wait.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From sultan(a)kerneltoast.com Fri Apr 10 11:07:34 2020 From: Sultan Alsawaf <sultan(a)kerneltoast.com> Date: Tue, 7 Apr 2020 00:18:09 -0700 Subject: drm/i915: Fix ref->mutex deadlock in i915_active_wait() To: Greg KH <greg(a)kroah.com> Cc: stable(a)vger.kernel.org, Jani Nikula <jani.nikula(a)linux.intel.com>, Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com>, Rodrigo Vivi <rodrigo.vivi(a)intel.com>, David Airlie <airlied(a)linux.ie>, Daniel Vetter <daniel(a)ffwll.ch>, Chris Wilson <chris(a)chris-wilson.co.uk>, intel-gfx(a)lists.freedesktop.org, dri-devel(a)lists.freedesktop.org, Sultan Alsawaf <sultan(a)kerneltoast.com> Message-ID: <20200407071809.3148-1-sultan(a)kerneltoast.com> From: Sultan Alsawaf <sultan(a)kerneltoast.com> The following deadlock exists in i915_active_wait() due to a double lock on ref->mutex (call chain listed in order from top to bottom): i915_active_wait(); mutex_lock_interruptible(&ref->mutex); <-- ref->mutex first acquired i915_active_request_retire(); node_retire(); active_retire(); mutex_lock_nested(&ref->mutex, SINGLE_DEPTH_NESTING); <-- DEADLOCK Fix the deadlock by skipping the second ref->mutex lock when active_retire() is called through i915_active_request_retire(). Note that this bug only affects 5.4 and has since been fixed in 5.5. Normally, a backport of the fix from 5.5 would be in order, but the patch set that fixes this deadlock involves massive changes that are neither feasible nor desirable for backporting [1][2][3]. Therefore, this small patch was made to address the deadlock specifically for 5.4. [1] 274cbf20fd10 ("drm/i915: Push the i915_active.retire into a worker") [2] 093b92287363 ("drm/i915: Split i915_active.mutex into an irq-safe spinlock for the rbtree") [3] 750bde2fd4ff ("drm/i915: Serialise with remote retirement") Fixes: 12c255b5dad1 ("drm/i915: Provide an i915_active.acquire callback") Cc: <stable(a)vger.kernel.org> # 5.4.x Signed-off-by: Sultan Alsawaf <sultan(a)kerneltoast.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/i915/i915_active.c | 27 +++++++++++++++++++++++---- drivers/gpu/drm/i915/i915_active.h | 4 ++-- 2 files changed, 25 insertions(+), 6 deletions(-) --- a/drivers/gpu/drm/i915/i915_active.c +++ b/drivers/gpu/drm/i915/i915_active.c @@ -120,13 +120,17 @@ static inline void debug_active_assert(s #endif +#define I915_ACTIVE_RETIRE_NOLOCK BIT(0) + static void __active_retire(struct i915_active *ref) { struct active_node *it, *n; struct rb_root root; bool retire = false; + unsigned long bits; + ref = ptr_unpack_bits(ref, &bits, 2); lockdep_assert_held(&ref->mutex); /* return the unused nodes to our slabcache -- flushing the allocator */ @@ -138,7 +142,8 @@ __active_retire(struct i915_active *ref) retire = true; } - mutex_unlock(&ref->mutex); + if (!(bits & I915_ACTIVE_RETIRE_NOLOCK)) + mutex_unlock(&ref->mutex); if (!retire) return; @@ -155,13 +160,18 @@ __active_retire(struct i915_active *ref) static void active_retire(struct i915_active *ref) { + struct i915_active *ref_packed = ref; + unsigned long bits; + + ref = ptr_unpack_bits(ref, &bits, 2); GEM_BUG_ON(!atomic_read(&ref->count)); if (atomic_add_unless(&ref->count, -1, 1)) return; /* One active may be flushed from inside the acquire of another */ - mutex_lock_nested(&ref->mutex, SINGLE_DEPTH_NESTING); - __active_retire(ref); + if (!(bits & I915_ACTIVE_RETIRE_NOLOCK)) + mutex_lock_nested(&ref->mutex, SINGLE_DEPTH_NESTING); + __active_retire(ref_packed); } static void @@ -170,6 +180,14 @@ node_retire(struct i915_active_request * active_retire(node_from_active(base)->ref); } +static void +node_retire_nolock(struct i915_active_request *base, struct i915_request *rq) +{ + struct i915_active *ref = node_from_active(base)->ref; + + active_retire(ptr_pack_bits(ref, I915_ACTIVE_RETIRE_NOLOCK, 2)); +} + static struct i915_active_request * active_instance(struct i915_active *ref, struct intel_timeline *tl) { @@ -421,7 +439,8 @@ int i915_active_wait(struct i915_active break; } - err = i915_active_request_retire(&it->base, BKL(ref)); + err = i915_active_request_retire(&it->base, BKL(ref), + node_retire_nolock); if (err) break; } --- a/drivers/gpu/drm/i915/i915_active.h +++ b/drivers/gpu/drm/i915/i915_active.h @@ -309,7 +309,7 @@ i915_active_request_isset(const struct i */ static inline int __must_check i915_active_request_retire(struct i915_active_request *active, - struct mutex *mutex) + struct mutex *mutex, i915_active_retire_fn retire) { struct i915_request *request; long ret; @@ -327,7 +327,7 @@ i915_active_request_retire(struct i915_a list_del_init(&active->link); RCU_INIT_POINTER(active->request, NULL); - active->retire(active, request); + retire(active, request); return 0; } Patches currently in stable-queue which might be from sultan(a)kerneltoast.com are queue-5.4/drm-i915-fix-ref-mutex-deadlock-in-i915_active_wait.patch

1 0

[PATCH] drm/ttm: Break out the loops if need_resched in bo delayed delete worker
by xinhui pan 10 Apr '20

10 Apr '20

The delayed delete list is per device which might be very huge. And in a heavy workload test, the list might always not be empty. That will trigger any RCU stall warnings or softlockups in non-preemptible kernels Lets do break out the loops in that case. Signed-off-by: xinhui pan <xinhui.pan(a)amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 9e07c3f75156..c5b516fa4eae 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -518,7 +518,7 @@ static bool ttm_bo_delayed_delete(struct ttm_bo_device *bdev, bool remove_all) INIT_LIST_HEAD(&removed); spin_lock(&glob->lru_lock); - while (!list_empty(&bdev->ddestroy)) { + while (!list_empty(&bdev->ddestroy) && !need_resched()) { struct ttm_buffer_object *bo; bo = list_first_entry(&bdev->ddestroy, struct ttm_buffer_object, -- 2.17.1

1 0

[PATCH v5 0/5] Genericize DW MIPI DSI bridge and add i.MX 6 driver
by Adrian Ratiu 10 Apr '20

10 Apr '20

Hello everyone, The v5 series is a significantly cleaned up version from v4, started by Ezequiel Garcia's suggestion of splitting out the regmap infrastructure from the drivers (thank you!). Turns out no changes are required to the existing drivers and the bridge can transparently take care of the layout logic, so there's no need to expose the regmap via plat_data anymore. Starting from this version I also opted to add per-patch changelogs. All review comments up to now have been addressed. Tested on IMX6DL. Adrian Ratiu (5): drm: bridge: dw_mipi_dsi: add initial regmap infrastructure drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: bridge: synopsis: add dsi v1.01 support drm: imx: Add i.MX 6 MIPI DSI host platform driver dt-bindings: display: add i.MX6 MIPI DSI host controller doc .../display/imx/fsl,mipi-dsi-imx6.yaml | 134 ++++ drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 683 +++++++++++++----- drivers/gpu/drm/imx/Kconfig | 7 + drivers/gpu/drm/imx/Makefile | 1 + drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 399 ++++++++++ 5 files changed, 1049 insertions(+), 175 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c -- 2.26.0

6 21

[PATCH v2] staging: android: ion: use macro DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
by R Veera Kumar 10 Apr '20

10 Apr '20

It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file operation rather than DEFINE_SIMPLE_ATTRIBUTE. Found using coccinelle. Signed-off-by: R Veera Kumar <vkor(a)vkten.in> --- Changes in v2: - Give correct explanation for patch - Adjust git commit tag and msg accordingly --- drivers/staging/android/ion/ion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 38b51eace4f9..dbe4018a6f83 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -554,8 +554,8 @@ static int debug_shrink_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, - debug_shrink_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get, + debug_shrink_set, "%llu\n"); void ion_device_add_heap(struct ion_heap *heap) { -- 2.20.1

2 1

[Bug 205589] New: Green screen crash with 3400G
by bugzilla-daemon＠bugzilla.kernel.org 10 Apr '20

10 Apr '20

https://bugzilla.kernel.org/show_bug.cgi?id=205589 Bug ID: 205589 Summary: Green screen crash with 3400G Product: Drivers Version: 2.5 Kernel Version: 5.x Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: pkk(a)spth.de Regression: No When I log into XFCE with a 5.x kernel on my AMD Ryzen 5 3400G-based system, the screen turns solid dark green; it stays that way until reboot. I see this issue on Debian GNU/Linux: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944420 Three others see the same issue on Manjaro: https://forum.manjaro.org/t/manjaro-with-ryzen-3-3200g-vega-8-any-experienc… https://forum.manjaro.org/t/kernel-question-amd-ryzen-5-2400g-with-radeon-v… Philipp -- You are receiving this mail because: You are watching the assignee of the bug.

1 6

[PATCH 1/2] drm/i915: remove unneeded ccflags-y from gvt/Makefile
by Masahiro Yamada 10 Apr '20

10 Apr '20

When CONFIG_DRM_I915_GVT=y, the same include path is added twice. drivers/gpu/drm/i915/Makefile specifies: subdir-ccflags-y += -I$(srctree)/$(src) drivers/gpu/drm/i915/gvt/Makefile adds the second '-I $(srctree)/$(src)', which is redundant. The include path '-I $(srctree)/$(src)/$(GVT_DIR)/' is added to allow include/trace/define_trace.h to find the gvt/trace.h By setting the correct relative path to TRACE_INCLUDE_PATH, this -I is also unneeded. Signed-off-by: Masahiro Yamada <masahiroy(a)kernel.org> --- drivers/gpu/drm/i915/gvt/Makefile | 1 - drivers/gpu/drm/i915/gvt/trace.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile index ea8324abc784..4d70f4689479 100644 --- a/drivers/gpu/drm/i915/gvt/Makefile +++ b/drivers/gpu/drm/i915/gvt/Makefile @@ -5,5 +5,4 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ execlist.o scheduler.o sched_policy.o mmio_context.o cmd_parser.o debugfs.o \ fb_decoder.o dmabuf.o page_track.o -ccflags-y += -I $(srctree)/$(src) -I $(srctree)/$(src)/$(GVT_DIR)/ i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) diff --git a/drivers/gpu/drm/i915/gvt/trace.h b/drivers/gpu/drm/i915/gvt/trace.h index 6d787750d279..d63b7eef6179 100644 --- a/drivers/gpu/drm/i915/gvt/trace.h +++ b/drivers/gpu/drm/i915/gvt/trace.h @@ -377,7 +377,7 @@ TRACE_EVENT(render_mmio, /* This part must be out of protection */ #undef TRACE_INCLUDE_PATH -#define TRACE_INCLUDE_PATH . +#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/i915/gvt #undef TRACE_INCLUDE_FILE #define TRACE_INCLUDE_FILE trace #include <trace/define_trace.h> -- 2.17.1

3 3

[PATCH] drm/ttm: Schedule out if possibe in bo delayed delete worker
by xinhui pan 10 Apr '20

10 Apr '20

The delayed delete list is per device which might be very huge. And in a heavy workload test, the list might always not be empty. That will trigger any RCU stall warnings or softlockups in non-preemptible kernels Lets do schedule out if possible in that case. Signed-off-by: xinhui pan <xinhui.pan(a)amd.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 9e07c3f75156..b8d853cab33b 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -541,6 +541,7 @@ static bool ttm_bo_delayed_delete(struct ttm_bo_device *bdev, bool remove_all) } ttm_bo_put(bo); + cond_resched(); spin_lock(&glob->lru_lock); } list_splice_tail(&removed, &bdev->ddestroy); -- 2.17.1

5 9

← Newer
1
...
75
76
77
78
79
80
81
...
95
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2020