dri-devel June 2020

dri-devel@lists.freedesktop.org

315 participants
731 discussions

[PATCH] drm: panel: simple: Drop drive/sample bus flags for LVDS panels
by Laurent Pinchart 29 Jun '20

29 Jun '20

The DRM bus flags reporting on which clock edge the pixel data and sync signals are sampled or driven don't make sense for LVDS panels, as the bus then uses sub-clock timings to send data. Drop those flags and add a warning in the probe function to make sure the mistake won't be repeated. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com> --- drivers/gpu/drm/panel/panel-simple.c | 30 +++++++++++++++++----------- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index bff1cab529d2..537d75ef7fc2 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -549,6 +549,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) panel_simple_parse_panel_timing_node(dev, panel, &dt); } + if (desc->connector_type == DRM_MODE_CONNECTOR_LVDS) + /* Catch common mistakes for LVDS panels. */ + WARN_ON(desc->bus_flags & + (DRM_BUS_FLAG_PIXDATA_POSEDGE | + DRM_BUS_FLAG_PIXDATA_NEGEDGE | + DRM_BUS_FLAG_SYNC_POSEDGE | + DRM_BUS_FLAG_SYNC_NEGEDGE)); + drm_panel_init(&panel->base, dev, &panel_simple_funcs, desc->connector_type); @@ -688,7 +696,7 @@ static const struct panel_desc auo_b101aw03 = { .height = 125, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -1398,7 +1406,7 @@ static const struct panel_desc chunghwa_claa070wp03xg = { .height = 150, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -1423,7 +1431,7 @@ static const struct panel_desc chunghwa_claa101wa01a = { .height = 120, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -1448,7 +1456,7 @@ static const struct panel_desc chunghwa_claa101wb01 = { .height = 125, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -2123,7 +2131,7 @@ static const struct panel_desc innolux_n156bge_l21 = { .height = 193, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -2256,7 +2264,7 @@ static const struct panel_desc koe_tx26d202vm0bwa = { .disable = 1000, }, .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -2497,9 +2505,7 @@ static const struct panel_desc logictechno_lt170410_2whc = { .height = 136, }, .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | - DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | - DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -3072,7 +3078,7 @@ static const struct panel_desc samsung_ltn101nt05 = { .height = 125, }, .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -3319,7 +3325,7 @@ static const struct panel_desc starry_kr070pe2t = { .height = 86, }, .bus_format = MEDIA_BUS_FMT_RGB888_1X24, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; @@ -3512,7 +3518,7 @@ static const struct panel_desc toshiba_lt089ac29000 = { .height = 116, }, .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, .connector_type = DRM_MODE_CONNECTOR_LVDS, }; -- Regards, Laurent Pinchart

4 4

[PATCH v2 0/6] Tegra DRM / Host1x drivers improvements and corrections
by Dmitry Osipenko 29 Jun '20

29 Jun '20

Hello! This small series fixes a few minor long-standing problems of the Tegra DRM and Host1x drivers. It also adds a push buffer dumping support, which is a minor debugging feature. Changelog: v2: - The drm/tegra and host1x patches got aggregated into this common series because I'm a bit worried that the standalone patches may become forgotten for a long time. - In the patch "gpu: host1x: debug: Dump push buffer state" I fixed the printk formatting problem on ARM64 that was reported by kernel test robot for a previous version of this patch. Dmitry Osipenko (6): drm/tegra: gr3d: Assert reset before power-gating drm/tegra: gr2d: Add tiled PATBASE address register gpu: host1x: Optimize BOs usage when firewall is enabled gpu: host1x: Put gather's BO on pinning error gpu: host1x: debug: Fix multiple channels emitting messages simultaneously gpu: host1x: debug: Dump push buffer state drivers/gpu/drm/tegra/gr2d.c | 1 + drivers/gpu/drm/tegra/gr2d.h | 1 + drivers/gpu/drm/tegra/gr3d.c | 2 ++ drivers/gpu/host1x/debug.c | 4 ++++ drivers/gpu/host1x/hw/debug_hw.c | 6 ++++++ drivers/gpu/host1x/job.c | 27 ++++++++++++++++++++------- 6 files changed, 34 insertions(+), 7 deletions(-) -- 2.26.0

1 6

[PATCH 1/2] drm/bridge: dw-hdmi: Don't cleanup i2c adapter and ddc ptr in __dw_hdmi_probe() bailout path
by Liu Ying 29 Jun '20

29 Jun '20

It's unnecessary to cleanup the i2c adapter and the ddc pointer in the bailout path of __dw_hdmi_probe(), since the adapter is not added and the ddc pointer is not set. Fixes: a23d6265f033 (drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function) Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Jonas Karlman <jonas(a)kwiboo.se> Cc: Jernej Skrabec <jernej.skrabec(a)siol.net> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Boris Brezillon <boris.brezillon(a)collabora.com> Cc: Jerome Brunet <jbrunet(a)baylibre.com> Cc: Cheng-Yi Chiang <cychiang(a)chromium.org> Cc: Dariusz Marcinkiewicz <darekm(a)google.com> Cc: Archit Taneja <architt(a)codeaurora.org> Cc: Jose Abreu <joabreu(a)synopsys.com> Cc: dri-devel(a)lists.freedesktop.org Cc: NXP Linux Team <linux-imx(a)nxp.com> Signed-off-by: Liu Ying <victor.liu(a)nxp.com> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 30681398c..da84a91 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -3358,11 +3358,6 @@ __dw_hdmi_probe(struct platform_device *pdev, return hdmi; err_iahb: - if (hdmi->i2c) { - i2c_del_adapter(&hdmi->i2c->adap); - hdmi->ddc = NULL; - } - clk_disable_unprepare(hdmi->iahb_clk); if (hdmi->cec_clk) clk_disable_unprepare(hdmi->cec_clk); -- 2.7.4

2 4

[GIT PULL] exynos-drm-fixes
by Inki Dae 29 Jun '20

29 Jun '20

Hi Dave, Just one cleanup and two fixups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit 687a0ed337367be5267652af5f6dbcfc954b8732: Merge tag 'drm-misc-fixes-2020-06-25' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2020-06-26 13:49:17 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-drm-fixes-for-v5.8-rc4 for you to fetch changes up to d4f5a095daf0d25f0b385e1ef26338608433a4c5: drm/exynos: fix ref count leak in mic_pre_enable (2020-06-29 09:38:41 +0900) ---------------------------------------------------------------- Two fixups - It fixes wrong return value by returing proper error value instead of fixed one. - It fixes ref count leak in mic_pre_enable. One cleanup - It removes dev_err() call on platform_get_irq() failure because platform_get_irq() call dev_err() itself on failure. ---------------------------------------------------------------- Marek Szyprowski (1): drm/exynos: Properly propagate return value in drm_iommu_attach_device() Navid Emamdoost (1): drm/exynos: fix ref count leak in mic_pre_enable Tamseel Shams (1): drm/exynos: Remove dev_err() on platform_get_irq() failure drivers/gpu/drm/exynos/exynos_drm_dma.c | 4 ++-- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++- 3 files changed, 5 insertions(+), 4 deletions(-)

1 0

linux-next: manual merge of the drm-misc tree with Linus' tree
by Stephen Rothwell 29 Jun '20

29 Jun '20

Hi all, Today's linux-next merge of the drm-misc tree got conflicts in: drivers/gpu/drm/nouveau/dispnv04/crtc.c drivers/gpu/drm/nouveau/dispnv04/overlay.c drivers/gpu/drm/nouveau/dispnv50/base507c.c drivers/gpu/drm/nouveau/dispnv50/wndw.c drivers/gpu/drm/nouveau/nouveau_dmem.c drivers/gpu/drm/nouveau/nouveau_fbcon.c between commits: 183405879255 ("drm/nouveau/kms: Remove field nvbo from struct nouveau_framebuffer") c586f30bf74c ("drm/nouveau/kms: Add format mod prop to base/ovly/nvdisp") 1d7f940c3a16 ("drm/nouveau/nouveau/hmm: fix nouveau_dmem_chunk allocations") from Linus' tree and commit: 0dc9b286b8d2 ("drm/nouveau: don't use ttm bo->offset v3") from the drm-misc tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/gpu/drm/nouveau/dispnv04/crtc.c index 640738f3196c,cc6ab3c2eec7..000000000000 --- a/drivers/gpu/drm/nouveau/dispnv04/crtc.c +++ b/drivers/gpu/drm/nouveau/dispnv04/crtc.c @@@ -840,12 -839,13 +840,12 @@@ nv04_crtc_do_mode_set_base(struct drm_c */ if (atomic) { drm_fb = passed_fb; - fb = nouveau_framebuffer(passed_fb); } else { drm_fb = crtc->primary->fb; - fb = nouveau_framebuffer(crtc->primary->fb); } - nv_crtc->fb.offset = fb->nvbo->offset; + nvbo = nouveau_gem_object(drm_fb->obj[0]); - nv_crtc->fb.offset = nvbo->bo.offset; ++ nv_crtc->fb.offset = nvbo->offset; if (nv_crtc->lut.depth != drm_fb->format->depth) { nv_crtc->lut.depth = drm_fb->format->depth; diff --cc drivers/gpu/drm/nouveau/dispnv04/overlay.c index 6248fd1dbc6d,9529bd9053e7..000000000000 --- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c +++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c @@@ -152,7 -150,7 +152,7 @@@ nv10_update_plane(struct drm_plane *pla nvif_mask(dev, NV_PCRTC_ENGINE_CTRL + soff2, NV_CRTC_FSEL_OVERLAY, 0); nvif_wr32(dev, NV_PVIDEO_BASE(flip), 0); - nvif_wr32(dev, NV_PVIDEO_OFFSET_BUFF(flip), nvbo->bo.offset); - nvif_wr32(dev, NV_PVIDEO_OFFSET_BUFF(flip), nv_fb->nvbo->offset); ++ nvif_wr32(dev, NV_PVIDEO_OFFSET_BUFF(flip), nvbo->offset); nvif_wr32(dev, NV_PVIDEO_SIZE_IN(flip), src_h << 16 | src_w); nvif_wr32(dev, NV_PVIDEO_POINT_IN(flip), src_y << 16 | src_x); nvif_wr32(dev, NV_PVIDEO_DS_DX(flip), (src_w << 20) / crtc_w); @@@ -174,7 -172,7 +174,7 @@@ if (format & NV_PVIDEO_FORMAT_PLANAR) { nvif_wr32(dev, NV_PVIDEO_UVPLANE_BASE(flip), 0); nvif_wr32(dev, NV_PVIDEO_UVPLANE_OFFSET_BUFF(flip), - nvbo->bo.offset + fb->offsets[1]); - nv_fb->nvbo->offset + fb->offsets[1]); ++ nvbo->offset + fb->offsets[1]); } nvif_wr32(dev, NV_PVIDEO_FORMAT(flip), format | fb->pitches[0]); nvif_wr32(dev, NV_PVIDEO_STOP, 0); @@@ -399,7 -396,7 +399,7 @@@ nv04_update_plane(struct drm_plane *pla for (i = 0; i < 2; i++) { nvif_wr32(dev, NV_PVIDEO_BUFF0_START_ADDRESS + 4 * i, - nvbo->bo.offset); - nv_fb->nvbo->offset); ++ nvbo->offset); nvif_wr32(dev, NV_PVIDEO_BUFF0_PITCH_LENGTH + 4 * i, fb->pitches[0]); nvif_wr32(dev, NV_PVIDEO_BUFF0_OFFSET + 4 * i, 0); diff --cc drivers/gpu/drm/nouveau/dispnv50/base507c.c index 511258bfbcbc,b60aa987d7b4..000000000000 --- a/drivers/gpu/drm/nouveau/dispnv50/base507c.c +++ b/drivers/gpu/drm/nouveau/dispnv50/base507c.c @@@ -274,9 -273,9 +274,9 @@@ base507c_new_(const struct nv50_wndw_fu if (*pwndw = wndw, ret) return ret; - ret = nv50_dmac_create(&drm->client.device, &disp->disp->object, + ret = nv50_dmac_create(&drm->client.device, &disp->disp.object, &oclass, head, &args, sizeof(args), - disp50->sync->bo.offset, &wndw->wndw); - disp->sync->offset, &wndw->wndw); ++ disp50->sync->offset, &wndw->wndw); if (ret) { NV_ERROR(drm, "base%04x allocation failed: %d\n", oclass, ret); return ret; diff --cc drivers/gpu/drm/nouveau/dispnv50/wndw.c index 99b9b681736d,ee0fd817185e..000000000000 --- a/drivers/gpu/drm/nouveau/dispnv50/wndw.c +++ b/drivers/gpu/drm/nouveau/dispnv50/wndw.c @@@ -521,12 -507,11 +521,12 @@@ nv50_wndw_prepare_fb(struct drm_plane * return PTR_ERR(ctxdma); } - asyw->image.handle[0] = ctxdma->object.handle; + if (asyw->visible) + asyw->image.handle[0] = ctxdma->object.handle; } - asyw->state.fence = dma_resv_get_excl_rcu(fb->nvbo->bo.base.resv); - asyw->image.offset[0] = fb->nvbo->offset; + asyw->state.fence = dma_resv_get_excl_rcu(nvbo->bo.base.resv); - asyw->image.offset[0] = nvbo->bo.offset; ++ asyw->image.offset[0] = nvbo->offset; if (wndw->func->prepare) { asyh = nv50_head_atom_get(asyw->state.state, asyw->state.crtc); diff --cc drivers/gpu/drm/nouveau/nouveau_dmem.c index e5c230d9ae24,f13086a32f0f..000000000000 --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c @@@ -75,32 -72,25 +75,32 @@@ struct nouveau_dmem_migrate struct nouveau_dmem { struct nouveau_drm *drm; - struct dev_pagemap pagemap; struct nouveau_dmem_migrate migrate; - struct list_head chunk_free; - struct list_head chunk_full; - struct list_head chunk_empty; + struct list_head chunks; struct mutex mutex; + struct page *free_pages; + spinlock_t lock; }; -static inline struct nouveau_dmem *page_to_dmem(struct page *page) +static struct nouveau_dmem_chunk *nouveau_page_to_chunk(struct page *page) { - return container_of(page->pgmap, struct nouveau_dmem, pagemap); + return container_of(page->pgmap, struct nouveau_dmem_chunk, pagemap); +} + +static struct nouveau_drm *page_to_drm(struct page *page) +{ + struct nouveau_dmem_chunk *chunk = nouveau_page_to_chunk(page); + + return chunk->drm; } -static unsigned long nouveau_dmem_page_addr(struct page *page) +unsigned long nouveau_dmem_page_addr(struct page *page) { - struct nouveau_dmem_chunk *chunk = page->zone_device_data; - unsigned long idx = page_to_pfn(page) - chunk->pfn_first; + struct nouveau_dmem_chunk *chunk = nouveau_page_to_chunk(page); + unsigned long off = (page_to_pfn(page) << PAGE_SHIFT) - + chunk->pagemap.res.start; - return chunk->bo->bo.offset + off; - return (idx << PAGE_SHIFT) + chunk->bo->offset; ++ return chunk->bo->offset + off; } static void nouveau_dmem_page_free(struct page *page) diff --cc drivers/gpu/drm/nouveau/nouveau_fbcon.c index 3d11b84d4cf9,1341c6fca3ed..000000000000 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@@ -393,7 -393,7 +393,7 @@@ nouveau_fbcon_create(struct drm_fb_help /* To allow resizeing without swapping buffers */ NV_INFO(drm, "allocated %dx%d fb: 0x%llx, bo %p\n", - fb->width, fb->height, nvbo->bo.offset, nvbo); - fb->base.width, fb->base.height, fb->nvbo->offset, nvbo); ++ fb->width, fb->height, nvbo->offset, nvbo); vga_switcheroo_client_fb_set(dev->pdev, info); return 0;

1 0

Re: [PATCH] fbtft-bus.c: Removing that prohibited space before ')'
by kernel test robot 29 Jun '20

29 Jun '20

Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v5.8-rc2 next-20200626] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/B-K-Karthik/fbtft-bus-c-Removing-t… base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 92cd1b5d65f5c67147c7da39a3c2ad7e6ff81027 config: ia64-randconfig-s031-20200624 (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-dirty # save the attached .config to linux build tree make W=1 C=1 ARCH=ia64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/staging/fbtft/fbtft-bus.c:65:1: sparse: sparse: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given drivers/staging/fbtft/fbtft-bus.c:67:1: sparse: sparse: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got void drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got ( >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got = >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'for' as identifier drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got < drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got ++ drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'do' as identifier drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got { drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got -> >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got < >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got -- drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got -> >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier >> drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Trying to use reserved word 'if' as identifier drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got : drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:66:1: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:69:1: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:69:1: sparse: sparse: got void drivers/staging/fbtft/fbtft-bus.c:76:13: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:76:13: sparse: sparse: got ( drivers/staging/fbtft/fbtft-bus.c:76:9: sparse: sparse: Trying to use reserved word 'if' as identifier drivers/staging/fbtft/fbtft-bus.c:78:24: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:78:24: sparse: sparse: got = drivers/staging/fbtft/fbtft-bus.c:78:17: sparse: sparse: Trying to use reserved word 'for' as identifier drivers/staging/fbtft/fbtft-bus.c:78:31: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:78:31: sparse: sparse: got < drivers/staging/fbtft/fbtft-bus.c:78:39: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:78:39: sparse: sparse: got ++ drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: got += drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:79:50: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: Trying to use reserved word 'do' as identifier drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: Expected ; at end of declaration drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: got { drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:81:17: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:84:9: sparse: sparse: Expected ; at the end of type declaration drivers/staging/fbtft/fbtft-bus.c:84:9: sparse: sparse: got } drivers/staging/fbtft/fbtft-bus.c:88:16: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:88:16: sparse: sparse: got -> drivers/staging/fbtft/fbtft-bus.c:88:9: sparse: sparse: Trying to use reserved word 'if' as identifier drivers/staging/fbtft/fbtft-bus.c:93:24: sparse: sparse: Expected ) in function declarator drivers/staging/fbtft/fbtft-bus.c:93:24: sparse: sparse: got = >> drivers/staging/fbtft/fbtft-bus.c:93:17: sparse: sparse: too many errors # https://github.com/0day-ci/linux/commit/f9a954fc5ae43b8fb5195dbb7152976581d… git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout f9a954fc5ae43b8fb5195dbb7152976581d80a1a vim +/define_fbtft_write_reg +65 drivers/staging/fbtft/fbtft-bus.c c296d5f9957c03 Thomas Petazzoni 2014-12-31 64 f9a954fc5ae43b B K Karthik 2020-06-27 @65 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8) 8d8825b420ffb3 Alfonso Lima Astor 2017-10-17 @66 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) f9a954fc5ae43b B K Karthik 2020-06-27 67 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16) c296d5f9957c03 Thomas Petazzoni 2014-12-31 68 c296d5f9957c03 Thomas Petazzoni 2014-12-31 69 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...) c296d5f9957c03 Thomas Petazzoni 2014-12-31 70 { c296d5f9957c03 Thomas Petazzoni 2014-12-31 71 va_list args; c296d5f9957c03 Thomas Petazzoni 2014-12-31 72 int i, ret; c296d5f9957c03 Thomas Petazzoni 2014-12-31 73 int pad = 0; c296d5f9957c03 Thomas Petazzoni 2014-12-31 74 u16 *buf = (u16 *)par->buf; c296d5f9957c03 Thomas Petazzoni 2014-12-31 75 c296d5f9957c03 Thomas Petazzoni 2014-12-31 76 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { c296d5f9957c03 Thomas Petazzoni 2014-12-31 77 va_start(args, len); c296d5f9957c03 Thomas Petazzoni 2014-12-31 78 for (i = 0; i < len; i++) c296d5f9957c03 Thomas Petazzoni 2014-12-31 79 *(((u8 *)buf) + i) = (u8)va_arg(args, unsigned int); c296d5f9957c03 Thomas Petazzoni 2014-12-31 80 va_end(args); c296d5f9957c03 Thomas Petazzoni 2014-12-31 @81 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, 333c7b940526be Leonardo Brás 2018-08-07 82 par->info->device, u8, buf, len, "%s: ", 333c7b940526be Leonardo Brás 2018-08-07 83 __func__); c296d5f9957c03 Thomas Petazzoni 2014-12-31 84 } c296d5f9957c03 Thomas Petazzoni 2014-12-31 85 if (len <= 0) c296d5f9957c03 Thomas Petazzoni 2014-12-31 86 return; c296d5f9957c03 Thomas Petazzoni 2014-12-31 87 c296d5f9957c03 Thomas Petazzoni 2014-12-31 88 if (par->spi && (par->spi->bits_per_word == 8)) { c296d5f9957c03 Thomas Petazzoni 2014-12-31 89 /* we're emulating 9-bit, pad start of buffer with no-ops b2ac4a927034d0 Anson Jacob 2016-08-25 90 * (assuming here that zero is a no-op) b2ac4a927034d0 Anson Jacob 2016-08-25 91 */ c296d5f9957c03 Thomas Petazzoni 2014-12-31 92 pad = (len % 4) ? 4 - (len % 4) : 0; c296d5f9957c03 Thomas Petazzoni 2014-12-31 @93 for (i = 0; i < pad; i++) c296d5f9957c03 Thomas Petazzoni 2014-12-31 94 *buf++ = 0x000; c296d5f9957c03 Thomas Petazzoni 2014-12-31 95 } c296d5f9957c03 Thomas Petazzoni 2014-12-31 96 c296d5f9957c03 Thomas Petazzoni 2014-12-31 97 va_start(args, len); c296d5f9957c03 Thomas Petazzoni 2014-12-31 98 *buf++ = (u8)va_arg(args, unsigned int); c296d5f9957c03 Thomas Petazzoni 2014-12-31 99 i = len - 1; c296d5f9957c03 Thomas Petazzoni 2014-12-31 100 while (i--) { c296d5f9957c03 Thomas Petazzoni 2014-12-31 101 *buf = (u8)va_arg(args, unsigned int); c296d5f9957c03 Thomas Petazzoni 2014-12-31 102 *buf++ |= 0x100; /* dc=1 */ c296d5f9957c03 Thomas Petazzoni 2014-12-31 103 } c296d5f9957c03 Thomas Petazzoni 2014-12-31 104 va_end(args); c296d5f9957c03 Thomas Petazzoni 2014-12-31 105 ret = par->fbtftops.write(par, par->buf, (len + pad) * sizeof(u16)); c296d5f9957c03 Thomas Petazzoni 2014-12-31 106 if (ret < 0) { c296d5f9957c03 Thomas Petazzoni 2014-12-31 107 dev_err(par->info->device, aed1c72e447f0a Haneen Mohammed 2015-03-06 108 "write() failed and returned %d\n", ret); c296d5f9957c03 Thomas Petazzoni 2014-12-31 109 return; c296d5f9957c03 Thomas Petazzoni 2014-12-31 110 } c296d5f9957c03 Thomas Petazzoni 2014-12-31 111 } c296d5f9957c03 Thomas Petazzoni 2014-12-31 112 EXPORT_SYMBOL(fbtft_write_reg8_bus9); c296d5f9957c03 Thomas Petazzoni 2014-12-31 113 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ kbuild mailing list -- kbuild(a)lists.01.org To unsubscribe send an email to kbuild-leave(a)lists.01.org

1 0

[RFC PATCH 0/4] DirectX on Linux
by Sasha Levin 28 Jun '20

28 Jun '20

There is a blog post that goes into more detail about the bigger picture, and walks through all the required pieces to make this work. It is available here: https://devblogs.microsoft.com/directx/directx-heart-linux . The rest of this cover letter will focus on the Linux Kernel bits. Overview ======== This is the first draft of the Microsoft Virtual GPU (vGPU) driver. The driver exposes a paravirtualized GPU to user mode applications running in a virtual machine on a Windows host. This enables hardware acceleration in environment such as WSL (Windows Subsystem for Linux) where the Linux virtual machine is able to share the GPU with the Windows host. The projection is accomplished by exposing the WDDM (Windows Display Driver Model) interface as a set of IOCTL. This allows APIs and user mode driver written against the WDDM GPU abstraction on Windows to be ported to run within a Linux environment. This enables the port of the D3D12 and DirectML APIs as well as their associated user mode driver to Linux. This also enables third party APIs, such as the popular NVIDIA Cuda compute API, to be hardware accelerated within a WSL environment. Only the rendering/compute aspect of the GPU are projected to the virtual machine, no display functionality is exposed. Further, at this time there are no presentation integration. So although the D3D12 API can be use to render graphics offscreen, there is no path (yet) for pixel to flow from the Linux environment back onto the Windows host desktop. This GPU stack is effectively side-by-side with the native Linux graphics stack. The driver creates the /dev/dxg device, which can be opened by user mode application and handles their ioctls. The IOCTL interface to the driver is defined in dxgkmthk.h (Dxgkrnl Graphics Port Driver ioctl definitions). The interface matches the D3DKMT interface on Windows. Ioctls are implemented in ioctl.c. When a VM starts, hyper-v on the host adds virtual GPU devices to the VM via the hyper-v driver. The host offers several VM bus channels to the VM: the global channel and one channel per virtual GPU, assigned to the VM. The driver registers with the hyper-v driver (hv_driver) for the arrival of VM bus channels. dxg_probe_device recognizes the vGPU channels and creates the corresponding objects (dxgadapter for vGPUs and dxgglobal for the global channel). The driver uses the hyper-V VM bus interface to communicate with the host. dxgvmbus.c implements the communication interface. The global channel has 8GB of IO space assigned by the host. This space is managed by the host and used to give the guest direct CPU access to some allocations. Video memory is allocated on the host except in the case of existing_sysmem allocations. The Windows host allocates memory for the GPU on behalf of the guest. The Linux guest can access that memory by mapping GPU virtual address to allocations and then referencing those GPU virtual address from within GPU command buffers submitted to the GPU. For allocations which require CPU access, the allocation is mapped by the host into a location in the 8GB of IO space reserved in the guest for that purpose. The Windows host uses the nested CPU page table to ensure that this guest IO space always map to the correct location for the allocation as it may migrate between dedicated GPU memory (e.g. VRAM, firmware reserved DDR) and shared system memory (regular DDR) over its lifetime. The Linux guest maps a user mode CPU virtual address to an allocation IO space range for direct access by user mode APIs and drivers. Implementation of LX_DXLOCK2 ioctl ================================== We would appreciate your feedback on the implementation of the LX_DXLOCK2 ioctl. This ioctl is used to get a CPU address to an allocation, which is resident in video/system memory on the host. The way it works: 1. The driver sends the Lock message to the host 2. The host allocates space in the VM IO space and maps it to the allocation memory 3. The host returns the address in IO space for the mapped allocation 4. The driver (in dxg_map_iospace) allocates a user mode virtual address range using vm_mmap and maps it to the IO space using io_remap_ofn_range) 5. The VA is returned to the application Internal objects ================ The following objects are created by the driver (defined in dxgkrnl.h): - dxgadapter - represents a virtual GPU - dxgprocess - tracks per process state (handle table of created objects, list of objects, etc.) - dxgdevice - a container for other objects (contexts, paging queues, allocations, GPU synchronization objects) - dxgcontext - represents thread of GPU execution for packet scheduling. - dxghwqueue - represents thread of GPU execution of hardware scheduling - dxgallocation - represents a GPU accessible allocation - dxgsyncobject - represents a GPU synchronization object - dxgresource - collection of dxgalloction objects - dxgsharedresource, dxgsharedsyncobj - helper objects to share objects between different dxgdevice objects, which can belong to different processes Object handles ============== All GPU objects, created by the driver, are accessible by a handle (d3dkmt_handle). Each process has its own handle table, which is implemented in hmgr.c. For each API visible object, created by the driver, there is an object, created on the host. For example, the is a dxgprocess object on the host for each dxgprocess object in the VM, etc. The object handles have the same value in the host and the VM, which is done to avoid translation from the guest handles to the host handles. Signaling CPU events by the host ================================ The WDDM interface provides a way to signal CPU event objects when execution of a context reached certain point. The way it is implemented: - application sends an event_fd via ioctl to the driver - eventfd_ctx_get is used to get a pointer to the file object (eventfd_ctx) - the pointer to sent the host via a VM bus message - when GPU execution reaches a certain point, the host sends a message to the VM with the event pointer - signal_guest_event() handles the messages and eventually eventfd_signal() is called. Sasha Levin (4): gpu: dxgkrnl: core code gpu: dxgkrnl: hook up dxgkrnl Drivers: hv: vmbus: hook up dxgkrnl gpu: dxgkrnl: create a MAINTAINERS entry MAINTAINERS | 7 + drivers/gpu/Makefile | 2 +- drivers/gpu/dxgkrnl/Kconfig | 10 + drivers/gpu/dxgkrnl/Makefile | 12 + drivers/gpu/dxgkrnl/d3dkmthk.h | 1635 +++++++++ drivers/gpu/dxgkrnl/dxgadapter.c | 1399 ++++++++ drivers/gpu/dxgkrnl/dxgkrnl.h | 913 ++++++ drivers/gpu/dxgkrnl/dxgmodule.c | 692 ++++ drivers/gpu/dxgkrnl/dxgprocess.c | 355 ++ drivers/gpu/dxgkrnl/dxgvmbus.c | 2955 +++++++++++++++++ drivers/gpu/dxgkrnl/dxgvmbus.h | 859 +++++ drivers/gpu/dxgkrnl/hmgr.c | 593 ++++ drivers/gpu/dxgkrnl/hmgr.h | 107 + drivers/gpu/dxgkrnl/ioctl.c | 5269 ++++++++++++++++++++++++++++++ drivers/gpu/dxgkrnl/misc.c | 280 ++ drivers/gpu/dxgkrnl/misc.h | 288 ++ drivers/video/Kconfig | 2 + include/linux/hyperv.h | 16 + 18 files changed, 15393 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/dxgkrnl/Kconfig create mode 100644 drivers/gpu/dxgkrnl/Makefile create mode 100644 drivers/gpu/dxgkrnl/d3dkmthk.h create mode 100644 drivers/gpu/dxgkrnl/dxgadapter.c create mode 100644 drivers/gpu/dxgkrnl/dxgkrnl.h create mode 100644 drivers/gpu/dxgkrnl/dxgmodule.c create mode 100644 drivers/gpu/dxgkrnl/dxgprocess.c create mode 100644 drivers/gpu/dxgkrnl/dxgvmbus.c create mode 100644 drivers/gpu/dxgkrnl/dxgvmbus.h create mode 100644 drivers/gpu/dxgkrnl/hmgr.c create mode 100644 drivers/gpu/dxgkrnl/hmgr.h create mode 100644 drivers/gpu/dxgkrnl/ioctl.c create mode 100644 drivers/gpu/dxgkrnl/misc.c create mode 100644 drivers/gpu/dxgkrnl/misc.h -- 2.25.1

10 30

[RFC PATCH 0/2] DRM driver for hyper-v synthetic video device
by Deepak Rawat 28 Jun '20

28 Jun '20

Hi All, First draft of DRM driver for hyper-v synthetic video device. This synthetic device is already supported by hyper-v and a corresponding framebuffer driver exist at drivers/video/fbdev/hyperv_fb.c. With this patch, just reworked the framebuffer driver into DRM, in doing so got mode-setting support. The code is similar to cirrus DRM driver, using simple display pipe and shmem backed GEM objects. The device support more features like hardware cursor, EDID, multiple dirty regions, etc, which were not supported with framebuffer driver. The plan is to add support for those in future iteration. Wanted to get initial feedback and discuss cursor support with simple kms helper. Is there any value to add cursor support to drm_simple_kms_helper.c so that others can use it, or should I just add cursor plane as device private? I believe we can still keep this driver in drm/tiny? For testing, ran GNOME and Weston with current changes in a Linux VM on Windows 10 with hyper-v enabled. Thanks, Deepak Deepak Rawat (2): drm/hyperv: Add DRM driver for hyperv synthetic video device MAINTAINERS: Add maintainer for hyperv video device MAINTAINERS | 8 + drivers/gpu/drm/tiny/Kconfig | 9 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/hyperv_drm.c | 1007 +++++++++++++++++++++++++++++ 4 files changed, 1025 insertions(+) create mode 100644 drivers/gpu/drm/tiny/hyperv_drm.c -- 2.27.0

6 16

[PATCH v2] drm/mediatek: remove unnecessary conversion to bool
by Bernard Zhao 28 Jun '20

28 Jun '20

In function mtk_dsi_clk_hs_state, remove unnecessary conversion to bool return, this change is to make the code a bit readable. Signed-off-by: Bernard Zhao <bernard(a)vivo.com> --- Changes since V1: *optimize to make the code a bit more clear. Link for V1: *https://lore.kernel.org/patchwork/patch/1255327/ --- drivers/gpu/drm/mediatek/mtk_dsi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 4491e64b3f06..840cc9b9efc8 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -316,10 +316,7 @@ static void mtk_dsi_lane0_ulp_mode_leave(struct mtk_dsi *dsi) static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi) { - u32 tmp_reg1; - - tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON); - return ((tmp_reg1 & LC_HS_TX_EN) == 1); + return (readl(dsi->regs + DSI_PHY_LCCON) & LC_HS_TX_EN); } static void mtk_dsi_clk_hs_mode(struct mtk_dsi *dsi, bool enter) -- 2.17.1

2 1

Kernel issues with Radeon Pro WX4100 and DP->HDMI dongles
by Maxim Levitsky 28 Jun '20

28 Jun '20

Hi, I recently tried to connect my TV and WX4100 via two different DP->HDMI dongles. One of them makes my main monitor to go dark, and system to lockup (I haven't yet debugged this futher), and the other one seems to work, most of the time, but sometimes causes a kernel panic on 5.8.0-rc1: [ +0.000000] ---[ end trace 0ce8685fac3db6b5 ]--- [ +2.142125] [drm:dc_link_detect_helper [amdgpu]] *ERROR* No EDID read. [ +0.065348] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.001002] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.006310] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.102119] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.000679] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +22.037707] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +16.202833] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.000685] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.053875] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.000351] [drm] amdgpu_dm_irq_schedule_work FAILED src 8 [ +0.031764] ------------[ cut here ]------------ [ +0.000001] WARNING: CPU: 58 PID: 504 at drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/gpio_base.c:66 dal_gpio_open_ex+0x1b/0x40 [amdgpu] [ +0.000001] Modules linked in: vfio_pci vfio_virqfd vfio_iommu_type1 vfio xfs rfcomm xt_MASQUERADE xt_conntrack ipt_REJECT iptable_mangle iptable_nat nf_nat ebtable_filter ebtables ip6table_filter ip6_tables tun bridge pmbus cmac pmbus_core ee1004 jc42 bnep sunrpc vfat fat dm_mirror dm_region_hash dm_log iwlmvm wmi_bmof mac80211 kvm_amd kvm libarc4 uvcvideo iwlwifi btusb btrtl btbcm btintel videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 snd_hda_codec_hdmi videobuf2_common snd_usb_audio bluetooth videodev input_leds snd_hda_intel cfg80211 snd_usbmidi_lib joydev snd_intel_dspcfg snd_rawmidi mc snd_hda_codec xpad ff_memless snd_hwdep thunderbolt ecdh_generic snd_seq ecc snd_hda_core irqbypass rfkill i2c_nvidia_gpu efi_pstore pcspkr snd_seq_device bfq snd_pcm snd_timer zenpower snd i2c_piix4 rtc_cmos tpm_crb tpm_tis tpm_tis_core tpm wmi button binfmt_misc dm_crypt sd_mod uas usb_storage hid_generic usbhid hid ext4 mbcache jbd2 amdgpu gpu_sched ttm drm_kms_helper syscopyarea sysfillrect [ +0.000018] sysimgblt crc32_pclmul ahci crc32c_intel fb_sys_fops libahci igb ccp cec xhci_pci libata i2c_algo_bit rng_core nvme xhci_hcd drm nvme_core t10_pi nbd usbmon it87 hwmon_vid fuse i2c_dev i2c_core ipv6 autofs4 [last unloaded: nvidia] [ +0.000005] CPU: 58 PID: 504 Comm: kworker/58:1 Tainted: P W O 5.8.0-rc1.stable #118 [ +0.000001] Hardware name: Gigabyte Technology Co., Ltd. TRX40 DESIGNARE/TRX40 DESIGNARE, BIOS F4c 03/05/2020 [ +0.000000] Workqueue: events dm_irq_work_func [amdgpu] [ +0.000001] RIP: 0010:dal_gpio_open_ex+0x1b/0x40 [amdgpu] [ +0.000001] Code: 08 89 47 10 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 83 7f 08 00 75 0f 48 83 7f 18 00 74 15 89 77 20 e9 65 07 00 00 <0f> 0b e8 ae 5b 8a e0 b8 05 00 00 00 c3 0f 0b e8 a1 5b 8a e0 b8 06 [ +0.000000] RSP: 0018:ffffc90002e93b90 EFLAGS: 00010282 [ +0.000001] RAX: 0000000000000000 RBX: ffff889fa4736ca0 RCX: 0000000000000000 [ +0.000000] RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffff889fa011ff00 [ +0.000001] RBP: 0000000000000003 R08: 0000000000000001 R09: 0000000000000231 [ +0.000000] R10: 000000000000017f R11: ffff889fbeea4b84 R12: ffffc90002e93c74 [ +0.000000] R13: 0000000000000000 R14: ffff889fa4736ca0 R15: ffff889fb0e2c100 [ +0.000001] FS: 0000000000000000(0000) GS:ffff889fbee80000(0000) knlGS:0000000000000000 [ +0.000000] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.000001] CR2: 00001ee62a52b000 CR3: 000000174d175000 CR4: 0000000000340ea0 [ +0.000000] Call Trace: [ +0.000000] dal_ddc_open+0x2d/0xe0 [amdgpu] [ +0.000001] ? dm_read_reg_func+0x33/0xa0 [amdgpu] [ +0.000000] dce_aux_transfer_raw+0xb4/0xa30 [amdgpu] [ +0.000000] ? hrtimer_try_to_cancel+0x28/0x100 [ +0.000001] dm_dp_aux_transfer+0x8f/0xf0 [amdgpu] [ +0.000000] drm_dp_dpcd_access+0x6b/0x110 [drm_kms_helper] [ +0.000000] drm_dp_dpcd_read+0xb6/0xf0 [drm_kms_helper] [ +0.000001] dm_helpers_dp_read_dpcd+0x28/0x50 [amdgpu] [ +0.000000] core_link_read_dpcd.part.0+0x1f/0x30 [amdgpu] [ +0.000000] read_hpd_rx_irq_data+0x39/0x90 [amdgpu] [ +0.000001] dc_link_handle_hpd_rx_irq+0x74/0x7c0 [amdgpu] [ +0.000000] handle_hpd_rx_irq+0x62/0x2e0 [amdgpu] [ +0.000000] ? __schedule+0x252/0x6a0 [ +0.000001] ? finish_task_switch+0x18d/0x280 [ +0.000000] dm_irq_work_func+0x43/0x50 [amdgpu] [ +0.000000] process_one_work+0x1d2/0x390 [ +0.000000] worker_thread+0x225/0x3b0 [ +0.000001] ? process_one_work+0x390/0x390 [ +0.000000] kthread+0xf9/0x130 [ +0.000000] ? kthread_park+0x90/0x90 [ +0.000001] ret_from_fork+0x1f/0x30 [ +0.000000] ---[ end trace 0ce8685fac3db6b6 ]--- [ +0.002807] int3: 0000 [#1] SMP [ +0.000001] CPU: 58 PID: 504 Comm: kworker/58:1 Tainted: P W O 5.8.0-rc1.stable #118 [ +0.000001] Hardware name: Gigabyte Technology Co., Ltd. TRX40 DESIGNARE/TRX40 DESIGNARE, BIOS F4c 03/05/2020 [ +0.000000] Workqueue: events dm_irq_work_func [amdgpu] [ +0.000001] RIP: 0010:kgdb_breakpoint+0x10/0x20 [ +0.000001] Code: 4d f9 ff eb c5 cc cc cc cc cc 0f 1f 44 00 00 31 c0 c3 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 f0 ff 05 3c be 3e 01 0f ae f8 cc <0f> ae f8 f0 ff 0d 2e be 3e 01 c3 0f 1f 44 00 00 0f 1f 44 00 00 e8 [ +0.000000] RSP: 0018:ffffc90002e93b88 EFLAGS: 00000202 [ +0.000001] RAX: 0000000000000000 RBX: ffff889fa4736ca0 RCX: 0000000000000000 [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffff889fa011ff00 [ +0.000000] RBP: 0000000000000003 R08: 0000000000000001 R09: 0000000000000231 [ +0.000001] R10: 000000000000017f R11: ffff889fbeea4b84 R12: ffffc90002e93c74 [ +0.000000] R13: 0000000000000000 R14: ffff889fa4736ca0 R15: ffff889fb0e2c100 [ +0.000001] FS: 0000000000000000(0000) GS:ffff889fbee80000(0000) knlGS:0000000000000000 [ +0.000000] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.000001] CR2: 00001ee62a52b000 CR3: 000000174d175000 CR4: 0000000000340ea0 [ +0.000000] Call Trace: [ +0.000001] dal_gpio_open_ex+0x22/0x40 [amdgpu] [ +0.000000] dal_ddc_open+0x2d/0xe0 [amdgpu] [ +0.000000] ? dm_read_reg_func+0x33/0xa0 [amdgpu] [ +0.000001] dce_aux_transfer_raw+0xb4/0xa30 [amdgpu] [ +0.000000] ? hrtimer_try_to_cancel+0x28/0x100 [ +0.000000] dm_dp_aux_transfer+0x8f/0xf0 [amdgpu] [ +0.000001] drm_dp_dpcd_access+0x6b/0x110 [drm_kms_helper] [ +0.000000] drm_dp_dpcd_read+0xb6/0xf0 [drm_kms_helper] [ +0.000000] dm_helpers_dp_read_dpcd+0x28/0x50 [amdgpu] [ +0.000001] core_link_read_dpcd.part.0+0x1f/0x30 [amdgpu] [ +0.000000] read_hpd_rx_irq_data+0x39/0x90 [amdgpu] [ +0.000000] dc_link_handle_hpd_rx_irq+0x74/0x7c0 [amdgpu] [ +0.000001] handle_hpd_rx_irq+0x62/0x2e0 [amdgpu] [ +0.000000] ? __schedule+0x252/0x6a0 [ +0.000000] ? finish_task_switch+0x18d/0x280 [ +0.000001] dm_irq_work_func+0x43/0x50 [amdgpu] [ +0.000000] process_one_work+0x1d2/0x390 [ +0.000000] worker_thread+0x225/0x3b0 [ +0.000001] ? process_one_work+0x390/0x390 [ +0.000000] kthread+0xf9/0x130 [ +0.000000] ? kthread_park+0x90/0x90 [ +0.000001] ret_from_fork+0x1f/0x30 [ +0.000000] Modules linked in: vfio_pci vfio_virqfd vfio_iommu_type1 vfio xfs rfcomm xt_MASQUERADE xt_conntrack ipt_REJECT iptable_mangle iptable_nat nf_nat ebtable_filter ebtables ip6table_filter ip6_tables tun bridge pmbus cmac pmbus_core ee1004 jc42 bnep sunrpc vfat fat dm_mirror dm_region_hash dm_log iwlmvm wmi_bmof mac80211 kvm_amd kvm libarc4 uvcvideo iwlwifi btusb btrtl btbcm btintel videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 snd_hda_codec_hdmi videobuf2_common snd_usb_audio bluetooth videodev input_leds snd_hda_intel cfg80211 snd_usbmidi_lib joydev snd_intel_dspcfg snd_rawmidi mc snd_hda_codec xpad ff_memless snd_hwdep thunderbolt ecdh_generic snd_seq ecc snd_hda_core irqbypass rfkill i2c_nvidia_gpu efi_pstore pcspkr snd_seq_device bfq snd_pcm snd_timer zenpower snd i2c_piix4 rtc_cmos tpm_crb tpm_tis tpm_tis_core tpm wmi button binfmt_misc dm_crypt sd_mod uas usb_storage hid_generic usbhid hid ext4 mbcache jbd2 amdgpu gpu_sched ttm drm_kms_helper syscopyarea sysfillrect [ +0.000018] sysimgblt crc32_pclmul ahci crc32c_intel fb_sys_fops libahci igb ccp cec xhci_pci libata i2c_algo_bit rng_core nvme xhci_hcd drm nvme_core t10_pi nbd usbmon it87 hwmon_vid fuse i2c_dev i2c_core ipv6 autofs4 [last unloaded: nvidia] [ +0.021468] ---[ end trace 0ce8685fac3db6b7 ]--- [ +0.000000] RIP: 0010:kgdb_breakpoint+0x10/0x20 [ +0.000001] Code: 4d f9 ff eb c5 cc cc cc cc cc 0f 1f 44 00 00 31 c0 c3 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 f0 ff 05 3c be 3e 01 0f ae f8 cc <0f> ae f8 f0 ff 0d 2e be 3e 01 c3 0f 1f 44 00 00 0f 1f 44 00 00 e8 [ +0.000000] RSP: 0018:ffffc90002e93b88 EFLAGS: 00000202 [ +0.000001] RAX: 0000000000000000 RBX: ffff889fa4736ca0 RCX: 0000000000000000 [ +0.000001] RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffff889fa011ff00 [ +0.000000] RBP: 0000000000000003 R08: 0000000000000001 R09: 0000000000000231 [ +0.000001] R10: 000000000000017f R11: ffff889fbeea4b84 R12: ffffc90002e93c74 [ +0.000000] R13: 0000000000000000 R14: ffff889fa4736ca0 R15: ffff889fb0e2c100 [ +0.000001] FS: 0000000000000000(0000) GS:ffff889fbee80000(0000) knlGS:0000000000000000 [ +0.000000] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.000000] CR2: 00001ee62a52b000 CR3: 000000174d175000 CR4: 0000000000340ea0 [ +0.000001] Kernel panic - not syncing: Fatal exception in interrupt [ +0.001035] Kernel Offset: disabled The 'amdgpu_dm_irq_schedule_work FAILED src 8' errors were from previous plugs of this adapter. On 5.7-rc7 kernel I also tried booting, I also see the 'amdgpu_dm_irq_schedule_work FAILED' errors but it seems for now that the crash doesn't happen, but it might have beeing luck. On top of all this, I tried a 3rd dongle and it does appear to work flawlessly (no messages in dmesg). Best regards, Maxim Levitsky

1 1

← Newer
1
...
25
26
27
28
29
30
31
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2020