dri-devel November 2021

dri-devel@lists.freedesktop.org

340 participants
748 discussions

[PATCH v2 00/15] DRM fbconv helpers for converting fbdev drivers
by Thomas Zimmermann 30 May '22

30 May '22

(was: DRM driver for fbdev devices) This is version 2 of the fbdev conversion helpers. It's more or less a rewrite of the original patchset. The fbdev subsystem is considered legacy and will probably be removed at some point. This would mean the loss of a signifanct number of drivers. Some of the affected hardware is not in use any longer, but some hardware is still around and provides good(-enough) framebuffers. The fbconv helpers allow for running the current DRM stack on top of fbdev drivers. It's a set of functions that convert between fbdev interfaces and DRM interfaces. Based on SHMEM and simple KMS helpers, it only offers the basic functionality of a framebuffer, but should be compatible with most existing fbdev drivers. A DRM driver using fbconv helpers consists of * DRM stub code that calls into fbconv helpers, and * the original fbdev driver code. The fbdev driver code has to be modified to register itself with the stub driver instead of the fbdev core framework. A tutorial on how to use the helpers is part of this patchset. The resulting driver hybrid can be refactored into a first-class DRM driver. The fbconv helpers contain a number of comments, labeled 'DRM porting note', which explain the required steps. I tested the current patchset with the following drivers: atyfb, aty128fb, matroxfb, pm2fb, pm3fb, rivafb, s3fb, savagefb, sisfb, tdfxfb and tridentfb. With each, I was able to successfully start with fbcon enabled, run weston and X11. The drivers are available at [1]. For reference, the patchset includes the Matrox stub driver. v2: * rename to fbconv helpers * rewrite as helper library * switch over to simple KMS helpers * switch over to SHMEM * add documentation [1] https://gitlab.freedesktop.org/tzimmermann/linux/commits/fbconv-plus-drivers Thomas Zimmermann (15): fbdev: Export fb_check_foreignness() fbdev: Export FBPIXMAPSIZE drm/simple-kms-helper: Add mode_fixup() to simple display pipe drm: Add fbconv helper module drm/fbconv: Add DRM <-> fbdev pixel-format conversion drm/fbconv: Add mode conversion DRM <-> fbdev drm/fbconv: Add modesetting infrastructure drm/fbconv: Add plane-state check and update drm/fbconv: Mode-setting pipeline enable / disable drm/fbconv: Reimplement several fbdev interfaces drm/fbconv: Add helpers for init and cleanup of fb_info structures drm/fbconv: Add helper documentation staging: Add mgakms driver staging/mgakms: Import matroxfb driver source code staging/mgakms: Update matroxfb driver code for DRM Documentation/gpu/drm-kms-helpers.rst | 12 + Documentation/gpu/todo.rst | 15 + drivers/gpu/drm/Kconfig | 11 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_fbconv_helper.c | 2126 +++++++++++++++++ drivers/gpu/drm/drm_simple_kms_helper.c | 15 + drivers/staging/Kconfig | 2 + drivers/staging/Makefile | 1 + drivers/staging/mgakms/Kconfig | 18 + drivers/staging/mgakms/Makefile | 17 + drivers/staging/mgakms/g450_pll.c | 539 +++++ drivers/staging/mgakms/g450_pll.h | 13 + drivers/staging/mgakms/i2c-matroxfb.c | 238 ++ drivers/staging/mgakms/matroxfb_DAC1064.c | 1082 +++++++++ drivers/staging/mgakms/matroxfb_DAC1064.h | 174 ++ drivers/staging/mgakms/matroxfb_Ti3026.c | 746 ++++++ drivers/staging/mgakms/matroxfb_Ti3026.h | 10 + drivers/staging/mgakms/matroxfb_accel.c | 519 +++++ drivers/staging/mgakms/matroxfb_accel.h | 9 + drivers/staging/mgakms/matroxfb_base.c | 2592 +++++++++++++++++++++ drivers/staging/mgakms/matroxfb_base.h | 700 ++++++ drivers/staging/mgakms/matroxfb_crtc2.h | 35 + drivers/staging/mgakms/matroxfb_g450.c | 640 +++++ drivers/staging/mgakms/matroxfb_g450.h | 10 + drivers/staging/mgakms/matroxfb_maven.h | 21 + drivers/staging/mgakms/matroxfb_misc.c | 815 +++++++ drivers/staging/mgakms/matroxfb_misc.h | 22 + drivers/staging/mgakms/mga_device.c | 68 + drivers/staging/mgakms/mga_device.h | 30 + drivers/staging/mgakms/mga_drv.c | 129 + drivers/staging/mgakms/mga_drv.h | 14 + drivers/video/fbdev/core/fbmem.c | 5 +- include/drm/drm_fbconv_helper.h | 150 ++ include/drm/drm_simple_kms_helper.h | 43 + include/linux/fb.h | 3 + 35 files changed, 10822 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/drm_fbconv_helper.c create mode 100644 drivers/staging/mgakms/Kconfig create mode 100644 drivers/staging/mgakms/Makefile create mode 100644 drivers/staging/mgakms/g450_pll.c create mode 100644 drivers/staging/mgakms/g450_pll.h create mode 100644 drivers/staging/mgakms/i2c-matroxfb.c create mode 100644 drivers/staging/mgakms/matroxfb_DAC1064.c create mode 100644 drivers/staging/mgakms/matroxfb_DAC1064.h create mode 100644 drivers/staging/mgakms/matroxfb_Ti3026.c create mode 100644 drivers/staging/mgakms/matroxfb_Ti3026.h create mode 100644 drivers/staging/mgakms/matroxfb_accel.c create mode 100644 drivers/staging/mgakms/matroxfb_accel.h create mode 100644 drivers/staging/mgakms/matroxfb_base.c create mode 100644 drivers/staging/mgakms/matroxfb_base.h create mode 100644 drivers/staging/mgakms/matroxfb_crtc2.h create mode 100644 drivers/staging/mgakms/matroxfb_g450.c create mode 100644 drivers/staging/mgakms/matroxfb_g450.h create mode 100644 drivers/staging/mgakms/matroxfb_maven.h create mode 100644 drivers/staging/mgakms/matroxfb_misc.c create mode 100644 drivers/staging/mgakms/matroxfb_misc.h create mode 100644 drivers/staging/mgakms/mga_device.c create mode 100644 drivers/staging/mgakms/mga_device.h create mode 100644 drivers/staging/mgakms/mga_drv.c create mode 100644 drivers/staging/mgakms/mga_drv.h create mode 100644 include/drm/drm_fbconv_helper.h -- 2.23.0

8 35

[Regression] No framebuffer console on Rpi since 5.14-rc1
by Stefan Wahren 20 May '22

20 May '22

Hi guys, starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 (no U-Boot, multi_v7_defconfig) isn't available anymore. The display shows the rainbow screen from the bootloader and than the HDMI screen goes black instead of kernel messages. I bisected the issue: 62fb9874f5da54fdb243003b386128037319b219 good e73f0f0ee7541171d89f2e2491130c7771ba58d3 bad e058a84bfddc42ba356a2316f2cf1141974625c9 bad a6eaf3850cb171c328a8b0db6d3c79286a1eba9d good 007b312c6f294770de01fbc0643610145012d244 good 18703923a66aecf6f7ded0e16d22eb412ddae72f good 334200bf52f0637a5ab8331c557dfcecbb9c30fa bad c707b73f0cfb1acc94a20389aecde65e6385349b bad caa18dd6dd9305d52943a6b59f410cbc960ad0a0 good 691cf8cd7a531dbfcc29d09a23c509a86fd9b24f bad 2fdcb55dfc86835e4845e3f422180b5596d23cb4 bad 6c3f953381e526a1623d4575660afae8b19ffa20 bad 5ea4dba68305d9648b9dba30036cc36d4e877bca bad 4a888ba03fd97d1cb0253581973533965bf348c4 good c5ef15ae09637fb51ae43e1d1d98329d67dd4fd6 good f611b1e7624ccdbd495c19e9805629e22265aa16 bad ff323d6d72e1e4971c8ba9e2f3cf8afc48f22383 good f611b1e7624ccdbd495c19e9805629e22265aa16 is the first bad commit commit f611b1e7624ccdbd495c19e9805629e22265aa16 Author: Kees Cook <keescook(a)chromium.org> Date: Wed Jun 2 14:52:50 2021 -0700 drm: Avoid circular dependencies for CONFIG_FB When cleaning up other drm config dependencies, it is too easy to create larger problems. Instead, mark CONFIG_FB as a "depends": drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! I compared the changes to the config (based on multi_v7_defconfig) with and without this patch and it shows a lot of changes. Is this intended? Best regards Stefan

3 9

[Bug 201497] New: [amdgpu]: '*ERROR* No EDID read' is back in 4.19
by bugzilla-daemon＠bugzilla.kernel.org 19 May '22

19 May '22

https://bugzilla.kernel.org/show_bug.cgi?id=201497 Bug ID: 201497 Summary: [amdgpu]: '*ERROR* No EDID read' is back in 4.19 Product: Drivers Version: 2.5 Kernel Version: 4.19 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: engywook(a)gmail.com Regression: No Hey, I have this EDID bug again, see https://lists.freedesktop.org/archives/amd-gfx/2018-July/023923.html 018d82e5f02ef3583411bcaa4e00c69786f46f19 seems to have gotten back in through: # first bad commit: [d98c71dadc2d0debdb80beb5a478baf1e6f98758] Merge drm-upstream/drm-next into drm-misc-next / Daniel -- You are receiving this mail because: You are watching the assignee of the bug.

2 26

DSI Bridge switching
by Jagan Teki 13 May '22

13 May '22

Hi, I think this seems to be a known use case for industrial these days with i.mx8m. The host DSI would configure with two bridges one for DSI to LVDS (SN65DSI83) and another for DSI to HDMI Out (ADV7535). Technically we can use only one bridge at a time as host DSI support single out port. So we can have two separate device tree files for LVDS and HDMI and load them static. But, one of the use cases is to support both of them in single dts, and - Turn On LVDS (default) - Turn Off LVDS then Turn On HDMI when cable plug-in. The HDMI event can be detected via some HDMI-INT GPIO on-board design. The possible solution, I'm thinking of adding LVDS on port 1, HDMI on port 2 in the DSI host node, and trying to attach the respective bridge based on HDMI-INT like repeating the bridge attachment cycle based on the HDMI-INT. Can it be possible to do bridge attachment at runtime? something like a bridge hotplug event? or any other possible solutions? Any suggestions? Thanks, Jagan.

6 15

BUG: unable to handle kernel paging request in bitfill_aligned (2)
by syzbot 12 May '22

12 May '22

Hello, syzbot found the following issue on: HEAD commit: 0062442e Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16584b81500000 kernel config: https://syzkaller.appspot.com/x/.config?x=f9aa2432c01bcb1f dashboard link: https://syzkaller.appspot.com/bug?extid=a4edd73d589b0b7efbeb compiler: gcc (GCC) 10.1.0-syz 20200507 userspace arch: i386 Unfortunately, I don't have any reproducer for this issue yet. IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+a4edd73d589b0b7efbeb(a)syzkaller.appspotmail.com BUG: unable to handle page fault for address: ffff888001000000 #PF: supervisor write access in kernel mode #PF: error_code(0x0003) - permissions violation PGD fc01067 P4D fc01067 PUD fc02067 PMD 80000000010001e1 Oops: 0003 [#1] PREEMPT SMP KASAN CPU: 0 PID: 12457 Comm: syz-executor.5 Not tainted 5.10.0-rc3-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:__writeq arch/x86/include/asm/io.h:98 [inline] RIP: 0010:bitfill_aligned drivers/video/fbdev/core/cfbfillrect.c:70 [inline] RIP: 0010:bitfill_aligned+0x11d/0x200 drivers/video/fbdev/core/cfbfillrect.c:35 Code: 41 83 fc 07 76 5f 4c 89 ed e8 bf 28 8a fd 48 89 5d 00 48 89 5d 08 48 89 5d 10 48 89 5d 18 48 89 5d 20 48 89 5d 28 48 8d 45 38 <48> 89 5d 30 48 83 c5 40 48 89 18 41 83 ef 08 bf 07 00 00 00 44 89 RSP: 0018:ffffc900082176d0 EFLAGS: 00010246 RAX: ffff888001000008 RBX: 0000000000000000 RCX: ffffc90013da2000 RDX: 0000000000040000 RSI: ffffffff83e60721 RDI: 0000000000000005 RBP: ffff888000ffffd0 R08: 0000000000001380 R09: 0000000000000040 R10: 0000000000000007 R11: 0000000000000000 R12: 000000000000004e R13: ffff888000ffff10 R14: 0000000000000000 R15: 0000000000000036 FS: 0000000000000000(0000) GS:ffff8880b9e00000(0063) knlGS:00000000f5542b40 CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033 CR2: ffff888001000000 CR3: 000000001c7d6000 CR4: 00000000001526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: cfb_fillrect+0x40b/0x7b0 drivers/video/fbdev/core/cfbfillrect.c:327 vga16fb_fillrect+0x683/0x1940 drivers/video/fbdev/vga16fb.c:951 bit_clear_margins+0x3f6/0x4b0 drivers/video/fbdev/core/bitblit.c:224 fbcon_clear_margins+0x1f1/0x280 drivers/video/fbdev/core/fbcon.c:1325 fbcon_switch+0xafe/0x16b0 drivers/video/fbdev/core/fbcon.c:2187 redraw_screen+0x2b9/0x790 drivers/tty/vt/vt.c:1021 vc_do_resize+0xed8/0x1150 drivers/tty/vt/vt.c:1326 vt_resize+0xa3/0xe0 drivers/tty/vt/vt.c:1367 tiocswinsz drivers/tty/tty_io.c:2278 [inline] tty_ioctl+0x11a2/0x1600 drivers/tty/tty_io.c:2576 tty_compat_ioctl+0x295/0x410 drivers/tty/tty_io.c:2818 __do_compat_sys_ioctl+0x1d3/0x230 fs/ioctl.c:842 do_syscall_32_irqs_on arch/x86/entry/common.c:78 [inline] __do_fast_syscall_32+0x56/0x80 arch/x86/entry/common.c:137 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:160 entry_SYSENTER_compat_after_hwframe+0x4d/0x5c RIP: 0023:0xf7f48549 Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 eb 0d 90 90 90 90 90 90 90 90 90 90 90 90 RSP: 002b:00000000f55420cc EFLAGS: 00000296 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000005414 RDX: 0000000020000040 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 Modules linked in: CR2: ffff888001000000 ---[ end trace 7c559c247d0f5502 ]--- RIP: 0010:__writeq arch/x86/include/asm/io.h:98 [inline] RIP: 0010:bitfill_aligned drivers/video/fbdev/core/cfbfillrect.c:70 [inline] RIP: 0010:bitfill_aligned+0x11d/0x200 drivers/video/fbdev/core/cfbfillrect.c:35 Code: 41 83 fc 07 76 5f 4c 89 ed e8 bf 28 8a fd 48 89 5d 00 48 89 5d 08 48 89 5d 10 48 89 5d 18 48 89 5d 20 48 89 5d 28 48 8d 45 38 <48> 89 5d 30 48 83 c5 40 48 89 18 41 83 ef 08 bf 07 00 00 00 44 89 RSP: 0018:ffffc900082176d0 EFLAGS: 00010246 RAX: ffff888001000008 RBX: 0000000000000000 RCX: ffffc90013da2000 RDX: 0000000000040000 RSI: ffffffff83e60721 RDI: 0000000000000005 RBP: ffff888000ffffd0 R08: 0000000000001380 R09: 0000000000000040 R10: 0000000000000007 R11: 0000000000000000 R12: 000000000000004e R13: ffff888000ffff10 R14: 0000000000000000 R15: 0000000000000036 FS: 0000000000000000(0000) GS:ffff8880b9e00000(0063) knlGS:00000000f5542b40 CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033 CR2: ffff888001000000 CR3: 000000001c7d6000 CR4: 00000000001526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

2 3

[syzbot] WARNING in drm_gem_shmem_vm_open
by syzbot 12 May '22

12 May '22

Hello, syzbot found the following issue on: HEAD commit: 614cb2751d31 Merge tag 'trace-v5.14-rc6' of git://git.kern.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1462cb61300000 kernel config: https://syzkaller.appspot.com/x/.config?x=96f0602203250753 dashboard link: https://syzkaller.appspot.com/bug?extid=91525b2bd4b5dff71619 compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=122bce0e300000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+91525b2bd4b5dff71619(a)syzkaller.appspotmail.com ------------[ cut here ]------------ WARNING: CPU: 0 PID: 11697 at drivers/gpu/drm/drm_gem_shmem_helper.c:562 drm_gem_shmem_vm_open+0x96/0xb0 drivers/gpu/drm/drm_gem_shmem_helper.c:562 Modules linked in: CPU: 0 PID: 11697 Comm: syz-executor.3 Not tainted 5.14.0-rc6-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:drm_gem_shmem_vm_open+0x96/0xb0 drivers/gpu/drm/drm_gem_shmem_helper.c:562 Code: 89 c6 e8 7d ec 23 fd 85 db 75 1a e8 34 e5 23 fd 48 89 ef 5b 5d 41 5c e9 e8 61 f5 ff e8 23 e5 23 fd 0f 0b eb ca e8 1a e5 23 fd <0f> 0b eb dd e8 b1 1f 6a fd eb 89 e8 aa 1f 6a fd eb a8 0f 1f 84 00 RSP: 0018:ffffc9000b3cfb90 EFLAGS: 00010293 RAX: 0000000000000000 RBX: 00000000fffffffc RCX: 0000000000000000 RDX: ffff8880364eb880 RSI: ffffffff8451c3e6 RDI: 0000000000000003 RBP: ffff888033c70948 R08: 0000000000000000 R09: 0000000000000000 R10: ffffffff8451c3c3 R11: 0000000000000001 R12: ffff888146490800 R13: ffff888033c70a50 R14: 0000000020166000 R15: ffff888033c709d8 FS: 00007fbe43056700(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000005422b8 CR3: 0000000036274000 CR4: 0000000000350ef0 Call Trace: __split_vma+0x23c/0x550 mm/mmap.c:2764 __do_munmap+0x32a/0x11c0 mm/mmap.c:2868 do_munmap mm/mmap.c:2922 [inline] munmap_vma_range mm/mmap.c:604 [inline] mmap_region+0x85a/0x1760 mm/mmap.c:1753 do_mmap+0x86e/0x1180 mm/mmap.c:1584 vm_mmap_pgoff+0x1b7/0x290 mm/util.c:519 ksys_mmap_pgoff+0x4a8/0x620 mm/mmap.c:1635 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x4665e9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbe43056188 EFLAGS: 00000246 ORIG_RAX: 0000000000000009 RAX: ffffffffffffffda RBX: 000000000056bf80 RCX: 00000000004665e9 RDX: 0000000000000000 RSI: 0000000000002000 RDI: 0000000020166000 RBP: 00000000004bfcc4 R08: 0000000000000004 R09: 0000000000000000 R10: 0000000000000013 R11: 0000000000000246 R12: 000000000056bf80 R13: 00007fffb615701f R14: 00007fbe43056300 R15: 0000000000022000 ---------------- Code disassembly (best guess): 0: 89 c6 mov %eax,%esi 2: e8 7d ec 23 fd callq 0xfd23ec84 7: 85 db test %ebx,%ebx 9: 75 1a jne 0x25 b: e8 34 e5 23 fd callq 0xfd23e544 10: 48 89 ef mov %rbp,%rdi 13: 5b pop %rbx 14: 5d pop %rbp 15: 41 5c pop %r12 17: e9 e8 61 f5 ff jmpq 0xfff56204 1c: e8 23 e5 23 fd callq 0xfd23e544 21: 0f 0b ud2 23: eb ca jmp 0xffffffef 25: e8 1a e5 23 fd callq 0xfd23e544 2a: 0f 0b ud2 <-- trapping instruction 2c: eb dd jmp 0xb 2e: e8 b1 1f 6a fd callq 0xfd6a1fe4 33: eb 89 jmp 0xffffffbe 35: e8 aa 1f 6a fd callq 0xfd6a1fe4 3a: eb a8 jmp 0xffffffe4 3c: 0f .byte 0xf 3d: 1f (bad) 3e: 84 00 test %al,(%rax) --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches

4 5

[PATCH v3 0/5] drm: Provide framebuffer vmap helpers
by Thomas Zimmermann 09 May '22

09 May '22

Add the new helpers drm_gem_fb_vmap() and drm_gem_fb_vunmap(), which provide vmap/vunmap for all BOs of a framebuffer. Convert shadow- plane helpers, gud and vkms. Callers of GEM vmap and vunmap functions used to do the minimum work or get some detail wrong. Therefore shadow-plane helpers were intro- duced to implement the details for all callers. The vmapping code in the shadow-plane helpers is also useful for gud and vkms. So it makes sense to provide rsp helpers. Simply call drm_gem_fb_vmap() to retrieve mappings of all of a framebuffer's BOs. Future work: besides the mapping's addresses, drm_gem_fb_vmap() should also return the mappings with the framebuffer data offset added. These are the addresses were the actual image data is located. A follow-up set of patches will implement this feature. v3: * free instances of struct vkms_writeback_job on cleanup or errors v2: * update commit message for first patch (Maxime) * fix error handling after DRM_FORMAT_MAX_PLANES changes (kernel test robot) * fix includes (kernel test robot) * use [static N] notations for array parameters Thomas Zimmermann (5): drm: Define DRM_FORMAT_MAX_PLANES drm/gem: Provide drm_gem_fb_{vmap,vunmap}() drm/gem: Clear mapping addresses for unused framebuffer planes drm/gud: Map framebuffer BOs with drm_gem_fb_vmap() drm/vkms: Map output framebuffer BOs with drm_gem_fb_vmap() drivers/gpu/drm/drm_gem_atomic_helper.c | 37 +------- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 96 ++++++++++++++++++-- drivers/gpu/drm/gud/gud_pipe.c | 10 +- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- drivers/gpu/drm/vkms/vkms_drv.h | 6 +- drivers/gpu/drm/vkms/vkms_writeback.c | 28 +++--- include/drm/drm_fourcc.h | 13 ++- include/drm/drm_framebuffer.h | 8 +- include/drm/drm_gem_atomic_helper.h | 3 +- include/drm/drm_gem_framebuffer_helper.h | 6 ++ 10 files changed, 139 insertions(+), 70 deletions(-) base-commit: 2bda1ca4d4acb4892556fec3a7ea1f02afcd40bb prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 -- 2.32.0

2 9

[Bug 214853] New: [amdgpu] UBSAN shows several null-ptr-deref in ../dc/bios/command_table2.c some array-index-out-of-bounds in ../dc/bios/bios_parser2.c and an invalid-load in ../amdgpu_dm/amdgpu_dm.c
by bugzilla-daemon＠bugzilla.kernel.org 09 May '22

09 May '22

https://bugzilla.kernel.org/show_bug.cgi?id=214853 Bug ID: 214853 Summary: [amdgpu] UBSAN shows several null-ptr-deref in ../dc/bios/command_table2.c some array-index-out-of-bounds in ../dc/bios/bios_parser2.c and an invalid-load in ../amdgpu_dm/amdgpu_dm.c Product: Drivers Version: 2.5 Kernel Version: 5.15-rc7 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: erhard_f(a)mailbox.org CC: christian.koenig(a)amd.com Regression: No Created attachment 299337 --> https://bugzilla.kernel.org/attachment.cgi?id=299337&action=edit kernel dmesg (kernel 5.15-rc7, AMD FX-8370) [...] UBSAN: null-ptr-deref in drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table2.c:872:3 member access within null pointer of type 'struct atom_master_list_of_command_functions_v2_1' CPU: 3 PID: 234 Comm: systemd-udevd Not tainted 5.15.0-rc7-bdver2 #11 Hardware name: Gigabyte Technology Co., Ltd. To be filled by O.E.M./970-GAMING, BIOS F2 04/06/2016 Call Trace: dump_stack_lvl+0x8d/0xd9 ubsan_epilogue+0x5/0x44 __ubsan_handle_type_mismatch_v1+0x45/0x4a dal_firmware_parser_init_cmd_tbl+0x31c/0x37c [amdgpu] bios_parser2_construct+0x16f/0x9cb [amdgpu] firmware_parser_create+0x36/0x4c [amdgpu] dal_bios_parser_create+0xc/0x20 [amdgpu] dc_create+0x25d/0x764 [amdgpu] dm_hw_init+0x28a/0x697 [amdgpu] ? dev_printk_emit+0x4c/0x66 amdgpu_device_init+0x1847/0x1e13 [amdgpu] amdgpu_driver_load_kms+0x47/0x33d [amdgpu] amdgpu_pci_probe+0xeb/0x1a6 [amdgpu] pci_device_probe+0xa1/0x121 really_probe+0xe4/0x331 __driver_probe_device+0x84/0xe1 driver_probe_device+0x1a/0x6d __driver_attach+0xac/0xc3 ? driver_attach+0x15/0x15 bus_for_each_dev+0x8c/0xc0 bus_add_driver+0xf5/0x1f2 driver_register+0x66/0xe7 ? 0xffffffffc0ff2000 do_one_initcall+0x109/0x1f4 ? 0xffffffffc0ff2000 do_init_module+0x5c/0x1f1 load_module+0x193f/0x1ca9 ? kernel_read_file_from_fd+0x5b/0x7e __se_sys_finit_module+0xa7/0xce do_syscall_64+0x79/0xa3 ? lockdep_hardirqs_on_prepare+0xf6/0x1e3 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7fa99ef681e9 Code: 00 00 b8 ca 00 00 00 0f 05 eb ac 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 4f fc 0b 00 f7 d8 64 89 01 48 RSP: 002b:00007fff06041ba8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 000055f2d378be20 RCX: 00007fa99ef681e9 RDX: 0000000000000000 RSI: 00007fa99f0af97f RDI: 0000000000000018 RBP: 0000000000020000 R08: 0000000000000000 R09: fffffffffffffeb8 R10: 0000000000000018 R11: 0000000000000246 R12: 0000000000000000 R13: 000055f2d38eba60 R14: 00007fa99f0af97f R15: 0000000000000000 ================================================================================ ================================================================================ UBSAN: array-index-out-of-bounds in drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:384:3 index 8 is out of range for type 'struct atom_gpio_pin_assignment [8]' CPU: 3 PID: 234 Comm: systemd-udevd Not tainted 5.15.0-rc7-bdver2 #11 Hardware name: Gigabyte Technology Co., Ltd. To be filled by O.E.M./970-GAMING, BIOS F2 04/06/2016 Call Trace: dump_stack_lvl+0x8d/0xd9 ubsan_epilogue+0x5/0x44 __ubsan_handle_out_of_bounds+0x9e/0xa0 get_gpio_i2c_info+0xe0/0x17e [amdgpu] bios_parser_get_i2c_info+0x5b/0xfa [amdgpu] dal_ddc_service_create+0xa7/0x1a8 [amdgpu] dcn20_resource_construct+0x106e/0x10ba [amdgpu] ? find_held_lock+0x41/0xc1 ? slab_post_alloc_hook+0x5f/0x8a dcn20_create_resource_pool+0x39/0x6f [amdgpu] dc_create_resource_pool+0x164/0x213 [amdgpu] ? dal_gpio_service_create+0x8f/0x193 [amdgpu] dc_create+0x2b3/0x764 [amdgpu] dm_hw_init+0x28a/0x697 [amdgpu] ? dev_printk_emit+0x4c/0x66 amdgpu_device_init+0x1847/0x1e13 [amdgpu] amdgpu_driver_load_kms+0x47/0x33d [amdgpu] amdgpu_pci_probe+0xeb/0x1a6 [amdgpu] pci_device_probe+0xa1/0x121 really_probe+0xe4/0x331 __driver_probe_device+0x84/0xe1 driver_probe_device+0x1a/0x6d __driver_attach+0xac/0xc3 ? driver_attach+0x15/0x15 bus_for_each_dev+0x8c/0xc0 bus_add_driver+0xf5/0x1f2 driver_register+0x66/0xe7 ? 0xffffffffc0ff2000 do_one_initcall+0x109/0x1f4 ? 0xffffffffc0ff2000 do_init_module+0x5c/0x1f1 load_module+0x193f/0x1ca9 ? kernel_read_file_from_fd+0x5b/0x7e __se_sys_finit_module+0xa7/0xce do_syscall_64+0x79/0xa3 ? lockdep_hardirqs_on_prepare+0xf6/0x1e3 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7fa99ef681e9 Code: 00 00 b8 ca 00 00 00 0f 05 eb ac 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 4f fc 0b 00 f7 d8 64 89 01 48 RSP: 002b:00007fff06041ba8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 000055f2d378be20 RCX: 00007fa99ef681e9 RDX: 0000000000000000 RSI: 00007fa99f0af97f RDI: 0000000000000018 RBP: 0000000000020000 R08: 0000000000000000 R09: fffffffffffffeb8 R10: 0000000000000018 R11: 0000000000000246 R12: 0000000000000000 R13: 000055f2d38eba60 R14: 00007fa99f0af97f R15: 0000000000000000 [...] = UBSAN: invalid-load in drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5865:85 load of value 170 is not a valid value for type 'bool' (aka '_Bool') CPU: 5 PID: 234 Comm: systemd-udevd Not tainted 5.15.0-rc7-bdver2 #11 Hardware name: Gigabyte Technology Co., Ltd. To be filled by O.E.M./970-GAMING, BIOS F2 04/06/2016 Call Trace: dump_stack_lvl+0x8d/0xd9 ubsan_epilogue+0x5/0x44 __ubsan_handle_load_invalid_value+0x9e/0xa0 create_validate_stream_for_sink+0x6bb/0x777 [amdgpu] ? lockdep_hardirqs_on_prepare+0xf6/0x1e3 amdgpu_dm_connector_mode_valid+0x70/0x1b9 [amdgpu] ? drm_connector_list_update+0xba/0x121 [drm] drm_connector_mode_valid+0x34/0x42 [drm_kms_helper] drm_helper_probe_single_connector_modes+0x4d7/0x88e [drm_kms_helper] ? drm_client_modeset_probe+0x1fa/0x14c9 [drm] drm_client_modeset_probe+0x232/0x14c9 [drm] ? add_chain_block+0x165/0x22f ? __lock_acquire+0xc7c/0x1e4d ? rcu_read_lock_sched_held+0x45/0xa5 ? lock_acquire+0xcb/0x210 ? drm_fb_helper_initial_config+0x32/0x4f [drm_kms_helper] __drm_fb_helper_initial_config_and_unlock+0x3e/0x5f0 [drm_kms_helper] amdgpu_fbdev_init+0xee/0x110 [amdgpu] amdgpu_device_init+0x1996/0x1e13 [amdgpu] amdgpu_driver_load_kms+0x47/0x33d [amdgpu] amdgpu_pci_probe+0xeb/0x1a6 [amdgpu] pci_device_probe+0xa1/0x121 really_probe+0xe4/0x331 __driver_probe_device+0x84/0xe1 driver_probe_device+0x1a/0x6d __driver_attach+0xac/0xc3 ? driver_attach+0x15/0x15 bus_for_each_dev+0x8c/0xc0 bus_add_driver+0xf5/0x1f2 driver_register+0x66/0xe7 ? 0xffffffffc0ff2000 do_one_initcall+0x109/0x1f4 ? 0xffffffffc0ff2000 do_init_module+0x5c/0x1f1 load_module+0x193f/0x1ca9 ? kernel_read_file_from_fd+0x5b/0x7e __se_sys_finit_module+0xa7/0xce do_syscall_64+0x79/0xa3 ? lockdep_hardirqs_on_prepare+0xf6/0x1e3 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7fa99ef681e9 Code: 00 00 b8 ca 00 00 00 0f 05 eb ac 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 4f fc 0b 00 f7 d8 64 89 01 48 RSP: 002b:00007fff06041ba8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 000055f2d378be20 RCX: 00007fa99ef681e9 RDX: 0000000000000000 RSI: 00007fa99f0af97f RDI: 0000000000000018 RBP: 0000000000020000 R08: 0000000000000000 R09: fffffffffffffeb8 R10: 0000000000000018 R11: 0000000000000246 R12: 0000000000000000 R13: 000055f2d38eba60 R14: 00007fa99f0af97f R15: 0000000000000000 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

2 3

[PATCH] drm/ast: Atomic CR/SR reg R/W
by KuoHsiang Chou 03 May '22

03 May '22

1. Avoid IO-index racing 2. IO-index racing happened on resolustion switching and mouse moving at the same time 3. System hung while IO-index racing occurred. Signed-off-by: KuoHsiang Chou <kuohsiang_chou(a)aspeedtech.com> --- drivers/gpu/drm/ast/ast_main.c | 48 +++++++++++++++++++++++++--------- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 79a361867..1d8fa70c5 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -41,28 +41,52 @@ void ast_set_index_reg_mask(struct ast_private *ast, uint32_t base, uint8_t index, uint8_t mask, uint8_t val) { - u8 tmp; - ast_io_write8(ast, base, index); - tmp = (ast_io_read8(ast, base + 1) & mask) | val; - ast_set_index_reg(ast, base, index, tmp); + uint16_t volatile usData; + uint8_t volatile jData; + + do { + ast_io_write8(ast, base, index); + usData = ast_io_read16(ast, base); + } while ((uint8_t)(usData) != index); + + jData = (uint8_t)(usData >> 8); + jData &= mask; + jData |= val; + usData = ((uint16_t) jData << 8) | (uint16_t) index; + ast_io_write16(ast, base, usData); } uint8_t ast_get_index_reg(struct ast_private *ast, uint32_t base, uint8_t index) { - uint8_t ret; - ast_io_write8(ast, base, index); - ret = ast_io_read8(ast, base + 1); - return ret; + uint16_t volatile usData; + uint8_t volatile jData; + + do { + ast_io_write8(ast, base, index); + usData = ast_io_read16(ast, base); + } while ((uint8_t)(usData) != index); + + jData = (uint8_t)(usData >> 8); + + return jData; } uint8_t ast_get_index_reg_mask(struct ast_private *ast, uint32_t base, uint8_t index, uint8_t mask) { - uint8_t ret; - ast_io_write8(ast, base, index); - ret = ast_io_read8(ast, base + 1) & mask; - return ret; + uint16_t volatile usData; + uint8_t volatile jData; + + do { + ast_io_write8(ast, base, index); + usData = ast_io_read16(ast, base); + } while ((uint8_t)(usData) != index); + + jData = (uint8_t)(usData >> 8); + jData &= mask; + + return jData; } static void ast_detect_config_mode(struct drm_device *dev, u32 *scu_rev) -- 2.18.4

3 7

[PATCH] drm/panel: panel-simple: Fix proper bpc for AM-1280800N3TZQW-T00H
by Jagan Teki 02 May '22

02 May '22

AM-1280800N3TZQW-T00H panel support 8 bpc not 6 bpc as per recent testing in i.MX8MM platform. Fix it. Fixes: bca684e69c4c ("drm/panel: simple: Add AM-1280800N3TZQW-T00H") Signed-off-by: Jagan Teki <jagan(a)amarulasolutions.com> --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index eb475a3a774b..cf3f21f649cb 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -719,7 +719,7 @@ static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = { static const struct panel_desc ampire_am_1280800n3tzqw_t00h = { .modes = &ampire_am_1280800n3tzqw_t00h_mode, .num_modes = 1, - .bpc = 6, + .bpc = 8, .size = { .width = 217, .height = 136, -- 2.25.1

3 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel November 2021