dri-devel February 2021

dri-devel@lists.freedesktop.org

314 participants
684 discussions

[PATCH v2 0/2] drm/vboxvideo: Use struct drm_shadow_plane_state for cursor plane
by Thomas Zimmermann 09 Feb '21

09 Feb '21

(was: drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb) Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the GEM object's vmap functionality in atomic_update. But, much better, we can use drm_shadow_plane_state to do all the mapping for us. Patch 1 exports the helpers for shadow-buffered planes from the DRM KMS helper library and adds documentation on how to use them. Patch 2 replaces the vmap code in vbox' cursor update code with a the helpers for shadow-buffered planes. Thomas Zimmermann (2): drm/gem: Export helpers for shadow-buffered planes drm/vboxvideo: Implement cursor plane with struct drm_shadow_plane_state drivers/gpu/drm/drm_gem_atomic_helper.c | 148 +++++++++++++++++++++++- drivers/gpu/drm/vboxvideo/vbox_mode.c | 28 ++--- include/drm/drm_gem_atomic_helper.h | 32 +++++ 3 files changed, 181 insertions(+), 27 deletions(-) -- 2.30.0

3 7

[PATCH][next] drm/i915/display: Fix spelling mistake "Couldnt" -> "Couldn't"
by Colin King 09 Feb '21

09 Feb '21

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a drm_dbg message. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 8c12d5375607..a338720cee2e 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2650,7 +2650,7 @@ void intel_dp_check_frl_training(struct intel_dp *intel_dp) if (intel_dp_pcon_start_frl_training(intel_dp) < 0) { int ret, mode; - drm_dbg(&dev_priv->drm, "Couldnt set FRL mode, continuing with TMDS mode\n"); + drm_dbg(&dev_priv->drm, "Couldn't set FRL mode, continuing with TMDS mode\n"); ret = drm_dp_pcon_reset_frl_config(&intel_dp->aux); mode = drm_dp_pcon_hdmi_link_mode(&intel_dp->aux, NULL); -- 2.30.0

1 0

[PATCH 0/5] sunxi: fix H6 HDMI related issues
by Jernej Skrabec 09 Feb '21

09 Feb '21

Over the year I got plenty of reports of troubles with H6 HDMI signal. Sometimes monitor flickers, sometimes there was no image at all and sometimes it didn't play well with AVR. It turns out there are multiple issues. Patch 1 fixes clock issue, which didn't adjust parent rate, even if it is allowed to do so. Patch 2 adds polarity config in tcon1. This is seemingly not needed for pre-HDMI2 controllers, although BSP drivers set it accordingly every time. It turns out that HDMI2 controllers often don't work with monitors if polarity is not set correctly. Patch 3 always set clock rate for HDMI controller. Patch 4 fixes cpce PHY setting for 594 MHz. Patch 5 fixes comment and clock rate limit (wrong reasoning). Please take a look. Best regards, Jernej Jernej Skrabec (5): clk: sunxi-ng: mp: fix parent rate change flag check drm/sun4i: tcon: set sync polarity for tcon1 channel drm/sun4i: dw-hdmi: always set clock rate drm/sun4i: Fix H6 HDMI PHY configuration drm/sun4i: dw-hdmi: Fix max. frequency for H6 drivers/clk/sunxi-ng/ccu_mp.c | 2 +- drivers/gpu/drm/sun4i/sun4i_tcon.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 5 +++++ drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 10 +++------- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 2 +- 6 files changed, 34 insertions(+), 10 deletions(-) -- 2.30.0

4 16

[PATCH 0/4] drm: Replace in_interrupt() usage.
by Sebastian Andrzej Siewior 09 Feb '21

09 Feb '21

Folks, in the discussion about preempt count consistency across kernel configurations: https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ it was concluded that the usage of in_interrupt() and related context checks should be removed from non-core code. In the long run, usage of 'preemptible, in_*irq etc.' should be banned from driver code completely. This series addresses the gma500 driver and parts of the amdgpu driver. There are still call sites left in in the amdgpu driver. Sebastian

3 6

Fw: [Bug 211587] New: X: page allocation failure: order:8, mode:0x190dc2(GFP_HIGHUSER|__GFP_NORETRY|__GFP_ZERO|__GFP_NOMEMALLOC), nodemask=(null),cpuset=/,mems_allowed=0
by Andrew Morton 09 Feb '21

09 Feb '21

I'm not sure who this belongs to... Begin forwarded message: Date: Sat, 06 Feb 2021 01:49:51 +0000 From: bugzilla-daemon(a)bugzilla.kernel.org To: akpm(a)linux-foundation.org Subject: [Bug 211587] New: X: page allocation failure: order:8, mode:0x190dc2(GFP_HIGHUSER|__GFP_NORETRY|__GFP_ZERO|__GFP_NOMEMALLOC), nodemask=(null),cpuset=/,mems_allowed=0 https://bugzilla.kernel.org/show_bug.cgi?id=211587 Bug ID: 211587 Summary: X: page allocation failure: order:8, mode:0x190dc2(GFP_HIGHUSER|__GFP_NORETRY|__GFP_ZERO|__ GFP_NOMEMALLOC), nodemask=(null),cpuset=/,mems_allowed=0 Product: Memory Management Version: 2.5 Kernel Version: v5.11-rc6 Hardware: i386 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Page Allocator Assignee: akpm(a)linux-foundation.org Reporter: erhard_f(a)mailbox.org Regression: No Created attachment 295083 --> https://bugzilla.kernel.org/attachment.cgi?id=295083&action=edit dmesg (kernel 5.11-rc6, Shuttle XPC FS51, Pentium 4) ... 1st occurence Got this while running btrfs testsuite on the machine. It's not 100 % reproducable, but it happened on several occasions. [...] X: page allocation failure: order:8, mode:0x190dc2(GFP_HIGHUSER|__GFP_NORETRY|__GFP_ZERO|__GFP_NOMEMALLOC), nodemask=(null),cpuset=/,mems_allowed=0 CPU: 0 PID: 199 Comm: X Not tainted 5.11.0-rc6-Pentium4 #4 Hardware name: /FS51, BIOS 6.00 PG 12/02/2003 Call Trace: dump_stack+0x6b/0x89 warn_alloc+0x87/0xe0 __alloc_pages_nodemask+0x9ba/0xa6e ? lock_acquire+0x86/0x2b4 ? __kmalloc+0x11a/0x12d ? kvmalloc_node+0x43/0x6b ttm_pool_alloc+0x135/0x3cd [ttm] radeon_ttm_tt_populate+0x72/0x79 [radeon] ? radeon_bo_reserve.constprop.0+0x4c/0x4c [radeon] ttm_tt_populate+0x2e/0x92 [ttm] ttm_bo_handle_move_mem+0x8d/0xd9 [ttm] ttm_bo_validate+0xe7/0x140 [ttm] ttm_bo_init_reserved+0x23e/0x26b [ttm] ttm_bo_init+0x48/0x67 [ttm] ? radeon_bo_gpu_offset+0x55/0x55 [radeon] radeon_bo_create+0x118/0x1ce [radeon] ? radeon_bo_gpu_offset+0x55/0x55 [radeon] radeon_gem_object_create+0x93/0x12e [radeon] radeon_gem_create_ioctl+0x4a/0xa9 [radeon] ? srcu_read_unlock.constprop.0+0x28/0x2b [drm] ? radeon_gem_pwrite_ioctl+0x19/0x19 [radeon] drm_ioctl_kernel+0x73/0xa9 [drm] drm_ioctl+0x225/0x2f7 [drm] ? radeon_gem_pwrite_ioctl+0x19/0x19 [radeon] ? lock_acquire+0x86/0x2b4 ? lock_acquire+0x86/0x2b4 ? lock_release+0x78/0x201 ? __pm_runtime_resume+0x5e/0x66 ? trace_hardirqs_on+0x43/0x45 ? __pm_runtime_resume+0x5e/0x66 radeon_drm_ioctl+0x3d/0x69 [radeon] ? radeon_pmops_runtime_idle+0x83/0x83 [radeon] vfs_ioctl+0x1a/0x24 __ia32_sys_ioctl+0x618/0x632 ? __vm_munmap+0x60/0x88 ? __vm_munmap+0x7e/0x88 ? exit_to_user_mode_prepare+0x16b/0x173 __do_fast_syscall_32+0x66/0x76 do_fast_syscall_32+0x29/0x5b do_SYSENTER_32+0x15/0x17 entry_SYSENTER_32+0x9f/0xf2 EIP: 0xb7f76545 Code: c4 01 10 03 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d 76 00 58 b8 77 00 00 00 cd 80 90 8d 76 EAX: ffffffda EBX: 0000000d ECX: c01c645d EDX: bff1a860 ESI: 0232da80 EDI: 00000002 EBP: bff1a818 ESP: bff1a7e8 DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00000286 Mem-Info: active_anon:229 inactive_anon:66945 isolated_anon:0 active_file:44149 inactive_file:364595 isolated_file:32 unevictable:0 dirty:25771 writeback:2106 slab_reclaimable:4183 slab_unreclaimable:6442 mapped:30206 shmem:1738 pagetables:941 bounce:0 free:23348 free_pcp:72 free_cma:0 Node 0 active_anon:916kB inactive_anon:267780kB active_file:176596kB inactive_file:1458380kB unevictable:0kB isolated(anon):0kB isolated(file):128kB mapped:120824kB dirty:103084kB writeback:8424kB shmem:6952kB shmem_thp: 0kB shmem_pmdmapped: 0kB anon_thp: 0kB writeback_tmp:0kB kernel_stack:2456kB pagetables:3764kB all_unreclaimable? no DMA free:8776kB min:788kB low:984kB high:1180kB reserved_highatomic:0KB active_anon:0kB inactive_anon:0kB active_file:0kB inactive_file:7136kB unevictable:0kB writepending:188kB present:16000kB managed:15916kB mlocked:0kB bounce:0kB free_pcp:0kB local_pcp:0kB free_cma:0kB lowmem_reserve[]: 0 834 1998 1998 Normal free:79860kB min:42468kB low:53084kB high:63700kB reserved_highatomic:0KB active_anon:0kB inactive_anon:60668kB active_file:58240kB inactive_file:608540kB unevictable:0kB writepending:12988kB present:888824kB managed:855428kB mlocked:0kB bounce:0kB free_pcp:36kB local_pcp:36kB free_cma:0kB lowmem_reserve[]: 0 0 9311 9311 HighMem free:4756kB min:4608kB low:19408kB high:34208kB reserved_highatomic:0KB active_anon:916kB inactive_anon:207112kB active_file:118332kB inactive_file:842684kB unevictable:0kB writepending:98340kB present:1191880kB managed:1191880kB mlocked:0kB bounce:0kB free_pcp:252kB local_pcp:252kB free_cma:0kB lowmem_reserve[]: 0 0 0 0 DMA: 2*4kB (UM) 2*8kB (UM) 1*16kB (U) 1*32kB (U) 2*64kB (UM) 1*128kB (U) 1*256kB (U) 2*512kB (UM) 1*1024kB (U) 1*2048kB (U) 1*4096kB (M) = 8776kB Normal: 229*4kB (U) 152*8kB (UME) 61*16kB (UME) 30*32kB (UME) 28*64kB (UME) 18*128kB (UE) 20*256kB (UME) 6*512kB (UE) 6*1024kB (UME) 4*2048kB (UME) 12*4096kB (U) = 79844kB HighMem: 3*4kB (UM) 1*8kB (U) 0*16kB 0*32kB 6*64kB (U) 2*128kB (U) 2*256kB (U) 1*512kB (M) 3*1024kB (M) 0*2048kB 0*4096kB = 4756kB Node 0 hugepages_total=0 hugepages_free=0 hugepages_surp=0 hugepages_size=4096kB 410490 total pagecache pages 0 pages in swap cache Swap cache stats: add 0, delete 0, find 0/0 Free swap = 8388604kB Total swap = 8388604kB 524176 pages RAM 297970 pages HighMem/MovableOnly 8370 pages reserved [...] # lspci 00:00.0 Host bridge: Silicon Integrated Systems [SiS] 651 Host (rev 02) 00:01.0 PCI bridge: Silicon Integrated Systems [SiS] AGP Port (virtual PCI-to-PCI bridge) 00:02.0 ISA bridge: Silicon Integrated Systems [SiS] SiS962 [MuTIOL Media IO] LPC Controller (rev 14) 00:02.1 SMBus: Silicon Integrated Systems [SiS] SiS961/2/3 SMBus controller 00:02.5 IDE interface: Silicon Integrated Systems [SiS] 5513 IDE Controller 00:02.7 Multimedia audio controller: Silicon Integrated Systems [SiS] SiS7012 AC'97 Sound Controller (rev a0) 00:03.0 USB controller: Silicon Integrated Systems [SiS] USB 1.1 Controller (rev 0f) 00:03.1 USB controller: Silicon Integrated Systems [SiS] USB 1.1 Controller (rev 0f) 00:03.2 USB controller: Silicon Integrated Systems [SiS] USB 1.1 Controller (rev 0f) 00:03.3 USB controller: Silicon Integrated Systems [SiS] USB 2.0 Controller 00:0a.0 Network controller: Ralink corp. RT2500 Wireless 802.11bg (rev 01) 00:0f.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8100/8101L/8139 PCI Fast Ethernet Adapter (rev 10) 00:10.0 FireWire (IEEE 1394): VIA Technologies, Inc. VT6306/7/8 [Fire II(M)] IEEE 1394 OHCI Controller (rev 46) 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] RV350 [Radeon 9550/9600/X1050 Series] 01:00.1 Display controller: Advanced Micro Devices, Inc. [AMD/ATI] RV350 [Radeon 9550/9600/X1050 Series] (Secondary) # lscpu Architecture: i686 CPU op-mode(s): 32-bit Byte Order: Little Endian Address sizes: 36 bits physical, 32 bits virtual CPU(s): 1 On-line CPU(s) list: 0 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 1 Vendor ID: GenuineIntel CPU family: 15 Model: 2 Model name: Intel(R) Pentium(R) 4 CPU 3.06GHz Stepping: 7 CPU MHz: 3062.724 BogoMIPS: 6127.67 Vulnerability Itlb multihit: Processor vulnerable Vulnerability L1tf: Vulnerable Vulnerability Mds: Vulnerable: Clear CPU buffers attempted, no microcode; SMT disabled Vulnerability Meltdown: Vulnerable Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe pebs bts cpuid cid xtpr -- You may reply to this email to add a comment. You are receiving this mail because: You are the assignee for the bug.

2 1

[PATCH v3 0/6] devicetree fixes for Protonic and Plymovent boards
by Oleksij Rempel 09 Feb '21

09 Feb '21

changes v3: - remove patch: ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node. This is done by Uwe in a separate patch - add Acked-by: Rob Herring... changes v2: - imx6dl-prtvt7: remove touchscreen-inverted-* Oleksij Rempel (6): dt-bindings: display: simple: add Innolux G070Y2-T02 panel drm: panel-simple: Add support for the Innolux G070Y2-T02 panel ARM: dts: imx6dl-prtvt7: Add display and panel nodes ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node ARM: dts: imx6dl-prtvt7: Remove backlight enable gpio ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties .../bindings/display/panel/panel-simple.yaml | 2 + arch/arm/boot/dts/imx6dl-plym2m.dts | 2 - arch/arm/boot/dts/imx6dl-prtvt7.dts | 71 ++++++++++++++++--- drivers/gpu/drm/panel/panel-simple.c | 16 +++++ 4 files changed, 80 insertions(+), 11 deletions(-) -- 2.30.0

1 6

[PATCH] drm/tilcdc: send vblank event when disabling crtc
by quanyang.wang＠windriver.com 09 Feb '21

09 Feb '21

From: Quanyang Wang <quanyang.wang(a)windriver.com> When run xrandr to change resolution on Beaglebone Black board, it will print the error information: root@beaglebone:~# xrandr -display :0 --output HDMI-1 --mode 720x400 [drm:drm_crtc_commit_wait] *ERROR* flip_done timed out [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:32:tilcdc crtc] commit wait timed out [drm:drm_crtc_commit_wait] *ERROR* flip_done timed out [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CONNECTOR:34:HDMI-A-1] commit wait timed out [drm:drm_crtc_commit_wait] *ERROR* flip_done timed out [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [PLANE:31:plane-0] commit wait timed out tilcdc 4830e000.lcdc: already pending page flip! This is because there is operation sequence as below: drm_atomic_connector_commit_dpms(mode is DRM_MODE_DPMS_OFF): ... drm_atomic_helper_setup_commit <- init_completion(commit_A->flip_done) drm_atomic_helper_commit_tail tilcdc_crtc_atomic_disable tilcdc_plane_atomic_update <- drm_crtc_send_vblank_event in tilcdc_crtc_irq is skipped since tilcdc_crtc->enabled is 0 tilcdc_crtc_atomic_flush <- drm_crtc_send_vblank_event is skipped since crtc->state->event is set to be NULL in tilcdc_plane_atomic_update drm_mode_setcrtc: ... drm_atomic_helper_setup_commit <- init_completion(commit_B->flip_done) drm_atomic_helper_wait_for_dependencies drm_crtc_commit_wait <- wait for commit_A->flip_done completing Just as shown above, the steps which could complete commit_A->flip_done are all skipped and commit_A->flip_done will never be completed. This will result a time-out ERROR when drm_crtc_commit_wait check the commit_A->flip_done. So add drm_crtc_send_vblank_event in tilcdc_crtc_atomic_disable to complete commit_A->flip_done. Fixes: cb345decb4d2 ("drm/tilcdc: Use standard drm_atomic_helper_commit") Signed-off-by: Quanyang Wang <quanyang.wang(a)windriver.com> --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..d99afd19ca08 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -515,6 +515,15 @@ static void tilcdc_crtc_off(struct drm_crtc *crtc, bool shutdown) drm_crtc_vblank_off(crtc); + spin_lock_irq(&crtc->dev->event_lock); + + if (crtc->state->event) { + drm_crtc_send_vblank_event(crtc, crtc->state->event); + crtc->state->event = NULL; + } + + spin_unlock_irq(&crtc->dev->event_lock); + tilcdc_crtc_disable_irqs(dev); pm_runtime_put_sync(dev->dev); -- 2.25.1

4 4

[RFC][PATCH 1/2] dma-buf: dma-heap: Provide accessor to get heap name
by John Stultz 09 Feb '21

09 Feb '21

It can be useful to access the name for the heap, so provide an accessor to do so. Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: Liam Mark <lmark(a)codeaurora.org> Cc: Chris Goldsworthy <cgoldswo(a)codeaurora.org> Cc: Laura Abbott <labbott(a)kernel.org> Cc: Brian Starkey <Brian.Starkey(a)arm.com> Cc: Hridya Valsaraju <hridya(a)google.com> Cc: Suren Baghdasaryan <surenb(a)google.com> Cc: Sandeep Patil <sspatil(a)google.com> Cc: Daniel Mentz <danielmentz(a)google.com> Cc: Ørjan Eide <orjan.eide(a)arm.com> Cc: Robin Murphy <robin.murphy(a)arm.com> Cc: Ezequiel Garcia <ezequiel(a)collabora.com> Cc: Simon Ser <contact(a)emersion.fr> Cc: James Jones <jajones(a)nvidia.com> Cc: linux-media(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: John Stultz <john.stultz(a)linaro.org> --- drivers/dma-buf/dma-heap.c | 13 +++++++++++++ include/linux/dma-heap.h | 9 +++++++++ 2 files changed, 22 insertions(+) diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c index afd22c9dbdcf..6c746ea67676 100644 --- a/drivers/dma-buf/dma-heap.c +++ b/drivers/dma-buf/dma-heap.c @@ -190,6 +190,19 @@ void *dma_heap_get_drvdata(struct dma_heap *heap) return heap->priv; } + +/** + * dma_heap_get_name() - get heap name + * @heap: DMA-Heap to retrieve private data for + * + * Returns: + * The char* for the heap name. + */ +char *dma_heap_get_name(struct dma_heap *heap) +{ + return heap->name; +} + struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) { struct dma_heap *heap, *h, *err_ret; diff --git a/include/linux/dma-heap.h b/include/linux/dma-heap.h index 454e354d1ffb..b91778291fb1 100644 --- a/include/linux/dma-heap.h +++ b/include/linux/dma-heap.h @@ -50,6 +50,15 @@ struct dma_heap_export_info { */ void *dma_heap_get_drvdata(struct dma_heap *heap); +/** + * dma_heap_get_name() - get heap name + * @heap: DMA-Heap to retrieve private data for + * + * Returns: + * The char* for the heap name. + */ +char *dma_heap_get_name(struct dma_heap *heap); + /** * dma_heap_add - adds a heap to dmabuf heaps * @exp_info: information needed to register this heap -- 2.25.1

3 6

[PATCH v2 0/7] devicetree fixes for Protonic and Plymovent boards
by Oleksij Rempel 09 Feb '21

09 Feb '21

changes v2: - imx6dl-prtvt7: remove touchscreen-inverted-* Oleksij Rempel (7): dt-bindings: display: simple: add Innolux G070Y2-T02 panel drm: panel-simple: Add support for the Innolux G070Y2-T02 panel ARM: dts: imx6dl-prtvt7: Add display and panel nodes ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node ARM: dts: imx6dl-prtvt7: Remove backlight enable gpio ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node. ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties .../bindings/display/panel/panel-simple.yaml | 2 + arch/arm/boot/dts/imx6dl-plym2m.dts | 2 - arch/arm/boot/dts/imx6dl-prtvt7.dts | 74 ++++++++++++++++--- drivers/gpu/drm/panel/panel-simple.c | 16 ++++ 4 files changed, 81 insertions(+), 13 deletions(-) -- 2.30.0

3 10

[PATCH] drm/i915/gvt/kvmgt: Fix the build failure in kvmgt.
by Yu Zhang 09 Feb '21

09 Feb '21

Previously, commit 531810caa9f4 ("KVM: x86/mmu: Use an rwlock for the x86 MMU") replaced KVM's mmu_lock with type rwlock_t. This will cause a build failure in kvmgt, which uses the same lock when trying to add/ remove some GFNs to/from the page tracker. Fix it with write_lock/unlocks in kvmgt. Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Signed-off-by: Yu Zhang <yu.c.zhang(a)linux.intel.com> --- drivers/gpu/drm/i915/gvt/kvmgt.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c index 60f1a386dd06..b4348256ae95 100644 --- a/drivers/gpu/drm/i915/gvt/kvmgt.c +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c @@ -1703,7 +1703,7 @@ static int kvmgt_page_track_add(unsigned long handle, u64 gfn) return -EINVAL; } - spin_lock(&kvm->mmu_lock); + write_lock(&kvm->mmu_lock); if (kvmgt_gfn_is_write_protected(info, gfn)) goto out; @@ -1712,7 +1712,7 @@ static int kvmgt_page_track_add(unsigned long handle, u64 gfn) kvmgt_protect_table_add(info, gfn); out: - spin_unlock(&kvm->mmu_lock); + write_unlock(&kvm->mmu_lock); srcu_read_unlock(&kvm->srcu, idx); return 0; } @@ -1737,7 +1737,7 @@ static int kvmgt_page_track_remove(unsigned long handle, u64 gfn) return -EINVAL; } - spin_lock(&kvm->mmu_lock); + write_lock(&kvm->mmu_lock); if (!kvmgt_gfn_is_write_protected(info, gfn)) goto out; @@ -1746,7 +1746,7 @@ static int kvmgt_page_track_remove(unsigned long handle, u64 gfn) kvmgt_protect_table_del(info, gfn); out: - spin_unlock(&kvm->mmu_lock); + write_unlock(&kvm->mmu_lock); srcu_read_unlock(&kvm->srcu, idx); return 0; } @@ -1772,7 +1772,7 @@ static void kvmgt_page_track_flush_slot(struct kvm *kvm, struct kvmgt_guest_info *info = container_of(node, struct kvmgt_guest_info, track_node); - spin_lock(&kvm->mmu_lock); + write_lock(&kvm->mmu_lock); for (i = 0; i < slot->npages; i++) { gfn = slot->base_gfn + i; if (kvmgt_gfn_is_write_protected(info, gfn)) { @@ -1781,7 +1781,7 @@ static void kvmgt_page_track_flush_slot(struct kvm *kvm, kvmgt_protect_table_del(info, gfn); } } - spin_unlock(&kvm->mmu_lock); + write_unlock(&kvm->mmu_lock); } static bool __kvmgt_vgpu_exist(struct intel_vgpu *vgpu, struct kvm *kvm) -- 2.17.1

2 1

← Newer
1
...
46
47
48
49
50
51
52
...
69
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2021