dri-devel February 2021

dri-devel@lists.freedesktop.org

314 participants
684 discussions

[GIT PULL v2] mediatek drm next for 5.12
by Chun-Kuang Hu 04 Feb '21

04 Feb '21

Hi, Dave & Daniel: This version fix fixes tag quotation missing. This includes: 1. Decouple Mediatek DRM sub driver 2. Share mtk mutex driver for both DRM and MDP 3. Add support for SoC MT8183 Regards, Chun-Kuang. The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git tags/mediatek-drm-next-5.12 for you to fetch changes up to 738ed4156fbac6f6eb84c23b95cf25aa57707332: drm/mediatek: Add matrix_bits private data for ccorr (2021-02-04 22:55:46 +0800) ---------------------------------------------------------------- Mediatek DRM Next for Linux 5.12 1. Decouple Mediatek DRM sub driver 2. Share mtk mutex driver for both DRM and MDP 3. Add support for SoC MT8183 ---------------------------------------------------------------- CK Hu (15): drm/mediatek: Separate getting larb device to a function drm/mediatek: Move clk info from struct mtk_ddp_comp to sub driver private data drm/mediatek: Move regs info from struct mtk_ddp_comp to sub driver private data drm/mediatek: Remove irq in struct mtk_ddp_comp drm/mediatek: Use struct cmdq_client_reg to gather cmdq variable drm/mediatek: Move cmdq_reg info from struct mtk_ddp_comp to sub driver private data drm/mediatek: Change sub driver interface from mtk_ddp_comp to device drm/mediatek: Register vblank callback function drm/mediatek: DRM driver directly refer to sub driver's function drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver drm/mediatek: Remove redundant file including drm/mediatek: Rename file mtk_drm_ddp to mtk_mutex drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver drm/mediatek: Automatically search unclaimed mtk mutex in mtk_mutex_get() soc / drm: mediatek: Move mtk mutex driver to soc folder Chun-Kuang Hu (2): drm/mediatek: Get CMDQ client register for all ddp component drm/mediatek: Use correct device pointer to get CMDQ client register Hsin-Yi Wang (2): drm/mediatek: mtk_dpi: Create connector for bridges drm/mediatek: Add mtk_dither_set_common() function Jitao Shi (1): drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type Yongqiang Niu (15): dt-bindings: mediatek: add description for mt8183 display dt-bindings: mediatek: add description for mt8192 display drm/mediatek: Check if fb is null dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display dt-bindings: mediatek: add description for postmask drm/mediatek: Fix aal size config drm/mediatek: Add fifo_size into rdma private data drm/mediatek: Separate gamma module drm/mediatek: Add has_dither private data for gamma drm/mediatek: Add support for SoC MT8183 drm/mediatek: Enable OVL_LAYER_SMI_ID_EN for multi-layer usecase drm/mediatek: Enable dither function drm/mediatek: Separate ccorr module drm/mediatek: Fix ccorr size config drm/mediatek: Add matrix_bits private data for ccorr .../bindings/display/mediatek/mediatek,disp.txt | 12 +- drivers/gpu/drm/mediatek/Makefile | 5 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 223 +++++++++ drivers/gpu/drm/mediatek/mtk_disp_color.c | 89 ++-- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 92 ++++ drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 197 ++++++++ drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 254 ++++++----- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 194 ++++---- drivers/gpu/drm/mediatek/mtk_dpi.c | 57 +-- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 107 ++--- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 - drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 28 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 503 ++++++++++----------- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 100 ++-- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 88 ++-- drivers/gpu/drm/mediatek/mtk_drm_drv.h | 5 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 50 +- drivers/soc/mediatek/Makefile | 1 + .../mtk_drm_ddp.c => soc/mediatek/mtk-mutex.c} | 328 +++++++------- include/linux/soc/mediatek/mtk-mutex.h | 26 ++ 20 files changed, 1446 insertions(+), 914 deletions(-) create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_ccorr.c create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_drv.h create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_gamma.c delete mode 100644 drivers/gpu/drm/mediatek/mtk_drm_ddp.h rename drivers/{gpu/drm/mediatek/mtk_drm_ddp.c => soc/mediatek/mtk-mutex.c} (53%) create mode 100644 include/linux/soc/mediatek/mtk-mutex.h

1 0

[PATCH 01/14] drm/amdkfd: Get unique_id dynamically v2
by Christian König 04 Feb '21

04 Feb '21

From: Kent Russell <kent.russell(a)amd.com> Instead of caching the value during amdgpu_device_init, just call the function directly. This avoids issues where the unique_id hasn't been saved by the time that KFD's topology snapshot is done (e.g. Arcturus). KFD's topology information from the amdgpu_device was initially cached at KFD initialization due to amdkfd and amdgpu being separate modules. Now that they are combined together, we can directly call the functions that we need and avoid this unnecessary duplication and complexity. As a side-effect of this change, we also remove unique_id=0 for CPUs, which is obviously not unique. v2: Drop previous patch printing unique_id in hex Signed-off-by: Kent Russell <kent.russell(a)amd.com> Reviewed-by: Felix Kuehling <Felix.Kuehling(a)amd.com> --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 6 +++--- drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c index a3fc23873819..0be72789ccbc 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c @@ -497,8 +497,6 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr, dev->node_props.num_sdma_queues_per_engine); sysfs_show_32bit_prop(buffer, offs, "num_cp_queues", dev->node_props.num_cp_queues); - sysfs_show_64bit_prop(buffer, offs, "unique_id", - dev->node_props.unique_id); if (dev->gpu) { log_max_watch_addr = @@ -529,6 +527,9 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr, dev->node_props.capability); sysfs_show_32bit_prop(buffer, offs, "sdma_fw_version", dev->gpu->sdma_fw_version); + sysfs_show_64bit_prop(buffer, offs, "unique_id", + amdgpu_amdkfd_get_unique_id(dev->gpu->kgd)); + } return sysfs_show_32bit_prop(buffer, offs, "max_engine_clk_ccompute", @@ -1340,7 +1341,6 @@ int kfd_topology_add_device(struct kfd_dev *gpu) dev->gpu->dqm->sched_policy != KFD_SCHED_POLICY_NO_HWS) ? amdgpu_amdkfd_get_num_gws(dev->gpu->kgd) : 0; dev->node_props.num_cp_queues = get_cp_queues_num(dev->gpu->dqm); - dev->node_props.unique_id = amdgpu_amdkfd_get_unique_id(dev->gpu->kgd); kfd_fill_mem_clk_max_info(dev); kfd_fill_iolink_non_crat_info(dev); diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h index 326d9b26b7aa..416fd910e12e 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h @@ -57,7 +57,6 @@ struct kfd_node_properties { uint64_t hive_id; - uint64_t unique_id; uint32_t cpu_cores_count; uint32_t simd_count; uint32_t mem_banks_count; -- 2.25.1

1 0

[GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1
by Andy Shevchenko 04 Feb '21

04 Feb '21

Hi guys, This is first part of Intel MID outdated platforms removal. It's collected into immutable branch with a given tag, please pull to yours subsystems. (All changes are tagged by the respective maintainers) Thanks, With Best Regards, Andy Shevchenko The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.infradead.org/linux-platform-drivers-x86.git tags/ib-drm-gpio-pdx86-rtc-wdt-v5.12-1 for you to fetch changes up to a507e5d90f3d6846a02d9c2c79e6f6395982db92: platform/x86: intel_scu_wdt: Get rid of custom x86 model comparison (2021-01-25 20:05:32 +0200) ---------------------------------------------------------------- ib-drm-gpio-pdx86-rtc-wdt for v5.12-1 First part of Intel MID outdated platforms removal. The following is an automated git shortlog grouped by driver: drm/gma500: - Get rid of duplicate NULL checks - Convert to use new SCU IPC API gpio: - msic: Remove driver for deprecated platform - intel-mid: Remove driver for deprecated platform intel_mid_powerbtn: - Remove driver for deprecated platform intel_mid_thermal: - Remove driver for deprecated platform intel_scu_wdt: - Get rid of custom x86 model comparison - Drop SCU notification - Move driver from arch/x86 rtc: - mrst: Remove driver for deprecated platform watchdog: - intel-mid_wdt: Postpone IRQ handler registration till SCU is ready - intel_scu_watchdog: Remove driver for deprecated platform ---------------------------------------------------------------- Andy Shevchenko (12): drm/gma500: Convert to use new SCU IPC API drm/gma500: Get rid of duplicate NULL checks gpio: intel-mid: Remove driver for deprecated platform gpio: msic: Remove driver for deprecated platform platform/x86: intel_mid_thermal: Remove driver for deprecated platform platform/x86: intel_mid_powerbtn: Remove driver for deprecated platform rtc: mrst: Remove driver for deprecated platform watchdog: intel_scu_watchdog: Remove driver for deprecated platform watchdog: intel-mid_wdt: Postpone IRQ handler registration till SCU is ready platform/x86: intel_scu_wdt: Move driver from arch/x86 platform/x86: intel_scu_wdt: Drop SCU notification platform/x86: intel_scu_wdt: Get rid of custom x86 model comparison MAINTAINERS | 2 - arch/x86/platform/intel-mid/device_libs/Makefile | 1 - drivers/gpio/Kconfig | 14 - drivers/gpio/Makefile | 1 - drivers/gpio/TODO | 2 +- drivers/gpio/gpio-intel-mid.c | 414 --------------- drivers/gpio/gpio-msic.c | 314 ------------ drivers/gpu/drm/gma500/Kconfig | 1 + drivers/gpu/drm/gma500/mdfld_device.c | 2 - drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 - drivers/gpu/drm/gma500/mdfld_output.c | 8 +- drivers/gpu/drm/gma500/oaktrail_device.c | 3 - drivers/gpu/drm/gma500/psb_drv.h | 3 + drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 30 +- drivers/platform/x86/Kconfig | 23 +- drivers/platform/x86/Makefile | 3 +- drivers/platform/x86/intel_mid_powerbtn.c | 233 --------- drivers/platform/x86/intel_mid_thermal.c | 560 --------------------- .../platform/x86/intel_scu_wdt.c | 41 +- drivers/rtc/Kconfig | 12 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-mrst.c | 521 ------------------- drivers/watchdog/Kconfig | 9 - drivers/watchdog/Makefile | 1 - drivers/watchdog/intel-mid_wdt.c | 8 +- drivers/watchdog/intel_scu_watchdog.c | 533 -------------------- drivers/watchdog/intel_scu_watchdog.h | 50 -- 27 files changed, 54 insertions(+), 2738 deletions(-) delete mode 100644 drivers/gpio/gpio-intel-mid.c delete mode 100644 drivers/gpio/gpio-msic.c delete mode 100644 drivers/platform/x86/intel_mid_powerbtn.c delete mode 100644 drivers/platform/x86/intel_mid_thermal.c rename arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c => drivers/platform/x86/intel_scu_wdt.c (69%) delete mode 100644 drivers/rtc/rtc-mrst.c delete mode 100644 drivers/watchdog/intel_scu_watchdog.c delete mode 100644 drivers/watchdog/intel_scu_watchdog.h -- With Best Regards, Andy Shevchenko

6 20

[PATCH v14] staging: fbtft: add tearing signal detect
by Carlis 04 Feb '21

04 Feb '21

From: Carlis <zhangxuezhi1(a)yulong.com> For st7789v IC, when we need continuous full screen refresh, it is best to wait for the tearing effect line signal to arrive to avoid screen tearing. Signed-off-by: Carlis <zhangxuezhi1(a)yulong.com> --- v14: change to define TE completion and TE irq only in st7789v. v13: change TE completion to par data struct member and add a new function to deal te gpio request, add new write_vmem function. v12: change dev_err to dev_err_probe and add space in comments start, and delete te_mutex, change te wait logic. v11: remove devm_gpio_put and change a dev_err to dev_info. v10: additional notes. v9: change pr_* to dev_*. v8: delete a log line. v7: return error value when request fail. v6: add te gpio request fail deal logic. v5: fix log print. v4: modify some code style and change te irq set function name. v3: modify author and signed-off-by name. v2: add release te gpio after irq request fail. --- drivers/staging/fbtft/fb_st7789v.c | 115 +++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c index 3a280cc..ee8866d 100644 --- a/drivers/staging/fbtft/fb_st7789v.c +++ b/drivers/staging/fbtft/fb_st7789v.c @@ -7,9 +7,13 @@ #include <linux/bitops.h> #include <linux/delay.h> +#include <linux/gpio/consumer.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/interrupt.h> +#include <linux/completion.h> #include <linux/module.h> + #include <video/mipi_display.h> #include "fbtft.h" @@ -66,6 +70,62 @@ enum st7789v_command { #define MADCTL_MX BIT(6) /* bitmask for column address order */ #define MADCTL_MY BIT(7) /* bitmask for page address order */ +/* 60Hz for 16.6ms, configured as 2*16.6ms */ +#define PANEL_TE_TIMEOUT_MS 33 + +static struct completion panel_te; /* completion for panel TE line */ +static int irq_te; /* Linux IRQ for LCD TE line */ + +static irqreturn_t panel_te_handler(int irq, void *data) +{ + complete(&panel_te); + return IRQ_HANDLED; +} + +/* + * init_tearing_effect_line() - init tearing effect line. + * @par: FBTFT parameter object. + * + * Return: 0 on success, or a negative error code otherwise. + */ +static int init_tearing_effect_line(struct fbtft_par *par) +{ + struct device *dev = par->info->device; + struct gpio_desc *te; + int rc, irq; + + te = gpiod_get_optional(dev, "te", GPIOD_IN); + if (IS_ERR(te)) + return dev_err_probe(dev, PTR_ERR(te), "Failed to request te GPIO\n"); + + /* if te is NULL, indicating no configuration, directly return success */ + if (!te) { + irq_te = 0; + return 0; + } + + irq = gpiod_to_irq(te); + + /* GPIO is locked as an IRQ, we may drop the reference */ + gpiod_put(te); + + if (irq < 0) + return irq; + + irq_te = irq; + init_completion(&panel_te); + + /* The effective state is high and lasts no more than 1000 microseconds */ + rc = devm_request_irq(dev, irq_te, panel_te_handler, + IRQF_TRIGGER_RISING, "TE_GPIO", par); + if (rc) + return dev_err_probe(dev, rc, "TE IRQ request failed.\n"); + + disable_irq_nosync(irq_te); + + return 0; +} + /** * init_display() - initialize the display controller * @@ -82,6 +142,12 @@ enum st7789v_command { */ static int init_display(struct fbtft_par *par) { + int rc; + + rc = init_tearing_effect_line(par); + if (rc) + return rc; + /* turn off sleep mode */ write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE); mdelay(120); @@ -137,6 +203,10 @@ static int init_display(struct fbtft_par *par) */ write_reg(par, PWCTRL1, 0xA4, 0xA1); + /* TE line output is off by default when powering on */ + if (irq_te) + write_reg(par, MIPI_DCS_SET_TEAR_ON, 0x00); + write_reg(par, MIPI_DCS_SET_DISPLAY_ON); if (HSD20_IPS) @@ -145,6 +215,50 @@ static int init_display(struct fbtft_par *par) return 0; } +/* + * write_vmem() - write data to display. + * @par: FBTFT parameter object. + * @offset: offset from screen_buffer. + * @len: the length of data to be writte. + * + * Return: 0 on success, or a negative error code otherwise. + */ +static int write_vmem(struct fbtft_par *par, size_t offset, size_t len) +{ + struct device *dev = par->info->device; + int ret; + + if (irq_te) { + enable_irq(irq_te); + reinit_completion(&panel_te); + ret = wait_for_completion_timeout(&panel_te, + msecs_to_jiffies(PANEL_TE_TIMEOUT_MS)); + if (ret == 0) + dev_err(dev, "wait panel TE timeout\n"); + + disable_irq(irq_te); + } + + ret = 0; + switch (par->pdata->display.buswidth) { + case 8: + ret = fbtft_write_vmem16_bus8(par, offset, len); + break; + case 9: + ret = fbtft_write_vmem16_bus9(par, offset, len); + break; + case 16: + ret = fbtft_write_vmem16_bus16(par, offset, len); + break; + default: + dev_err(dev, "Unsupported buswidth %d\n", + par->pdata->display.buswidth); + break; + } + + return ret; +} + /** * set_var() - apply LCD properties like rotation and BGR mode * @@ -259,6 +373,7 @@ static int blank(struct fbtft_par *par, bool on) .gamma = HSD20_IPS_GAMMA, .fbtftops = { .init_display = init_display, + .write_vmem = write_vmem, .set_var = set_var, .set_gamma = set_gamma, .blank = blank, -- 1.9.1

1 0

[PATCH] drm/bridge/analogix: remove redundant when devm_kzalloc failed
by Bernard Zhao 04 Feb '21

04 Feb '21

Line 1590 DRM_ERROR is redundant because devm_kzalloc() already prints an error. Signed-off-by: Bernard Zhao <bernard(a)vivo.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index aa1bb86293fd..8f6258eb9960 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1586,10 +1586,8 @@ static int analogix_dp_create_bridge(struct drm_device *drm_dev, int ret; bridge = devm_kzalloc(drm_dev->dev, sizeof(*bridge), GFP_KERNEL); - if (!bridge) { - DRM_ERROR("failed to allocate for drm bridge\n"); + if (!bridge) return -ENOMEM; - } dp->bridge = bridge; -- 2.29.0

2 1

[PULL] drm-intel-fixes
by Jani Nikula 04 Feb '21

04 Feb '21

Hi Dave & Daniel - There's a bit more here than I'd generally like at this stage, however many of them are cc: stable anyway, and I've opted to include a couple of extra backports to allow the actual fixes to apply without conflicts instead of modifying the fixes. Hopefully things will calm down now, fingers crossed. drm-intel-fixes-2021-02-04: drm/i915 fixes for v5.11-rc7: - Skip vswing programming for TBT - Power up combo PHY lanes for HDMI - Fix double YUV range correction on HDR planes - Fix the MST PBN divider calculation - Fix LTTPR vswing/pre-emp setting in non-transparent mode - Move the breadcrumb to the signaler if completed upon cancel - Close race between enable_breadcrumbs and cancel_breadcrumbs - Drop lru bumping on display unpinning BR, Jani. The following changes since commit 1048ba83fb1c00cd24172e23e8263972f6b5d9ac: Linux 5.11-rc6 (2021-01-31 13:50:09 -0800) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2021-02-04 for you to fetch changes up to 88ebe1f572e284ecfe088648e0ae93803a75a459: drm/i915/dp: Fix LTTPR vswing/pre-emp setting in non-transparent mode (2021-02-02 17:31:37 +0200) ---------------------------------------------------------------- drm/i915 fixes for v5.11-rc7: - Skip vswing programming for TBT - Power up combo PHY lanes for HDMI - Fix double YUV range correction on HDR planes - Fix the MST PBN divider calculation - Fix LTTPR vswing/pre-emp setting in non-transparent mode - Move the breadcrumb to the signaler if completed upon cancel - Close race between enable_breadcrumbs and cancel_breadcrumbs - Drop lru bumping on display unpinning ---------------------------------------------------------------- Andres Calderon Jaramillo (1): drm/i915/display: Prevent double YUV range correction on HDR planes Chris Wilson (3): drm/i915/gt: Move the breadcrumb to the signaler if completed upon cancel drm/i915/gt: Close race between enable_breadcrumbs and cancel_breadcrumbs drm/i915/gem: Drop lru bumping on display unpinning Imre Deak (4): drm/dp/mst: Export drm_dp_get_vc_payload_bw() drm/i915: Fix the MST PBN divider calculation drm/i915/dp: Move intel_dp_set_signal_levels() to intel_dp_link_training.c drm/i915/dp: Fix LTTPR vswing/pre-emp setting in non-transparent mode Ville Syrjälä (3): drm/i915: Skip vswing programming for TBT drm/i915: Extract intel_ddi_power_up_lanes() drm/i915: Power up combo PHY lanes for for HDMI as well drivers/gpu/drm/drm_dp_mst_topology.c | 24 ++++++-- drivers/gpu/drm/i915/display/intel_ddi.c | 43 ++++++++------ drivers/gpu/drm/i915/display/intel_display.c | 9 ++- drivers/gpu/drm/i915/display/intel_dp.c | 20 +------ drivers/gpu/drm/i915/display/intel_dp.h | 3 - .../gpu/drm/i915/display/intel_dp_link_training.c | 25 ++++++++- .../gpu/drm/i915/display/intel_dp_link_training.h | 3 + drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 +- drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/intel_sprite.c | 65 ++++------------------ drivers/gpu/drm/i915/gem/i915_gem_domain.c | 45 --------------- drivers/gpu/drm/i915/gem/i915_gem_object.h | 1 - drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 47 +++++++++------- include/drm/drm_dp_mst_helper.h | 1 + 14 files changed, 118 insertions(+), 176 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

1 0

[PATCH] drm/fourcc: introduce DRM_FOURCC_STANDALONE guard
by Emil Velikov 04 Feb '21

04 Feb '21

Currently, the drm_fourcc.h header depends on drm.h for __u32 and __u64. At the same time drm.h pulls a lot of unneeded symbols. Add new guard DRM_FOURCC_STANDALONE, which when set will use local declaration of said symbols. When used on linux - this is a trivial but only when building in strict c99 mode. One is welcome to ignore the warning, silence it or use c11. If neither of the three is an option, then do _not_ set the new guard. Cc: James Park <james.park(a)lagfreegames.com> Cc: Pekka Paalanen <pekka.paalanen(a)collabora.com> Cc: Simon Ser <contact(a)emersion.fr> Signed-off-by: Emil Velikov <emil.l.velikov(a)gmail.com> --- As mentioned before - there's little point in having yet another header since keeping those in sync has been a PITA in the past. --- include/uapi/drm/drm_fourcc.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 6f0628eb13a6..c1522902f6c9 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -24,7 +24,26 @@ #ifndef DRM_FOURCC_H #define DRM_FOURCC_H +/* + * Define DRM_FOURCC_STANDALONE you're interested only FOURCC and do not want + * to pull drm.h into your application. + */ +#ifdef DRM_FOURCC_STANDALONE +#if defined(__linux__) + +#include <linux/types.h> + +#else /* One of the BSDs */ + +#include <stdint.h> +typedef uint32_t __u32; +typedef uint64_t __u64; + +#endif /* __linux __ */ + +#else #include "drm.h" +#endif /* DRM_FOURCC_STANDALONE */ #if defined(__cplusplus) extern "C" { -- 2.30.0

3 14

Re: [PATCH 01/13] powerpc/powernv: remove get_cxl_module
by Michael Ellerman 04 Feb '21

04 Feb '21

Christoph Hellwig <hch(a)lst.de> writes: > The static inline get_cxl_module function is entirely unused since commit > 8bf6b91a5125a ("Revert "powerpc/powernv: Add support for the cxl kernel > api on the real phb"), so remove it. > > Signed-off-by: Christoph Hellwig <hch(a)lst.de> > Reviewed-by: Andrew Donnellan <ajd(a)linux.ibm.com> > --- > arch/powerpc/platforms/powernv/pci-cxl.c | 22 ---------------------- > 1 file changed, 22 deletions(-) Acked-by: Michael Ellerman <mpe(a)ellerman.id.au> cheers

1 0

[PATCH][next] drm/i915/display: fix spelling mistake "Couldnt" -> "Couldn't"
by Colin King 04 Feb '21

04 Feb '21

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a drm_dbg message. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 8c12d5375607..a338720cee2e 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2650,7 +2650,7 @@ void intel_dp_check_frl_training(struct intel_dp *intel_dp) if (intel_dp_pcon_start_frl_training(intel_dp) < 0) { int ret, mode; - drm_dbg(&dev_priv->drm, "Couldnt set FRL mode, continuing with TMDS mode\n"); + drm_dbg(&dev_priv->drm, "Couldn't set FRL mode, continuing with TMDS mode\n"); ret = drm_dp_pcon_reset_frl_config(&intel_dp->aux); mode = drm_dp_pcon_hdmi_link_mode(&intel_dp->aux, NULL); -- 2.29.2

2 1

[PATCH v7 00/17] follow_pfn and other iomap races
by Daniel Vetter 04 Feb '21

04 Feb '21

Hi all Another update of my patch series to clamp down a bunch of races and gaps around follow_pfn and other access to iomem mmaps. Previous version: v1: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ff… v2: https://lore.kernel.org/dri-devel/20201009075934.3509076-1-daniel.vetter@ff… v3: https://lore.kernel.org/dri-devel/20201021085655.1192025-1-daniel.vetter@ff… v4: https://lore.kernel.org/dri-devel/20201026105818.2585306-1-daniel.vetter@ff… v5: https://lore.kernel.org/dri-devel/20201030100815.2269-1-daniel.vetter@ffwll… v6: https://lore.kernel.org/dri-devel/20201119144146.1045202-1-daniel.vetter@ff… And the discussion that sparked this journey: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ff… I think the first 12 patches are ready for landing. The parts starting with "mm: Add unsafe_follow_pfn" probably need more baking time. Andrew, can you please pick these up, or do you prefer I do a topic branch and send them to Linus directly in the next merge window? Changes in v7: - more acks/reviews - reordered with the ready pieces at the front - simplified the new follow_pfn function as Jason suggested Changes in v6: - Tested v4l userptr as Tomasz suggested. No boom observed - Added RFC for locking down follow_pfn, per discussion with Christoph and Jason. - Explain why pup_fast is safe in relevant patches, there was a bit a confusion when discussing v5. - Fix up the resource patch, with CONFIG_IO_STRICT_DEVMEM it crashed on boot due to an unintended change (reported by John) Changes in v5: - Tomasz found some issues in the media patches - Polish suggested by Christoph for the unsafe_follow_pfn patch Changes in v4: - Drop the s390 patch, that was very stand-alone and now queued up to land through s390 trees. - Comment polish per Dan's review. Changes in v3: - Bunch of polish all over, no functional changes aside from one barrier in the resource code, for consistency. - A few more r-b tags. Changes in v2: - tons of small polish&fixes all over, thanks to all the reviewers who spotted issues - I managed to test at least the generic_access_phys and pci mmap revoke stuff with a few gdb sessions using our i915 debug tools (hence now also the drm/i915 patch to properly request all the pci bar regions) - reworked approach for the pci mmap revoke: Infrastructure moved into kernel/resource.c, address_space mapping is now set up at open time for everyone (which required some sysfs changes). Does indeed look a lot cleaner and a lot less invasive than I feared at first. Coments and review on the remaining bits very much welcome, especially from the kvm and vfio side. Cheers, Daniel Daniel Vetter (17): drm/exynos: Stop using frame_vector helpers drm/exynos: Use FOLL_LONGTERM for g2d cmdlists misc/habana: Stop using frame_vector helpers misc/habana: Use FOLL_LONGTERM for userptr mm/frame-vector: Use FOLL_LONGTERM media: videobuf2: Move frame_vector into media subsystem mm: Close race in generic_access_phys PCI: Obey iomem restrictions for procfs mmap /dev/mem: Only set filp->f_mapping resource: Move devmem revoke code to resource framework sysfs: Support zapping of binary attr mmaps PCI: Revoke mappings like devmem mm: Add unsafe_follow_pfn media/videobuf1|2: Mark follow_pfn usage as unsafe vfio/type1: Mark follow_pfn as unsafe kvm: pass kvm argument to follow_pfn callsites mm: add mmu_notifier argument to follow_pfn arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- arch/powerpc/kvm/e500_mmu_host.c | 2 +- arch/x86/kvm/mmu/mmu.c | 8 +- drivers/char/mem.c | 86 +------------- drivers/gpu/drm/exynos/Kconfig | 1 - drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++---- drivers/media/common/videobuf2/Kconfig | 1 - drivers/media/common/videobuf2/Makefile | 1 + .../media/common/videobuf2}/frame_vector.c | 57 ++++----- .../media/common/videobuf2/videobuf2-memops.c | 3 +- drivers/media/platform/omap/Kconfig | 1 - drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- drivers/misc/habanalabs/Kconfig | 1 - drivers/misc/habanalabs/common/habanalabs.h | 6 +- drivers/misc/habanalabs/common/memory.c | 52 +++----- drivers/pci/pci-sysfs.c | 4 + drivers/pci/proc.c | 6 + drivers/vfio/vfio_iommu_type1.c | 4 +- fs/sysfs/file.c | 11 ++ include/linux/ioport.h | 6 +- include/linux/kvm_host.h | 9 +- include/linux/mm.h | 50 +------- include/linux/sysfs.h | 2 + include/media/frame_vector.h | 47 ++++++++ include/media/videobuf2-core.h | 1 + kernel/resource.c | 98 ++++++++++++++- mm/Kconfig | 3 - mm/Makefile | 1 - mm/memory.c | 112 +++++++++++++++--- mm/nommu.c | 16 ++- security/Kconfig | 13 ++ virt/kvm/kvm_main.c | 56 +++++---- 33 files changed, 413 insertions(+), 299 deletions(-) rename {mm => drivers/media/common/videobuf2}/frame_vector.c (84%) create mode 100644 include/media/frame_vector.h -- 2.29.2

7 31

← Newer
1
...
56
57
58
59
60
61
62
...
69
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2021