dri-devel February 2021

dri-devel@lists.freedesktop.org

314 participants
684 discussions

Re: [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE
by Miroslav Benes 02 Feb '21

02 Feb '21

On Tue, 2 Feb 2021, Christoph Hellwig wrote: > As far as I can tell this has never been used at all, and certainly > not any time recently. Right, I've always wondered about this one. > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Miroslav Benes <mbenes(a)suse.cz> M

1 0

[PATCH v4 00/13] drm: Support short-term vmap via vmap_local
by Thomas Zimmermann 02 Feb '21

02 Feb '21

GEM VRAM helpers used to pin the BO in their implementation of vmap, so that they could not be relocated. In recent discussions, [1][2] it became clear that this is incorrect for in-kernel use cases, such as fbdev emulation; which should rather depend on the reservation lock to prevent relocation. This patchset addresses the issue by introducing the new interfaces vmap_local and vunmap_local throughout dma-buf and GEM. It further adds support to DRM's CMA, SHMEM and VRAM helpers and finally converts fbdev emulation to the new interface. Patches 1 and 2 add the vmap_local infrastructure throughout dma-buf, GEM and PRIME. Patches 3 to 11 add implementations of vmap_local to DRM's various GEM helper libraries. Due to the simple nature of these libraries, existing vmap code can be reused easily. Several drivers are updated as well to use the new interfaces. Patch 12 converts generic fbdev emulation to use vmap_local. Only DRM drivers that use GEM helpers currently use fbdev emulation, so patches 3 to 11 covered all necessary instances. Finally patch 13 removes drm_gem_vram_vmap() functionality, which is now unused. I smoke-tested the patchset with ast (VRAM helpers), mgag200 (SHMEM) and vc4 (CMA). I also tested with a version of radeon (raw TTM) that had been converted to generic fbdev emulation. v4: * move driver changes out of SHMEM and VRAM patches (Daniel) * call dma_buf_vmap_local() in SHMEM implementation (Daniel) * remove unused drm_gem_vram_vmap() functionality * update documentation (Daniel) v3: * rewrite patchset around vmap_local v2: * make importers acquire resv locks by themselves * document dma-buf vmap/vunmap ops [1] https://patchwork.freedesktop.org/patch/400054/?series=83765&rev=1 [2] https://patchwork.freedesktop.org/patch/405407/?series=84401&rev=2 Thomas Zimmermann (13): dma-buf: Add vmap_local and vnumap_local operations drm/gem: Create infrastructure for GEM vmap_local drm/cma-helper: Provide a vmap function for short-term mappings drm/shmem-helper: Provide a vmap function for short-term mappings drm/mgag200: Use drm_gem_shmem_vmap_local() in damage handling drm/cirrus: Use drm_gem_shmem_vmap_local() in damage handling drm/gm12u320: Use drm_gem_shmem_vmap_local() in damage handling drm/udl: Use drm_gem_shmem_vmap_local() in damage handling drm/vram-helper: Provide a vmap function for short-term mappings drm/ast: Use drm_gem_vram_vmap_local() in cursor update drm/vboxvideo: Use drm_gem_vram_vmap_local() in cursor update drm/fb-helper: Move BO locking from DRM client to fbdev damage worker drm/vram-helper: Remove unused drm_gem_vram_{vmap,vunmap}() drivers/dma-buf/dma-buf.c | 81 ++++++++++++++ drivers/gpu/drm/ast/ast_cursor.c | 37 +++++-- drivers/gpu/drm/drm_client.c | 94 +++++++++++++++++ drivers/gpu/drm/drm_fb_helper.c | 41 ++++---- drivers/gpu/drm/drm_gem.c | 28 +++++ drivers/gpu/drm/drm_gem_cma_helper.c | 27 +++++ drivers/gpu/drm/drm_gem_shmem_helper.c | 90 ++++++++++++++-- drivers/gpu/drm/drm_gem_vram_helper.c | 139 ++++++++----------------- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_prime.c | 39 +++++++ drivers/gpu/drm/mgag200/mgag200_mode.c | 16 ++- drivers/gpu/drm/tiny/cirrus.c | 10 +- drivers/gpu/drm/tiny/gm12u320.c | 14 ++- drivers/gpu/drm/udl/udl_modeset.c | 18 ++-- drivers/gpu/drm/vboxvideo/vbox_mode.c | 15 +-- drivers/gpu/drm/vc4/vc4_bo.c | 1 + drivers/gpu/drm/virtio/virtgpu_prime.c | 2 + include/drm/drm_client.h | 4 + include/drm/drm_gem.h | 21 ++++ include/drm/drm_gem_cma_helper.h | 1 + include/drm/drm_gem_shmem_helper.h | 2 + include/drm/drm_gem_vram_helper.h | 4 +- include/drm/drm_prime.h | 2 + include/linux/dma-buf.h | 34 ++++++ 24 files changed, 566 insertions(+), 156 deletions(-) -- 2.29.2

3 31

Re: [PATCH 11/13] module: move struct symsearch to module.c
by Miroslav Benes 02 Feb '21

02 Feb '21

On Tue, 2 Feb 2021, Christoph Hellwig wrote: > struct symsearch is only used inside of module.h, so move the definition > out of module.h. > > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Miroslav Benes <mbenes(a)suse.cz> M

1 0

Re: [PATCH 10/13] module: pass struct find_symbol_args to find_symbol
by Miroslav Benes 02 Feb '21

02 Feb '21

> void *__symbol_get(const char *symbol) > { > - struct module *owner; > - const struct kernel_symbol *sym; > + struct find_symbol_arg fsa = { > + .name = symbol, > + .gplok = true, > + .warn = true, > + }; > > preempt_disable(); > - sym = find_symbol(symbol, &owner, NULL, NULL, true, true); > - if (sym && strong_try_module_get(owner)) > - sym = NULL; > + if (!find_symbol(&fsa) || !strong_try_module_get(fsa.owner)) { I think this should be in fact if (!find_symbol(&fsa) || strong_try_module_get(fsa.owner)) { to get the logic right (note the missing !). We want to return NULL if strong_try_module_get() does not succeed for a found symbol. > + preempt_enable(); > + return NULL; > + } > preempt_enable(); > - > - return sym ? (void *)kernel_symbol_value(sym) : NULL; > + return (void *)kernel_symbol_value(fsa.sym); > } > EXPORT_SYMBOL_GPL(__symbol_get); Miroslav

1 0

Re: [PATCH 09/13] module: merge each_symbol_section into find_symbol
by Miroslav Benes 02 Feb '21

02 Feb '21

On Tue, 2 Feb 2021, Christoph Hellwig wrote: > each_symbol_section is only called by find_symbol, so merge the two > functions. > > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Miroslav Benes <mbenes(a)suse.cz> M

1 0

Re: [PATCH 08/13] module: remove each_symbol_in_section
by Miroslav Benes 02 Feb '21

02 Feb '21

On Tue, 2 Feb 2021, Christoph Hellwig wrote: > each_symbol_in_section just contains a trivial loop over its arguments. > Just open code the loop in the two callers. > > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Miroslav Benes <mbenes(a)suse.cz> M

1 0

Re: [PATCH 07/13] module: mark module_mutex static
by Miroslav Benes 02 Feb '21

02 Feb '21

On Tue, 2 Feb 2021, Christoph Hellwig wrote: > Except for two lockdep asserts module_mutex is only used in module.c. > Remove the two asserts given that the functions they are in are not > exported and just called from the module code, and mark module_mutex > static. > > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Miroslav Benes <mbenes(a)suse.cz> M

1 0

Re: [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol when required
by Miroslav Benes 02 Feb '21

02 Feb '21

On Tue, 2 Feb 2021, Christoph Hellwig wrote: > kallsyms_on_each_symbol and module_kallsyms_on_each_symbol are only used > by the livepatching code, so don't build them if livepatching is not > enabled. > > Signed-off-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Miroslav Benes <mbenes(a)suse.cz> M

1 0

[PATCH v6 0/5] drm: Move struct drm_device.pdev to legacy
by Thomas Zimmermann 02 Feb '21

02 Feb '21

V6 of the patchset fixes i915/selftests to do the assigment of pdev in a later patch. This was forgotten in v5. The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic device stored in struct drm_device.dev. To reduce duplication and remove the special case of PCI, this patchset converts all modesetting drivers from pdev to dev and makes pdev a field for legacy UMS drivers. For PCI devices, the pointer in struct drm_device.dev can be upcasted to struct pci_device; or tested for PCI with dev_is_pci(). In several places the code can use the dev field directly. After converting all drivers and the DRM core, the pdev fields becomes only relevant for legacy drivers. In a later patchset, we may want to convert these as well and remove pdev entirely. v6: * also remove assignment in i915/selftests in later patch (Chris) v5: * remove assignment in later patch (Chris) v4: * merged several patches * moved core changes into separate patch * vmwgfx build fix v3: * merged several patches * fix one pdev reference in nouveau (Jeremy) * rebases v2: * move whitespace fixes into separate patches (Alex, Sam) * move i915 gt/ and gvt/ changes into separate patches (Joonas) Thomas Zimmermann (5): drm/i915: Remove references to struct drm_device.pdev drm/i915/gt: Remove references to struct drm_device.pdev drm/i915/gvt: Remove references to struct drm_device.pdev drm/i915: Don't assign to struct drm_device.pdev drm: Move struct drm_device.pdev to legacy section drivers/gpu/drm/i915/display/intel_bios.c | 2 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 14 ++++++------- drivers/gpu/drm/i915/display/intel_csr.c | 2 +- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 2 +- .../gpu/drm/i915/display/intel_lpe_audio.c | 5 +++-- drivers/gpu/drm/i915/display/intel_opregion.c | 6 +++--- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.c | 4 ++-- drivers/gpu/drm/i915/display/intel_quirks.c | 2 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +- drivers/gpu/drm/i915/display/intel_vga.c | 8 ++++---- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 6 +++--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 10 +++++----- drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_reset.c | 6 +++--- drivers/gpu/drm/i915/gvt/cfg_space.c | 5 +++-- drivers/gpu/drm/i915/gvt/firmware.c | 10 +++++----- drivers/gpu/drm/i915/gvt/gtt.c | 12 +++++------ drivers/gpu/drm/i915/gvt/gvt.c | 6 +++--- drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ++-- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 20 +++++++++---------- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++--- drivers/gpu/drm/i915/i915_getparam.c | 5 +++-- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- drivers/gpu/drm/i915/i915_pmu.c | 2 +- drivers/gpu/drm/i915/i915_suspend.c | 4 ++-- drivers/gpu/drm/i915/i915_switcheroo.c | 4 ++-- drivers/gpu/drm/i915/i915_vgpu.c | 2 +- drivers/gpu/drm/i915/intel_device_info.c | 2 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- .../gpu/drm/i915/selftests/mock_gem_device.c | 1 - drivers/gpu/drm/i915/selftests/mock_gtt.c | 2 +- include/drm/drm_device.h | 6 +++--- 43 files changed, 100 insertions(+), 101 deletions(-) base-commit: 3836b7fdfad40e2bac5dc882332f42bed6942cf4 prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d -- 2.30.0

2 6

[PULL] drm-misc-fixes
by Thomas Zimmermann 02 Feb '21

02 Feb '21

Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. There are 3 patches for the bridge code and one for TTM. Best regards Thomas drm-misc-fixes-2021-02-02: * drm/bridge/lontium-lt9611uxc: EDID fixes; Don't handle hotplug events in IRQ handler * drm/ttm: Use _GFP_NOWARN for huge pages The following changes since commit f6b57101a6b31277a4bde1d8028c46e898bd2ff2: drm/vc4: Correct POS1_SCL for hvs5 (2021-01-25 11:53:44 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-fixes-2021-02-02 for you to fetch changes up to 2b1b3e544f65f40df5eef99753e460a127910479: drm/ttm: Use __GFP_NOWARN for huge pages in ttm_pool_alloc_page (2021-01-28 13:01:52 +0100) ---------------------------------------------------------------- * drm/bridge/lontium-lt9611uxc: EDID fixes; Don't handle hotplug events in IRQ handler * drm/ttm: Use _GFP_NOWARN for huge pages ---------------------------------------------------------------- Dmitry Baryshkov (3): drm/bridge/lontium-lt9611uxc: fix waiting for EDID to become available drm/bridge/lontium-lt9611uxc: fix get_edid return code drm/bridge/lontium-lt9611uxc: move HPD notification out of IRQ handler Michel Dänzer (1): drm/ttm: Use __GFP_NOWARN for huge pages in ttm_pool_alloc_page drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 57 +++++++++++++++++++++++------- drivers/gpu/drm/ttm/ttm_pool.c | 2 +- 2 files changed, 46 insertions(+), 13 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer

1 0

← Newer
1
...
62
63
64
65
66
67
68
69
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel February 2021