dri-devel April 2021

dri-devel@lists.freedesktop.org

317 participants
715 discussions

[PATCH v5 00/21] Host1x/TegraDRM UAPI
by Mikko Perttunen 08 Apr '21

08 Apr '21

Hi all, here's the fifth revision of the Host1x/TegraDRM UAPI proposal, containing primarily small bug fixes. It has also been rebased on top of recent linux-next. vaapi-tegra-driver has been updated to support the new UAPI as well as Tegra186: https://github.com/cyndis/vaapi-tegra-driver The `putsurface` program has been tested to work. The test suite for the new UAPI is available at https://github.com/cyndis/uapi-test The series can be also found in https://github.com/cyndis/linux/commits/work/host1x-uapi-v5. Older versions: v1: https://www.spinics.net/lists/linux-tegra/msg51000.html v2: https://www.spinics.net/lists/linux-tegra/msg53061.html v3: https://www.spinics.net/lists/linux-tegra/msg54370.html v4: https://www.spinics.net/lists/dri-devel/msg279897.html Thank you, Mikko Mikko Perttunen (21): gpu: host1x: Use different lock classes for each client gpu: host1x: Allow syncpoints without associated client gpu: host1x: Show number of pending waiters in debugfs gpu: host1x: Remove cancelled waiters immediately gpu: host1x: Use HW-equivalent syncpoint expiration check gpu: host1x: Cleanup and refcounting for syncpoints gpu: host1x: Introduce UAPI header gpu: host1x: Implement /dev/host1x device node gpu: host1x: DMA fences and userspace fence creation gpu: host1x: Add no-recovery mode gpu: host1x: Add job release callback gpu: host1x: Add support for syncpoint waits in CDMA pushbuffer gpu: host1x: Reset max value when freeing a syncpoint gpu: host1x: Reserve VBLANK syncpoints at initialization drm/tegra: Add new UAPI to header drm/tegra: Boot VIC during runtime PM resume drm/tegra: Set resv fields when importing/exporting GEMs drm/tegra: Allocate per-engine channel in core code drm/tegra: Implement new UAPI drm/tegra: Implement job submission part of new UAPI drm/tegra: Add job firewall drivers/gpu/drm/tegra/Makefile | 4 + drivers/gpu/drm/tegra/dc.c | 10 +- drivers/gpu/drm/tegra/drm.c | 69 ++-- drivers/gpu/drm/tegra/drm.h | 9 + drivers/gpu/drm/tegra/gem.c | 2 + drivers/gpu/drm/tegra/gr2d.c | 4 +- drivers/gpu/drm/tegra/gr3d.c | 4 +- drivers/gpu/drm/tegra/uapi.h | 63 ++++ drivers/gpu/drm/tegra/uapi/firewall.c | 221 +++++++++++++ drivers/gpu/drm/tegra/uapi/gather_bo.c | 86 +++++ drivers/gpu/drm/tegra/uapi/gather_bo.h | 22 ++ drivers/gpu/drm/tegra/uapi/submit.c | 436 +++++++++++++++++++++++++ drivers/gpu/drm/tegra/uapi/submit.h | 21 ++ drivers/gpu/drm/tegra/uapi/uapi.c | 307 +++++++++++++++++ drivers/gpu/drm/tegra/vic.c | 118 ++++--- drivers/gpu/host1x/Makefile | 2 + drivers/gpu/host1x/bus.c | 7 +- drivers/gpu/host1x/cdma.c | 69 +++- drivers/gpu/host1x/debug.c | 14 +- drivers/gpu/host1x/dev.c | 15 + drivers/gpu/host1x/dev.h | 16 +- drivers/gpu/host1x/fence.c | 208 ++++++++++++ drivers/gpu/host1x/fence.h | 13 + drivers/gpu/host1x/hw/cdma_hw.c | 2 +- drivers/gpu/host1x/hw/channel_hw.c | 63 ++-- drivers/gpu/host1x/hw/debug_hw.c | 11 +- drivers/gpu/host1x/intr.c | 32 +- drivers/gpu/host1x/intr.h | 6 +- drivers/gpu/host1x/job.c | 79 +++-- drivers/gpu/host1x/job.h | 14 + drivers/gpu/host1x/syncpt.c | 187 ++++++----- drivers/gpu/host1x/syncpt.h | 16 +- drivers/gpu/host1x/uapi.c | 385 ++++++++++++++++++++++ drivers/gpu/host1x/uapi.h | 22 ++ drivers/staging/media/tegra-video/vi.c | 4 +- include/linux/host1x.h | 47 ++- include/uapi/drm/tegra_drm.h | 338 +++++++++++++++++-- include/uapi/linux/host1x.h | 134 ++++++++ 38 files changed, 2771 insertions(+), 289 deletions(-) create mode 100644 drivers/gpu/drm/tegra/uapi.h create mode 100644 drivers/gpu/drm/tegra/uapi/firewall.c create mode 100644 drivers/gpu/drm/tegra/uapi/gather_bo.c create mode 100644 drivers/gpu/drm/tegra/uapi/gather_bo.h create mode 100644 drivers/gpu/drm/tegra/uapi/submit.c create mode 100644 drivers/gpu/drm/tegra/uapi/submit.h create mode 100644 drivers/gpu/drm/tegra/uapi/uapi.c create mode 100644 drivers/gpu/host1x/fence.c create mode 100644 drivers/gpu/host1x/fence.h create mode 100644 drivers/gpu/host1x/uapi.c create mode 100644 drivers/gpu/host1x/uapi.h create mode 100644 include/uapi/linux/host1x.h -- 2.30.0

7 96

[PATCH v2 -next] phy: phy-mtk-mipi-dsi: Remove redundant dev_err call in mtk_mipi_tx_probe()
by He Ying 08 Apr '21

08 Apr '21

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reviewed-by: Chunfeng Yun <chunfeng.yun(a)mediatek.com> Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: He Ying <heying24(a)huawei.com> --- v2: - Use 'return PTR_ERR();' instead of 'ret = PTR_ERR();return ret;'. drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index c51114d8e437..01cf31633019 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c @@ -151,9 +151,7 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev) mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); mipi_tx->regs = devm_ioremap_resource(dev, mem); if (IS_ERR(mipi_tx->regs)) { - ret = PTR_ERR(mipi_tx->regs); - dev_err(dev, "Failed to get memory resource: %d\n", ret); - return ret; + return PTR_ERR(mipi_tx->regs); } ref_clk = devm_clk_get(dev, NULL); -- 2.17.1

1 0

[PATCH 0/3] switch to unsafe_follow_pfn
by Daniel Vetter 08 Apr '21

08 Apr '21

Hi all, This are the leftovers from my pull that landed in 5.12: https://lore.kernel.org/dri-devel/CAKMK7uHQ=6OJcRguCUtiB456RWdCfwSNEXV8pQsf… Only changes compared to the old submission are: - dropped vfio and kvm patch - add patch to just remove follow_pfn at the end Assuming no objections I'd like to lande these three patches in my topic branch for 5.13, for sufficient amounts of testing in linux-next before the merge window. Ack/review especially on the two mm patches very much thought after. Cheers, Daniel Daniel Vetter (3): mm: Add unsafe_follow_pfn media/videobuf1|2: Mark follow_pfn usage as unsafe mm: unexport follow_pfn drivers/media/common/videobuf2/frame_vector.c | 2 +- drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- include/linux/mm.h | 4 +- mm/memory.c | 46 ++++++++++++------- mm/nommu.c | 28 ++++++++--- security/Kconfig | 13 ++++++ 6 files changed, 68 insertions(+), 27 deletions(-) -- 2.30.0

4 12

[RESEND 00/25] Rid W=1 warnings from HID
by Lee Jones 08 Apr '21

08 Apr '21

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' HID: intel-ish: Supply some missing param descriptions HID: intel-ish: Fix a naming disparity and a formatting error HID: usbhid: Repair a formatting issue in a struct description HID: intel-ish-hid: Fix a little doc-rot HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses HID: hid-alps: Correct struct misnaming HID: intel-ish-hid: Fix potential copy/paste error HID: hid-core: Fix incorrect function name in header HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() HID: hid-kye: Fix incorrect function name for kye_tablet_enable() HID: hid-picolcd_core: Remove unused variable 'ret' HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers HID: hid-sensor-custom: Remove unused variable 'ret' HID: wacom_sys: Demote kernel-doc abuse HID: hid-sensor-hub: Remove unused struct member 'quirks' HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning drivers/hid/hid-alps.c | 2 +- drivers/hid/hid-core.c | 2 +- drivers/hid/hid-kye.c | 2 +- drivers/hid/hid-logitech-hidpp.c | 7 +-- drivers/hid/hid-picolcd_core.c | 5 +-- drivers/hid/hid-sensor-custom.c | 5 +-- drivers/hid/hid-sensor-hub.c | 4 +- drivers/hid/hid-thrustmaster.c | 24 +++++------ drivers/hid/hid-uclogic-params.c | 8 ++-- drivers/hid/hid-uclogic-rdesc.c | 2 +- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++---------- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++-- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +--- drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++- drivers/hid/intel-ish-hid/ishtp/client.c | 5 +-- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +- drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +- drivers/hid/usbhid/hid-pidff.c | 4 +- drivers/hid/usbhid/usbkbd.c | 2 +- drivers/hid/wacom_sys.c | 2 +- include/linux/intel-ish-client-if.h | 8 +++- 24 files changed, 90 insertions(+), 81 deletions(-) Cc: Alexandre Torgue <alexandre.torgue(a)foss.st.com> Cc: Anssi Hannula <anssi.hannula(a)gmail.com> Cc: Benjamin Tissoires <benjamin.tissoires(a)redhat.com> Cc: "Bruno Prémont" <bonbons(a)linux-vserver.org> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: Daniel Drubin <daniel.drubin(a)intel.com> Cc: Dario Pagani <dario.pagani.146+linuxk(a)gmail.com> Cc: dri-devel(a)lists.freedesktop.org Cc: Henrik Rydberg <rydberg(a)bitmath.org> Cc: Jiri Kosina <jikos(a)kernel.org> Cc: Jonathan Cameron <jic23(a)kernel.org> Cc: Kai-Heng Feng <kai.heng.feng(a)canonical.com> Cc: Kim Kuparinen <kimi.h.kuparinen(a)gmail.com> Cc: "Krzysztof Wilczyński" <kw(a)linux.com> Cc: Lee Jones <lee.jones(a)linaro.org> Cc: linaro-mm-sig(a)lists.linaro.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-iio(a)vger.kernel.org Cc: linux-input(a)vger.kernel.org Cc: linux-media(a)vger.kernel.org Cc: linux-stm32(a)st-md-mailman.stormreply.com Cc: linux-usb(a)vger.kernel.org Cc: Lopez Casado <nlopezcasad(a)logitech.com> Cc: "L. Vinyard, Jr" <rvinyard(a)cs.nmsu.edu> Cc: Masaki Ota <masaki.ota(a)jp.alps.com> Cc: Maxime Coquelin <mcoquelin.stm32(a)gmail.com> Cc: message to <vojtech(a)ucw.cz> Cc: Michael Haboustak <mike-(a)cinci.rr.com> Cc: Rushikesh S Kadam <rushikesh.s.kadam(a)intel.com> Cc: Srinivas Pandruvada <srinivas.pandruvada(a)linux.intel.com> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: "Uwe Kleine-König" <uwe(a)kleine-koenig.org> Cc: Vojtech Pavlik <vojtech(a)suse.cz> Cc: Zhang Lixu <lixu.zhang(a)intel.com> -- 2.27.0

2 6

[PATCH] drm/syncobj: use newly allocated stub fences
by David Stevens 08 Apr '21

08 Apr '21

From: David Stevens <stevensd(a)chromium.org> Allocate a new private stub fence in drm_syncobj_assign_null_handle, instead of using a static stub fence. When userspace creates a fence with DRM_SYNCOBJ_CREATE_SIGNALED or when userspace signals a fence via DRM_IOCTL_SYNCOBJ_SIGNAL, the timestamp obtained when the fence is exported and queried with SYNC_IOC_FILE_INFO should match when the fence's status was changed from the perspective of userspace, which is during the respective ioctl. When a static stub fence started being used in by these ioctls, this behavior changed. Instead, the timestamp returned by SYNC_IOC_FILE_INFO became the first time anything used the static stub fence, which has no meaning to userspace. Signed-off-by: David Stevens <stevensd(a)chromium.org> --- drivers/dma-buf/dma-fence.c | 33 ++++++++++++++++++++++++++++++++- drivers/gpu/drm/drm_syncobj.c | 28 ++++++++++++++++++++-------- include/linux/dma-fence.h | 1 + 3 files changed, 53 insertions(+), 9 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index d64fc03929be..6081eb962490 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -26,6 +26,11 @@ EXPORT_TRACEPOINT_SYMBOL(dma_fence_signaled); static DEFINE_SPINLOCK(dma_fence_stub_lock); static struct dma_fence dma_fence_stub; +struct drm_fence_private_stub { + struct dma_fence base; + spinlock_t lock; +}; + /* * fence context counter: each execution context should have its own * fence context, this allows checking if fences belong to the same @@ -123,7 +128,9 @@ static const struct dma_fence_ops dma_fence_stub_ops = { /** * dma_fence_get_stub - return a signaled fence * - * Return a stub fence which is already signaled. + * Return a stub fence which is already signaled. The fence's + * timestamp corresponds to the first time after boot this + * function is called. */ struct dma_fence *dma_fence_get_stub(void) { @@ -141,6 +148,30 @@ struct dma_fence *dma_fence_get_stub(void) } EXPORT_SYMBOL(dma_fence_get_stub); +/** + * dma_fence_allocate_private_stub - return a private, signaled fence + * + * Return a newly allocated and signaled stub fence. + */ +struct dma_fence *dma_fence_allocate_private_stub(void) +{ + struct drm_fence_private_stub *fence; + + fence = kzalloc(sizeof(*fence), GFP_KERNEL); + if (fence == NULL) + return ERR_PTR(-ENOMEM); + + spin_lock_init(&fence->lock); + dma_fence_init(&fence->base, + &dma_fence_stub_ops, + &fence->lock, + 0, 0); + dma_fence_signal(&fence->base); + + return &fence->base; +} +EXPORT_SYMBOL(dma_fence_allocate_private_stub); + /** * dma_fence_context_alloc - allocate an array of fence contexts * @num: amount of contexts to allocate diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 349146049849..c6125e57ae37 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -350,12 +350,15 @@ EXPORT_SYMBOL(drm_syncobj_replace_fence); * * Assign a already signaled stub fence to the sync object. */ -static void drm_syncobj_assign_null_handle(struct drm_syncobj *syncobj) +static int drm_syncobj_assign_null_handle(struct drm_syncobj *syncobj) { - struct dma_fence *fence = dma_fence_get_stub(); + struct dma_fence *fence = dma_fence_allocate_private_stub(); + if (IS_ERR(fence)) + return PTR_ERR(fence); - drm_syncobj_replace_fence(syncobj, fence); - dma_fence_put(fence); + drm_syncobj_replace_fence(syncobj, fence); + dma_fence_put(fence); + return 0; } /* 5s default for wait submission */ @@ -469,6 +472,7 @@ EXPORT_SYMBOL(drm_syncobj_free); int drm_syncobj_create(struct drm_syncobj **out_syncobj, uint32_t flags, struct dma_fence *fence) { + int ret; struct drm_syncobj *syncobj; syncobj = kzalloc(sizeof(struct drm_syncobj), GFP_KERNEL); @@ -479,8 +483,13 @@ int drm_syncobj_create(struct drm_syncobj **out_syncobj, uint32_t flags, INIT_LIST_HEAD(&syncobj->cb_list); spin_lock_init(&syncobj->lock); - if (flags & DRM_SYNCOBJ_CREATE_SIGNALED) - drm_syncobj_assign_null_handle(syncobj); + if (flags & DRM_SYNCOBJ_CREATE_SIGNALED) { + ret = drm_syncobj_assign_null_handle(syncobj); + if (ret < 0) { + drm_syncobj_put(syncobj); + return ret; + } + } if (fence) drm_syncobj_replace_fence(syncobj, fence); @@ -1322,8 +1331,11 @@ drm_syncobj_signal_ioctl(struct drm_device *dev, void *data, if (ret < 0) return ret; - for (i = 0; i < args->count_handles; i++) - drm_syncobj_assign_null_handle(syncobjs[i]); + for (i = 0; i < args->count_handles; i++) { + ret = drm_syncobj_assign_null_handle(syncobjs[i]); + if (ret < 0) + break; + } drm_syncobj_array_free(syncobjs, args->count_handles); diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index 9f12efaaa93a..6ffb4b2c6371 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-fence.h @@ -587,6 +587,7 @@ static inline signed long dma_fence_wait(struct dma_fence *fence, bool intr) } struct dma_fence *dma_fence_get_stub(void); +struct dma_fence *dma_fence_allocate_private_stub(void); u64 dma_fence_context_alloc(unsigned num); #define DMA_FENCE_TRACE(f, fmt, args...) \ -- 2.31.0.208.g409f899ff0-goog

3 3

[PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers
by Thomas Zimmermann 08 Apr '21

08 Apr '21

The implementation of drm_driver.dumb_map_offset is the same for several TTM-based drivers. Provide a common function in GEM-TTM helpers. Thomas Zimmermann (4): drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset drm/vram-helper: Use drm_gem_ttm_dumb_map_offset() drm/nouveau: Use drm_gem_ttm_dumb_map_offset() drm/qxl: Use drm_gem_ttm_dumb_map_offset() drivers/gpu/drm/drm_gem_ttm_helper.c | 33 ++++++++++++++++ drivers/gpu/drm/drm_gem_vram_helper.c | 48 ----------------------- drivers/gpu/drm/nouveau/nouveau_display.c | 18 --------- drivers/gpu/drm/nouveau/nouveau_display.h | 2 - drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +- drivers/gpu/drm/qxl/qxl_drv.c | 3 +- drivers/gpu/drm/qxl/qxl_drv.h | 3 -- drivers/gpu/drm/qxl/qxl_dumb.c | 17 -------- drivers/gpu/drm/qxl/qxl_ioctl.c | 4 +- drivers/gpu/drm/qxl/qxl_object.h | 5 --- include/drm/drm_gem_ttm_helper.h | 5 ++- include/drm/drm_gem_vram_helper.h | 7 +--- 12 files changed, 45 insertions(+), 103 deletions(-) -- 2.30.2

4 9

[PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock
by Huang Guobin 08 Apr '21

08 Apr '21

From: Guobin Huang <huangguobin4(a)huawei.com> spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Guobin Huang <huangguobin4(a)huawei.com> --- drivers/gpu/drm/gma500/power.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c index 56ef88237ef6..f07641dfa5a4 100644 --- a/drivers/gpu/drm/gma500/power.c +++ b/drivers/gpu/drm/gma500/power.c @@ -36,7 +36,7 @@ #include <linux/pm_runtime.h> static struct mutex power_mutex; /* Serialize power ops */ -static spinlock_t power_ctrl_lock; /* Serialize power claim */ +static DEFINE_SPINLOCK(power_ctrl_lock); /* Serialize power claim */ /** * gma_power_init - initialise power manager @@ -55,7 +55,6 @@ void gma_power_init(struct drm_device *dev) dev_priv->display_power = true; /* We start active */ dev_priv->display_count = 0; /* Currently no users */ dev_priv->suspended = false; /* And not suspended */ - spin_lock_init(&power_ctrl_lock); mutex_init(&power_mutex); if (dev_priv->ops->init_pm)

2 1

[PATCH v8 0/2] gpu: drm: add driver for ili9361 panel
by Daniel Mack 08 Apr '21

08 Apr '21

This is v3 of the series. Changelog: v2 -> v3: * Turn Documentation into yaml format v3 -> v4: * Fix reference error in yaml file v4 -> v5: * More yaml file documentation fixes v5 -> v6: * More yaml file documentation fixes v6 -> v7: * Fix ordering of patches v7 -> v8: * More yaml file documentation fixes Daniel Mack (2): dt-bindings: display: add bindings for newhaven,1.8-128160EF drm/tiny: add driver for newhaven,1.8-128160EF .../display/panel/ilitek,ili9163.yaml | 69 +++++++++++++++++++ drivers/gpu/drm/tiny/Kconfig | 13 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9163.c | 224 ++++++++++++++++++ 4 files changed, 307 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9163.yaml create mode 100644 drivers/gpu/drm/tiny/ili9163.c -- 2.29.2

3 4

[PATCH] drm/nouveau/hwmon: convert sysfs snprintf to sysfs_emit
by Carlis 08 Apr '21

08 Apr '21

From: Xuezhi Zhang <zhangxuezhi1(a)yulong.com> Fix the following coccicheck warning: drivers/gpu/drm//nouveau/nouveau_hwmon.c:44:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm//nouveau/nouveau_hwmon.c:57:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm//nouveau/nouveau_hwmon.c:90:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang <zhangxuezhi1(a)yulong.com> --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index 1c3104d20571..c6e5ee9ece6d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c @@ -41,7 +41,7 @@ static ssize_t nouveau_hwmon_show_temp1_auto_point1_pwm(struct device *d, struct device_attribute *a, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", 100); + return sysfs_emit(buf, "%d\n", 100); } static SENSOR_DEVICE_ATTR(temp1_auto_point1_pwm, 0444, nouveau_hwmon_show_temp1_auto_point1_pwm, NULL, 0); @@ -54,7 +54,7 @@ nouveau_hwmon_temp1_auto_point1_temp(struct device *d, struct nouveau_drm *drm = nouveau_drm(dev); struct nvkm_therm *therm = nvxx_therm(&drm->client.device); - return snprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST) * 1000); } static ssize_t @@ -87,7 +87,7 @@ nouveau_hwmon_temp1_auto_point1_temp_hyst(struct device *d, struct nouveau_drm *drm = nouveau_drm(dev); struct nvkm_therm *therm = nvxx_therm(&drm->client.device); - return snprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", therm->attr_get(therm, NVKM_THERM_ATTR_THRS_FAN_BOOST_HYST) * 1000); } static ssize_t -- 2.25.1

1 0

[PATCH] drm/drm_internal.h: Remove repeated struct declaration
by Wan Jiabing 08 Apr '21

08 Apr '21

struct drm_gem_object is declared twice. One is declared at 40th line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing <wanjiabing(a)vivo.com> --- drivers/gpu/drm/drm_internal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h index fad2249ee67b..1265de2b9d90 100644 --- a/drivers/gpu/drm/drm_internal.h +++ b/drivers/gpu/drm/drm_internal.h @@ -170,7 +170,6 @@ void drm_sysfs_connector_remove(struct drm_connector *connector); void drm_sysfs_lease_event(struct drm_device *dev); /* drm_gem.c */ -struct drm_gem_object; int drm_gem_init(struct drm_device *dev); int drm_gem_handle_create_tail(struct drm_file *file_priv, struct drm_gem_object *obj, -- 2.25.1

2 1

← Newer
1
...
56
57
58
59
60
61
62
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2021