dri-devel April 2021

dri-devel@lists.freedesktop.org

317 participants
715 discussions

[GIT PULL] drm/tegra: Changes for v5.13-rc1
by Thierry Reding 01 Apr '21

01 Apr '21

Hi Dave, The following changes since commit 51c3b916a4d7e24b4918925965867fdd9bd8dd59: Merge tag 'drm-misc-next-2021-03-03' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2021-03-16 17:08:46 +1000) are available in the Git repository at: ssh://git.freedesktop.org/git/tegra/linux.git tags/drm/tegra/for-5.13-rc1 for you to fetch changes up to 7b6f846785f41d57917e36851c120cfbe87f0809: drm/tegra: Support sector layout on Tegra194 (2021-03-31 17:42:14 +0200) Note that I've based this on your pull of drm-misc-next-2021-03-03 and the drm/tegra/for-5.12-rc6 fixes branch that I just sent out a PR for because otherwise there would've been a bunch of non-trivial conflicts. The shortlog below includes everything from drm/tegra/for-5.12-rc6 for clarity. Thierry ---------------------------------------------------------------- drm/tegra: Changes for v5.13-rc1 The changes this time around contain a couple of fixes for host1x along with some improvements for Tegra DRM. Most notably the Tegra DRM driver now supports the hardware cursor on Tegra186 and later, more correctly reflects the capabilities of the display pipelines on various Tegra SoC generations and knows how to deal with the dGPU sector layout by using framebuffer modifiers. ---------------------------------------------------------------- Dmitry Osipenko (1): drm/tegra: dc: Don't set PLL clock to 0Hz Jon Hunter (1): gpu: host1x: Fix Tegra194 syncpt interrupt threshold Mikko Perttunen (9): gpu: host1x: Use different lock classes for each client gpu: host1x: Allow syncpoints without associated client gpu: host1x: Show number of pending waiters in debugfs gpu: host1x: Remove cancelled waiters immediately gpu: host1x: Use HW-equivalent syncpoint expiration check gpu: host1x: Cleanup and refcounting for syncpoints gpu: host1x: Reset max value when freeing a syncpoint gpu: host1x: Reserve VBLANK syncpoints at initialization gpu: host1x: Assign intr waiter inside lock Thierry Reding (11): drm/tegra: dc: Restore coupling of display controllers drm/tegra: sor: Grab runtime PM reference across reset Merge branch 'drm/tegra/fixes' into drm/tegra/for-next gpu: host1x: Add early init and late exit callbacks drm/tegra: dc: Inherit DMA mask drm/tegra: dc: Parameterize maximum resolution drm/tegra: dc: Implement hardware cursor on Tegra186 and later drm/tegra: fb: Add diagnostics for framebuffer modifiers drm/tegra: gem: Add a clarifying comment drm/tegra: Count number of display controllers at runtime drm/tegra: Support sector layout on Tegra194 drivers/gpu/drm/tegra/dc.c | 143 ++++++++++++++++++----- drivers/gpu/drm/tegra/dc.h | 6 + drivers/gpu/drm/tegra/drm.c | 27 +++-- drivers/gpu/drm/tegra/drm.h | 5 + drivers/gpu/drm/tegra/fb.c | 10 ++ drivers/gpu/drm/tegra/gem.h | 6 + drivers/gpu/drm/tegra/gr2d.c | 4 +- drivers/gpu/drm/tegra/gr3d.c | 4 +- drivers/gpu/drm/tegra/hub.c | 41 ++++++- drivers/gpu/drm/tegra/plane.c | 32 ++++++ drivers/gpu/drm/tegra/sor.c | 7 ++ drivers/gpu/drm/tegra/vic.c | 4 +- drivers/gpu/host1x/bus.c | 41 ++++++- drivers/gpu/host1x/cdma.c | 11 +- drivers/gpu/host1x/debug.c | 14 ++- drivers/gpu/host1x/dev.c | 6 + drivers/gpu/host1x/dev.h | 13 ++- drivers/gpu/host1x/hw/cdma_hw.c | 2 +- drivers/gpu/host1x/hw/channel_hw.c | 10 +- drivers/gpu/host1x/hw/debug_hw.c | 2 +- drivers/gpu/host1x/hw/hw_host1x07_vm.h | 2 +- drivers/gpu/host1x/intr.c | 28 +++-- drivers/gpu/host1x/intr.h | 4 +- drivers/gpu/host1x/job.c | 5 +- drivers/gpu/host1x/syncpt.c | 202 ++++++++++++++++++++------------- drivers/gpu/host1x/syncpt.h | 4 +- drivers/staging/media/tegra-video/vi.c | 6 +- include/linux/host1x.h | 27 ++++- 28 files changed, 494 insertions(+), 172 deletions(-)

1 0

[GIT PULL] drm/tegra: Fixes for v5.12-rc6
by Thierry Reding 01 Apr '21

01 Apr '21

Hi Dave, The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: ssh://git.freedesktop.org/git/tegra/linux.git tags/drm/tegra/for-5.12-rc6 for you to fetch changes up to ac097aecfef0bb289ca53d2fe0b73fc7e1612a05: drm/tegra: sor: Grab runtime PM reference across reset (2021-03-30 19:51:39 +0200) Thanks, Thierry ---------------------------------------------------------------- drm/tegra: Fixes for v5.12-rc6 This contains a couple of fixes for various issues such as lockdep warnings, runtime PM references, coupled display controllers and misconfigured PLLs. ---------------------------------------------------------------- Dmitry Osipenko (1): drm/tegra: dc: Don't set PLL clock to 0Hz Mikko Perttunen (1): gpu: host1x: Use different lock classes for each client Thierry Reding (2): drm/tegra: dc: Restore coupling of display controllers drm/tegra: sor: Grab runtime PM reference across reset drivers/gpu/drm/tegra/dc.c | 30 +++++++++++++----------------- drivers/gpu/drm/tegra/sor.c | 7 +++++++ drivers/gpu/host1x/bus.c | 10 ++++++---- include/linux/host1x.h | 9 ++++++++- 4 files changed, 34 insertions(+), 22 deletions(-)

1 0

[PATCH v4 0/2] add support for Waveshare 2inch LCD module
by Carlis 01 Apr '21

01 Apr '21

From: Xuezhi Zhang <zhangxuezhi1(a)yulong.com> This patch add support for Waveshare 2inch LCD module. Xuezhi Zhang (2): drm/tiny: add support for Waveshare 2inch LCD module dt-bindings: display: sitronix,st7789v-dbi: Add Waveshare 2inch LCD module .../display/sitronix,st7789v-dbi.yaml | 72 +++++ MAINTAINERS | 7 + drivers/gpu/drm/tiny/Kconfig | 14 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/st7789v.c | 269 ++++++++++++++++++ 5 files changed, 363 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/sitronix,st7789v-dbi.yaml create mode 100644 drivers/gpu/drm/tiny/st7789v.c -- 2.25.1

2 3

[PATCH v7 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs
by Liu Ying 01 Apr '21

01 Apr '21

Hi, This is the v7 series to add some DRM bridge drivers support for i.MX8qm/qxp SoCs. The bridges may chain one by one to form display pipes to support LVDS displays. The relevant display controller is DPU embedded in i.MX8qm/qxp SoCs. The DPU KMS driver can be found at: https://www.spinics.net/lists/devicetree/msg414766.html This series supports the following display pipes: 1) i.MX8qxp: prefetch eng -> DPU -> pixel combiner -> pixel link -> pixel link to DPI(PXL2DPI) -> LVDS display bridge(LDB) 2) i.MX8qm: prefetch eng -> DPU -> pixel combiner -> pixel link -> LVDS display bridge(LDB) This series dropped the patch 'phy: Add LVDS configuration options', as suggested by Robert Foss, because it has already been sent with the following series to add Mixel combo PHY found in i.MX8qxp: https://www.spinics.net/lists/devicetree/msg414149.html So, this version depends on that series. Patch 1/14 and 2/14 add bus formats used by pixel combiner. Patch 7/14 adds dt-binding for Control and Status Registers module(a syscon used by PXL2DPI and LDB), which references the PXL2DPI and LDB schemas. Patch 10/14 adds a helper for LDB bridge drivers. Patch 3/14 ~ 6/14, 8/14, 9/14 and 11/14 ~ 13/14 add drm bridge drivers and dt-bindings support for the bridges. Patch 14/14 updates MAINTAINERS. I've tested this series with a koe,tx26d202vm0bwa dual link LVDS panel and a LVDS to HDMI bridge(with a downstream drm bridge driver). Marcel Ziswiler has tested v6 with two LVDS panels(single link LT170410-2WHC and dual link LP156WF1) on Toradex Colibri iMX8X. Welcome comments, thanks. v6->v7: * Fix complaints from 'checkpatch.pl --strict' on the LDB DRM bridge helper driver(patch 10/14) and some DRM bridge drivers(patch 9/14, 12/14 and 13/14). (Robert) * Fix complaints from 'checkpatch --strict' on the rest DRM bridge drivers(patch 4/14 and 6/14). * A trivial indentation fix for patch 9/14. (Robert) * Add Robert's R-b tags on patch 9/14, 10/14, 12/14, 13/14 and 14/14. * Add Marcel's T-b tags on all DRM bridge drivers. * Add Rob's R-b tag on patch 7/14 for CSR module dt-binding. v5->v6: * Fix data organizations in documentation(patch 2/14) for MEDIA_BUS_FMT_RGB{666,888}_1X30-CPADLO. (Laurent) * Add Laurent's R-b tags on patch 1/14 and 2/14. * Drop 'select' schema from the CSR dt-binding documentation(patch 7/14). (Rob) * Add Rob's R-b tag on patch 8/14. v4->v5: * Drop the patch 'phy: Add LVDS configuration options'. (Robert) * Add Robert's R-b tags on patch 1/14, 2/14, 4/14 and 6/14. * Drop the 'PC_BUF_PARA_REG' register definition from the pixel combiner bridge driver(patch 4/14). (Robert) * Make a comment occupy a line in the pixel link bridge driver(patch 6/14). (Robert) * Introduce a new patch(patch 7/14) to add dt-binding for Control and Status Registers module. (Rob) * Make imx-ldb-helper be a pure object to be linked with i.MX8qxp LDB bridge driver and i.MX8qm LDB bridge driver, instead of a module. Correspondingly, rename 'imx8{qm, qxp}-ldb.c' to 'imx8{qm, qxp}-ldb-drv.c'. (Robert) * Move 'imx_ldb_helper.h' to 'drivers/gpu/drm/bridge/imx/imx-ldb-helper.h'. (Robert) * s/__FSL_IMX_LDB__/__IMX_LDB_HELPER__/ for 'imx-ldb-helper.h'. v3->v4: * Use 'fsl,sc-resource' DT property to get the SCU resource ID associated with the PXL2DPI instance instead of using alias ID. (Rob) * Add Rob's R-b tag on patch 11/14. v2->v3: * Drop 'fsl,syscon' DT properties from fsl,imx8qxp-ldb.yaml and fsl,imx8qxp-pxl2dpi.yaml. (Rob) * Mention the CSR module controls LDB and PXL2DPI in fsl,imx8qxp-ldb.yaml and fsl,imx8qxp-pxl2dpi.yaml. * Call syscon_node_to_regmap() to get regmaps from LDB bridge helper driver and PXL2DPI bridger driver instead of syscon_regmap_lookup_by_phandle(). * Drop two macros from pixel link bridge driver which help define functions and define them directly. * Properly disable all pixel link controls to POR value by calling imx8qxp_pixel_link_disable_all_controls() from imx8qxp_pixel_link_bridge_probe(). * Add Rob's R-b tags on patch 4/14 and 6/14. v1->v2: * Rebase the series upon the latest drm-misc-next branch(5.11-rc2 based). * Use graph schema in the dt-bindings of the bridges. (Laurent) * Require all four pixel link output ports in fsl,imx8qxp-pixel-link.yaml. (Laurent) * Side note i.MX8qm/qxp LDB official name 'pixel mapper' in fsl,imx8qxp-ldb.yaml. (Laurent) * Mention pixel link is accessed via SCU firmware in fsl,imx8qxp-pixel-link.yaml. (Rob) * Use enum instead of oneOf + const for the reg property of pixel combiner channels in fsl,imx8qxp-pixel-combiner.yaml. (Rob) * Rewrite the function to find the next bridge in pixel link bridge driver by properly using OF APIs and dropping unnecessary DT validation. (Rob) * Drop unnecessary port availability check in i.MX8qxp pixel link to DPI bridge driver. * Drop unnecessary DT validation from i.MX8qxp LDB bridge driver. * Use of_graph_get_endpoint_by_regs() and of_graph_get_remote_endpoint() to get the input remote endpoint in imx8qxp_ldb_set_di_id() of i.MX8qxp LDB bridge driver. * Avoid using companion_port OF node after putting it in imx8qxp_ldb_parse_dt_companion() of i.MX8qxp LDB bridge driver. * Drop unnecessary check for maximum available LDB channels from i.MX8qm LDB bridge driver. * Mention i.MX8qm/qxp LDB official name 'pixel mapper' in i.MX8qm/qxp LDB bridge drivers and Kconfig help messages. Liu Ying (14): media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner media: docs: Add some RGB bus formats for i.MX8qm/qxp pixel combiner dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding drm/bridge: imx: Add i.MX8qm/qxp display pixel link support dt-bindings: mfd: Add i.MX8qm/qxp Control and Status Registers module binding dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding drm/bridge: imx: Add i.MX8qxp pixel link to DPI support drm/bridge: imx: Add LDB driver helper support dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding drm/bridge: imx: Add LDB support for i.MX8qxp drm/bridge: imx: Add LDB support for i.MX8qm MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs .../bindings/display/bridge/fsl,imx8qxp-ldb.yaml | 173 +++++ .../display/bridge/fsl,imx8qxp-pixel-combiner.yaml | 144 ++++ .../display/bridge/fsl,imx8qxp-pixel-link.yaml | 106 +++ .../display/bridge/fsl,imx8qxp-pxl2dpi.yaml | 108 +++ .../devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml | 192 ++++++ .../userspace-api/media/v4l/subdev-formats.rst | 156 +++++ MAINTAINERS | 10 + drivers/gpu/drm/bridge/Kconfig | 2 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/imx/Kconfig | 42 ++ drivers/gpu/drm/bridge/imx/Makefile | 9 + drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 232 +++++++ drivers/gpu/drm/bridge/imx/imx-ldb-helper.h | 98 +++ drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c | 587 +++++++++++++++++ drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c | 722 +++++++++++++++++++++ .../gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 448 +++++++++++++ drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 429 ++++++++++++ drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 487 ++++++++++++++ include/uapi/linux/media-bus-format.h | 6 +- 19 files changed, 3951 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml create mode 100644 Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml create mode 100644 drivers/gpu/drm/bridge/imx/Kconfig create mode 100644 drivers/gpu/drm/bridge/imx/Makefile create mode 100644 drivers/gpu/drm/bridge/imx/imx-ldb-helper.c create mode 100644 drivers/gpu/drm/bridge/imx/imx-ldb-helper.h create mode 100644 drivers/gpu/drm/bridge/imx/imx8qm-ldb-drv.c create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-ldb-drv.c create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c create mode 100644 drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c -- 2.7.4

2 17

[PATCH] drm/sched: add missing member documentation
by Christian König 01 Apr '21

01 Apr '21

Just fix a warning. Signed-off-by: Christian König <christian.koenig(a)amd.com> Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Fixes: f2f12eb9c32b ("drm/scheduler: provide scheduler score externally") --- include/drm/gpu_scheduler.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index 1c815e0a14ed..f888b5e9583a 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -277,6 +277,7 @@ struct drm_sched_backend_ops { * @hang_limit: once the hangs by a job crosses this limit then it is marked * guilty and it will be considered for scheduling further. * @score: score to help loadbalancer pick a idle sched + * @_score: score used when the driver doesn't provide one * @ready: marks if the underlying HW is ready to work * @free_guilty: A hit to time out handler to free the guilty job. * -- 2.25.1

2 1

[PATCH] drivers: gpu: drm: bridge: fix kconfig dependency on DRM_KMS_HELPER
by Julian Braha 01 Apr '21

01 Apr '21

When DRM_TOSHIBA_TC358762 is enabled and DRM_KMS_HELPER is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for DRM_PANEL_BRIDGE Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && DRM_KMS_HELPER [=n] Selected by [y]: - DRM_TOSHIBA_TC358762 [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=y] This is because DRM_TOSHIBA_TC358762 selects DRM_PANEL_BRIDGE, without depending on or selecting DRM_KMS_HELPER, despite that config option depending on DRM_KMS_HELPER. Signed-off-by: Julian Braha <julianbraha(a)gmail.com> --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index e4110d6ca7b3..909d0a5643c2 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -183,6 +183,7 @@ config DRM_TOSHIBA_TC358762 tristate "TC358762 DSI/DPI bridge" depends on OF select DRM_MIPI_DSI + select DRM_KMS_HELPER select DRM_PANEL_BRIDGE help Toshiba TC358762 DSI/DPI bridge driver. -- 2.27.0

2 1

[PATCH v3 0/2] drm/mediatek: Don't support hdmi connector creation
by Dafna Hirschfeld 01 Apr '21

01 Apr '21

commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk_dpi calls drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR while mtk_hdmi does not yet support this flag. These three patches fix that by adding support for DRM_BRIDGE_ATTACH_NO_CONNECTOR in mtk_hdmi bridge attachment. changes since v2: 1. squash patch 3 with patch 2 to not break bisection 2. remove the funtion mtk_hdmi_get_edid and inline its code in mtk_hdmi_bridge_get_edid 3. small aligment changes since v1: 1. split the first patch - now the first patch only moves the bridge ops to the atomic API while the replacement of the field 'conn' with the field '*curr_conn' is done in a new third patch. 2. in the function 'get_eld' use the current conn only if 'enabled = true'. Dafna Hirschfeld (2): drm/mediatek: Switch the hdmi bridge ops to the atomic versions drm/mediatek: Don't support hdmi connector creation drivers/gpu/drm/mediatek/mtk_hdmi.c | 174 ++++++++++++---------------- 1 file changed, 71 insertions(+), 103 deletions(-) -- 2.17.1

2 3

re: drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
by Colin Ian King 01 Apr '21

01 Apr '21

Hi, Static analysis with Coverity on Linux-next has detected a potential issue with the following commit: commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7 Author: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Date: Tue Mar 23 16:50:49 2021 +0100 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal The analysis by Coverity is as follows: 145 static int igt_ppgtt_alloc(void *arg) 146 { 147 struct drm_i915_private *dev_priv = arg; 148 struct i915_ppgtt *ppgtt; 1. var_decl: Declaring variable ww without initializer. 149 struct i915_gem_ww_ctx ww; 150 u64 size, last, limit; 151 int err = 0; 152 153 /* Allocate a ppggt and try to fill the entire range */ 154 2. Condition !(dev_priv->__info.ppgtt_type != INTEL_PPGTT_NONE), taking false branch. 155 if (!HAS_PPGTT(dev_priv)) 156 return 0; 157 158 ppgtt = i915_ppgtt_create(&dev_priv->gt); 3. Condition IS_ERR(ppgtt), taking false branch. 159 if (IS_ERR(ppgtt)) 160 return PTR_ERR(ppgtt); 161 4. Condition !ppgtt->vm.allocate_va_range, taking true branch. 162 if (!ppgtt->vm.allocate_va_range) 5. Jumping to label err_ppgtt_cleanup. 163 goto err_ppgtt_cleanup; 164 165 /* 166 * While we only allocate the page tables here and so we could 167 * address a much larger GTT than we could actually fit into 168 * RAM, a practical limit is the amount of physical pages in the system. 169 * This should ensure that we do not run into the oomkiller during 170 * the test and take down the machine wilfully. 171 */ 172 limit = totalram_pages() << PAGE_SHIFT; 173 limit = min(ppgtt->vm.total, limit); 174 175 i915_gem_ww_ctx_init(&ww, false); 176retry: 177 err = i915_vm_lock_objects(&ppgtt->vm, &ww); 178 if (err) 179 goto err_ppgtt_cleanup; 180 181 /* Check we can allocate the entire range */ 182 for (size = 4096; size <= limit; size <<= 2) { 183 struct i915_vm_pt_stash stash = {}; 184 185 err = i915_vm_alloc_pt_stash(&ppgtt->vm, &stash, size); 186 if (err) 187 goto err_ppgtt_cleanup; 188 189 err = i915_vm_pin_pt_stash(&ppgtt->vm, &stash); 190 if (err) { 191 i915_vm_free_pt_stash(&ppgtt->vm, &stash); 192 goto err_ppgtt_cleanup; 193 } 194 195 ppgtt->vm.allocate_va_range(&ppgtt->vm, &stash, 0, size); 196 cond_resched(); 197 198 ppgtt->vm.clear_range(&ppgtt->vm, 0, size); 199 200 i915_vm_free_pt_stash(&ppgtt->vm, &stash); 201 } 202 203 /* Check we can incrementally allocate the entire range */ 204 for (last = 0, size = 4096; size <= limit; last = size, size <<= 2) { 205 struct i915_vm_pt_stash stash = {}; 206 207 err = i915_vm_alloc_pt_stash(&ppgtt->vm, &stash, size - last); 208 if (err) 209 goto err_ppgtt_cleanup; 210 211 err = i915_vm_pin_pt_stash(&ppgtt->vm, &stash); 212 if (err) { 213 i915_vm_free_pt_stash(&ppgtt->vm, &stash); 214 goto err_ppgtt_cleanup; 215 } 216 217 ppgtt->vm.allocate_va_range(&ppgtt->vm, &stash, 218 last, size - last); 219 cond_resched(); 220 221 i915_vm_free_pt_stash(&ppgtt->vm, &stash); 222 } 223 224 err_ppgtt_cleanup: 6. Condition err == -35, taking false branch. 225 if (err == -EDEADLK) { 226 err = i915_gem_ww_ctx_backoff(&ww); 227 if (!err) 228 goto retry; 229 } 7. uninit_use_in_call: Using uninitialized value ww.contended when calling i915_gem_ww_ctx_fini. Uninitialized pointer read (UNINIT) 8. uninit_use_in_call: Using uninitialized value ww.ctx.acquired when calling i915_gem_ww_ctx_fini. 230 i915_gem_ww_ctx_fini(&ww); 231 232 i915_vm_put(&ppgtt->vm); 233 return err; 234 } Coverity is reporting use of uninitialized values in (lines 230. Not sure what the best fix is for this, so I'm reporting this as a potential issue. Colin

1 0

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE
by Will Deacon 01 Apr '21

01 Apr '21

On Thu, Apr 01, 2021 at 11:59:45AM +0200, Christoph Hellwig wrote: > For now I'll just pass the iommu_domain to iommu_get_dma_strict, > so that we can check for it. We can do additional cleanups on top > of that later. Sounds good to me, cheers! Will

1 0

[PATCH][next] drm/i915: Fix an uninitialized variable issue
by Colin King 01 Apr '21

01 Apr '21

From: Colin Ian King <colin.king(a)canonical.com> Currently there is a while loop that contains a handful of continue statements that can skip over the assignment of the variable err. At the end of the loop there is a potiential for err to be unassigned and possibly causing issues when err is checked for a non-zero value. Fix this by setting err to zero before the while loop starts. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c index 3e248d3bd869..1e24ba872029 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c @@ -180,6 +180,7 @@ i915_gem_shrink(struct i915_gem_ww_ctx *ww, * the unbound/bound list until actually freed. */ spin_lock_irqsave(&i915->mm.obj_lock, flags); + err = 0; while (count < target && (obj = list_first_entry_or_null(phase->list, typeof(*obj), @@ -202,7 +203,6 @@ i915_gem_shrink(struct i915_gem_ww_ctx *ww, spin_unlock_irqrestore(&i915->mm.obj_lock, flags); - err = 0; if (unsafe_drop_pages(obj, shrink)) { /* May arrive from get_pages on another bo */ if (!ww) { -- 2.30.2

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2021