dri-devel May 2021

dri-devel@lists.freedesktop.org

348 participants
807 discussions

[PATCH] i915: Increase *_latency array size
by Andi Kleen 06 May '21

06 May '21

From: Andi Kleen <andi(a)firstfloor.org> Newer gcc prints the following warning: drivers/gpu/drm/i915/intel_pm.c:3057:9: warning: ‘intel_print_wm_latency’ reading 16 bytes from a region of size 10 [-Wstringop-overread] and some other related warnings in similar functions. gcc has a point here. Some of the latency arrays only have 5 members, but print_wm_latency may read up to max_level returned by ilk_wm_max_level, which can be upto 7 for the >= GEN9 case. So it will read some fields beyond the array. Increase all the latency fields to 8 members, which is enough for SKL. I don't know if they are correctly initialized upto 8, but dev_priv should start out as zero, so presumably they will be zero. Signed-off-by: Andi Kleen <andi(a)firstfloor.org> --- drivers/gpu/drm/i915/i915_drv.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index cb62ddba2035..c80add5f6d33 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1095,11 +1095,11 @@ struct drm_i915_private { * in 0.5us units for WM1+. */ /* primary */ - u16 pri_latency[5]; + u16 pri_latency[8]; /* sprite */ - u16 spr_latency[5]; + u16 spr_latency[8]; /* cursor */ - u16 cur_latency[5]; + u16 cur_latency[8]; /* * Raw watermark memory latency values * for SKL for all 8 levels -- 2.25.4

3 4

[PATCH 1/8] drm/arm: Don't set allow_fb_modifiers explicitly
by Daniel Vetter 06 May '21

06 May '21

Since commit 890880ddfdbe256083170866e49c87618b706ac7 Author: Paul Kocialkowski <paul.kocialkowski(a)bootlin.com> Date: Fri Jan 4 09:56:10 2019 +0100 drm: Auto-set allow_fb_modifiers when given modifiers at plane init this is done automatically as part of plane init, if drivers set the modifier list correctly. Which is the case here for both komeda and malidp. Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> Cc: "James (Qian) Wang" <james.qian.wang(a)arm.com> Cc: Liviu Dudau <liviu.dudau(a)arm.com> Cc: Mihail Atanassov <mihail.atanassov(a)arm.com> Cc: Brian Starkey <brian.starkey(a)arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 1 - drivers/gpu/drm/arm/malidp_drv.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index aeda4e5ec4f4..ff45f23f3d56 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -247,7 +247,6 @@ static void komeda_kms_mode_config_init(struct komeda_kms_dev *kms, config->min_height = 0; config->max_width = 4096; config->max_height = 4096; - config->allow_fb_modifiers = true; config->funcs = &komeda_mode_config_funcs; config->helper_private = &komeda_mode_config_helpers; diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index d83c7366b348..de59f3302516 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -403,7 +403,6 @@ static int malidp_init(struct drm_device *drm) drm->mode_config.max_height = hwdev->max_line_size; drm->mode_config.funcs = &malidp_mode_config_funcs; drm->mode_config.helper_private = &malidp_mode_config_helpers; - drm->mode_config.allow_fb_modifiers = true; ret = malidp_crtc_init(drm); if (ret) -- 2.31.0

7 19

[PATCH v1 0/3] Add support for next gen eDP driver on sc7280
by Sankeerth Billakanti 06 May '21

06 May '21

These patches add support for the next generation eDP driver on SnapDragon with dpu support. The existing eDP driver cannot support the new eDP hardware. So, to maintain backward compatibility, the older eDP driver is moved to v200 folder and the new generation eDP driver is added in the v510 folder. These are baseline changes with which we can enable display. The new eDP controller can also support additional features such as backlight control, PSR etc. which will be enabled in subsequent patch series. Summary of changes: DPU driver interface to the new eDP v510 display driver. New generation eDP controller and phy driver implementation. A common interface to choose enable the required eDP driver. Sankeerth Billakanti (3): drm/msm/edp: support multiple generations of edp hardware drm/msm/edp: add support for next gen edp drm/msm/disp/dpu1: add support for edp encoder drivers/gpu/drm/msm/Makefile | 19 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 33 + drivers/gpu/drm/msm/edp/edp.c | 198 --- drivers/gpu/drm/msm/edp/edp.h | 78 - drivers/gpu/drm/msm/edp/edp.xml.h | 380 ----- drivers/gpu/drm/msm/edp/edp_aux.c | 264 ---- drivers/gpu/drm/msm/edp/edp_bridge.c | 111 -- drivers/gpu/drm/msm/edp/edp_common.c | 38 + drivers/gpu/drm/msm/edp/edp_common.h | 47 + drivers/gpu/drm/msm/edp/edp_connector.c | 132 -- drivers/gpu/drm/msm/edp/edp_ctrl.c | 1375 ------------------ drivers/gpu/drm/msm/edp/edp_phy.c | 98 -- drivers/gpu/drm/msm/edp/v200/edp.xml.h | 380 +++++ drivers/gpu/drm/msm/edp/v200/edp_v200.c | 210 +++ drivers/gpu/drm/msm/edp/v200/edp_v200.h | 70 + drivers/gpu/drm/msm/edp/v200/edp_v200_aux.c | 264 ++++ drivers/gpu/drm/msm/edp/v200/edp_v200_bridge.c | 111 ++ drivers/gpu/drm/msm/edp/v200/edp_v200_connector.c | 132 ++ drivers/gpu/drm/msm/edp/v200/edp_v200_ctrl.c | 1375 ++++++++++++++++++ drivers/gpu/drm/msm/edp/v200/edp_v200_phy.c | 98 ++ drivers/gpu/drm/msm/edp/v510/edp_v510.c | 220 +++ drivers/gpu/drm/msm/edp/v510/edp_v510.h | 151 ++ drivers/gpu/drm/msm/edp/v510/edp_v510_aux.c | 268 ++++ drivers/gpu/drm/msm/edp/v510/edp_v510_bridge.c | 111 ++ drivers/gpu/drm/msm/edp/v510/edp_v510_connector.c | 117 ++ drivers/gpu/drm/msm/edp/v510/edp_v510_ctrl.c | 1583 +++++++++++++++++++++ drivers/gpu/drm/msm/edp/v510/edp_v510_phy.c | 641 +++++++++ drivers/gpu/drm/msm/edp/v510/edp_v510_reg.h | 339 +++++ 29 files changed, 6207 insertions(+), 2643 deletions(-) delete mode 100644 drivers/gpu/drm/msm/edp/edp.c delete mode 100644 drivers/gpu/drm/msm/edp/edp.h delete mode 100644 drivers/gpu/drm/msm/edp/edp.xml.h delete mode 100644 drivers/gpu/drm/msm/edp/edp_aux.c delete mode 100644 drivers/gpu/drm/msm/edp/edp_bridge.c create mode 100644 drivers/gpu/drm/msm/edp/edp_common.c create mode 100644 drivers/gpu/drm/msm/edp/edp_common.h delete mode 100644 drivers/gpu/drm/msm/edp/edp_connector.c delete mode 100644 drivers/gpu/drm/msm/edp/edp_ctrl.c delete mode 100644 drivers/gpu/drm/msm/edp/edp_phy.c create mode 100644 drivers/gpu/drm/msm/edp/v200/edp.xml.h create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200.c create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200.h create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200_aux.c create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200_bridge.c create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200_connector.c create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200_ctrl.c create mode 100644 drivers/gpu/drm/msm/edp/v200/edp_v200_phy.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510.h create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510_aux.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510_bridge.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510_connector.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510_ctrl.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510_phy.c create mode 100644 drivers/gpu/drm/msm/edp/v510/edp_v510_reg.h -- The Qualcomm Innovatin Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

1 3

[pull] radeon, amdgpu drm-fixes-5.13
by Alex Deucher 06 May '21

06 May '21

Hi Dave, Daniel, Fixes for 5.13. The following changes since commit a1a1ca70deb3ec600eeabb21de7f3f48aaae5695: Merge tag 'drm-misc-next-fixes-2021-04-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2021-04-23 13:53:07 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.13-2021-05-05 for you to fetch changes up to 234055fd9728e6726787bc63b24b6450034876cf: drm/amdgpu: Use device specific BO size & stride check. (2021-05-05 23:09:54 -0400) ---------------------------------------------------------------- amd-drm-fixes-5.13-2021-05-05: amdgpu: - MPO hang workaround - Fix for concurrent VM flushes on vega/navi - dcefclk is not adjustable on navi1x and newer - MST HPD debugfs fix - Suspend/resumes fixes - Register VGA clients late in case driver fails to load - Fix GEM leak in user framebuffer create - Add support for polaris12 with 32 bit memory interface - Fix duplicate cursor issue when using overlay - Fix corruption with tiled surfaces on VCN3 - Add BO size and stride check to fix BO size verification radeon: - Fix off-by-one in power state parsing - Fix possible memory leak in power state parsing ---------------------------------------------------------------- Bas Nieuwenhuizen (2): drm/amdgpu: Init GFX10_ADDR_CONFIG for VCN v3 in DPG mode. drm/amdgpu: Use device specific BO size & stride check. Christian König (1): drm/amdgpu: fix concurrent VM flushes on Vega/Navi v2 Darren Powell (2): amdgpu/pm: Prevent force of DCEFCLK on NAVI10 and SIENNA_CICHLID amdgpu/pm: set pp_dpm_dcefclk to readonly on NAVI10 and newer gpus Evan Quan (1): drm/amdgpu: add new MC firmware for Polaris12 32bit ASIC Harry Wentland (1): drm/amd/display: Reject non-zero src_y and src_x for video planes Kai-Heng Feng (1): drm/amdgpu: Register VGA clients after init can no longer fail Kees Cook (2): drm/radeon: Fix off-by-one power_state index heap overwrite drm/radeon: Avoid power table parsing memory leaks Mikita Lipski (1): drm/amd/display: fix wrong statement in mst hpd debugfs Pavan Kumar Ramayanam (1): drm/amdgpu: Handling of amdgpu_device_resume return value for graceful teardown Rodrigo Siqueira (1): drm/amd/display: Fix two cursor duplication when using overlay Simon Ser (1): amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create Tom Rix (1): drm/amd/pm: initialize variable Victor Zhao (1): drm/amdgpu: fix r initial values drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 184 ++++++++++++++++++++- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 19 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 13 +- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 4 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 68 ++++++++ .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 +- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 5 +- .../drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 +- drivers/gpu/drm/radeon/radeon_atombios.c | 26 ++- 14 files changed, 328 insertions(+), 45 deletions(-)

1 0

[PATCH] fbmem: Correct position of '__maybe_unused' in proc_fb_seq_ops
by Nathan Chancellor 06 May '21

06 May '21

Clang warns: drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes] static const struct __maybe_unused seq_operations proc_fb_seq_ops = { ^ ./include/linux/compiler_attributes.h:273:56: note: expanded from macro '__maybe_unused' #define __maybe_unused __attribute__((__unused__)) ^ ./include/linux/seq_file.h:31:8: note: previous definition is here struct seq_operations { ^ 1 warning generated. The attribute should not split the type 'struct seq_operations'. Move it before the struct keyword so that it works properly and there is no more warning. Fixes: b9d79e4ca4ff ("fbmem: Mark proc_fb_seq_ops as __maybe_unused") Link: https://github.com/ClangBuiltLinux/linux/issues/1371 Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Nathan Chancellor <nathan(a)kernel.org> --- drivers/video/fbdev/core/fbmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 52c606c0f8a2..84c484f37b4a 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v) return 0; } -static const struct __maybe_unused seq_operations proc_fb_seq_ops = { +static const __maybe_unused struct seq_operations proc_fb_seq_ops = { .start = fb_seq_start, .next = fb_seq_next, .stop = fb_seq_stop, base-commit: b9d79e4ca4ff23543d6b33c736ba07c1f0a9dcb1 -- 2.31.1.362.g311531c9de

2 1

[PATCH 0/4] drm/i915/display Try YCbCr420 color when RGB fails
by Werner Sembach 05 May '21

05 May '21

When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previously failed silently. AMDGPU had nearly the exact same issue. This problem description is therefore copied from my commit message of the AMDGPU patch. On some setups, while the monitor and the gpu support display modes with pixel clocks of up to 600MHz, the link encoder might not. This prevents YCbCr444 and RGB encoding for 4k60Hz, but YCbCr420 encoding might still be possible. However, which color mode is used is decided before the link encoder capabilities are checked. This patch fixes the problem by retrying to find a display mode with YCbCr420 enforced and using it, if it is valid. This patchset is revision 3. I did not (yet) include all suggested changes as I'm waiting for some clarification. See my last emails.

2 5

[PATCH 0/6] drm/vmwgfx: SVGA v3 and arm64 support
by Zack Rusin 05 May '21

05 May '21

This set includes some lost fixes and adds SVGA v3 and arm64 support to the driver. SVGA v3 is the next version of our virtual device, it's largely about making the device a little easier and cleaner to use (e.g. MMIO for register accesses instead of ioports, adding MSI-X support, deprecating the FIFO MMIO and removing a lot of the old and legacy functionality). We'll be able to get rid of some of the locking as well, which improves the performance. Our ARM64 support is only available in svga v3. Currently guest memory objects are not supported on arm so 3D is not yet available there. Thomas Hellstrom (2): drm/vmwgfx: Mark a surface gpu-dirty after the SVGA3dCmdDXGenMips command drm/vmwgfx: Fix cpu updates of coherent multisample surfaces Zack Rusin (4): drm/vmwgfx: Fix incorrect enum usage drm/vmwgfx: Remove the reservation semaphore drm/vmwgfx: Add basic support for SVGA3 drm/vmwgfx: Port vmwgfx to arm64 drivers/gpu/drm/vmwgfx/Kconfig | 3 +- drivers/gpu/drm/vmwgfx/Makefile | 2 +- .../device_include/svga3d_surfacedefs.h | 8 +- .../gpu/drm/vmwgfx/device_include/svga_reg.h | 55 ++++- drivers/gpu/drm/vmwgfx/ttm_lock.c | 194 ---------------- drivers/gpu/drm/vmwgfx/ttm_lock.h | 218 ----------------- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 31 --- drivers/gpu/drm/vmwgfx/vmwgfx_cmd.c | 114 +++++---- drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 13 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 161 +++++++++---- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 128 +++++++--- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 27 ++- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 8 - drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 16 +- drivers/gpu/drm/vmwgfx/vmwgfx_fence.h | 2 - drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 60 +---- drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 75 ++---- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 30 +-- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 36 +-- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 31 ++- drivers/gpu/drm/vmwgfx/vmwgfx_msg.h | 214 ----------------- drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h | 130 +++++++++++ drivers/gpu/drm/vmwgfx/vmwgfx_msg_x86.h | 219 ++++++++++++++++++ drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_reg.h | 4 - drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 4 - drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 6 - .../gpu/drm/vmwgfx/vmwgfx_simple_resource.c | 5 - drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 30 ++- 29 files changed, 783 insertions(+), 1043 deletions(-) delete mode 100644 drivers/gpu/drm/vmwgfx/ttm_lock.c delete mode 100644 drivers/gpu/drm/vmwgfx/ttm_lock.h delete mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_msg.h create mode 100755 drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_msg_x86.h -- 2.27.0

2 11

[PATCH] drm: bridge: make a const array static, makes object smaller
by Colin King 05 May '21

05 May '21

From: Colin Ian King <colin.king(a)canonical.com> Don't populate the const array frs_limits on the stack but instead it static. Makes the object code smaller by 128 bytes: Before: text data bss dec hex filename 24835 7440 64 32339 7e53 drivers/gpu/drm/bridge/tc358768.o After: text data bss dec hex filename 24739 7408 64 32211 7dd3 drivers/gpu/drm/bridge/tc358768.o (gcc version 10.3.0) Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/bridge/tc358768.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 8ed8302d6bbb..2495ea46b091 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -291,7 +291,7 @@ static int tc358768_calc_pll(struct tc358768_priv *priv, const struct drm_display_mode *mode, bool verify_only) { - const u32 frs_limits[] = { + static const u32 frs_limits[] = { 1000000000, 500000000, 250000000, -- 2.30.2

1 0

[PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies
by Adrien Grassein 05 May '21

05 May '21

LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from DRM framework that needs VIDEOMODE_HELPERS to be enabled. Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Reported-by: Michal Suchánek <msuchanek(a)suse.de> Signed-off-by: Adrien Grassein <adrien.grassein(a)gmail.com> --- drivers/gpu/drm/bridge/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 400193e38d29..70bcceaae9bf 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B select DRM_KMS_HELPER select DRM_MIPI_DSI select REGMAP_I2C + select VIDEOMODE_HELPERS help Driver for Lontium LT8912B DSI to HDMI bridge chip driver. -- 2.25.1

3 3

[PATCH 0/3] drm/i915/display Try YCbCr420 color when RGB fails
by Werner Sembach 05 May '21

05 May '21

When encoder validation of a display mode fails, retry with less bandwidth heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups to support 4k60Hz output, which previously failed silently. AMDGPU had nearly the exact same issue. This problem description is therefore copied from my commit message of the AMDGPU patch. On some setups, while the monitor and the gpu support display modes with pixel clocks of up to 600MHz, the link encoder might not. This prevents YCbCr444 and RGB encoding for 4k60Hz, but YCbCr420 encoding might still be possible. However, which color mode is used is decided before the link encoder capabilities are checked. This patch fixes the problem by retrying to find a display mode with YCbCr420 enforced and using it, if it is valid. This patchset is revision 4. After getting clarification on questions ask on the mailing list.

1 3

← Newer
1
...
69
70
71
72
73
74
75
...
81
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel May 2021