dri-devel July 2021

dri-devel@lists.freedesktop.org

321 participants
829 discussions

[Bug 206349] New: WARNING: dcn20_validate_bandwidth+0x87/0x9e [ amdgpu on 5700 XT ]
by bugzilla-daemon＠bugzilla.kernel.org 05 Oct '21

05 Oct '21

https://bugzilla.kernel.org/show_bug.cgi?id=206349 Bug ID: 206349 Summary: WARNING: dcn20_validate_bandwidth+0x87/0x9e [ amdgpu on 5700 XT ] Product: Drivers Version: 2.5 Kernel Version: 5.5.0 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: low Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: doublej472(a)gmail.com Regression: No Created attachment 287027 --> https://bugzilla.kernel.org/attachment.cgi?id=287027&action=edit dmesg warnings from amdgpu I've been seeing this warning pop up in my dmesg for a while from amdgpu, all relating to dcn20_validate_bandwidth. I'm not sure if it's affecting my machine in a significant manner, but it keeps showing up. [ 8236.203353] arch-desktop kernel: ------------[ cut here ]------------ [ 8236.203403] arch-desktop kernel: WARNING: CPU: 9 PID: 555 at drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:2959 dcn20_validate_bandwidth+0x87/0x9e [amdgpu] [ 8236.203405] arch-desktop kernel: Modules linked in: bridge stp llc bcache crc64 raid1 snd_usb_audio snd_usbmidi_lib kvm_amd snd_rawmidi kvm amdgpu gpu_sched k10temp ttm sch_fq_codel efivarfs [ 8236.203414] arch-desktop kernel: CPU: 9 PID: 555 Comm: Xorg Not tainted 5.5.0-gentoo #1 [ 8236.203415] arch-desktop kernel: Hardware name: System manufacturer System Product Name/PRIME X370-PRO, BIOS 5220 09/12/2019 [ 8236.203451] arch-desktop kernel: RIP: 0010:dcn20_validate_bandwidth+0x87/0x9e [amdgpu] [ 8236.203453] arch-desktop kernel: Code: 00 00 01 eb 29 31 d2 f2 0f 11 85 70 21 00 00 48 89 ee e8 e9 f7 ff ff 89 c2 22 85 b8 1d 00 00 74 09 c6 85 b8 1d 00 00 00 eb 04 <0f> 0b 89 d0 f2 0f 10 1c 24 f2 0f 11 9d 70 21 00 00 48 83 c4 10 5d [ 8236.203455] arch-desktop kernel: RSP: 0018:ffff8e9800c9fa80 EFLAGS: 00010246 [ 8236.203457] arch-desktop kernel: RAX: 0000000000000000 RBX: ffff8b19d3f6b900 RCX: 0000000000215f49 [ 8236.203458] arch-desktop kernel: RDX: 0000000000000001 RSI: 0000000000215f09 RDI: 000000000002e300 [ 8236.203460] arch-desktop kernel: RBP: ffff8b17ee190000 R08: ffff8b1b7b406840 R09: ffffffffc0345b6b [ 8236.203461] arch-desktop kernel: R10: ffff8b1b66e6a000 R11: ffff8b1b66e6a000 R12: 0000000000000000 [ 8236.203462] arch-desktop kernel: R13: 0000000000000000 R14: ffff8b17ee190000 R15: 0000000000000002 [ 8236.203464] arch-desktop kernel: FS: 00007ff890a4e980(0000) GS:ffff8b1b7ea40000(0000) knlGS:0000000000000000 [ 8236.203465] arch-desktop kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 8236.203467] arch-desktop kernel: CR2: 00005620d7c8eef0 CR3: 00000007e2886000 CR4: 0000000000340ee0 [ 8236.203468] arch-desktop kernel: Call Trace: [ 8236.203504] arch-desktop kernel: dc_validate_global_state+0x1b6/0x1d7 [amdgpu] [ 8236.203549] arch-desktop kernel: amdgpu_dm_atomic_check+0x52a/0x666 [amdgpu] [ 8236.203556] arch-desktop kernel: drm_atomic_check_only+0x586/0x62e [ 8236.203559] arch-desktop kernel: ? drm_atomic_set_crtc_for_connector+0xd9/0xe1 [ 8236.203562] arch-desktop kernel: drm_atomic_commit+0xe/0x44 [ 8236.203565] arch-desktop kernel: drm_atomic_helper_set_config+0x50/0x66 [ 8236.203569] arch-desktop kernel: drm_mode_setcrtc+0x221/0x5dc [ 8236.203574] arch-desktop kernel: ? drm_mode_getcrtc+0x145/0x145 [ 8236.203576] arch-desktop kernel: drm_ioctl_kernel+0x8d/0xe1 [ 8236.203579] arch-desktop kernel: drm_ioctl+0x1f9/0x2d3 [ 8236.203582] arch-desktop kernel: ? drm_mode_getcrtc+0x145/0x145 [ 8236.203613] arch-desktop kernel: amdgpu_drm_ioctl+0x45/0x71 [amdgpu] [ 8236.203617] arch-desktop kernel: vfs_ioctl+0x19/0x26 [ 8236.203620] arch-desktop kernel: do_vfs_ioctl+0x574/0x59e [ 8236.203623] arch-desktop kernel: ksys_ioctl+0x49/0x68 [ 8236.203626] arch-desktop kernel: __x64_sys_ioctl+0x11/0x14 [ 8236.203629] arch-desktop kernel: do_syscall_64+0x48/0x55 [ 8236.203632] arch-desktop kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 8236.203634] arch-desktop kernel: RIP: 0033:0x7ff890d0b5c7 [ 8236.203636] arch-desktop kernel: Code: 00 00 00 75 0c 48 c7 c0 ff ff ff ff 48 83 c4 18 c3 e8 0d c8 01 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 99 e8 0c 00 f7 d8 64 89 01 48 [ 8236.203638] arch-desktop kernel: RSP: 002b:00007ffea4921a48 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 8236.203639] arch-desktop kernel: RAX: ffffffffffffffda RBX: 00007ffea4921a80 RCX: 00007ff890d0b5c7 [ 8236.203641] arch-desktop kernel: RDX: 00007ffea4921a80 RSI: 00000000c06864a2 RDI: 000000000000000c [ 8236.203642] arch-desktop kernel: RBP: 00000000c06864a2 R08: 0000000000000000 R09: 0000000000000000 [ 8236.203643] arch-desktop kernel: R10: 0000000000000000 R11: 0000000000000246 R12: 00005620d7fe1e70 [ 8236.203644] arch-desktop kernel: R13: 000000000000000c R14: 00005620d8e342f0 R15: 00005620d6dc2040 [ 8236.203649] arch-desktop kernel: ---[ end trace 82184d8b2d613936 ]--- I've attached a few more warnings to this bug report. I'm not sure what causes this warning. It *might* happen whenever the GPU is being used, if I leave the machine alone it tends to not show. It could be related to waking up my monitor? (Attached to a DisplayPort cable, running at 1920x1080 @ 144 Hz, if that matters) My system is running on an ASUS PRIME X370-PRO motherboard with a ryzen 3900x, 32GB of ram, and a 5700 XT GPU (on a PCIe 3.0 x16 link). Please let me know if you need more info! -- You are receiving this mail because: You are watching the assignee of the bug.

1 1

[PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
by Marek Vasut 05 Oct '21

05 Oct '21

Decoder input LVDS format is a property of the decoder chip or even its strapping. Add DT property data-mapping the same way lvds-panel does, to define the LVDS data mapping. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: devicetree(a)vger.kernel.org To: dri-devel(a)lists.freedesktop.org --- V2: - Use allOf - Move the data-mapping to endpoint V3: - Rebase on V2 submitted a while ago, reinstate changelog - Drop the allOf and un-rebase on previous pclk patch V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and add $ref: /schemas/graph.yaml#/$defs/port-base --- .../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml index 304a1367faaa7..c0400c60f272a 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml @@ -55,11 +55,26 @@ properties: For LVDS decoders, port 0 is the LVDS input port@1: - $ref: /schemas/graph.yaml#/properties/port + $ref: /schemas/graph.yaml#/$defs/port-base description: | For LVDS encoders, port 1 is the LVDS output For LVDS decoders, port 1 is the parallel output + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-mapping: + enum: + - jeida-18 + - jeida-24 + - vesa-24 + description: | + The color signals mapping order. See details in + Documentation/devicetree/bindings/display/panel/lvds.yaml + required: - port@0 - port@1 @@ -71,6 +86,22 @@ properties: power-supply: true +if: + not: + properties: + compatible: + contains: + const: lvds-decoder +then: + properties: + ports: + properties: + port@1: + properties: + endpoint: + properties: + data-mapping: false + required: - compatible - ports -- 2.30.2

3 6

[Bug 213201] New: [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56)
by bugzilla-daemon＠bugzilla.kernel.org 04 Oct '21

04 Oct '21

https://bugzilla.kernel.org/show_bug.cgi?id=213201 Bug ID: 213201 Summary: [KAVERI] memory leak - unreferenced object 0xffff8881700cf988 (size 56) Product: Drivers Version: 2.5 Kernel Version: 5.13-rc3 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: erhard_f(a)mailbox.org CC: daniel(a)ffwll.ch Regression: No Created attachment 296967 --> https://bugzilla.kernel.org/attachment.cgi?id=296967&action=edit kernel dmesg (5.13-rc3, AMD A10 PRO-7800B) Get this shortly after booting kernel 5.13-rc3. Looks like amdgpu is involved: unreferenced object 0xffff8881700cf988 (size 56): comm "systemd-udevd", pid 216, jiffies 4294885043 (age 1739.830s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 0d 01 70 00 00 00 00 00 ..........p..... 7b 98 01 00 00 c9 ff ff 00 00 00 00 00 00 00 00 {............... backtrace: [<00000000f3e5fc85>] kmem_cache_alloc+0x10a/0x1e4 [<00000000fff767c3>] acpi_ps_alloc_op+0x4e/0xdc [<00000000445cacf1>] acpi_ps_create_op+0x24e/0x473 [<000000003452a27a>] acpi_ps_parse_loop+0x25e/0xa39 [<000000004e3469e0>] acpi_ps_parse_aml+0xf3/0x450 [<00000000be1f7fd0>] acpi_ps_execute_method+0x278/0x2bb [<000000004564e9a8>] acpi_ns_evaluate+0x34f/0x45d [<0000000072f73c39>] acpi_evaluate_object+0x201/0x3b5 [<0000000036379e33>] amdgpu_atcs_call+0x11d/0x19b [amdgpu] [<00000000829cc77d>] amdgpu_acpi_init+0xf3/0x7b8 [amdgpu] [<00000000671194bb>] amdgpu_driver_load_kms+0x1e5/0x354 [amdgpu] [<000000005ad1722a>] amdgpu_pci_probe+0x150/0x1d2 [amdgpu] [<00000000e32ddc8a>] pci_device_probe+0xf3/0x17e [<00000000f74eb70d>] really_probe+0x215/0x539 [<00000000af9fda84>] driver_probe_device+0x9d/0xd6 [<00000000bc527018>] device_driver_attach+0x66/0x8a unreferenced object 0xffff8881700ceb30 (size 56): comm "systemd-udevd", pid 216, jiffies 4294885043 (age 1739.834s) hex dump (first 32 bytes): 88 f9 0c 70 81 88 ff ff 0d 01 2d 00 00 00 00 00 ...p......-..... 7c 98 01 00 00 c9 ff ff 00 00 00 00 00 00 00 00 |............... backtrace: [<00000000f3e5fc85>] kmem_cache_alloc+0x10a/0x1e4 [<00000000fff767c3>] acpi_ps_alloc_op+0x4e/0xdc [<00000000445cacf1>] acpi_ps_create_op+0x24e/0x473 [<000000003452a27a>] acpi_ps_parse_loop+0x25e/0xa39 [<000000004e3469e0>] acpi_ps_parse_aml+0xf3/0x450 [<00000000be1f7fd0>] acpi_ps_execute_method+0x278/0x2bb [<000000004564e9a8>] acpi_ns_evaluate+0x34f/0x45d [<0000000072f73c39>] acpi_evaluate_object+0x201/0x3b5 [<0000000036379e33>] amdgpu_atcs_call+0x11d/0x19b [amdgpu] [<00000000829cc77d>] amdgpu_acpi_init+0xf3/0x7b8 [amdgpu] [<00000000671194bb>] amdgpu_driver_load_kms+0x1e5/0x354 [amdgpu] [<000000005ad1722a>] amdgpu_pci_probe+0x150/0x1d2 [amdgpu] [<00000000e32ddc8a>] pci_device_probe+0xf3/0x17e [<00000000f74eb70d>] really_probe+0x215/0x539 [<00000000af9fda84>] driver_probe_device+0x9d/0xd6 [<00000000bc527018>] device_driver_attach+0x66/0x8a # inxi -bZ System: Host: yea Kernel: 5.13.0-rc3-bdver3 x86_64 bits: 64 Console: tty 1 Distro: Gentoo Base System release 2.7 Machine: Type: Desktop Mobo: ASRock model: FM2A88M Pro3+ serial: N/A UEFI: American Megatrends v: P2.60 date: 01/11/2016 CPU: Info: Quad Core AMD A10 PRO-7800B R7 12 Compute Cores 4C+8G [MCP] speed: 1897 MHz min/max: 1400/3500 MHz Graphics: Device-1: Advanced Micro Devices [AMD/ATI] Kaveri [Radeon R7 Graphics] driver: amdgpu v: kernel Display: server: X.org 1.20.11 driver: amdgpu,ati unloaded: fbdev,modesetting tty: 211x54 Message: Advanced graphics data unavailable in console for root. Network: Device-1: Realtek RTL8111/8168/8411 PCI Express Gigabit Ethernet driver: r8169 # lspci -s 00:01.0 -vv 00:01.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Kaveri [Radeon R7 Graphics] (prog-if 00 [VGA controller]) Subsystem: ASRock Incorporation Kaveri [Radeon R7 Graphics] Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 56 IOMMU group: 0 Region 0: Memory at c0000000 (64-bit, prefetchable) [size=256M] Region 2: Memory at d0000000 (64-bit, prefetchable) [size=8M] Region 4: I/O ports at f000 [size=256] Region 5: Memory at feb00000 (32-bit, non-prefetchable) [size=256K] Expansion ROM at 000c0000 [disabled] [size=128K] Capabilities: [48] Vendor Specific Information: Len=08 <?> Capabilities: [50] Power Management version 3 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1+,D2+,D3hot+,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Capabilities: [58] Express (v2) Root Complex Integrated Endpoint, MSI 00 DevCap: MaxPayload 256 bytes, PhantFunc 0 ExtTag+ RBE+ FLReset- DevCtl: CorrErr- NonFatalErr- FatalErr- UnsupReq- RlxdOrd+ ExtTag+ PhantFunc- AuxPwr- NoSnoop+ MaxPayload 256 bytes, MaxReadReq 512 bytes DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr- TransPend- DevCap2: Completion Timeout: Not Supported, TimeoutDis- NROPrPrP- LTR- 10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt+ EETLPPrefix+, MaxEETLPPrefixes 1 EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit- FRS- AtomicOpsCap: 32bit- 64bit- 128bitCAS- DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- OBFF Disabled, AtomicOpsCtl: ReqEn- Capabilities: [a0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Address: 00000000fee02004 Data: 0029 Capabilities: [100 v1] Vendor Specific Information: ID=0001 Rev=1 Len=010 <?> Capabilities: [270 v1] Secondary PCI Express LnkCtl3: LnkEquIntrruptEn- PerformEqu- LaneErrStat: 0 Capabilities: [2b0 v1] Address Translation Service (ATS) ATSCap: Invalidate Queue Depth: 00 ATSCtl: Enable+, Smallest Translation Unit: 00 Capabilities: [2c0 v1] Page Request Interface (PRI) PRICtl: Enable- Reset- PRISta: RF- UPRGI- Stopped+ Page Request Capacity: 00000020, Page Request Allocation: 00000000 Capabilities: [2d0 v1] Process Address Space ID (PASID) PASIDCap: Exec- Priv-, Max PASID Width: 10 PASIDCtl: Enable- Exec- Priv- Kernel driver in use: amdgpu Kernel modules: amdgpu -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 14

[PATCH 0/4] drm/i915: Fix older platforms
by Ville Syrjala 04 Oct '21

04 Oct '21

From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Fix a div-by-zero on gen2, and make the L-shaped memory detection actually work on cl/ctg. Atm the SWIZZLE_UNKNOWN stuff just trips some GEM_BUG_ONs. This doesn't fix those but since I populate all my memory channels symmetrically I get to avoid the GEM_BUG_ONs by correctly detecting that I don't have an L-shaped memory configuration. Ville Syrjälä (4): drm/i915: Avoid div-by-zero on gen2 drm/i915: Read C0DRB3/C1DRB3 as 16 bits again drm/i915: Give C0DRB3/C1DRB3 a _BW suffix drm/i915: Rewrite CL/CTG L-shaped memory detection drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 19 ++++++++++--------- drivers/gpu/drm/i915/i915_debugfs.c | 16 ++++++++++++---- drivers/gpu/drm/i915/i915_reg.h | 8 ++++++-- 4 files changed, 29 insertions(+), 16 deletions(-) -- 2.26.3

3 11

[PATCH v2 0/8] dsi: rework clock parents and timing handling
by Dmitry Baryshkov 03 Oct '21

03 Oct '21

This patch series brings back several patches targeting assigning dispcc clock parents, that were removed from the massive dsi rework patchset earlier. Few notes: - assign-clock-parents is a mandatory proprety according to the current dsi.txt description. - There is little point in duplicating this functionality with the ad-hoc implementation in the dsi code. On top of that come few minor cleanups for the DSI PHY drivers. I'd kindly ask to bring all dts changes also through the drm tree, so that there won't be any breakage of the functionality. The patchset was tested on RB3 (single DSI), RB5 (single DSI, two independent DSI, bonded DSI, two last configs require additional patches which do not concern the DSI timings code). Changes since v1: - add dt-bindings change - drop the patch removing msm_dsi_dphy_timing The following changes since commit e88bbc91849b2bf57683119c339e52916d34433f: Revert "drm/msm/mdp5: provide dynamic bandwidth management" (2021-06-23 14:06:20 -0700) are available in the Git repository at: https://git.linaro.org/people/dmitry.baryshkov/kernel.git dsi-phy-update for you to fetch changes up to a79d84d8eac721a7ebaf3cfc65b200077b1d6947: drm/msm/dsi: drop msm_dsi_phy_get_shared_timings (2021-07-10 00:02:18 +0300) ---------------------------------------------------------------- Dmitry Baryshkov (8): dt-bindings: display: msm: dsi-controller-main: restore assigned-clocks arm64: dts: qcom: sc7180: assign DSI clock source parents arm64: dts: qcom: sdm845: assign DSI clock source parents arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents arm64: dts: qcom: sm8250: assign DSI clock source parents drm/msm/dsi: stop setting clock parents manually drm/msm/dsi: phy: use of_device_get_match_data drm/msm/dsi: drop msm_dsi_phy_get_shared_timings .../bindings/display/msm/dsi-controller-main.yaml | 17 ++++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++ arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++ drivers/gpu/drm/msm/dsi/dsi.h | 7 +-- drivers/gpu/drm/msm/dsi/dsi_host.c | 51 ---------------------- drivers/gpu/drm/msm/dsi/dsi_manager.c | 8 +--- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 34 ++++----------- 9 files changed, 47 insertions(+), 88 deletions(-)

2 10

[V2] drm: msm: adreno: use IS_ERR() instead of null pointer check
by Wang Qing 02 Oct '21

02 Oct '21

a6xx_gmu_get_mmio() never return null in case of error, but ERR_PTR(), so we should use IS_ERR() instead of null pointer check and IS_ERR_OR_NULL(). Signed-off-by: Wang Qing <wangqing(a)vivo.com> --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index 491fee4..82420f7 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -492,7 +492,7 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) void __iomem *seqptr = a6xx_gmu_get_mmio(pdev, "gmu_pdc_seq"); uint32_t pdc_address_offset; - if (!pdcptr || !seqptr) + if (IS_ERR(pdcptr) || IS_ERR(seqptr)) goto err; if (adreno_is_a618(adreno_gpu) || adreno_is_a640(adreno_gpu)) @@ -580,9 +580,9 @@ static void a6xx_gmu_rpmh_init(struct a6xx_gmu *gmu) wmb(); err: - if (!IS_ERR_OR_NULL(pdcptr)) + if (!IS_ERR(pdcptr)) iounmap(pdcptr); - if (!IS_ERR_OR_NULL(seqptr)) + if (!IS_ERR(seqptr)) iounmap(seqptr); } -- 2.7.4

2 2

[PATCH] drm/msm: delete conversion from bool value to bool return
by Bernard Zhao 02 Oct '21

02 Oct '21

Delete the conversion from bool value to bool function return. Signed-off-by: Bernard Zhao <bernard(a)vivo.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c index 8493d68ad841..411222f4cd6f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c @@ -37,7 +37,7 @@ static bool dpu_encoder_phys_cmd_is_master(struct dpu_encoder_phys *phys_enc) { - return (phys_enc->split_role != ENC_ROLE_SLAVE) ? true : false; + return (phys_enc->split_role != ENC_ROLE_SLAVE); } static bool dpu_encoder_phys_cmd_mode_fixup( -- 2.29.0

2 1

[PATCH] drm/msm: dsi: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare
by Xu Wang 02 Oct '21

02 Oct '21

Because clk_prepare_enable() and clk_disable_unprepare() already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Signed-off-by: Xu Wang <vulab(a)iscas.ac.cn> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index ab281cba0f08..e7af90f045bf 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -565,13 +565,11 @@ int dsi_link_clk_enable_6g(struct msm_dsi_host *msm_host) goto pixel_clk_err; } - if (msm_host->byte_intf_clk) { - ret = clk_prepare_enable(msm_host->byte_intf_clk); - if (ret) { - pr_err("%s: Failed to enable byte intf clk\n", - __func__); - goto byte_intf_clk_err; - } + ret = clk_prepare_enable(msm_host->byte_intf_clk); + if (ret) { + pr_err("%s: Failed to enable byte intf clk\n", + __func__); + goto byte_intf_clk_err; } return 0; @@ -667,8 +665,7 @@ void dsi_link_clk_disable_6g(struct msm_dsi_host *msm_host) dev_pm_opp_set_rate(&msm_host->pdev->dev, 0); clk_disable_unprepare(msm_host->esc_clk); clk_disable_unprepare(msm_host->pixel_clk); - if (msm_host->byte_intf_clk) - clk_disable_unprepare(msm_host->byte_intf_clk); + clk_disable_unprepare(msm_host->byte_intf_clk); clk_disable_unprepare(msm_host->byte_clk); } -- 2.17.1

2 1

[PATCH] drm/msm/mdp5: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare
by Xu Wang 02 Oct '21

02 Oct '21

Because clk_prepare_enable() and clk_disable_unprepare() already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Signed-off-by: Xu Wang <vulab(a)iscas.ac.cn> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 18 ++++++------------ drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c | 12 ++++-------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 15aed45022bc..8d373d2ffd51 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c @@ -303,15 +303,12 @@ static int mdp5_disable(struct mdp5_kms *mdp5_kms) mdp5_kms->enable_count--; WARN_ON(mdp5_kms->enable_count < 0); - if (mdp5_kms->tbu_rt_clk) - clk_disable_unprepare(mdp5_kms->tbu_rt_clk); - if (mdp5_kms->tbu_clk) - clk_disable_unprepare(mdp5_kms->tbu_clk); + clk_disable_unprepare(mdp5_kms->tbu_rt_clk); + clk_disable_unprepare(mdp5_kms->tbu_clk); clk_disable_unprepare(mdp5_kms->ahb_clk); clk_disable_unprepare(mdp5_kms->axi_clk); clk_disable_unprepare(mdp5_kms->core_clk); - if (mdp5_kms->lut_clk) - clk_disable_unprepare(mdp5_kms->lut_clk); + clk_disable_unprepare(mdp5_kms->lut_clk); return 0; } @@ -325,12 +322,9 @@ static int mdp5_enable(struct mdp5_kms *mdp5_kms) clk_prepare_enable(mdp5_kms->ahb_clk); clk_prepare_enable(mdp5_kms->axi_clk); clk_prepare_enable(mdp5_kms->core_clk); - if (mdp5_kms->lut_clk) - clk_prepare_enable(mdp5_kms->lut_clk); - if (mdp5_kms->tbu_clk) - clk_prepare_enable(mdp5_kms->tbu_clk); - if (mdp5_kms->tbu_rt_clk) - clk_prepare_enable(mdp5_kms->tbu_rt_clk); + clk_prepare_enable(mdp5_kms->lut_clk); + clk_prepare_enable(mdp5_kms->tbu_clk); + clk_prepare_enable(mdp5_kms->tbu_rt_clk); return 0; } diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c index 09bd46ad820b..02c6c4b68c68 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_mdss.c @@ -137,10 +137,8 @@ static int mdp5_mdss_enable(struct msm_mdss *mdss) DBG(""); clk_prepare_enable(mdp5_mdss->ahb_clk); - if (mdp5_mdss->axi_clk) - clk_prepare_enable(mdp5_mdss->axi_clk); - if (mdp5_mdss->vsync_clk) - clk_prepare_enable(mdp5_mdss->vsync_clk); + clk_prepare_enable(mdp5_mdss->axi_clk); + clk_prepare_enable(mdp5_mdss->vsync_clk); return 0; } @@ -150,10 +148,8 @@ static int mdp5_mdss_disable(struct msm_mdss *mdss) struct mdp5_mdss *mdp5_mdss = to_mdp5_mdss(mdss); DBG(""); - if (mdp5_mdss->vsync_clk) - clk_disable_unprepare(mdp5_mdss->vsync_clk); - if (mdp5_mdss->axi_clk) - clk_disable_unprepare(mdp5_mdss->axi_clk); + clk_disable_unprepare(mdp5_mdss->vsync_clk); + clk_disable_unprepare(mdp5_mdss->axi_clk); clk_disable_unprepare(mdp5_mdss->ahb_clk); return 0; -- 2.17.1

2 1

[PATCH] drm/msm/mdp4: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare
by Xu Wang 02 Oct '21

02 Oct '21

2 1

← Newer
1
...
6
7
8
9
10
11
12
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel July 2021