dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

[PATCH] drm/tegra: Stop using iommu_present()
by Robin Murphy 08 Apr '22

08 Apr '22

Remove the pointless check. host1x_drm_wants_iommu() cannot return true unless an IOMMU exists for the host1x platform device, which at the moment means the iommu_present() test could never fail. Signed-off-by: Robin Murphy <robin.murphy(a)arm.com> --- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index 9464f522e257..bc4321561400 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -1149,7 +1149,7 @@ static int host1x_drm_probe(struct host1x_device *dev) goto put; } - if (host1x_drm_wants_iommu(dev) && iommu_present(&platform_bus_type)) { + if (host1x_drm_wants_iommu(dev)) { tegra->domain = iommu_domain_alloc(&platform_bus_type); if (!tegra->domain) { err = -ENOMEM; -- 2.28.0.dirty

2 4

[PATCH] drm/i915/uncore: Warn only if unclaimed access remains flagged
by Lucas De Marchi 08 Apr '22

08 Apr '22

Commit 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed accesses") tried to improve our report of unclaimed register access, however it unveiled cases that were not previously causing any harm. Downgrade the first message to debug so we can still see them and eventually fix, but don't warn. Fixes: 4b276ed3c7ac ("drm/i915/uncore: Warn on previous unclaimed accesses") Signed-off-by: Lucas De Marchi <lucas.demarchi(a)intel.com> --- Tested on top of intel/CI_DRM_11471 as drm-tip is currently broken by other things. drivers/gpu/drm/i915/intel_uncore.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index df59ec88459e..83517a703eb6 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -1518,13 +1518,11 @@ __unclaimed_previous_reg_debug(struct intel_uncore *uncore, const i915_reg_t reg, const bool read) { - if (drm_WARN(&uncore->i915->drm, - check_for_unclaimed_mmio(uncore), - "Unclaimed access detected before %s register 0x%x\n", - read ? "read from" : "write to", - i915_mmio_reg_offset(reg))) - /* Only report the first N failures */ - uncore->i915->params.mmio_debug--; + if (check_for_unclaimed_mmio(uncore)) + drm_dbg(&uncore->i915->drm, + "Unclaimed access detected before %s register 0x%x\n", + read ? "read from" : "write to", + i915_mmio_reg_offset(reg)); } static inline void -- 2.35.1

2 1

[PATCH v2 0/5] Fix some race conditions that exists between fbmem and sysfb
by Javier Martinez Canillas 08 Apr '22

08 Apr '22

Hello, The patches in this series are mostly changes suggested by Daniel Vetter to fix some race conditions that exists between the fbdev core (fbmem) and sysfb with regard to device registration and removal. For example, it is currently possible for sysfb to register a platform device after a real DRM driver was registered and requested to remove the conflicting framebuffers. A symptom of this issue, was worked around with by commit fb561bf9abde ("fbdev: Prevent probing generic drivers if a FB is already registered") but that's really a hack and should be reverted. This series attempt to fix it more properly and revert the mentioned hack. That will also unblock a pending patch to not make the num_registered_fb variable visible to drivers anymore, since that's internal to fbdev core. This is a v2 that addresses issues in v1 pointed out by Daniel. Patch #1 is just a trivial preparatory change. Patch #2 add sysfb_disable() and sysfb_try_unregister() helpers for fbmem to use them. Patch #3 changes how is dealt with conflicting framebuffers unregistering, rather than having a variable to determine if a lock should be take, it just drops the lock before unregistering the platform device. Patch #4 fixes the mentioned race conditions and finally patch #5 is the revert patch that was posted by Daniel before but he dropped from his set. The patches were tested on a rpi4 using different video configurations: (simpledrm -> vc4 both builtin, only vc4 builtin, only simpledrm builtin and simpledrm builtin with vc4 built as a module). Best regards, Javier Changes in v2: - Rebase on top of latest drm-misc-next and fix conflicts (Daniel Vetter). - Add kernel-doc comments and include in other_interfaces.rst (Daniel Vetter). - Explain in the commit message that fbmem has to unregister the device as fallback if a driver registered the device itself (Daniel Vetter). - Also explain that fallback in a comment in the code (Daniel Vetter). - Don't encode in fbmem the assumption that sysfb will always register platform devices (Daniel Vetter). - Add a FIXME comment about drivers registering devices (Daniel Vetter). - Drop RFC prefix since patches were already reviewed by Daniel Vetter. - Add Daniel Reviewed-by tags to the patches. Daniel Vetter (1): Revert "fbdev: Prevent probing generic drivers if a FB is already registered" Javier Martinez Canillas (4): firmware: sysfb: Make sysfb_create_simplefb() return a pdev pointer firmware: sysfb: Add helpers to unregister a pdev and disable registration fbdev: Restart conflicting fb removal loop when unregistering devices fbdev: Fix some race conditions between fbmem and sysfb .../driver-api/firmware/other_interfaces.rst | 6 ++ drivers/firmware/sysfb.c | 77 +++++++++++++++++-- drivers/firmware/sysfb_simplefb.c | 16 ++-- drivers/video/fbdev/core/fbmem.c | 57 ++++++++++---- drivers/video/fbdev/efifb.c | 11 --- drivers/video/fbdev/simplefb.c | 11 --- include/linux/fb.h | 1 - include/linux/sysfb.h | 29 +++++-- 8 files changed, 150 insertions(+), 58 deletions(-) -- 2.35.1

1 5

[PATCH] drm/bridge: anx7625: Use irq flags from devicetree
by Nícolas F. R. A. Prado 08 Apr '22

08 Apr '22

Read the irq flags, like which edge to trigger on, from the devicetree and use those when registering the irq instead of hardcoding them. In case none was specified, fallback to falling edge trigger. Signed-off-by: Nícolas F. R. A. Prado <nfraprado(a)collabora.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 6516f9570b86..97d954b8cc12 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -2588,6 +2588,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, struct anx7625_platform_data *pdata; int ret = 0; struct device *dev = &client->dev; + unsigned long irqflags; if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) { @@ -2639,10 +2640,13 @@ static int anx7625_i2c_probe(struct i2c_client *client, goto free_hdcp_wq; } + irqflags = irq_get_trigger_type(client->irq); + if (!irqflags) + irqflags = IRQF_TRIGGER_FALLING; + ret = devm_request_threaded_irq(dev, platform->pdata.intp_irq, NULL, anx7625_intr_hpd_isr, - IRQF_TRIGGER_FALLING | - IRQF_ONESHOT, + irqflags | IRQF_ONESHOT, "anx7625-intp", platform); if (ret) { DRM_DEV_ERROR(dev, "fail to request irq\n"); -- 2.35.1

2 2

[PATCH v2 0/5] drm: Fix monochrome conversion for sdd130x
by Geert Uytterhoeven 08 Apr '22

08 Apr '22

Hi all, This patch series contains fixes and improvements for the XRGB888 to monochrome conversion in the DRM core, and for its users. This has been tested on an Adafruit FeatherWing 128x32 OLED, connected to an OrangeCrab ECP5 FPGA board running a 64 MHz VexRiscv RISC-V softcore, using a text console with 4x6, 7x14 and 8x8 fonts. Thanks! Geert Uytterhoeven (5): drm/format-helper: Rename drm_fb_xrgb8888_to_mono_reversed() drm/format-helper: Fix XRGB888 to monochrome conversion drm/ssd130x: Fix rectangle updates drm/ssd130x: Reduce temporary buffer sizes drm/repaper: Reduce temporary buffer size in repaper_fb_dirty() drivers/gpu/drm/drm_format_helper.c | 74 +++++++++++------------------ drivers/gpu/drm/solomon/ssd130x.c | 24 +++++++--- drivers/gpu/drm/tiny/repaper.c | 4 +- include/drm/drm_format_helper.h | 5 +- 4 files changed, 48 insertions(+), 59 deletions(-) -- 2.25.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

4 11

[PATCH 0/4] lrc selftest fixes
by Ramalingam C 08 Apr '22

08 Apr '22

Few bug fixes for lrc selftest. Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Clear the output buffers before GPU writes drm/i915/selftest: Always cancel semaphore on error drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 17 +++ drivers/gpu/drm/i915/gt/selftest_lrc.c | 115 ++++++++++++++++---- 3 files changed, 113 insertions(+), 20 deletions(-) -- 2.20.1

3 8

[linux-next:pending-fixes] BUILD REGRESSION 02f3bd309a78c84c8e12ff44a3fd4de16d1180c3
by kernel test robot 08 Apr '22

08 Apr '22

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git pending-fixes branch HEAD: 02f3bd309a78c84c8e12ff44a3fd4de16d1180c3 Merge branch 'for-linux-next-fixes' of git://anongit.freedesktop.org/drm/drm-misc Unverified Error/Warning (likely false positive, please contact us if interested): drivers/dma-buf/st-dma-fence-unwrap.c:261:1: internal compiler error: Segmentation fault Error/Warning ids grouped by kconfigs: gcc_recent_errors `-- riscv-randconfig-r042-20220406 `-- drivers-dma-buf-st-dma-fence-unwrap.c:internal-compiler-error:Segmentation-fault elapsed time: 726m configs tested: 105 configs skipped: 3 gcc tested configs: arm allyesconfig arm defconfig arm64 defconfig arm allmodconfig arm64 allyesconfig parisc allyesconfig sh allmodconfig h8300 allyesconfig xtensa allyesconfig arc allyesconfig alpha allyesconfig nios2 allyesconfig arm integrator_defconfig powerpc taishan_defconfig sh polaris_defconfig sh dreamcast_defconfig openrisc or1ksim_defconfig sh sh7710voipgw_defconfig arm gemini_defconfig x86_64 alldefconfig ia64 generic_defconfig xtensa alldefconfig sh sdk7780_defconfig x86_64 randconfig-c001 i386 randconfig-c001 arm randconfig-c002-20220408 ia64 allmodconfig ia64 allyesconfig ia64 defconfig m68k allyesconfig m68k allmodconfig m68k defconfig nios2 defconfig alpha defconfig csky defconfig arc defconfig s390 defconfig s390 allmodconfig parisc defconfig parisc64 defconfig s390 allyesconfig sparc defconfig i386 allyesconfig sparc allyesconfig i386 defconfig i386 debian-10.3-kselftests i386 debian-10.3 mips allyesconfig mips allmodconfig powerpc allyesconfig powerpc allnoconfig powerpc allmodconfig x86_64 randconfig-a002 x86_64 randconfig-a006 x86_64 randconfig-a004 i386 randconfig-a001 i386 randconfig-a003 i386 randconfig-a005 x86_64 randconfig-a013 x86_64 randconfig-a011 x86_64 randconfig-a015 i386 randconfig-a014 i386 randconfig-a012 i386 randconfig-a016 arc randconfig-r043-20220408 riscv randconfig-r042-20220408 s390 randconfig-r044-20220408 riscv defconfig riscv nommu_virt_defconfig riscv rv32_defconfig riscv nommu_k210_defconfig riscv allnoconfig riscv allmodconfig riscv allyesconfig um x86_64_defconfig um i386_defconfig x86_64 defconfig x86_64 allyesconfig x86_64 kexec x86_64 rhel-8.3-func x86_64 rhel-8.3 x86_64 rhel-8.3-kunit x86_64 rhel-8.3-kselftests clang tested configs: powerpc mpc512x_defconfig powerpc microwatt_defconfig powerpc socrates_defconfig arm pcm027_defconfig riscv allnoconfig arm collie_defconfig powerpc powernv_defconfig mips rs90_defconfig arm defconfig arm socfpga_defconfig x86_64 randconfig-a001 x86_64 randconfig-a003 x86_64 randconfig-a005 i386 randconfig-a002 i386 randconfig-a004 i386 randconfig-a006 x86_64 randconfig-a012 x86_64 randconfig-a014 x86_64 randconfig-a016 i386 randconfig-a013 i386 randconfig-a011 i386 randconfig-a015 hexagon randconfig-r045-20220408 hexagon randconfig-r041-20220408 -- 0-DAY CI Kernel Test Service https://01.org/lkp

1 0

[PATCH v2] drm/msm/mdp5: check the return of kzalloc()
by xkernel.wang＠foxmail.com 08 Apr '22

08 Apr '22

From: Xiaoke Wang <xkernel.wang(a)foxmail.com> kzalloc() is a memory allocation function which can return NULL when some internal memory errors happen. So it is better to check it to prevent potential wrong memory access. Besides, since mdp5_plane_reset() is void type, so we should better set `plane-state` to NULL after releasing it. Signed-off-by: Xiaoke Wang <xkernel.wang(a)foxmail.com> --- ChangeLog: v1->v2 simplify the patch and update the description. drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c index c6b69af..50e8542 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c @@ -90,7 +90,10 @@ static void mdp5_plane_reset(struct drm_plane *plane) __drm_atomic_helper_plane_destroy_state(plane->state); kfree(to_mdp5_plane_state(plane->state)); + plane->state = NULL; mdp5_state = kzalloc(sizeof(*mdp5_state), GFP_KERNEL); + if (!mdp5_state) + return; if (plane->type == DRM_PLANE_TYPE_PRIMARY) mdp5_state->base.zpos = STAGE_BASE; --

2 1

[PATCH] drm/msm: Fix range size vs end confusion
by Rob Clark 08 Apr '22

08 Apr '22

From: Rob Clark <robdclark(a)chromium.org> The fourth param is size, rather than range_end. Note that we could increase the address space size if we had a way to prevent buffers from spanning a 4G split, mostly just to avoid fw bugs with 64b math. Fixes: 84c31ee16f90 ("drm/msm/a6xx: Add support for per-instance pagetables") Signed-off-by: Rob Clark <robdclark(a)chromium.org> --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 17de46fc4bf2..80d57608b34a 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -1742,7 +1742,7 @@ a6xx_create_private_address_space(struct msm_gpu *gpu) return ERR_CAST(mmu); return msm_gem_address_space_create(mmu, - "gpu", 0x100000000ULL, 0x1ffffffffULL); + "gpu", 0x100000000ULL, SZ_4G); } static uint32_t a6xx_get_rptr(struct msm_gpu *gpu, struct msm_ringbuffer *ring) -- 2.35.1

2 1

[PATCH] drm/msm/dp: add fail safe mode outside of event_mutex context
by Kuogee Hsieh 08 Apr '22

08 Apr '22

There is possible circular locking dependency detected on event_mutex. To break this possible circular locking, this patch move setting fail safe mode out of event_mutex scope. Fixes: d4aca422539c ("drm/msm/dp: always add fail-safe mode into connector mode list") Signed-off-by: Kuogee Hsieh <quic_khsieh(a)quicinc.com> --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++++++ drivers/gpu/drm/msm/dp/dp_panel.c | 20 ++++++++++---------- drivers/gpu/drm/msm/dp/dp_panel.h | 1 + 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 178b774..a42732b 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -580,6 +580,12 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data) dp->dp_display.connector_type, state); mutex_unlock(&dp->event_mutex); + /* + * add fail safe mode outside event_mutex scope + * to avoid potiential circular lock with drm thread + */ + dp_panel_add_fail_safe_mode(dp->dp_display.connector); + /* uevent will complete connection part */ return 0; }; diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index f141872..26c3653 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -151,6 +151,15 @@ static int dp_panel_update_modes(struct drm_connector *connector, return rc; } +void dp_panel_add_fail_safe_mode(struct drm_connector *connector) +{ + /* fail safe edid */ + mutex_lock(&connector->dev->mode_config.mutex); + if (drm_add_modes_noedid(connector, 640, 480)) + drm_set_preferred_mode(connector, 640, 480); + mutex_unlock(&connector->dev->mode_config.mutex); +} + int dp_panel_read_sink_caps(struct dp_panel *dp_panel, struct drm_connector *connector) { @@ -207,16 +216,7 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel, goto end; } - /* fail safe edid */ - mutex_lock(&connector->dev->mode_config.mutex); - if (drm_add_modes_noedid(connector, 640, 480)) - drm_set_preferred_mode(connector, 640, 480); - mutex_unlock(&connector->dev->mode_config.mutex); - } else { - /* always add fail-safe mode as backup mode */ - mutex_lock(&connector->dev->mode_config.mutex); - drm_add_modes_noedid(connector, 640, 480); - mutex_unlock(&connector->dev->mode_config.mutex); + dp_panel_add_fail_safe_mode(connector); } if (panel->aux_cfg_update_done) { diff --git a/drivers/gpu/drm/msm/dp/dp_panel.h b/drivers/gpu/drm/msm/dp/dp_panel.h index 9023e5b..99739ea 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.h +++ b/drivers/gpu/drm/msm/dp/dp_panel.h @@ -59,6 +59,7 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel); int dp_panel_deinit(struct dp_panel *dp_panel); int dp_panel_timing_cfg(struct dp_panel *dp_panel); void dp_panel_dump_regs(struct dp_panel *dp_panel); +void dp_panel_add_fail_safe_mode(struct drm_connector *connector); int dp_panel_read_sink_caps(struct dp_panel *dp_panel, struct drm_connector *connector); u32 dp_panel_get_mode_bpp(struct dp_panel *dp_panel, u32 mode_max_bpp, -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

2 1

← Newer
1
...
71
72
73
74
75
76
77
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022