dri-devel April 2022

dri-devel@lists.freedesktop.org

351 participants
951 discussions

[PATCH AUTOSEL 5.10 01/65] drm: Add orientation quirk for GPD Win Max
by Sasha Levin 01 Apr '22

01 Apr '22

From: Anisse Astier <anisse(a)astier.eu> [ Upstream commit 0b464ca3e0dd3cec65f28bc6d396d82f19080f69 ] Panel is 800x1280, but mounted on a laptop form factor, sideways. Signed-off-by: Anisse Astier <anisse(a)astier.eu> Reviewed-by: Hans de Goede <hdegoede(a)redhat.com> Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211229222200.53128-3-anisse… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 448c2f2d803a..f5ab891731d0 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -166,6 +166,12 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MicroPC"), }, .driver_data = (void *)&lcd720x1280_rightside_up, + }, { /* GPD Win Max */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-01"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* * GPD Pocket, note that the the DMI data is less generic then * it seems, devices with a board-vendor of "AMI Corporation" -- 2.34.1

1 4

[PATCH AUTOSEL 5.15 01/98] drm: Add orientation quirk for GPD Win Max
by Sasha Levin 01 Apr '22

01 Apr '22

1 11

[PATCH AUTOSEL 5.16 001/109] drm: Add orientation quirk for GPD Win Max
by Sasha Levin 01 Apr '22

01 Apr '22

From: Anisse Astier <anisse(a)astier.eu> [ Upstream commit 0b464ca3e0dd3cec65f28bc6d396d82f19080f69 ] Panel is 800x1280, but mounted on a laptop form factor, sideways. Signed-off-by: Anisse Astier <anisse(a)astier.eu> Reviewed-by: Hans de Goede <hdegoede(a)redhat.com> Signed-off-by: Jani Nikula <jani.nikula(a)intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211229222200.53128-3-anisse… Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index b910978d3e48..4e853acfd1e8 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -180,6 +180,12 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MicroPC"), }, .driver_data = (void *)&lcd720x1280_rightside_up, + }, { /* GPD Win Max */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1619-01"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, { /* * GPD Pocket, note that the the DMI data is less generic then * it seems, devices with a board-vendor of "AMI Corporation" -- 2.34.1

1 16

[PATCH i-g-t 00/11] Per client GPU utilisation
by Tvrtko Ursulin 01 Apr '22

01 Apr '22

From: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> This series contains four main components: 1. Per client support for intel_gpu_top. 2. IGT test for per client data exposed via fdinfo from i915. 3. Extracting intel_gpu_top code into shared IGT libraries - which makes possible to write: 4. Vendor agnostic rudimentary gputop tool. Since I had the intel_gpu_top code for years, this flow of the series is what I ended up with. But it also makes sense since we can have a cut point after intel_gpu_top, in case the common drm fdinfo specification does not end up getting enough traction. Example of the intel_gpu_top output: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ intel-gpu-top: Intel Tigerlake (Gen12) @ /dev/dri/card0 - 220/ 221 MHz 70% RC6; 0.62/ 7.08 W; 760 irqs/s ENGINES BUSY MI_SEMA MI_WAIT Render/3D 23.06% |██████▊ | 0% 0% Blitter 0.00% | | 0% 0% Video 5.40% |█▋ | 0% 0% VideoEnhance 20.67% |██████ | 0% 0% PID NAME Render/3D Blitter Video VideoEnhance 3082 mpv | || ||▌ ||██ | 3117 neverball |█▉ || || || | 1 systemd |▍ || || || | 2338 gnome-shell | || || || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Example of the gputop output: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ DRM minor 0 PID NAME render copy video 3816 kwin_x11 |███▎ || || || | 3523 Xorg |▊ || || || | 1120449 mpv | || ||▋ || | 1120529 glxgears |▋ || || || | 1120449 mpv |▍ || || || | 3860 plasmashell |▏ || || || | 4764 krunner | || || || | 575206 chrome | || || || | 833481 firefox | || || || | 892924 thunderbird | || || || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Tvrtko Ursulin (11): lib: Helper library for parsing i915 fdinfo output tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo intel-gpu-top: Add support for per client stats lib: Extract igt_drm_clients from intel_gpu_top libdrmfdinfo: Allow specifying custom engine map libdrmclients: Record client drm minor libdrmclient: Support multiple DRM cards libdrmfdinfo: Track largest engine index libdrmclient/intel_gpu_top: Decouple hardcoded engine assumptions libdrmclient: Enforce client status sort order in the library gputop: Basic vendor agnostic GPU top tool lib/igt_drm_clients.c | 443 +++++++++++++++++++++++++++++++ lib/igt_drm_clients.h | 104 ++++++++ lib/igt_drm_fdinfo.c | 200 ++++++++++++++ lib/igt_drm_fdinfo.h | 52 ++++ lib/meson.build | 15 ++ man/intel_gpu_top.rst | 4 + tests/i915/drm_fdinfo.c | 565 ++++++++++++++++++++++++++++++++++++++++ tests/meson.build | 8 + tools/gputop.c | 276 ++++++++++++++++++++ tools/intel_gpu_top.c | 497 ++++++++++++++++++++++++++++++++++- tools/meson.build | 7 +- 11 files changed, 2159 insertions(+), 12 deletions(-) create mode 100644 lib/igt_drm_clients.c create mode 100644 lib/igt_drm_clients.h create mode 100644 lib/igt_drm_fdinfo.c create mode 100644 lib/igt_drm_fdinfo.h create mode 100644 tests/i915/drm_fdinfo.c create mode 100644 tools/gputop.c -- 2.32.0

2 17

[PATCH v2] drm: add PSR2 support and capability definition as per eDP 1.5
by David Zhang 01 Apr '22

01 Apr '22

[why & how] As per eDP 1.5 spec, add the below two DPCD bit fields for PSR-SU support and capability: 1. DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 2. DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED changes in v2 ------------------ * fixed the typo * explicitly list what DPCD bit fields are added Signed-off-by: David Zhang <dingchen.zhang(a)amd.com> Reviewed-by: Harry Wentland <harry.wentland(a)amd.com> --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 30359e434c3f..ac7b7571ae66 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -361,6 +361,7 @@ struct drm_panel; # define DP_PSR_IS_SUPPORTED 1 # define DP_PSR2_IS_SUPPORTED 2 /* eDP 1.4 */ # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED 3 /* eDP 1.4a */ +# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED 4 /* eDP 1.5, adopted eDP 1.4b SCR */ #define DP_PSR_CAPS 0x071 /* XXX 1.2? */ # define DP_PSR_NO_TRAIN_ON_EXIT 1 @@ -375,6 +376,7 @@ struct drm_panel; # define DP_PSR_SETUP_TIME_SHIFT 1 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED (1 << 4) /* eDP 1.4a */ # define DP_PSR2_SU_GRANULARITY_REQUIRED (1 << 5) /* eDP 1.4b */ +# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */ #define DP_PSR2_SU_X_GRANULARITY 0x072 /* eDP 1.4b */ #define DP_PSR2_SU_Y_GRANULARITY 0x074 /* eDP 1.4b */ -- 2.25.1

1 0

Re: [PATCH v7 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g
by Wang, Zhi A 01 Apr '22

01 Apr '22

Hi Jani and Joonas: Are you OK with these patches? I noticed I need to change the license of the new file. Will do that when check-in if you are OK with these. Thanks, Zhi. On 3/28/22 6:50 AM, Christoph Hellwig wrote: > On Fri, Mar 25, 2022 at 01:52:49PM -0400, Zhi Wang wrote: >> >> v7: >> >> - Keep the marcos of device generation in GVT-g. (Christoph, Jani) > > The changelog go under the "---" line (also for the other patches). > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch(a)lst.de> >

2 2

[PATCH 0/5] fix missing break in list_or_each_entry
by Xiaomeng Tong 01 Apr '22

01 Apr '22

Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. It could lead to invalid reference or set 'is_*' flags mistakely. To fix this, when an entry is found, add a break to exit the loop. Xiaomeng Tong (5): gma500: fix a missing break in oaktrail_crtc_mode_set gma500: fix a missing break in cdv_intel_crtc_mode_set gma500: fix a missing break in psb_intel_crtc_mode_set gma500: fix a missing break in cdv_intel_dp_set_m_n gma500: fix a missing break in psb_driver_load drivers/gpu/drm/gma500/cdv_intel_display.c | 2 ++ drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 ++ drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 ++ drivers/gpu/drm/gma500/psb_drv.c | 2 ++ drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++ 5 files changed, 10 insertions(+) -- 2.17.1

2 12

[PATCH v2 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list
by Lee Jones 01 Apr '22

01 Apr '22

This ensures userspace cannot prematurely clean-up the client before it is fully initialised which has been proven to cause issues in the past. Cc: Felix Kuehling <Felix.Kuehling(a)amd.com> Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones(a)linaro.org> --- CAVEAT: This patch is completely untested I can't seem to find a configuration strategy to compile test this allyesconfig and allmodconfig do not appear sufficient v2: Also remove Client from RCU list in error path drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 24 +++++++++++++-------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c index e4beebb1c80a2..f2e1d506ba211 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c @@ -247,15 +247,6 @@ int kfd_smi_event_open(struct kfd_dev *dev, uint32_t *fd) return ret; } - ret = anon_inode_getfd(kfd_smi_name, &kfd_smi_ev_fops, (void *)client, - O_RDWR); - if (ret < 0) { - kfifo_free(&client->fifo); - kfree(client); - return ret; - } - *fd = ret; - init_waitqueue_head(&client->wait_queue); spin_lock_init(&client->lock); client->events = 0; @@ -265,5 +256,20 @@ int kfd_smi_event_open(struct kfd_dev *dev, uint32_t *fd) list_add_rcu(&client->list, &dev->smi_clients); spin_unlock(&dev->smi_lock); + ret = anon_inode_getfd(kfd_smi_name, &kfd_smi_ev_fops, (void *)client, + O_RDWR); + if (ret < 0) { + spin_lock(&dev->smi_lock); + list_del_rcu(&client->list); + spin_unlock(&dev->smi_lock); + + synchronize_rcu(); + + kfifo_free(&client->fifo); + kfree(client); + return ret; + } + *fd = ret; + return 0; } -- 2.35.1.1021.g381101b075-goog

1 1

[bug report] drm/tve200: Clean up panel bridging
by Dan Carpenter 01 Apr '22

01 Apr '22

[ Old code... ] Hello Linus Walleij, The patch 9ab12e88a0b4: "drm/tve200: Clean up panel bridging" from Sep 11, 2017, leads to the following Smatch static checker warning: drivers/gpu/drm/tve200/tve200_drv.c:96 tve200_modeset_init() warn: missing error code here? '_dev_err()' failed. 'ret' = '0' drivers/gpu/drm/tve200/tve200_drv.c 62 static int tve200_modeset_init(struct drm_device *dev) 63 { 64 struct drm_mode_config *mode_config; 65 struct tve200_drm_dev_private *priv = dev->dev_private; 66 struct drm_panel *panel; 67 struct drm_bridge *bridge; 68 int ret = 0; 69 70 drm_mode_config_init(dev); 71 mode_config = &dev->mode_config; 72 mode_config->funcs = &mode_config_funcs; 73 mode_config->min_width = 352; 74 mode_config->max_width = 720; 75 mode_config->min_height = 240; 76 mode_config->max_height = 576; 77 78 ret = drm_of_find_panel_or_bridge(dev->dev->of_node, 79 0, 0, &panel, &bridge); 80 if (ret && ret != -ENODEV) 81 return ret; There is a return check here. 82 if (panel) { 83 bridge = drm_panel_bridge_add_typed(panel, 84 DRM_MODE_CONNECTOR_Unknown); 85 if (IS_ERR(bridge)) { 86 ret = PTR_ERR(bridge); 87 goto out_bridge; 88 } 89 } else { 90 /* 91 * TODO: when we are using a different bridge than a panel 92 * (such as a dumb VGA connector) we need to devise a different 93 * method to get the connector out of the bridge. 94 */ 95 dev_err(dev->dev, "the bridge is not a panel\n"); --> 96 goto out_bridge; >From reading this code without looking deeply into the context it looks like ret can be either 0 or -ENODEV. Smatch does cross function analysis (sometimes badly) and says that drm_of_find_panel_or_bridge() only returns -EINVAL, zero, and -EPROBE_DEFER so it must be zero here. 97 } 98 99 ret = tve200_display_init(dev); 100 if (ret) { 101 dev_err(dev->dev, "failed to init display\n"); 102 goto out_bridge; 103 } 104 105 ret = drm_simple_display_pipe_attach_bridge(&priv->pipe, 106 bridge); 107 if (ret) { 108 dev_err(dev->dev, "failed to attach bridge\n"); 109 goto out_bridge; 110 } 111 112 priv->panel = panel; 113 priv->connector = drm_panel_bridge_connector(bridge); 114 priv->bridge = bridge; 115 116 dev_info(dev->dev, "attached to panel %s\n", 117 dev_name(panel->dev)); 118 119 ret = drm_vblank_init(dev, 1); 120 if (ret) { 121 dev_err(dev->dev, "failed to init vblank\n"); 122 goto out_bridge; 123 } 124 125 drm_mode_config_reset(dev); 126 drm_kms_helper_poll_init(dev); 127 128 goto finish; 129 130 out_bridge: 131 if (panel) 132 drm_panel_bridge_remove(bridge); 133 drm_mode_config_cleanup(dev); 134 finish: 135 return ret; 136 } regards, dan carpenter

1 0

[PATCH] media: mediatek: vcodec: fix v4l2 compliance decoder cmd test fail
by Yunfei Dong 01 Apr '22

01 Apr '22

Will return -EINVAL using standard framework api when test stateless decoder with cmd VIDIOC_(TRY)DECODER_CMD. Using another return value to adjust v4l2 compliance test for user driver(GStreamer/Chrome) won't use decode cmd. Signed-off-by: Yunfei Dong <yunfei.dong(a)mediatek.com> --- drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c index 3859e4c651c6..69b0e797d342 100644 --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c @@ -51,8 +51,7 @@ static int vidioc_try_decoder_cmd(struct file *file, void *priv, /* Use M2M stateless helper if relevant */ if (ctx->dev->vdec_pdata->uses_stateless_api) - return v4l2_m2m_ioctl_stateless_try_decoder_cmd(file, priv, - cmd); + return -ENOTTY; else return v4l2_m2m_ioctl_try_decoder_cmd(file, priv, cmd); } -- 2.25.1

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2022