Re: [PATCH v4 3/5] drm: bridge: Link encoder and bridge in core code

On 2016/12/14 17:59, Laurent Pinchart wrote:

int fsl_dcu_create_outputs(struct fsl_dcu_drm_device *fsl_dev) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 998452ad0fcb..1737e98bc10a 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -709,10 +709,7 @@ static int dsi_bridge_init(struct drm_device *dev, struct dw_dsi *dsi) int ret;

/* associate the bridge to dsi encoder */

• encoder->bridge = bridge;
• bridge->encoder = encoder;
• ret = drm_bridge_attach(dev, bridge);

• ret = drm_bridge_attach(encoder, bridge, NULL); if (ret) { DRM_ERROR("failed to attach external bridge\n"); return ret;

For hisilicon,

Acked-by: Xinliang Liu z.liuxinliang@hisilicon.com