From: Wang Qing wangqing@vivo.com
fix memdup_user.cocci warning: gpu/drm/tegra/submit.c:172:8-16: WARNING opportunity for vmemdup_user
Signed-off-by: Wang Qing wangqing@vivo.com --- drivers/gpu/drm/tegra/submit.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index c326984..842a2d3 --- a/drivers/gpu/drm/tegra/submit.c +++ b/drivers/gpu/drm/tegra/submit.c @@ -169,16 +169,7 @@ static void *alloc_copy_user_array(void __user *from, size_t count, size_t size) if (copy_len > 0x4000) return ERR_PTR(-E2BIG);
- data = kvmalloc(copy_len, GFP_KERNEL); - if (!data) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(data, from, copy_len)) { - kvfree(data); - return ERR_PTR(-EFAULT); - } - - return data; + return vmemdup_user(from, copy_len); }
static int submit_copy_gather_data(struct gather_bo **pbo, struct device *dev,