Re: [PATCH] drm/panel-notatek-nt35510: Fix enable/disable sequence

On Wed, Aug 5, 2020 at 4:28 PM Linus Walleij linus.walleij@linaro.org wrote:

The driver was relying on only prepare()/unprepare() to enable/disable the display.

This does not work because prepare() will be called before the DSI host/bridge is ready to send any DSI commands and disable() will be called after the DSI host/bridge is disabled and thus unable to send any DSI commands.

Move all DCS command sending to the enable() and disable() callbacks, as is proper.

Ahem this is against how all panel drivers are written. Surely the DSI host must be up and running at prepare() and unprepare() time.

I take this patch back to the drawing table.

Yours, Linus Walleij