Re: 2.6.35-rc6+: i915: Bisected regression

Thomas Meyer wrote:

This commit makes suspend to ram unreliable for me:

commit d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0 Author: Zou Nan hai nanhai.zou@intel.com Date: Fri May 21 09:08:57 2010 +0800

drm/i915: implement BSD ring buffer V2

The BSD (bit stream decoder) ring is used for accessing the BSD engine
which decodes video bitstream for H.264 and VC1 on G45+.  It is
asynchronous with the render ring and has access to separate parts of
the GPU from it, though the render cache is coherent between the two.

Signed-off-by: Zou Nan hai <nanhai.zou@intel.com>
Signed-off-by: Xiang Hai hao <haihao.xiang@intel.com>
Signed-off-by: Eric Anholt <eric@anholt.net>

git revert didn't work on 2.6.35-rc6 so I just changed the HAS_BSD thing to:

#define HAS_BSD(dev) (0)

with this change applied suspend to ram is back to the reliability of 2.6.34.y

with kind regards thomas

Added CCs.

Thomas, on what hardware did you observe the regression? Is it suspend or resume that is unreliable? What are the particular symptoms --- does not suspend, crashes during suspend, crashes during resume...?