Re: [PATCH v2 5/5] drm/tilcdc: WARN if CRTC is touched without CRTC lock

On 06/09/16 23:59, Jyri Sarha wrote:

WARN if CRTC is touched without CRTC lock. The crtc functions should not be called simultaneously from multiple threads. Having the DRM CRTC lock should take care of that.

tilcdc_crtc_destroy() has to take the CRTC lock befor calling tilcdc_crtc_disable() because drm_mode_config_cleanup() does not take the lock. If this ever changes the CRTC locking has to be removed from tilcdc_crtc_destroy().

Shouldn't these be two separate patches? This one is (according to subject) adding WARNs, but it is actually also adding locking.

Tomi