Re: [PATCH 3/5] drm/radeon: Setup HDMI_CONTROL for hdmi deep color gcp's.

On Wed, May 21, 2014 at 1:58 AM, Rafał Miłecki zajec5@gmail.com wrote:

On 21 May 2014 01:17, Alex Deucher alexdeucher@gmail.com wrote:

...

•   val = RREG32(HDMI_CONTROL + offset);
  

•   val &= ~HDMI_DEEP_COLOR_ENABLE;
  

•   val &= ~HDMI_DEEP_COLOR_DEPTH_MASK;
  

...

•   switch (bpc) {
  

(...)

•   }
  

•   WREG32(HDMI_CONTROL + offset, val);
  

What about using helper:

WREG32_P(HDMI_CONTROL + offset, val, ~(HDMI_DEEP_COLOR_ENABLE | HDMI_DEEP_COLOR_DEPTH_MASK));

We could. I don't think it really makes much difference one way or the other though. I don't really have a strong preference.

Alex