On 28/04/18 18:30, Laurent Pinchart wrote:
Hi again,
On Saturday, 28 April 2018 20:25:44 EEST Laurent Pinchart wrote:
On Saturday, 28 April 2018 20:16:11 EEST Kieran Bingham wrote:
On 22/04/18 23:34, Laurent Pinchart wrote:
The implementation of the set_fmt pad operation is identical in the three modules. Move it to a generic helper function.
Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com
Only a minor pair of comments below regarding source/sink pad descriptions.
If it's not convenient/accurate to define these with an enum then don't worry about it.
It's a good point. There are however other locations in vsp1_entity.c that hardcode pad numbers, so I'll submit a patch on top of this series to fix them all in one go.
Actually I can compare the pad number to entity->source_pad, I'll update this patch accordingly in v3.
Perfect, that sounds more explicit, easier to read, and future proof against entities with multiple sinks, such as the BRx.
-- Kieran