Hi Josh
On 05/09/14 18:19, Josh Boyer wrote:
The userspace drm.h include doesn't prefix the drm directory. This can lead to compile failures as /usr/include/drm/ isn't in the standard gcc include paths. Fix it to be <drm/drm.h>, which matches the rest of the driver drm header files that get installed into /usr/include/drm.
Is this an actual issue or a hypothetical one ? Afaict no-one is using the kernel drm headers, but instead the ones from libdrm are in place. linux-headers does not even ship /usr/include/drm on my Archlinux box.
Additionally most (all?) vmwgfx components (mesa, ddx) use a local version of the header, which albeit not ideal should not cause issues.
Or perhaps I'm missing something ?
To the VMware guys,
Any objections if we update the libdrm header and drop the mesa/ddx copies ?
Cheers, Emil
P.S. I'm against the patch in any way :)
Red Hat Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1138759
Fixes: 1d7a5cbf8f74e Reported-by: Jeffrey Bastian jbastian@redhat.com Signed-off-by: Josh Boyer jwboyer@fedoraproject.org
include/uapi/drm/vmwgfx_drm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/vmwgfx_drm.h b/include/uapi/drm/vmwgfx_drm.h index 4fc66f6b12ce..c472bedbe38e 100644 --- a/include/uapi/drm/vmwgfx_drm.h +++ b/include/uapi/drm/vmwgfx_drm.h @@ -29,7 +29,7 @@ #define __VMWGFX_DRM_H__
#ifndef __KERNEL__ -#include <drm.h> +#include <drm/drm.h> #endif
#define DRM_VMW_MAX_SURFACE_FACES 6