On Mon, Aug 12, 2019 at 03:54:03PM +0800, Chen-Yu Tsai wrote:
On Mon, Aug 12, 2019 at 3:45 PM Jernej Škrabec jernej.skrabec@gmail.com wrote:
Dne torek, 06. avgust 2019 ob 17:57:39 CEST je megous@megous.com napisal(a):
From: Ondrej Jirman megous@megous.com
This series implements support for Xunlong Orange Pi 3 board. There are only a few patches remaining.
- ethernet support - just a DT change (patch 1)
- HDMI support (patches 2-4)
For some people, ethernet doesn't work after reboot because u-boot doesn't support AXP805 PMIC, and will not turn off the etherent PHY regulators. So the regulator controlled by gpio will be shut down, but the other one controlled by the AXP PMIC will not.
This is a problem only when running with a builtin driver. This needs to be fixed in u-boot.
Please take a look.
Is there anything missing? It would be nice to get this in 5.4. There is a lot of H6 boards which needs DDC bus enable mechanism (part of H6 reference design), including Beelink GS1 which already has HDMI node in mainline kernel DT, but due to disabled DDC lines works only with 1024x768 (fallback resolution in DRM core).
I have a few minor comments about patch 1.
I think the HDMI bits are good, but I don't have maintainership / commit permissions for drm-misc, so I'll have to wait until someone applies patches 2 and 3 before I apply patch 4.
I've applied 2,3 and 4
Thanks! Maxime
-- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com