Hey John,
On 01/26/2018 08:29 PM, John Stultz wrote:
On Wed, Jan 24, 2018 at 11:32 AM, Rob Herring rob.herring@linaro.org wrote:
On Wed, Jan 24, 2018 at 1:05 PM, John Stultz john.stultz@linaro.org wrote:
On Wed, Jan 24, 2018 at 7:23 AM, Sean Paul seanpaul@chromium.org wrote:
On Tue, Jan 23, 2018 at 03:16:37PM -0800, John Stultz wrote:
This allows for importing buffers allocated from the hikey and hikey960 gralloc implelementations.
Cc: Marissa Wall marissaw@google.com Cc: Sean Paul seanpaul@google.com Cc: Dmitry Shmidt dimitrysh@google.com Cc: Robert Foss robert.foss@collabora.com Cc: Matt Szczesiak matt.szczesiak@arm.com Cc: Liviu Dudau Liviu.Dudau@arm.com Cc: David Hanna david.hanna11@gmail.com Cc: Rob Herring rob.herring@linaro.org Signed-off-by: John Stultz john.stultz@linaro.org
v2:
- Make platformhisi and the generic importer exclusive in the build
I actually prefer the opposite. If everything is always compiled, we reduce the chance of breaking boards when the base class is updated. I'm sure there is a good reason for this, but perhaps there's another way?
The main reason for this was avoiding the build breaking when "gralloc_priv.h" isn't supplied or present.
Similarly the current freedesktop/master code won't build in the Android environment as the platformdrmgeneric.cpp file depends on the gralloc_drm_handle.h, which doesn't exist.
That will be fixed soon. We're moving the handle definition to libdrm.
How soon is that eta? Do you have a current patch for libdrm I should work against?
Currently it is a bit more up in the air than I was hoping for. I'll make another stab at it today :)
Rob.