Re: [PATCH v2 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

Hi Michael.

Thanks for the quick feedback and the conversion. There is a few things you need to improve as noted below.

Sam

On Thu, Jan 30, 2020 at 06:11:27PM +0100, michael.srba@seznam.cz wrote:

From: Michael Srba Michael.Srba@seznam.cz

This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes use of their S6E88A0 controller.

Signed-off-by: Michael Srba Michael.Srba@seznam.cz

Hi, Thanks for the review. I believe I've fixed everything, and I tested that I get image on drm-next with these patches applied.

Changes since v1: use yaml format for the binding

.../panel/samsung,s6e88a0-ams452ef01.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml new file mode 100644 index 000000000000..3d9b480ec706 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: GPL-2.0-only

For new bindings please use: (GPL-2.0-only OR BSD-2-Clause)

+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#

Filename must match

+$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Samsung AMS452EF01 AMOLED panel with S6E88A0 video mode DSI controller

+maintainers:

• • Michael Srba Michael.Srba@seznam.cz

+allOf:

• • $ref: panel-common.yaml#

+properties:

• compatible:
• const: samsung,s6e88a0-ams452ef01
• reg: true
• reset-gpios: true
• vdd3-supply:

• description: core voltage supply
  

• vci-supply:

• description: voltage supply for analog circuits
  

• enforce-video-mode: true

enforce-video-mode is not referenced in the driver - is it relevant?

+required:

• • compatible
• • reg
• • vdd3-supply
• • vci-supply
• • reset-gpios

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• panel@0 {

• reg = <0>;
  

• compatible = "samsung,s6e88a0-ams452ef01";
  

• vdd3-supply = <&pm8916_l17>;
  

• vci-supply = <&reg_vlcd_vci>;
  

• reset-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
  

• };

No tabs in yaml files. And fix indent so it matches. Closing '}' below 'p' in ports.

+...

Drop - not needed.