On Fri, Feb 08, 2019 at 09:56:59AM +0100, Daniel Vetter wrote:
On Fri, Feb 08, 2019 at 01:02:58AM -0500, Michael S. Tsirkin wrote:
Use linux/mman.h to make sure we get all mmap flags we need.
Signed-off-by: Michael S. Tsirkin mst@redhat.com
drmP.h is seriously deprecated (and a monster mess). If this fixes anything, I think would be better to include the right header in the right places, and leave drmP.h to die quietly ...
What exactly does this fix? -Daniel
I don't know. I am moving flags from asm/mman.h and if there are direct users which there should not be, some code might break. Even if it's a bad header people copy code around, so why leave wrong examples there? What's the harm in being proactive?
include/drm/drmP.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/drm/drmP.h b/include/drm/drmP.h index bdb0d5548f39..a3184416ddc5 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -57,8 +57,7 @@ #include <linux/workqueue.h> #include <linux/dma-fence.h> #include <linux/module.h>
-#include <asm/mman.h> +#include <linux/mman.h> #include <asm/pgalloc.h> #include <linux/uaccess.h>
-- MST
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch