Re: [PATCH] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo

On Tue, Feb 26, 2013 at 12:05:50PM +0900, Jingoo Han wrote:

VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH, because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync.

Signed-off-by: Jingoo Han jg1.han@samsung.com Cc: Steffen Trumtrar s.trumtrar@pengutronix.de

---

drivers/video/fbmon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index 94ad0f7..7f67099 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm, fbmode->vmode = 0; if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH) fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;

• if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)

• if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH) fbmode->sync |= FB_SYNC_VERT_HIGH_ACT; if (vm->data_flags & DISPLAY_FLAGS_INTERLACED) fbmode->vmode |= FB_VMODE_INTERLACED;

Hi,

looks good to me.

Regards, Steffen