On Tue, Sep 03, 2019 at 04:45:56PM -0400, Lyude Paul wrote:
These are most certainly accessed from far more than the mgr work. In fact, up_req_recv is -only- ever accessed from outside the mgr work.
Cc: Juston Li juston.li@intel.com Cc: Imre Deak imre.deak@intel.com Cc: Ville Syrjälä ville.syrjala@linux.intel.com Cc: Harry Wentland hwentlan@amd.com Cc: Daniel Vetter daniel.vetter@ffwll.ch Signed-off-by: Lyude Paul lyude@redhat.com
Reviewed-by: Sean Paul sean@poorly.run
include/drm/drm_dp_mst_helper.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h index f253ee43e9d9..8ba2a01324bb 100644 --- a/include/drm/drm_dp_mst_helper.h +++ b/include/drm/drm_dp_mst_helper.h @@ -489,15 +489,11 @@ struct drm_dp_mst_topology_mgr { int conn_base_id;
/**
* @down_rep_recv: Message receiver state for down replies. This and
* @up_req_recv are only ever access from the work item, which is
* serialised.
*/ struct drm_dp_sideband_msg_rx down_rep_recv; /*** @down_rep_recv: Message receiver state for down replies.
* @up_req_recv: Message receiver state for up requests. This and
* @down_rep_recv are only ever access from the work item, which is
* serialised.
*/ struct drm_dp_sideband_msg_rx up_req_recv;* @up_req_recv: Message receiver state for up requests.
-- 2.21.0