Aw: [PATCH v11 17/24] arm64: dts: rockchip: rk356x: Add HDMI nodes

Hi,

Gesendet: Freitag, 22. April 2022 um 09:28 Uhr Von: "Sascha Hauer" s.hauer@pengutronix.de Betreff: [PATCH v11 17/24] arm64: dts: rockchip: rk356x: Add HDMI nodes

Add support for the HDMI port found on RK3568.

Signed-off-by: Sascha Hauer s.hauer@pengutronix.de

Notes: Changes since v7: - Rename hclk to niu

clock-name no more present since v9, see below

Changes since v5:
- Drop unnecessary #size-cells/#address-cells from nodes with only single endpoint

...

--- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi @@ -620,6 +620,38 @@ vop_mmu: iommu@fe043e00 { status = "disabled"; };

• hdmi: hdmi@fe0a0000 {

• compatible = "rockchip,rk3568-dw-hdmi";
  

• reg = <0x0 0xfe0a0000 0x0 0x20000>;
  

• interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
  

• clocks = <&cru PCLK_HDMI_HOST>,
  

• 	 <&cru CLK_HDMI_SFR>,
  

• 	 <&cru CLK_HDMI_CEC>,
  

• 	 <&pmucru CLK_HDMI_REF>,
  

• 	 <&cru HCLK_VO>;
  

• clock-names = "iahb", "isfr", "cec", "ref";
  

noticed there are still 5 clocks, but only 4 clock-names. So i added "niu" after ref. maybe missing clock-name was causing my iommu page-faults...on a quick test i have not got it, but they came not every time.

what do you think?

• pinctrl-names = "default";
  

• pinctrl-0 = <&hdmitx_scl &hdmitx_sda &hdmitxm0_cec>;
  

• power-domains = <&power RK3568_PD_VO>;
  

regards Frank