Re: [PATCH 2/2] drm: panel: simple: Add AM-1280800N3TZQW-T00H

Hi Jagan.

On Fri, Aug 28, 2020 at 09:29:38PM +0530, Jagan Teki wrote:

Add Ampire, AM-1280800N3TZQW-T00H 10.1" TFT LCD panel timings.

Signed-off-by: Jagan Teki jagan@amarulasolutions.com

drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b6ecd1552132..c988fe8094f8 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -592,6 +592,31 @@ static void panel_simple_shutdown(struct device *dev) drm_panel_unprepare(&panel->base); }

+static const struct drm_display_mode ampire_am_1280800n3tzqw_t00h_mode = {

• .clock = 71100,
• .hdisplay = 1280,
• .hsync_start = 1280 + 40,
• .hsync_end = 1280 + 40 + 80,
• .htotal = 1280 + 40 + 80 + 40,
• .vdisplay = 800,
• .vsync_start = 800 + 3,
• .vsync_end = 800 + 3 + 10,
• .vtotal = 800 + 3 + 10 + 10,
• .vrefresh = 60,

No longer preset - delete.

• .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,

+};

+static const struct panel_desc ampire_am_1280800n3tzqw_t00h = {

• .modes = &ampire_am_1280800n3tzqw_t00h_mode,
• .num_modes = 1,
• .bpc = 6,
• .size = {

• .width = 217,
  

• .height = 136,
  

• },
• .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,

+};

.connector_type is mandatory today. And based on connector type you may need to specify .bus_flags.

Sam

static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = { .clock = 9000, .hdisplay = 480, @@ -3637,6 +3662,9 @@ static const struct panel_desc arm_rtsm = {

static const struct of_device_id platform_of_match[] = { {

• .compatible = "ampire,am-1280800n3tzqw-t00h",
  

• .data = &ampire_am_1280800n3tzqw_t00h,
  

• }, { .compatible = "ampire,am-480272h3tmqw-t01h", .data = &ampire_am_480272h3tmqw_t01h, }, {

-- 2.25.1