On Wed, 4 May 2011 16:16:37 -0700 Jesse Barnes jbarnes@virtuousgeek.org wrote:
On Wed, 04 May 2011 15:17:31 -0700 Ian Romanick idr@freedesktop.org wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 05/03/2011 12:21 PM, Jesse Barnes wrote:
We only spec a 32 bit swap count, so drop the high sbc field.
Signed-off-by: Jesse Barnes jbarnes@virtuousgeek.org
Is there any way we could do this and NOT break building older versions of Mesa? I'd like to be able to build 7.9, 7.10, and master on my system without having two different versions of glproto.
We did that the last time glproto bumped (kept the req at 1.4.10 and added ifdefs), but that added bugs that we didn't find for awhile, so I wanted to try to avoid it this time. Another option for you would be to build 7.9, 7.10, and master against different install roots with PKG_CONFIG_PATH set appropriately...
Or just backport the fix to 7.x :) The server is only sending 32 bytes regardless, so having the fix in older client library versions will give either the right sbc number (if the server is new) or 0 if the server is old (unless you've wrapped the sbc_lo field and sbc_hi is set). So an improvement either way.