Hi Lucas,
Thanks for taking some time to look over this series.
On Mon, Feb 24, 2020 at 06:27:25PM +0100, Lucas Stach wrote:
Hi Laurentiu,
just a first drive-by comment, more in-depth review tomorrow.
On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote:
This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). Some of its capabilities include:
- 4K@60fps;
- HDR10;
- one graphics and 2 video pipelines;
- on-the-fly decompression of compressed video and graphics;
The reference manual can be found here: https://www.nxp.com/webapp/Download?colCode=IMX8MDQLQRM
The current patch adds only basic functionality: one primary plane for graphics, linear, tiled and super-tiled buffers support (no graphics decompression yet), no HDR10 and no video planes.
Video planes support and HDR10 will be added in subsequent patches once per-plane de-gamma/CSC/gamma support is in.
Signed-off-by: Laurentiu Palcu laurentiu.palcu@nxp.com
[...]
diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig new file mode 100644 index 00000000..a189dac --- /dev/null +++ b/drivers/gpu/drm/imx/dcss/Kconfig @@ -0,0 +1,8 @@ +config DRM_IMX_DCSS
- tristate "i.MX8MQ DCSS"
- select RESET_CONTROLLER
- select IMX_IRQSTEER
This driver has no build time dependency on the IRQSTEER driver. It needs it at runtime, but those dependencies are normally not described in Kconfig.
On the other hand this is missing a "select DRM_KMS_CMA_HELPER".
Oops, I guess I missed this. I'll add it in next revision. Waiting for your in-depth review first.
Thanks, laurentiu
Regards, Lucas
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel