Re: [PATCH v5] drm/panel: Add support for E Ink VB3300-KCA

Hi Alistair,

On Fri, Jul 30, 2021 at 10:13:10PM +1000, Alistair Francis wrote:

Add support for the 10.3" E Ink panel described at: https://www.eink.com/product.html?type=productdetail&id=7

Signed-off-by: Alistair Francis alistair@alistair23.me Acked-by: Rob Herring robh@kernel.org Reviewed-by: Sam Ravnborg sam@ravnborg.org

---

v5:

• Add .connector_type

I missed this revision before sending my last mail. I tried to apply this patch but every patch confliced due to other changes since the kernel this is based on.

I need you to generate a new patch on top of drm-misc-next, or as an alternative on top of linux-next. You are in a much better position to do this right than I am.

Sorry for the troubles!

Sam

.../bindings/display/panel/panel-simple.yaml | 2 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 ++ drivers/gpu/drm/panel/panel-simple.c | 30 +++++++++++++++++++ 3 files changed, 34 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index b3797ba2698b..799e20222551 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -128,6 +128,8 @@ properties: # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch - edt,etm0700g0dh6 - edt,etm0700g0edh6

•    # E Ink VB3300-KCA
  

•  - eink,vb3300-kca
     # Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
   - evervision,vgg804821
     # Foxlink Group 5" WVGA TFT LCD panel
  

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index 71da86e7b3a2..31745c45dd92 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -339,6 +339,8 @@ patternProperties: description: eGalax_eMPIA Technology Inc "^einfochips,.*": description: Einfochips

• "^eink,.*":
• description: E Ink Corporation "^elan,.*": description: Elan Microelectronic Corp. "^element14,.*":

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 21939d4352cf..90d96091f09f 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2046,6 +2046,33 @@ static const struct panel_desc edt_etm0700g0bdh6 = { .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, };

+static const struct display_timing eink_vb3300_kca_timing = {

• .pixelclock = { 40000000, 40000000, 40000000 },
• .hactive = { 334, 334, 334 },
• .hfront_porch = { 1, 1, 1 },
• .hback_porch = { 1, 1, 1 },
• .hsync_len = { 1, 1, 1 },
• .vactive = { 1405, 1405, 1405 },
• .vfront_porch = { 1, 1, 1 },
• .vback_porch = { 1, 1, 1 },
• .vsync_len = { 1, 1, 1 },
• .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |

•  DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE,
  

+};

+static const struct panel_desc eink_vb3300_kca = {

• .timings = &eink_vb3300_kca_timing,
• .num_timings = 1,
• .bpc = 6,
• .size = {

• .width = 157,
  

• .height = 209,
  

• },
• .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
• .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
• .connector_type = DRM_MODE_CONNECTOR_DPI,

+};

static const struct display_timing evervision_vgg804821_timing = { .pixelclock = { 27600000, 33300000, 50000000 }, .hactive = { 800, 800, 800 }, @@ -4350,6 +4377,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,etm0700g0edh6", .data = &edt_etm0700g0bdh6,

• }, {

• .compatible = "eink,vb3300-kca",
  

• .data = &eink_vb3300_kca,
  

  }, { .compatible = "evervision,vgg804821", .data = &evervision_vgg804821,

-- 2.31.1