Re: [PATCH v2] drm: of: Add drm_of_lvds_get_data_mapping

On 10/12/21 10:05 PM, Sam Ravnborg wrote:

[...]

...

diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 37c34146eea8..a9217bc18e8f 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -402,3 +402,36 @@ int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, DRM_LVDS_DUAL_LINK_ODD_EVEN_PIXELS; } EXPORT_SYMBOL_GPL(drm_of_lvds_get_dual_link_pixel_order);

+/**

• • drm_of_lvds_get_data_mapping - Get LVDS data mapping
• • @port: DT port node of the LVDS source or sink
• • Convert DT "data-mapping" property string value into media bus format value.
• • Return:
• • MEDIA_BUS_FMT_RGB666_1X7X3_SPWG - data-mapping is "jeida-18"
• • MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA - data-mapping is "jeida-24"
• • MEDIA_BUS_FMT_RGB888_1X7X4_SPWG - data-mapping is "vesa-24"
• • -EINVAL - the "data-mapping" property is unsupported
• • -ENODEV - the "data-mapping" property is missing
• */

I tried to look at the output of this - it looks bad.

See the chapter "Return values" here: https://docs.kernel.org/doc-guide/kernel-doc.html Sorry for not catching this during the first review.

Should be fixed in V3.