Re: [Intel-gfx] [PATCH 5/7] drm/i915: Use container_of() in the fbdev code

On Mon, Jun 03, 2013 at 11:08:30AM +0100, Chris Wilson wrote:

On Fri, May 31, 2013 at 08:07:05PM +0300, ville.syrjala@linux.intel.com wrote:

...

From: Ville Syrjälä ville.syrjala@linux.intel.com

Use container_of() instead of a cast to get struct intel_fbdev from struct drm_fb_helper.

Also populate the fb_info->par correctly with the drm_fb_helper pointer instead of the intel_fbdev pointer.

There's no actual functional change since the drm_fb_helper happens to be the first member inside intel_fbdev.

Reviewed-by: Chris Wilson chris@chris-wilson.co.uk

Queued for -next, thanks for the patch. -Daniel