Re: [PATCH 2/4] drm/i915/gt: nuke unused legacy engine hw_id

On Wed, Jul 21, 2021 at 03:47:22PM -0700, Matt Roper wrote:

On Tue, Jul 20, 2021 at 04:20:12PM -0700, Lucas De Marchi wrote:

...

The engine hw_id is only used by RING_FAULT_REG(), which is not used since GRAPHICS_VER == 8. We tend to keep adding new defines just to be consistent, but let's try to remove them and let them defined to 0 when not used.

s/when not used/for engines that only exist on gen8+ platforms/

Reviewed-by: Matt Roper matthew.d.roper@intel.com

For historical reference, we did use hw_id on gen8+ platforms too until relatively recently --- it was used to set the engine's guc_id as well up until:

   commit c784e5249e773689e38d2bc1749f08b986621a26
   Author: John Harrison <John.C.Harrison@Intel.com>
   Date:   Wed Oct 28 07:58:24 2020 -0700

       drm/i915/guc: Update to use firmware v49.0.1

thanks for digging this, I will add that to the commit message as well.

Lucas De Marchi