RE: [RFC 10/28] drm: rcar-du: of: Increase buff size for compatible variable

Hi Geert,

Thanks for the feedback.

Subject: Re: [RFC 10/28] drm: rcar-du: of: Increase buff size for compatible variable

Hi Biju,

On Wed, Jan 12, 2022 at 6:46 PM Biju Das biju.das.jz@bp.renesas.com wrote:

...

Increase buff size for compatible variable to avoid stack corruption with RZ/G2L SoC's(renesas,du-r9a07g044l) which requires a buff size more than the current allocated size.

Signed-off-by: Biju Das biju.das.jz@bp.renesas.com

Thanks for your patch!

...

--- a/drivers/gpu/drm/rcar-du/rcar_du_of.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c @@ -200,7 +200,7 @@ static void __init rcar_du_of_lvds_patch(const

struct of_device_id *of_ids)

...

    struct device_node *lvds_node;
    struct device_node *soc_node;
    struct device_node *du_node;

•   char compatible[22];
  

•   char compatible[24];
    const char *soc_name;
    unsigned int i;
    int ret;
  

What about changing the code to use kasprintf() instead, to prevent this from ever happening again?

OK. Will try to use kasprintf. It took some time to figure out the original corruption issue with RZ/G2L, where string length "socname-lvds" is beyond the limit.

Regards, Biju