Re: [PATCH 1/9] drm: Add drm driver for Rockchip Socs

On Mon, Aug 04, 2014 at 12:45:07PM +0800, mark yao wrote:

This patch is a DRM Driver for Rockchip Socs, driver provides an abstraction for the graphics hardware, such as lcd controller and connector interface.

Signed-off-by: mark yao yzq@rock-chips.com

Just a quick drive-by comment below, don't consider this a full review by far ;-)

+static int lcdc_bind(struct device *dev, struct device *master, void *data) +{

• struct drm_device *drm_dev = data;
• struct rockchip_drm_private *private = drm_dev->dev_private;
• struct lcdc_context *ctx = dev_get_drvdata(dev);
• struct drm_crtc *crtc;
• ctx->drm_dev = drm_dev;
• ctx->pipe = rockchip_drm_pipe_get(dev);
• ctx->dpms = DRM_MODE_DPMS_OFF;
• crtc = &ctx->crtc;
• private->crtc[ctx->pipe] = crtc;
• ctx->plane = rockchip_plane_init(drm_dev, 1 << ctx->pipe, true);
• drm_crtc_init(drm_dev, crtc, &rockchip_crtc_funcs);

This function is deprecated, please use the _with_planes versions so that this new driver supports universal planes properly.

Thanks, Daniel