On 2/5/20 7:02 PM, Philippe Mathieu-Daudé wrote:
On Sun, Feb 2, 2020 at 3:41 AM Finn Thain fthain@telegraphics.com.au wrote:
This patch resolves these compiler errors and warnings --
CC drivers/video/fbdev/g364fb.o drivers/video/fbdev/g364fb.c: In function 'g364fb_cursor': drivers/video/fbdev/g364fb.c:137:9: error: 'x' undeclared (first use in this function) drivers/video/fbdev/g364fb.c:137:9: note: each undeclared identifier is reported only once for each function it appears in drivers/video/fbdev/g364fb.c:137:7: error: implicit declaration of function 'fontwidth' [-Werror=implicit-function-declaration] drivers/video/fbdev/g364fb.c:137:23: error: 'p' undeclared (first use in this function) drivers/video/fbdev/g364fb.c:137:38: error: 'y' undeclared (first use in this function) drivers/video/fbdev/g364fb.c:137:7: error: implicit declaration of function 'fontheight' [-Werror=implicit-function-declaration] drivers/video/fbdev/g364fb.c: In function 'g364fb_init': drivers/video/fbdev/g364fb.c:233:24: error: 'fbvar' undeclared (first use in this function) drivers/video/fbdev/g364fb.c:234:24: error: 'xres' undeclared (first use in this function)
18 years unnoticed...
drivers/video/fbdev/g364fb.c:201:14: warning: unused variable 'j' [-Wunused-variable] drivers/video/fbdev/g364fb.c:197:25: warning: unused variable 'pal_ptr' [-Wunused-variable]
The MIPS Magnum framebuffer console now works when tested in QEMU.
Cc: Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
This commit is the kernel 'git origin' import, not the proper reference.
The actual change is between v2.5.17/2.5.19: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/diff/driver... Date: 2002-05-22 07:52:33...
The same commit introduced the changes in g364fb_cursor(), which was implemented previous to v2.4.0 so it is hard to follow from there.
Nobody complains during 18 years so I doubt anyone care that g364fb_cursor() is removed. And by removing it, you improve the kernel quality, so: Reviewed-by: Philippe Mathieu-Daudé f4bug@amsat.org (Maybe remove the unhelpful 'Fixes' tag).
Signed-off-by: Finn Thain fthain@telegraphics.com.au
drivers/video/fbdev/g364fb.c | 29 +++-------------------------- 1 file changed, 3 insertions(+), 26 deletions(-)
Note, you need to rebase your series due to:
commit 8a48ac339398f21282985bff16552447d41dcfb2 Author: Jani Nikula jani.nikula@intel.com Date: Tue Dec 3 18:38:50 2019 +0200
video: constify fb ops across all drivers