Hi Emil,
On 14/04/16 16:06, Emil Velikov wrote:
Hi Enric,
On 14 April 2016 at 14:42, Enric Balletbo i Serra enric.balletbo@collabora.com wrote:
The patch was implemented first without OR'ing error codes. The reason why I changed this is because I received the comments that checking the error on every regmap_* didn't help the readability of the driver and is likely to not fail if the first call doesn't fail.
For example, originally the code was like this: http://pastebin.com/rPgyji8k but I changed to this http://pastebin.com/rPgyji8k
Both links are the same ;-) But I believe we all get what you meant.
Ooops, sorry. This is the other link
Just a side note: many other drivers in DRM subsystem, inconsistently check the return value of the regmap API. Note sure how likely is any of it [regmap_foo] to fail and/or how determined people are to handle every possible error case.
-Emil
Enric