Re: [PATCH] drm: crtc-helper: Remove useless loop

Hi Daniel,

On Wednesday 28 May 2014 15:36:38 Daniel Vetter wrote:

On Wed, May 28, 2014 at 02:43:36PM +0200, Laurent Pinchart wrote:

...

Commit e3d6ddb35f6221859b6054879d186e13a3af351e ("drm/crtc-helper: don't disable disconnected outputs") made the for each loop over connectors empty in __drm_helper_disable_unused_functions(). Remove the loop altogether.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com

Isn't the local variable connector now unused?

Yes it is. Missing hunk in my patch, sorry about that :-/

At least that's what my old patch did:

http://patchwork.freedesktop.org/patch/24184/

Looks like I've missed it. Sorry for the noise.

/me looks at Dave ...

Cheers, Daniel