Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()

Hi John,

john.hubbard@gmail.com writes:

diff --git a/arch/powerpc/mm/book3s64/iommu_api.c b/arch/powerpc/mm/book3s64/iommu_api.c index b056cae3388b..e126193ba295 100644 --- a/arch/powerpc/mm/book3s64/iommu_api.c +++ b/arch/powerpc/mm/book3s64/iommu_api.c @@ -203,6 +202,7 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) { long i; struct page *page = NULL;

• bool dirty = false;

I don't think you need that initialisation do you?

if (!mem->hpas) return; @@ -215,10 +215,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem) if (!page) continue;

• if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY)
  

• 	SetPageDirty(page);
  

• dirty = mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY;
  

• put_page(page);
  

• put_user_pages_dirty_lock(&page, 1, dirty);
  

  mem->hpas[i] = 0; }

}

cheers