On Wed, Mar 13, 2013 at 08:48:22PM +0100, Paul Bolle wrote:
Signed-off-by: Paul Bolle pebolle@tiscali.nl
Untested. Perhaps the first test that people with access to the relevant hardware might do, is to test _before applying this patch_ with FB_OMAP2 set. Perhaps this negative dependency isn't needed at all. Or is it obvious?
I don't think you need access to hardware to test this. Checking that the dependencies work properly (using menuconfig for example) and build testing should be enough.
drivers/gpu/drm/omapdrm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig index 09f65dc..45875a0 100644 --- a/drivers/gpu/drm/omapdrm/Kconfig +++ b/drivers/gpu/drm/omapdrm/Kconfig @@ -1,7 +1,7 @@
config DRM_OMAP tristate "OMAP DRM"
- depends on DRM && !CONFIG_FB_OMAP2
- depends on DRM && !FB_OMAP2 depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM depends on OMAP2_DSS select DRM_KMS_HELPER
Regardless of whether the dependency is needed or not, the typo should be fixed, so:
Reviewed-by: Thierry Reding thierry.reding@gmail.com