On Wed, Mar 31, 2021 at 09:47:12AM +0800, Kevin Tang wrote:
diff --git a/drivers/gpu/drm/sprd/Makefile
b/drivers/gpu/drm/sprd/Makefile
index 6c25bfa99..d49f4977b 100644 --- a/drivers/gpu/drm/sprd/Makefile +++ b/drivers/gpu/drm/sprd/Makefile @@ -1,5 +1,8 @@ # SPDX-License-Identifier: GPL-2.0
obj-y := sprd_drm.o \
sprd_dpu.o
sprd_dpu.o \sprd_dsi.o \dw_dsi_ctrl.o \dw_dsi_ctrl_ppi.o \So it's a designware IP? There's a driver for it already that seems fairly similar: drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
Our dw dsi controller is not a standard synopsys ip, we have updated a lot on the basic ip version, the entire control register is different, i have cc to drm/bridge reviewers and maintainers.
You should make it more obvious then in a comment or in the name of the driver. If it's fairly different from the original IP from Synopsys, maybe you should just drop the reference to the name?
Maxime